Re: [clang-tools-extra] r350847 - [clangd] Introduce loading of shards within auto-index

Hi Kadir, It seems this commit started causing failures on builds in green dragon, starting from: http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/52811/ Can you please take a look, and revert if the fix

Re: r350856 - Split -Wdelete-non-virtual-dtor into two groups

Might be handy to summarize the changes from the previous reverted version of this patch (& mention the original commit revision and revert revision) - in the commit message is ideal, but in a reply to the commit after the fact will do in a pinch On Fri, Jan 11, 2019 at 4:06 AM Erik Pilkington

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

efriedma added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; jyu2 wrote: > jyu2 wrote: > > efriedma wrote: > > > jyu2 wrote: > > >

[PATCH] D55394: Re-order type param children of ObjC nodes

dblaikie added inline comments. Comment at: test/AST/ast-dump-decl.m:90 // CHECK-NEXT: -ObjCProtocol {{.+}} 'P' +// CHECK-NEXT: -ObjCTypeParamDecl {{.+}} col:33 T 'id':'id' steveire wrote: > aaron.ballman wrote: > > It seems strange to me to print out

r351029 - [X86] Remove mask parameter from vpshufbitqmb intrinsics. Change result to a vXi1 vector.

Author: ctopper Date: Sun Jan 13 16:03:55 2019 New Revision: 351029 URL: http://llvm.org/viewvc/llvm-project?rev=351029=rev Log: [X86] Remove mask parameter from vpshufbitqmb intrinsics. Change result to a vXi1 vector. We'll do the scalar<->vXi1 conversions with bitcasts in IR. Fixes PR40258

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

a_sidorin added a comment. Hi Rafael, The change looks mostly fine but I have some comments inline. Comment at: lib/AST/ASTImporter.cpp:3243 + + if (R) { +CXXDestructorDecl *ToDtor = cast(*R); It's better to move this code to VisitFunctionDecl to keep

[PATCH] D56652: [CMake][Fuchsia] Synchronize first and second stage builds

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett, leonardchan. Herald added subscribers: cfe-commits, mgorny. This reorders options between the first and second stage builds to make them better lined up. The change also re-enables tests for first stage

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

teemperor added a comment. Didn't really upstream any non-trivial ASTImporter patches yet, so please point out any style errors. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/ https://reviews.llvm.org/D56651

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

teemperor created this revision. teemperor added reviewers: shafik, martong, a_sidorin. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Shafik found out that importing a CXXConstructorDecl will create a translation unit that causes Clang's CodeGen to crash.

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 181484. mgorny marked 7 inline comments as done. mgorny set the repository for this revision to rLLD LLVM Linker. mgorny added a comment. Herald added a subscriber: fedor.sergeev. Split target logic into D56650 , switched to

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny added inline comments. Comment at: ELF/Driver.cpp:770 + // Start with a default initial triple + Config->TargetTriple = llvm::Triple(getDefaultTargetTriple()); + krytarowski wrote: > krytarowski wrote: > > arichardson wrote: > > > arichardson wrote: > >

[PATCH] D56650: [lld] [ELF] Support inferring target triple from filename

mgorny created this revision. mgorny added reviewers: ruiu, joerg, krytarowski, arichardson. Herald added subscribers: llvm-commits, emaste. Herald added a reviewer: espindola. Support inferring the target triple from linker filename (e.g. ${triple}-ld.lld), and customizing the linker behavior

[PATCH] D56597: [clangd] Add Limit parameter for xref.

hokein updated this revision to Diff 181481. hokein added a comment. Fix an issue and add comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56597/new/ https://reviews.llvm.org/D56597 Files: clangd/ClangdLSPServer.cpp

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx added a comment. I've added the implicit access specifier check and run it on some bigger codebases. My findings are as below: - Dolphin: 6 //triggers across// 856 //record types// - OpenCV: 31 //triggers across// 3370 //record types// - Inkscape: 39 //triggers across// 846 //record

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx updated this revision to Diff 181474. m4tx marked an inline comment as not done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire updated this revision to Diff 181475. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56642/new/ https://reviews.llvm.org/D56642 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

Eugene.Zelenko added a comment. It'll be worth to mention change in Release Notes (in changes list, in alphabetical order). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56644/new/ https://reviews.llvm.org/D56644

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

lebedev.ri added inline comments. Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:34 return; const auto ValidContainer = qualType(hasUnqualifiedDesugaredType( ``` auto ContainerLenghtFuncNames = anyOf(hasName("size"), hasName("length"));

[PATCH] D56647: [WIP] [ELF] Implement --copy-dt-needed-entries

mgorny created this revision. mgorny added reviewers: ruiu, krytarowski. Herald added subscribers: llvm-commits, jfb, arichardson, emaste. Herald added a reviewer: espindola. This is my proof-of-concept on making `--copy-dt-needed-entries` work. Apparently, i've been able to hack on it hard

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

Quolyk marked an inline comment as done. Quolyk added inline comments. Comment at: test/clang-tidy/readability-container-size-empty.cpp:19-20 basic_string operator+(const basic_string& other) const; unsigned long size() const; + unsigned long length() const; bool

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

lebedev.ri added a comment. Seems to look good. Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:65 hasType(references(ValidContainer), -callee(cxxMethodDecl(hasName("size"))), WrongUse, +

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

Quolyk updated this revision to Diff 181467. Quolyk added a comment. Update tests. Handle length. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56644/new/ https://reviews.llvm.org/D56644 Files: clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D56646: [OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1, 2}d_array_t variants are OpenCL-1.2+, mark them as such

lebedev.ri created this revision. lebedev.ri added reviewers: yaxunl, Anastasia, echuraev, asavonic. lebedev.ri added a project: clang. Refer to `6.11.13.2 Built-in Image Functions` , and `9.6.8 Image Read and Write