[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

wuzish added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-error.c:78 +void testDSS(int index) { + vec_dss(index); //expected-error {{argument to '__builtin_altivec_dss' must be a constant integer}} + It would be better if add range constraint

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

zsrkmyn added a comment. Thanks @lebedev.ri , I'm currently under discussion with @erichkeane , and I'll add lit test after the final decision on how to solve the issue. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67058/new/ https://reviews.llvm.org/D67058

r370691 - [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512

Author: pengfei Date: Mon Sep 2 19:06:15 2019 New Revision: 370691 URL: http://llvm.org/viewvc/llvm-project?rev=370691=rev Log: [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512 Reviewers: craig.topper, pengfei, LuoYuanke, RKSimon,

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaronpuchert added a comment. In D66919#1655048 , @dexonsmith wrote: > I went back to read notes from when we deployed `-Wstrict-prototypes` (which > we have had on-by-default for our users for a couple of years, since it > catches lots of

r370689 - Rename -Wc++20-designator to -Wc++2a-designator for consistency and add

Author: rsmith Date: Mon Sep 2 16:27:54 2019 New Revision: 370689 URL: http://llvm.org/viewvc/llvm-project?rev=370689=rev Log: Rename -Wc++20-designator to -Wc++2a-designator for consistency and add some test coverage for the flag. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td

r370688 - Split -Wreorder into different warnings for reordering a constructor

Author: rsmith Date: Mon Sep 2 16:17:32 2019 New Revision: 370688 URL: http://llvm.org/viewvc/llvm-project?rev=370688=rev Log: Split -Wreorder into different warnings for reordering a constructor mem-initializer list and for reordering a designated initializer list. Modified:

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

dexonsmith added a comment. I went back to read notes from when we deployed `-Wstrict-prototypes` (which we have had on-by-default for our users for a couple of years, since it catches lots of `-fblocks`-related bugs). I was mainly objecting because I had (mis)remembered trying and backing

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

thakis added a comment. This is a cool warning. Could the note have a fixit attached to it, so that it's easy to mass-clean-up the warning automatically? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

boga95 updated this revision to Diff 218395. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp test/Analysis/taint-generic.c Index: test/Analysis/taint-generic.c

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge added a comment. In D66990#1654312 , @ilya-biryukov wrote: > I think this makes sense, but it should be done for **all** declarations and > not just functions. > But doing that in the current design would mean we need to double the number > of

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane marked 9 inline comments as done. jpakkane added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything())), unless(isInstantiated())) +

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 218392. jpakkane added a comment. Updated to fix review comments. NOTE: detecting the include fix is broken because I could not get it to work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files:

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. In D64672#1654983 , @craig.topper wrote: > In D64672#1654687 , @RKSimon wrote: > > > Tests look great - please can you pre-commit them and update the patch to > > show the diff? Also,

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 218388. krisb marked an inline comment as done. krisb added a comment. Applied the comment: enable 'sha2' and 'aes' only for armv8 A profile, report warning and disable 'crypto' for other archs. Add more tests. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper added a comment. In D64672#1654687 , @RKSimon wrote: > Tests look great - please can you pre-commit them and update the patch to > show the diff? Also, maybe call the test file x86-vec-i128.c and add a > comment in the file describing

[PATCH] D67065: [RISCV] Define __riscv_cmodel_medlow and __riscv_cmodel_medany correctly

lenary added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:91 Builder.defineMacro("__riscv_xlen", Is64Bit ? "64" : "32"); // TODO: modify when more code models are supported. + StringRef CodeModel = getTargetOpts().CodeModel; This TODO

[PATCH] D67084: Fix bugprone-argument-comment bug: negative literal number is not checked.

xyb created this revision. xyb added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. For example: void foo(int a); foo(-2); should be fixed as: foo(/*a=*/-2); This change tries to fix this issue. Repository: rCTE Clang Tools Extra

[PATCH] D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

gribozavr added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66706/new/ https://reviews.llvm.org/D66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL370677: [Wdocumentation] fixes an assertion failure with typedefed function and block… (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r370677 - [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

Author: gribozavr Date: Mon Sep 2 11:24:33 2019 New Revision: 370677 URL: http://llvm.org/viewvc/llvm-project?rev=370677=rev Log: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer Summary: The assertion happens when compiling with -Wdocumentation with

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

erichkeane added a comment. In D67058#1654347 , @lebedev.ri wrote: > Tests missing. > Is that what gcc does? I'd personally thought those should be internalized. GCC doesn't implement CPU dispatch, this is an ICC thing. ICC uses the Windows behavior

[PATCH] D50147: clang-format: support external styles

MyDeveloperDay added a comment. but perhaps I'm really just agreeing to @sammccall 's suggestion of "-style=" which kind of feels sufficient to me.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50147/new/ https://reviews.llvm.org/D50147

[PATCH] D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

Mordante added a comment. Thanks for the review. using D = void(); D = ...; ///< \return none Is no issue, I added tests for it. Can you commit the code for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66706/new/ https://reviews.llvm.org/D66706

[PATCH] D50147: clang-format: support external styles

MyDeveloperDay added a comment. I am not opposed to this idea, I actually think this has some mileage based on a use case I've encountered: our team tends to use windows builds of clang-format from (https://llvm.org/builds/) because its easy to distribute the installer, this is ok but

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL370673: [SVE][Inline-Asm] Support for SVE asm operands (authored by kmclaughlin, committed by ). Changed prior to commit: https://reviews.llvm.org/D66302?vs=216655=218376#toc Repository: rL LLVM

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

ostannard added a comment. LGTM with one small nit. Comment at: clang/utils/TableGen/NeonEmitter.cpp:1906 std::string Intrinsic::generate() { + // Avoid duplicated code for big and small endians + if (isBigEndianSafe()) { s/small endians/little endian/

r370671 - ThinLTO: Document the option BOOTSTRAP_LLVM_ENABLE_LTO

Author: sylvestre Date: Mon Sep 2 08:34:53 2019 New Revision: 370671 URL: http://llvm.org/viewvc/llvm-project?rev=370671=rev Log: ThinLTO: Document the option BOOTSTRAP_LLVM_ENABLE_LTO Modified: cfe/trunk/docs/ThinLTO.rst Modified: cfe/trunk/docs/ThinLTO.rst URL:

[PATCH] D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

jsji added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66748/new/ https://reviews.llvm.org/D66748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67080: Fix bugprone-argument-comment bug if there are marcos.

xyb updated this revision to Diff 218372. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67080/new/ https://reviews.llvm.org/D67080 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tools-extra/test/clang-tidy/bugprone-argument-comment-literals.cpp Index:

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

jsji added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66699/new/ https://reviews.llvm.org/D66699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67080: Fix bugprone-argument-comment bug if there are marcos.

xyb created this revision. xyb added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix bugprone-argument-comment bug if there are marcos. For example: #define X(x) (x) void j(int a, int b, int c); j(X(1), /*b=*/1, X(1)); clang-tidy can't

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:211 }, - /*IsPrunable=*/true); + /*IsPrunable=*/!CastCtx.CastSucceeds); } That could be helpful, but I

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. The key is `CXXRecordDecl::isDerivedFrom()`. Repository:

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard marked 4 inline comments as done. ostannard added a comment. > It isn't that common, but it seems worth doing if it can be done easily. > That said, I note that it does appear that your implementation will end up > preserving the pointer in the vtable in this case because you're

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard updated this revision to Diff 218363. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D67023: Diagnose use of ATOMIC_VAR_INIT

aaron.ballman added a comment. In D67023#1654070 , @jfb wrote: > I refer you to http://wg21.link/p0883 > I don’t think this diagnostic should be added to clang until p0883 is fully > implemented, even just for C. Otherwise we leave users with no

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. Tests look great - please can you pre-commit them and update the patch to show the diff? Also, maybe call the test file x86-vec-i128.c and add a comment in the file describing PR42607? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66694: [libclang][index][NFCi] Refactor machinery for skipping already parsed function bodies

gribozavr added inline comments. Comment at: clang/tools/libclang/Indexing.cpp:134 void copyTo(PPRegionSetTy ) { std::lock_guard MG(Mux); Set = ParsedRegions; jkorous wrote: > gribozavr wrote: > > I think we should lock both the source and

[PATCH] D67077: [libclang] Refactored SharedParsedRegionsStorage

gribozavr created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. gribozavr added a reviewer: jkorous. Herald added a subscriber: dexonsmith. Removed the `PPRegionSetTy` typedef because it is only used 3 times, and obscures code more than it helps.

[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:174 + /// This location is used by clients rendering diagnostics. + virtual PathDiagnosticLocation getLocation(const SourceManager ) const { +

r370650 - [unittests][AST] CommentParser: don't name variable 'DEBUG'

Author: lebedevri Date: Mon Sep 2 05:34:21 2019 New Revision: 370650 URL: http://llvm.org/viewvc/llvm-project?rev=370650=rev Log: [unittests][AST] CommentParser: don't name variable 'DEBUG' It's may be an already-defined macro name, resulting in compilation errors. Modified:

[PATCH] D66806: [LifetimeAnalysis] Fix some false positives

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Looks like a reasonable way to suppress some false positives. It will suppress some true positives (e.g., imagine an "identity" function that returns the same pointer as was provided to

[PATCH] D66652: [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes.

gribozavr added a comment. > So, I plan to rework this into two revisions: one to match > https://reviews.llvm.org/D66676 (and keep the tests esssentially as they are) > and one to add getRuleMatchLoc for future use. That SGTM. I don't have an opinion about whether they should be separate

[PATCH] D65182: [analyzer] Add fix-it hint support.

gribozavr added inline comments. Comment at: clang/test/Analysis/dead-stores.c:11 long idx=abc+3*5; // expected-warning {{never read}} expected-warning{{unused variable 'idx'}} + // expected-remark-re@-1.*}}:11 - {{.*}}:18 - ''}} } NoQ wrote: >

[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

gribozavr added a comment. Thank you for the conversation so far! This is not a complete review from me, but I'm trying to avoid branching in too many directions at once. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:122 + /// Get the

Re: r370642 - Revert [Clang Interpreter] Initial patch for the constexpr interpreter

When reverting a commit it is customary to mention *why* it is getting reverted. On Mon, Sep 2, 2019 at 2:33 PM Nandor Licker via cfe-commits wrote: > > Author: nand > Date: Mon Sep 2 04:34:47 2019 > New Revision: 370642 > > URL: http://llvm.org/viewvc/llvm-project?rev=370642=rev > Log: >

r370642 - Revert [Clang Interpreter] Initial patch for the constexpr interpreter

Author: nand Date: Mon Sep 2 04:34:47 2019 New Revision: 370642 URL: http://llvm.org/viewvc/llvm-project?rev=370642=rev Log: Revert [Clang Interpreter] Initial patch for the constexpr interpreter This reverts r370636 (git commit 8327fed9475a14c3376b4860c75370c730e08f33) Removed:

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

uenoku accepted this revision. uenoku added a comment. This revision is now accepted and ready to land. I think the logic is sound. It looks good to me. Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2618 +else + Attrs.emplace_back(Attribute::get(Ctx,

[PATCH] D65182: [analyzer] Add fix-it hint support.

gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:350 + + llvm::ArrayRef getFixits() const { return Fixits; } + No need to qualify with "llvm::". Comment at:

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370639: [AST] AST structural equivalence to work internally with pairs. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r370639 - [AST] AST structural equivalence to work internally with pairs.

Author: balazske Date: Mon Sep 2 04:01:09 2019 New Revision: 370639 URL: http://llvm.org/viewvc/llvm-project?rev=370639=rev Log: [AST] AST structural equivalence to work internally with pairs. Summary: The structural equivalence check stores now pairs of nodes in the 'from' and 'to' context

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:460 + using iterator = ReportList::iterator; + using const_iterator = ReportList::const_iterator; + gribozavr wrote: > gribozavr wrote: > > I don't

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:460 + using iterator = ReportList::iterator; + using const_iterator = ReportList::const_iterator; + gribozavr wrote: > I don't think we intend users

[PATCH] D67065: [RISCV] Define __riscv_cmodel_medlow and __riscv_cmodel_medany correctly

lewis-revill accepted this revision. lewis-revill added a comment. This revision is now accepted and ready to land. Thanks Kito. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67065/new/ https://reviews.llvm.org/D67065

[PATCH] D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers

rovka added a comment. Just some drive-by suggestions :) Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:5747 + +PredicateConstraint isPredicateConstraint(StringRef Constraint) { + PredicateConstraint P = PredicateConstraint::Invalid; Nit: I think get-

[PATCH] D67066: [RISCV] Add option aliases: -mcmodel=medany and -mcmodel=medlow

kito-cheng created this revision. kito-cheng added reviewers: asb, apazos. Herald added subscribers: cfe-commits, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal,

[PATCH] D67065: [RISCV] Define __riscv_cmodel_medlow and __riscv_cmodel_medany correctly

kito-cheng created this revision. kito-cheng added reviewers: asb, apazos, lewis-revill. Herald added subscribers: cfe-commits, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva0217,

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske marked 3 inline comments as done. balazske added a comment. In D64480#1653629 , @shafik wrote: > It is worth noting that: > > typedef int T; > typedef int T; > > > is not valid C99 see godbolt Should we handle

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thanks for the simplification! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:460 + using iterator = ReportList::iterator; + using

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

lebedev.ri added a comment. Tests missing. Is that what gcc does? I'd personally thought those should be internalized. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67058/new/ https://reviews.llvm.org/D67058 ___

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

gribozavr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/misc-unused-using-decls.cpp:214 +class Bar {}; +Bar *bar; It is very unclear what this test does, if I didn't know about this bug. Could you add a comment? Repository: rG LLVM

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske updated this revision to Diff 218311. balazske added a comment. - Removed unneeded structs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske updated this revision to Diff 218310. balazske added a comment. Improved the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

ilya-biryukov added a comment. In D66990#1653833 , @nridge wrote: > I think it makes sense to style function declarations differently from > function uses for emphasis. For example, you can use the same color for both, > but make the declarations bold.

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

ilya-biryukov added a comment. In D66990#1653833 , @nridge wrote: > There is precedent for highlighting declarations and uses differently in > other C++ editors. For example, Eclipse CDT has separate highlightings for > function and functions

[PATCH] D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. LGTM, but could you also verify that references are not an issue? using D = void(); D = ...; ///< \return none CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66706/new/

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio added a comment. Hi, I do agree that giving the user a warning that the argument is ignored is the best solution. If you wouldn't mind adding it to this patch, that would be great. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/

[PATCH] D66866: [ASTImporter] At import of records re-order indirect fields too.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370621: [ASTImporter] At import of records re-order indirect fields too. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r370621 - [ASTImporter] At import of records re-order indirect fields too.

Author: balazske Date: Mon Sep 2 00:17:01 2019 New Revision: 370621 URL: http://llvm.org/viewvc/llvm-project?rev=370621=rev Log: [ASTImporter] At import of records re-order indirect fields too. Summary: Correct order of fields and indirect fields in imported RecordDecl is needed for correct

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

a_sidorin accepted this revision. a_sidorin added a comment. Looks good, thank you for addressing the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66538/new/ https://reviews.llvm.org/D66538