[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. For reference, I also posted a proof-of-concept client impl in D67537 , which I used to test/validate this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge added a comment. This is not for review yet, I'm just posting it to illustrate the client side of D67536 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67537 Files:

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge created this revision. nridge added reviewers: sammccall, ilya-biryukov, hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. nridge added a comment. This patch adds server-side support for greying out code in inactive

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. This patch adds server-side support for greying out code in inactive preprocessor branches (issue #132 ). I didn't write test yet. I wanted to post the patch for feedback first, to see if the general approach is ok.

[PATCH] D67490: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67490/new/ https://reviews.llvm.org/D67490

r371816 - Fix interaction between r371813 and r371814.

Author: rsmith Date: Thu Sep 12 22:29:16 2019 New Revision: 371816 URL: http://llvm.org/viewvc/llvm-project?rev=371816=rev Log: Fix interaction between r371813 and r371814. Modified: cfe/trunk/test/CodeGen/builtins-ppc-altivec.c Modified: cfe/trunk/test/CodeGen/builtins-ppc-altivec.c URL:

r371814 - Remove reliance on lax vector conversions from altivec.h and its test.

Author: rsmith Date: Thu Sep 12 22:19:12 2019 New Revision: 371814 URL: http://llvm.org/viewvc/llvm-project?rev=371814=rev Log: Remove reliance on lax vector conversions from altivec.h and its test. Modified: cfe/trunk/include/clang/Basic/BuiltinsPPC.def cfe/trunk/lib/Headers/altivec.h

r371813 - Revert "For PR17164: split -fno-lax-vector-conversion into three different"

Author: jdevlieghere Date: Thu Sep 12 22:16:59 2019 New Revision: 371813 URL: http://llvm.org/viewvc/llvm-project?rev=371813=rev Log: Revert "For PR17164: split -fno-lax-vector-conversion into three different" This breaks the LLDB build. I tried reaching out to Richard, but haven't gotten a

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

rjmccall added a comment. I have to say that I disagree. The ABI certainly doesn't get to control the language and define what constitutes a volatile access, but when the language has decided that a volatile access is actually performed, I think ABIs absolutely ought to define how they should

r371805 - For PR17164: split -fno-lax-vector-conversion into three different

Author: rsmith Date: Thu Sep 12 19:20:00 2019 New Revision: 371805 URL: http://llvm.org/viewvc/llvm-project?rev=371805=rev Log: For PR17164: split -fno-lax-vector-conversion into three different levels: -- none: no lax vector conversions [new GCC default] -- integer: only conversions between

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: test/Sema/typo-correction-ambiguity.cpp:7 + +namespace AmibguousCorrection +{ Is the typo in "Ambiguous" here intentional? :) Repository:

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

tlively added a comment. In D67425#1668831 , @aheejin wrote: > LGTM. > > - Maybe we can lower these > > to these new

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. LGTM. - Maybe we can lower these to these new

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

rsmith added a comment. In D67399#1668759 , @rjmccall wrote: > The exact sequence of volatile accesses is observable behavior, and it's the > ABI's right to define correct behavior for compliant implementations, so we > do need to do this. I'm not

[PATCH] D61717: Fix arm_neon.h to be clean under -fno-lax-vector-conversions.

rsmith abandoned this revision. rsmith added a comment. This patch doesn't work, and the ARM NEON intrinsic header emitter is too opaque and mysterious for me to be able to fix this, and it's not even clear that the generator knows what the actual parameter types of the compiler builtins are.

r371799 - Revert r371785.

Author: manojgupta Date: Thu Sep 12 17:28:37 2019 New Revision: 371799 URL: http://llvm.org/viewvc/llvm-project?rev=371799=rev Log: Revert r371785. r371785 is causing fails on clang-hexagon-elf buildbots. Removed: cfe/trunk/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain , + const llvm::opt::ArgList , kito-cheng wrote: > MaskRay wrote: > > gold doesn't support RISC-V,

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

rjmccall added a comment. The exact sequence of volatile accesses is observable behavior, and it's the ABI's right to define correct behavior for compliant implementations, so we do need to do this. Diogo, IRGen breaks up bit-field storage units in CGRecordLowering::accumulateBitFields. I'm

r371794 - [libclang] Fix UninstallAbortingLLVMFatalErrorHandler test

Author: jkorous Date: Thu Sep 12 16:51:48 2019 New Revision: 371794 URL: http://llvm.org/viewvc/llvm-project?rev=371794=rev Log: [libclang] Fix UninstallAbortingLLVMFatalErrorHandler test Modified: cfe/trunk/unittests/libclang/CrashTests/LibclangCrashTest.cpp Modified:

[PATCH] D63031: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

dblaikie added a comment. Some more ping (: Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63031/new/ https://reviews.llvm.org/D63031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r371787 - [libclang] Expose abort()-ing LLVM fatal error handler

Author: jkorous Date: Thu Sep 12 15:55:55 2019 New Revision: 371787 URL: http://llvm.org/viewvc/llvm-project?rev=371787=rev Log: [libclang] Expose abort()-ing LLVM fatal error handler Differential Revision: https://reviews.llvm.org/D66775 Added: cfe/trunk/include/clang-c/FatalErrorHandler.h

[PATCH] D52524: Add -Wpoison-system-directories warning

manojgupta closed this revision. manojgupta added a comment. Submitted as https://reviews.llvm.org/rL371785. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 ___ cfe-commits

r371785 - Add -Wpoison-system-directories warning

Author: manojgupta Date: Thu Sep 12 15:36:13 2019 New Revision: 371785 URL: http://llvm.org/viewvc/llvm-project?rev=371785=rev Log: Add -Wpoison-system-directories warning When using clang as a cross-compiler, we should not use system headers to do the compilation. This CL adds support of a new

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:517 +if (V) + State = addTaint(State, *V, TaintTagNotTainted); + } Why not simply remove taint? CHANGES SINCE LAST ACTION

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jfb accepted this revision. jfb added a comment. Sounds like this is ready to land again! Thanks for fixing everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146

[PATCH] D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

NoQ added a comment. rC371781 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66714/new/ https://reviews.llvm.org/D66714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r371781 - [analyzer] Fix the 'analyzer-enabled-checkers.c' test on non-linux machines.

Author: dergachev Date: Thu Sep 12 15:11:15 2019 New Revision: 371781 URL: http://llvm.org/viewvc/llvm-project?rev=371781=rev Log: [analyzer] Fix the 'analyzer-enabled-checkers.c' test on non-linux machines. '-Xclang -triple' doesn't seem to override the default target triple as reliably as

[PATCH] D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

NoQ added a comment. Umm, this test fails for me locally because i see `osx` checkers displayed in the list. Which is weird because they're supposed to be enabled based on the target platform, not on the host platform. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

rsmith added a comment. In D67414#1668475 , @mstorsjo wrote: > In D67414#1668443 , @rsmith wrote: > > > Seems very surprising to me that the `gnu_inline` attribute has different > > behavior in their C and C++

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

jonathanmeier added a comment. Nice! I don't have commit access, so we'll need someone else have another look. @alexfh, since you previously worked on this, would you mind taking a look at this patch? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker.

NoQ added a comment. `SimpleStreamChecker` is a historical tutorial example , i don't think we should be updating it other than for modernizing checker API use. It was supposed to handle a few simple examples correctly but it wasn't supposed to

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 220007. poelmanc added a comment. Sorry one more test at the end to make sure a multi-typedef with all that Variadic stuff still doesn't get changed to using. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 220002. poelmanc added a comment. Nice catch, that simplifies the code quite a bit! I added two more nested, complex multiple-template-argument tests and am happy to add more. (We could do a case fallthrough after tok::l_brace, though some linters warn

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Szelethus added a comment. Yes, thank you! I've been keeping my mailbox open and commiting slowly, it seems like the buildbots have a wrong email address set up for me. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67140/new/ https://reviews.llvm.org/D67140

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

NoQ added a subscriber: timshen. NoQ added a comment. rL371773 - thanks @timshen! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67140/new/ https://reviews.llvm.org/D67140 ___

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus added a comment. In D67420#1668474 , @NoQ wrote: > It's not that `AnalyzerOptions` is //necessary// to construct this, it's more > like //sufficient//. *sudden enlightenment* Ah, okay, right, I'm a dummie, I think I got what's happening

[clang-tools-extra] r371773 - [ClangTidy] Adjust the name getCheckName to getCheckerName due to API change.

Author: timshen Date: Thu Sep 12 14:18:44 2019 New Revision: 371773 URL: http://llvm.org/viewvc/llvm-project?rev=371773=rev Log: [ClangTidy] Adjust the name getCheckName to getCheckerName due to API change. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp Modified:

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a comment. In D67420#1668099 , @Szelethus wrote: > ...and the second is similar in nature, but in the actual code -- it doesn't > doesn't feel natural to me that `AnalyzerOptions` is required to construct > this, while at the same time we're

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

mstorsjo added a comment. In D67414#1668443 , @rsmith wrote: > Seems very surprising to me that the `gnu_inline` attribute has different > behavior in their C and C++ frontends. That said, it looks like it's a > behavior that they document; their

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

rsmith added a comment. Seems very surprising to me that the `gnu_inline` attribute has different behavior in their C and C++ frontends. That said, it looks like it's a behavior that they document; their documentation says "In C++, this attribute does not depend on extern in any way, but it

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain , + const llvm::opt::ArgList , MaskRay wrote: > gold doesn't support RISC-V, does it? Gold

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

mstorsjo marked 2 inline comments as done. mstorsjo added inline comments. Comment at: lib/AST/Decl.cpp:3283 if (Context.getLangOpts().CPlusPlus) return false; nickdesaulniers wrote: > I would have thought the existing case here would handle your

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

nickdesaulniers added inline comments. Comment at: lib/AST/Decl.cpp:3283 if (Context.getLangOpts().CPlusPlus) return false; I would have thought the existing case here would handle your change. If it doesn't, why not? Should your change also remove

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1663748 , @rjmccall wrote: > Hmm, you know, there are enough different FP options that I think we should > probably split them all out into their own section in the manual instead of > just listing them under "code

[PATCH] D67516: [clang] Enable GNU Toolchain to find musl GCC installations

staticfloat created this revision. staticfloat added reviewers: rsmith, fedor.sergeev. staticfloat added a project: clang. Herald added a subscriber: cfe-commits. The GNU Toolchain GCCDetector misses GCC installations with the triplet `x86_64-linux-musl`, looking only instead for

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. I'd like the test cases to actually demonstrate the correct use of the filters and the correct behavior of the Analyzer when the filters are annotated correctly, but it looks to me that they either demonstrate behavior when the annotation is //not// used correctly, or we

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

jonathanmeier added a comment. Thanks, this looks much better now. I think there's no need to track nesting of parenthesis, brackets and braces separately, so we can collapse `ParenLevel`, `BraceLevel` and `SquareBracketLevel` into a single `NestingLevel`, which simplifies all the conditions

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

congliu updated this revision to Diff 219988. congliu marked an inline comment as done. congliu added a comment. Addressed Haojian's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67135/new/ https://reviews.llvm.org/D67135 Files:

[PATCH] D67429: Improve code generation for thread_local variables:

This revision was automatically updated to reflect the committed changes. Closed by commit rL371767: Improve code generation for thread_local variables: (authored by rsmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 updated this revision to Diff 219981. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/lib/StaticAnalyzer/Checkers/Taint.cpp

r371767 - Improve code generation for thread_local variables:

Author: rsmith Date: Thu Sep 12 13:00:24 2019 New Revision: 371767 URL: http://llvm.org/viewvc/llvm-project?rev=371767=rev Log: Improve code generation for thread_local variables: Summary: * Don't bother using a thread wrapper when the variable is known to have constant initialization. *

[PATCH] D66715: [CFG] Add dumps for CFGElement and CFGElementRef

This revision was automatically updated to reflect the committed changes. Closed by commit rL371765: [CFG] Add dumps for CFGElement and CFGElementRef (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371766 - [Clang][CodeGen] support alias attribute w/ gnu_inline

Author: nickdesaulniers Date: Thu Sep 12 12:53:35 2019 New Revision: 371766 URL: http://llvm.org/viewvc/llvm-project?rev=371766=rev Log: [Clang][CodeGen] support alias attribute w/ gnu_inline Summary: r369705 did not consider the addition of gnu_inline on function declarations of alias

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

This revision was automatically updated to reflect the committed changes. Closed by commit rL371766: [Clang][CodeGen] support alias attribute w/ gnu_inline (authored by nickdesaulniers, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r371765 - [CFG] Add dumps for CFGElement and CFGElementRef

Author: szelethus Date: Thu Sep 12 12:52:34 2019 New Revision: 371765 URL: http://llvm.org/viewvc/llvm-project?rev=371765=rev Log: [CFG] Add dumps for CFGElement and CFGElementRef Seems like we never had these, so here we go! I also did some refactoring as I was chasing a bug unrelated to this

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

dgoldman updated this revision to Diff 219978. dgoldman added a comment. - Fix method name in test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67515/new/ https://reviews.llvm.org/D67515 Files: lib/Sema/SemaExprCXX.cpp

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk added a comment. > I was unable to reproduce the failures when I moved the check to createFile. > What kind of failures did you see? Did you move it right to the start of the > function? I would recommend rebasing the patch and retrying. I saw an assertion error - but I realize now

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219976. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219975. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

dgoldman created this revision. dgoldman added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug introduced in D62648 , where Clang could infinite loop if it became stuck on a single TypoCorrection when it

[PATCH] D67509: [CUDA][HIP] Diagnose defaulted constructor only if it is used

tra added a comment. Example of the actual error produced by clang: https://godbolt.org/z/Dl1FfC Ugh. Another corner case of the way we're dealing with implicit `__host__ __device__` functions. :-( LGTM for postponing the error until actual use. Comment at:

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

This revision was automatically updated to reflect the committed changes. Closed by commit rL371760: [analyzer][NFC] Fix inconsistent references to checkers as checks (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r371760 - [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Author: szelethus Date: Thu Sep 12 12:09:24 2019 New Revision: 371760 URL: http://llvm.org/viewvc/llvm-project?rev=371760=rev Log: [analyzer][NFC] Fix inconsistent references to checkers as "checks" Traditionally, clang-tidy uses the term check, and the analyzer uses checker, but in the very

r371759 - NFC, add missing cl::cat option category to clang-scan-deps options to ensure they show up in -help

Author: arphaman Date: Thu Sep 12 12:00:32 2019 New Revision: 371759 URL: http://llvm.org/viewvc/llvm-project?rev=371759=rev Log: NFC, add missing cl::cat option category to clang-scan-deps options to ensure they show up in -help Modified: cfe/trunk/tools/clang-scan-deps/ClangScanDeps.cpp

[PATCH] D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rL371756: [analyzer] Dont run the analyzer for -analyzer-list-enabled-checkers (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

broadwaylamb added a comment. In D66981#1651897 , @phosek wrote: > LGTM Can you please commit this? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66981/new/

r371756 - [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

Author: szelethus Date: Thu Sep 12 11:53:48 2019 New Revision: 371756 URL: http://llvm.org/viewvc/llvm-project?rev=371756=rev Log: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers Short and sweet. Whenever I use -analyzer-list-enabled-checkers, I'm only interested about the

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman added a subscriber: jkorous. arphaman added a comment. In D67091#1667821 , @kousikk wrote: > Sorry about the delay on this - I was OOO (back now). > > 1. I added tests. > 2. I couldn't add isDirectory() check to createFile() since that resulted

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 219957. poelmanc added a comment. Thanks for the stressing test cases. I reverted to your original test case with a single >, added a separate one with a single <, and expanded the final case to have a non-balanced number of > and <. I added all your new

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL371753: [MS] Warn when shadowing template parameters under -fms-compatibility (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67509: [CUDA][HIP] Diagnose defaulted constructor only if it is used

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Clang infers defaulted ctor as `__device__ __host__` and virtual dtor as `__host__`. It diagnose the following code in device compilation as B() references ~A() implicitly. struct A { virtual ~A(); }; struct B: public A

r371753 - [MS] Warn when shadowing template parameters under -fms-compatibility

Author: rnk Date: Thu Sep 12 11:26:34 2019 New Revision: 371753 URL: http://llvm.org/viewvc/llvm-project?rev=371753=rev Log: [MS] Warn when shadowing template parameters under -fms-compatibility Summary: C++ does not allow shadowing template parameters, but previously we allowed it under

Re: r371663 - Start porting ivfsoverlay tests to Windows

Thanks, that seems like the correct fix. The property that makes them fail is the native system path style, not the default target. On Thu, Sep 12, 2019 at 5:03 AM Jeremy Morse wrote: > On Thu, Sep 12, 2019 at 11:24 AM Jeremy Morse > wrote: > > Assuming no-one else is looking at this, I'll

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. > I see some problems with using llvm-objcopy for that. First issue is that > symbols created by llvm-objcopy for embedded data depend on the input file > name. As you know these symbols are referenced from the offload registration > code that is currently

r371751 - [clang-scan-deps] remove dots and dots dots from the reported file dependency paths

Author: arphaman Date: Thu Sep 12 11:03:24 2019 New Revision: 371751 URL: http://llvm.org/viewvc/llvm-project?rev=371751=rev Log: [clang-scan-deps] remove dots and dots dots from the reported file dependency paths This resolves differences observed on LLVM + Clang when running the comparison

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1668006 , @JonChesterfield wrote: > >> Does this diff mix getting rid of the linker script with other changes? > >> E.g. it looks like the metadata generation is moving from clang to the new > >> tool, but that

[PATCH] D67426: Don't warn about selectany on implicitly inline variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGb00a49d1b3a1: Dont warn about selectany on implicitly inline variables (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67426/new/

r371749 - Don't warn about selectany on implicitly inline variables

Author: rnk Date: Thu Sep 12 10:55:48 2019 New Revision: 371749 URL: http://llvm.org/viewvc/llvm-project?rev=371749=rev Log: Don't warn about selectany on implicitly inline variables Summary: This avoids a -Wignored-attribute warning on the code pattern Microsoft recommends for integral const

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. In D64146#1667567 , @nand wrote: > Thanks for looking into the problem - sorry for the delay! No problem, you still need a specialist to approve the patch though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus added a comment. In D67420#1666578 , @NoQ wrote: > In D67420#1666141 , @Szelethus wrote: > > > I do! > > > Hmm, it sounds like you want to force both Clang frontend and Clang-Tidy to > use the same set

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2266 let Spellings = [CXX11<"", "maybe_unused", 201603>, GCC<"unused">, - C2x<"", "maybe_unused">]; + C2x<"",

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain , + const llvm::opt::ArgList , gold doesn't support RISC-V, does it? CHANGES SINCE LAST ACTION

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 219941. khchen added a comment. @lenary Yes, you are right. add LTO support for Linux platform. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. >> Does this diff mix getting rid of the linker script with other changes? E.g. >> it looks like the metadata generation is moving from clang to the new tool, >> but that seems orthogonal to dropping the linker script. > > Metadata is still generated by the

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1667469 , @JonChesterfield wrote: > I'm on board with getting rid of the linker script. Gold's limited support > for that seems conclusive. > > I believe the current script does two things: > 1/ takes a binary and

[PATCH] D52524: Add -Wpoison-system-directories warning

denik marked 2 inline comments as done. denik added inline comments. Comment at: clang/lib/Frontend/InitHeaderSearch.cpp:141-143 + if (HasSysroot) { +if (MappedPathStr.startswith("/usr/include") || +MappedPathStr.startswith("/usr/local/include")) {

[PATCH] D52524: Add -Wpoison-system-directories warning

denik updated this revision to Diff 219924. denik added a comment. Combined two if into one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/Frontend/InitHeaderSearch.cpp

r371742 - [Alignment] Move OffsetToAlignment to Alignment.h

Author: gchatelet Date: Thu Sep 12 08:20:36 2019 New Revision: 371742 URL: http://llvm.org/viewvc/llvm-project?rev=371742=rev Log: [Alignment] Move OffsetToAlignment to Alignment.h Summary: This is patch is part of a series to introduce an Alignment type. See this thread for context:

[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL371742: [Alignment] Move OffsetToAlignment to Alignment.h (authored by gchatelet, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

gchatelet updated this revision to Diff 219923. gchatelet marked an inline comment as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67499/new/ https://reviews.llvm.org/D67499 Files:

[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

courbet added inline comments. Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1024 NextBlockOffset = BBInfo[Water->getNumber()].postOffset(); -NextBlockLogAlignment = 0; +NextBlockAlignment = llvm::Align(); } else { this statement is

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

xyb created this revision. xyb added a reviewer: alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Clang-tidy supports output diagnostics from header files if user specifies --header-filter. But it can't handle relative path well. For example, the folder

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk added a comment. Sorry about the delay on this - I was OOO (back now). 1. I added tests. 2. I couldn't add isDirectory() check to createFile() since that resulted in failures to normal scenarios where it was previously passing. PTAL! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219918. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219917. kousikk added a comment. - Add tests and remove the fix inside createFile since it fails in other cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, seiya, jsji, atanasyan, MaskRay, jrtc27, jakehehrlich, kbarton, hiraditya, nemanjai, sdardis. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexshap. Herald

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

MyDeveloperDay added a comment. > Yes, it would be good if it is landed. And can I know the procedure for > getting commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5998 +QualType Type = Var->getType(); +if (Type->isSamplerT() || Type->isVoidType()) + return; I don't seem to need a check for

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Manikishan added a comment. >>! In D64695#1667696 , >>@MyDeveloperDay wrote: > Does this need landing? given that you have a number of patches in flight > perhaps it would be good to request commit access Yes, it would be good if it is landed. And can

  1   2   >