[clang] 6589a29 - [Driver][test] Create empty file Inputs/basic_cross_linux_tree/usr/x86_64-unknown-linux-gnu/bin/ld.lld

Author: Fangrui Song Date: 2020-02-07T23:30:54-08:00 New Revision: 6589a2914762eb6c2a1181c6b71edbb5d09130b2 URL: https://github.com/llvm/llvm-project/commit/6589a2914762eb6c2a1181c6b71edbb5d09130b2 DIFF: https://github.com/llvm/llvm-project/commit/6589a2914762eb6c2a1181c6b71edbb5d09130b2.diff

[clang] 8aa3f50 - [Driver] Don't pass -plugin LLVMgold.so when the linker is ld.lld

Author: Fangrui Song Date: 2020-02-07T22:53:14-08:00 New Revision: 8aa3f507c38a2ccd8ed7cb33d02a6f645cdbc03a URL: https://github.com/llvm/llvm-project/commit/8aa3f507c38a2ccd8ed7cb33d02a6f645cdbc03a DIFF: https://github.com/llvm/llvm-project/commit/8aa3f507c38a2ccd8ed7cb33d02a6f645cdbc03a.diff

[clang] 70e0935 - [Driver][test] Refactor LLVMgold tests

Author: Fangrui Song Date: 2020-02-07T22:37:11-08:00 New Revision: 70e0935256fc173fbc57c7333727ab222af476eb URL: https://github.com/llvm/llvm-project/commit/70e0935256fc173fbc57c7333727ab222af476eb DIFF: https://github.com/llvm/llvm-project/commit/70e0935256fc173fbc57c7333727ab222af476eb.diff

[clang] 8d4fe86 - [Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds after 305bf5b21dbdb2345ef86b5700285e42d992c954

Author: Fangrui Song Date: 2020-02-07T22:28:45-08:00 New Revision: 8d4fe864c4bdc53b3e6a2df43112520cb646afcf URL: https://github.com/llvm/llvm-project/commit/8d4fe864c4bdc53b3e6a2df43112520cb646afcf DIFF: https://github.com/llvm/llvm-project/commit/8d4fe864c4bdc53b3e6a2df43112520cb646afcf.diff

[PATCH] D72954: [clang-doc] Improving Markdown Output

phosek added a comment. This is failing on Windows: ../../clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp(77): error: Expected: Expected Which is: "# namespace Namespace\n\n\n\n## Namespaces\n\n* [ChildNamespace](../ChildNamespace/index.md)\n\n\n## Records\n\n*

[clang-tools-extra] 7b627bb - Revert "[clang-doc] Improving Markdown Output"

Author: Petr Hosek Date: 2020-02-07T19:43:47-08:00 New Revision: 7b627bb6e019b5457aa64ea19debefe307f68a19 URL: https://github.com/llvm/llvm-project/commit/7b627bb6e019b5457aa64ea19debefe307f68a19 DIFF: https://github.com/llvm/llvm-project/commit/7b627bb6e019b5457aa64ea19debefe307f68a19.diff

[PATCH] D72954: [clang-doc] Improving Markdown Output

This revision was automatically updated to reflect the committed changes. Closed by commit rGdac21fdd5923: [clang-doc] Improving Markdown Output (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/

[clang-tools-extra] dac21fd - [clang-doc] Improving Markdown Output

Author: Petr Hosek Date: 2020-02-07T19:17:03-08:00 New Revision: dac21fdd5923730342a4bc9abc0858fb56ff8d52 URL: https://github.com/llvm/llvm-project/commit/dac21fdd5923730342a4bc9abc0858fb56ff8d52 DIFF: https://github.com/llvm/llvm-project/commit/dac21fdd5923730342a4bc9abc0858fb56ff8d52.diff

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + kiranchandramohan wrote: >

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

rjmccall added a comment. In D69272#1865266 , @rsmith wrote: > I don't see any changes to the constant evaluator here. You need to properly > handle constant evaluation within `FENV_ACCESS ON` contexts, somehow, or > you'll miscompile floating-point

[clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

Author: Richard Smith Date: 2020-02-07T18:40:41-08:00 New Revision: 0e3a48778408b505946e465abf5c77a2ddd4918c URL: https://github.com/llvm/llvm-project/commit/0e3a48778408b505946e465abf5c77a2ddd4918c DIFF: https://github.com/llvm/llvm-project/commit/0e3a48778408b505946e465abf5c77a2ddd4918c.diff

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

plotfi added a comment. @thakis I got sidetracked by some other things and had not made more progress, if progress is not made yes I think -emit-interface-stubs should imply -fno-integrated-cc1 if that seems like the right thing to do to you. @erichkeane Thanks for filing the bugzilla bug. I

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I don't see any changes to the constant evaluator here. You need to properly handle constant evaluation within `FENV_ACCESS ON` contexts, somehow, or you'll miscompile

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 243325. simoncook added a comment. Add support for Z extensions also under this scheme. In order to support these I've had to tweak the multi-letter extension parsing a little. The net result is that error messages printed regarding version numbers are

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

kiranchandramohan added inline comments. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + jdoerfert wrote: > kiranchandramohan wrote: > > jdoerfert wrote: > >

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

grokos created this revision. grokos added reviewers: hfinkel, jdoerfert, ABataev, mdtoguchi, kbobrovs, sdmitriev. grokos added a project: clang. Herald added a subscriber: Anastasia. This is the bundler-side patch for enabling static library support in clang. The scheme has been discussed

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 243307. logan-5 marked an inline comment as done. logan-5 added a comment. Changed `Whitelist` to `AllowedIdentifiers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72282/new/ https://reviews.llvm.org/D72282

[PATCH] D74260: Change default relocation model for hexagon when triple includes musl

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, martell, dalias. Herald added a project: clang. Herald added a subscriber: cfe-commits. Right now if the triple includes musl, saying something like: "--target=x86_64--linux-musl" then the default relocation model is pic.

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") JDevlieghere wrote: > kschwarz wrote: > > Hi

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") kschwarz wrote: > Hi @JDevlieghere, we've noticed that

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

This revision was automatically updated to reflect the committed changes. Closed by commit rGd65bbf81f8be: [clang] Add support for __builtin_memcpy_inline (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/

[clang] d65bbf8 - [clang] Add support for __builtin_memcpy_inline

Author: Guillaume Chatelet Date: 2020-02-07T23:55:26+01:00 New Revision: d65bbf81f8be3ff806b86776cf95b001a4cf43ad URL: https://github.com/llvm/llvm-project/commit/d65bbf81f8be3ff806b86776cf95b001a4cf43ad DIFF:

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added a comment. Thx a lot ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

This revision was automatically updated to reflect the committed changes. Closed by commit rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 243289. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Remove unrelated memcpy in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2229 +* ``memcpy`` * ``memchr`` efriedma wrote: > Not sure putting "memcpy" in this list makes sense. We did add support for > constant-evaluating memcpy, but it was separately

[clang] fafc6e4 - [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

Author: Erik Pilkington Date: 2020-02-07T14:39:31-08:00 New Revision: fafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402 URL: https://github.com/llvm/llvm-project/commit/fafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402 DIFF:

Re: [PATCH] D68720: Support -fstack-clash-protection for x86

On Fri, Feb 07, 2020 at 07:12:39PM +, Nico Weber via Phabricator wrote: > thakis added a comment. > > This breaks check-clang on mac and win: > http://45.33.8.238/mac/7485/step_7.txt http://45.33.8.238/win/7753/step_7.txt > > Please revert and then investigate asynchronously, unless the fix

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 243272. dgoldman added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea updated this revision to Diff 243241. aganea marked 2 inline comments as done. aganea edited the summary of this revision. aganea added a comment. Simplified patch after landing previous incremental changes mentioned above . @arichardson If you

[clang] e8e05de - [OPENMP50]Add codegen for acq_rel clause in atomic|flush directives.

Author: Alexey Bataev Date: 2020-02-07T15:05:09-05:00 New Revision: e8e05de08bea1931420da19462533a8caa4b0e26 URL: https://github.com/llvm/llvm-project/commit/e8e05de08bea1931420da19462533a8caa4b0e26 DIFF: https://github.com/llvm/llvm-project/commit/e8e05de08bea1931420da19462533a8caa4b0e26.diff

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___ cfe-commits mailing list

[PATCH] D68720: Support -fstack-clash-protection for x86

vvereschaka added a comment. Also got failed clang tests on Arm/Aarch64 builders http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4295 http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4277 - FAIL: Clang::stack-clash-protection.c - FAIL:

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

efriedma added a comment. Sorry about the delayed response, I was traveling. Comment at: clang/docs/LanguageExtensions.rst:2252 + + * ``__builtin_memcpy_inline`` + gchatelet wrote: > efriedma wrote: > > This is in the wrong section of the documentation. We

[PATCH] D68720: Support -fstack-clash-protection for x86

thakis added a comment. Reverted in b03c3d8c620 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720

[clang] 42efd35 - [cxx_status] Fix status of P1766R to not bleed into adjacent cells.

Author: Richard Smith Date: 2020-02-07T11:54:48-08:00 New Revision: 42efd35ba04daa2b74f69a05877927af0a8fcbb0 URL: https://github.com/llvm/llvm-project/commit/42efd35ba04daa2b74f69a05877927af0a8fcbb0 DIFF: https://github.com/llvm/llvm-project/commit/42efd35ba04daa2b74f69a05877927af0a8fcbb0.diff

[clang] b03c3d8 - Revert "Support -fstack-clash-protection for x86"

Author: Nico Weber Date: 2020-02-07T14:49:38-05:00 New Revision: b03c3d8c62096af1e27b23480fa4623bb64bfab9 URL: https://github.com/llvm/llvm-project/commit/b03c3d8c62096af1e27b23480fa4623bb64bfab9 DIFF: https://github.com/llvm/llvm-project/commit/b03c3d8c62096af1e27b23480fa4623bb64bfab9.diff

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ae1b4a0ce9c: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7ae1b4a - Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

Author: Richard Smith Date: 2020-02-07T11:47:37-08:00 New Revision: 7ae1b4a0ce9c7f269cf3069e41496a78e3f28d49 URL: https://github.com/llvm/llvm-project/commit/7ae1b4a0ce9c7f269cf3069e41496a78e3f28d49 DIFF: https://github.com/llvm/llvm-project/commit/7ae1b4a0ce9c7f269cf3069e41496a78e3f28d49.diff

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3687 - args.add(EmitAnyExprToTemp(E), type); } thegameg wrote: > Is there any other use of `EmitAnyExprToTemp` that can benefit

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 243251. dgoldman marked 5 inline comments as done. dgoldman added a comment. - Refactor to use `forceRebuild` and `ParseOptions` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:653 - Server->addDocument(File, *Contents, WantDiags); + Server->addDocument(File, *Contents, WantDiags, ForceReload); }

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

thegameg added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3687 - args.add(EmitAnyExprToTemp(E), type); } Is there any other use of `EmitAnyExprToTemp` that can benefit from this? CHANGES SINCE LAST ACTION

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane updated this revision to Diff 243248. erichkeane added a comment. Remove conversions between _ExtInt until WG14 decides what should be done with them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 Files:

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

erik.pilkington updated this revision to Diff 243243. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Disable the optimization for non-trivially destructible types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/

[PATCH] D68720: Support -fstack-clash-protection for x86

thakis added a comment. This breaks check-clang on mac and win: http://45.33.8.238/mac/7485/step_7.txt http://45.33.8.238/win/7753/step_7.txt Please revert and then investigate asynchronously, unless the fix is obvious. Comment at:

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2077 +getDataLayout().getABITypeAlignment(getTypes().ConvertType(RetTy))) + SRETAttrs.addAlignmentAttr(Align); ArgAttrs[IRFunctionArgs.getSRetArgNo()] = rjmccall wrote: >

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

dexonsmith added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2077 +getDataLayout().getABITypeAlignment(getTypes().ConvertType(RetTy))) + SRETAttrs.addAlignmentAttr(Align); ArgAttrs[IRFunctionArgs.getSRetArgNo()] = rjmccall wrote:

[clang] 4a1a069 - Support -fstack-clash-protection for x86

Author: serge_sans_paille Date: 2020-02-07T19:54:39+01:00 New Revision: 4a1a0690ad6813a4c8cdb8dc20ea6337aa1f61e0 URL: https://github.com/llvm/llvm-project/commit/4a1a0690ad6813a4c8cdb8dc20ea6337aa1f61e0 DIFF:

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2077 +getDataLayout().getABITypeAlignment(getTypes().ConvertType(RetTy))) + SRETAttrs.addAlignmentAttr(Align); ArgAttrs[IRFunctionArgs.getSRetArgNo()] = dexonsmith wrote:

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

dexonsmith added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2077 +getDataLayout().getABITypeAlignment(getTypes().ConvertType(RetTy))) + SRETAttrs.addAlignmentAttr(Align); ArgAttrs[IRFunctionArgs.getSRetArgNo()] = scanon wrote: >

[PATCH] D73701: [clang] fix linkage of nested lambda

hliao added a comment. In D73701#1864136 , @blastrock wrote: > Thanks for the reviews! I do not have commit access, so please merge this > whenever you can. done in 2926917f430 .

[PATCH] D73701: [clang] fix linkage of nested lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rG2926917f430d: [clang] Fix linkage of nested lambdas. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D73701?vs=241713=243224#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] 2926917 - [clang] Fix linkage of nested lambdas.

Author: Michael Liao Date: 2020-02-07T13:24:21-05:00 New Revision: 2926917f430d705f084813b63a40fafc61872524 URL: https://github.com/llvm/llvm-project/commit/2926917f430d705f084813b63a40fafc61872524 DIFF: https://github.com/llvm/llvm-project/commit/2926917f430d705f084813b63a40fafc61872524.diff

[PATCH] D74238: [clang] [clang] Improve diagnostic note for implicit conversion sequences that would work if more than one implicit user-defined conversion were allowed.

logan-5 created this revision. logan-5 added a reviewer: rsmith. logan-5 added a project: clang. Herald added a subscriber: cfe-commits. The current text of the 'note' diagnostic for bad conversions is confusing in the presence of user-defined conversion operations: https://godbolt.org/z/zrgeHH

[PATCH] D74009: [clang] Improve diagnostic note for implicit conversions that are disallowed because they involve more than one user-defined conversion.

logan-5 abandoned this revision. logan-5 added a comment. I split this patch into multiple, and reworked the implementation. The new stuff lives here and here and here: D74238 D74234 D74235

[PATCH] D74235: [clang] [NFC] Rename Sema::DiagnoseMultipleUserConversion to DiagnoseAmbiguousUserConversion

logan-5 created this revision. logan-5 added a reviewer: rsmith. logan-5 added a project: clang. Herald added a subscriber: cfe-commits. logan-5 added a child revision: D74238: [clang] [clang] Improve diagnostic note for implicit conversion sequences that would work if more than one implicit

[PATCH] D74234: [clang] [NFC] Change boolean SuppressUserConversions parameters to an enum

logan-5 created this revision. logan-5 added a reviewer: rsmith. logan-5 added a project: clang. Herald added a subscriber: cfe-commits. logan-5 added a child revision: D74238: [clang] [clang] Improve diagnostic note for implicit conversion sequences that would work if more than one implicit

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D74229: [Clang] Cover '#pragma clang __debug overflow_stack' in tests

aganea planned changes to this revision. aganea added a comment. Withdrawing this, I found an crash in Debug build. I think this can't work without doing all the crash processing in a separate, pre-allocated thread. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

rjmccall added a comment. This shouldn't be an expensive function call, and being a little inefficient on the error path to get better diagnostics is a good trade-off. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74116/new/ https://reviews.llvm.org/D74116

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

sammccall added a comment. Thanks for this. It makes me a bit sad but I don't really see a clean way to make this "just work". Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:653 - Server->addDocument(File, *Contents, WantDiags); + Server->addDocument(File,

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio updated this revision to Diff 243197. dnsampaio added a comment. Added opt-out flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D74229: [Clang] Cover '#pragma clang __debug overflow_stack' in tests

aganea created this revision. aganea added reviewers: rnk, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1148 +#ifdef __clang__ +

[PATCH] D74229: [Clang] Cover '#pragma clang __debug overflow_stack' in tests

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1148 +#ifdef __clang__ + __attribute__((optnone)) Would it be better if we had something like `LLVM_[DISABLE|ENABLE]_OPT` in `Compiler.h` instead of

[PATCH] D73701: [clang] fix linkage of nested lambda

blastrock added a comment. Thanks for the reviews! I do not have commit access, so please merge this whenever you can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73701/new/ https://reviews.llvm.org/D73701

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong added a comment. > What I mean by that is that we must do over-approximation if the argument is > symbolic. I.e. we presume that the constraints do hold otherwise the program > would be ill-formed and there is no point to continue the analysis on this > path. Sorry, that's actually

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong added a comment. In D73898#1864066 , @martong wrote: > In D73898#1863710 , @Szelethus wrote: > > > I wouldn't like to see reports emitted by a checker that resides in > > `apiModeling`. Could we create a

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 243178. balazske added a comment. Adding a simplified version. - The check is only for "EOFOrNegative" case. - Long list of functions is removed. - Not checking for "access in condition". - Removed the warning if value is unused. Repository: rG LLVM

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:697-699 + // The behavior is undefined if the value of the argument is not + // representable as unsigned char or is

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2547 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); `-fno-sycl` should not be

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

scanon added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2077 +getDataLayout().getABITypeAlignment(getTypes().ConvertType(RetTy))) + SRETAttrs.addAlignmentAttr(Align); ArgAttrs[IRFunctionArgs.getSRetArgNo()] = rjmccall wrote: >

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def fno_sycl : Flag<["-"], "fno-sycl">, Group,

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong added a comment. In D73898#1863710 , @Szelethus wrote: > I wouldn't like to see reports emitted by a checker that resides in > `apiModeling`. Could we create a new one? Some checkers, like the > `IteratorChecker`, `MallocChecker` and

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added a comment. In D72705#1863499 , @balazske wrote: > If more discussion is needed it is better to use "Discourse" instead of this > review? I've been meaning to suggest that we use either that or discord for casual chatting (for simple

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 243173. bader marked 2 inline comments as done. bader added a comment. Applied code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:42-49 // The following standard C functions are currently supported: // // fgetc getline isdigit isupper // fread isalnum isgraph isxdigit //

[PATCH] D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons

xazax.hun added a comment. You cannot always have constant bounds. E.g. a dynamically allocated array size might depend on a variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73536/new/ https://reviews.llvm.org/D73536

[PATCH] D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics

aganea added a comment. Relanded as rG75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74076/new/ https://reviews.llvm.org/D74076

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

aganea added a comment. Relanded as rG75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74070/new/ https://reviews.llvm.org/D74070

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

Thank you for the patch -- I think the changes look reasonable, but it should come with some test cases as well. Source location stuff is a bit onerous to try to test, but I think the best approach would be to add a new test that uses FileCheck instead of -verify so that you can validate the

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:33 // // This checker uses eval::Call for modeling "pure" functions, for which // their `FunctionSummaryTy' is a precise model. This avoids unnecessary

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight added a comment. In D67983#1863019 , @arphaman wrote: > @jyknight @rjmccall I'm not sure this change is 100% fine. For example, the > following code no longer compiles with ARC: > > @protocol Delegate > @end > > @interface X > >

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

martong updated this revision to Diff 243167. martong marked 6 inline comments as done. martong added a comment. - Describe what pure means Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73897/new/ https://reviews.llvm.org/D73897 Files:

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

Szelethus added a comment. Thanks! Bug report generation seems far less of a mess than is used to be :) Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:44 -/// BugReporterVisitors are used to add custom diagnostics along a path. +///

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

I think this looks okay. I think Richard or Aaron might be able to provide a more informed opinion. -- HT On Fri, Feb 7, 2020 at 10:06 AM John Marshall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Ping. I am a newcomer to Clang so don't know who might be appropriate > reviewers to CC,

[PATCH] D74222: [AArch64][SVE] Add mul/mla/mls lane & dup intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: c-rhodes, sdesmalen, dancgr, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following intrinsics: -

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

Ping. I am a newcomer to Clang so don't know who might be appropriate reviewers to CC, so I've CCed a couple of general people from clang/CODE_OWNERS.TXT who may be able to forward as appropriate. Thanks, John On 20 Jan 2020, at 16:09, John Marshall wrote: > > This small patch improves

[clang] 75f09b5 - Re-land "[Clang][Driver] Remove -M group options ..." and "[Clang] Avoid crashing when generating crash diagnostics when '#pragma clang __debug ..."

Author: Alexandre Ganea Date: 2020-02-07T09:51:09-05:00 New Revision: 75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 URL: https://github.com/llvm/llvm-project/commit/75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 DIFF:

[clang] ea9166b - [OPENMP50]Add parsing/sema for acq_rel clause.

Author: Alexey Bataev Date: 2020-02-07T09:21:10-05:00 New Revision: ea9166b5a838d788a4ec0c9ddf0c83b09f49cfe4 URL: https://github.com/llvm/llvm-project/commit/ea9166b5a838d788a4ec0c9ddf0c83b09f49cfe4 DIFF: https://github.com/llvm/llvm-project/commit/ea9166b5a838d788a4ec0c9ddf0c83b09f49cfe4.diff

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def fno_sycl : Flag<["-"], "fno-sycl">, Group,

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added a comment. Anything else @efriedma ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

mbrkusanin added a comment. Not yet, a proposal was made to both GCC and LLVM and as far as I can tell no work was done on GCC yet. If we accept these names I'll let them know so we end up with matching names. As for 4/8 byte loads, in case of having them implemented as **ld** plus some extra

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

mbrkusanin added a comment. Rebase. Not yet, a proposal was made to both GCC and LLVM and as far as I can tell no work was done on that yet. If we accept these names I'll let them know so we end up with matching names. As for 4/8 byte loads, in case of having them implemented as **ld** plus

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

mbrkusanin updated this revision to Diff 243153. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73644/new/ https://reviews.llvm.org/D73644 Files: clang/include/clang/Basic/BuiltinsMips.def clang/lib/Headers/msa.h clang/lib/Sema/SemaChecking.cpp

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

erichkeane added a comment. I've filed this bug against this patch: https://bugs.llvm.org/show_bug.cgi?id=44823 We've discovered in cases where multiple TUs are invoked in a single command line that the memory between calls isn't cleaned up like it was previously. This results in really high

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze updated this revision to Diff 243149. zukatsinadze marked an inline comment as done. zukatsinadze added a comment. - Removed dead code. - Removed unnecessary if condition. - Changed error phrasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/

  1   2   >