[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-07-01 Thread JF Bastien via Phabricator via cfe-commits
jfb updated this revision to Diff 275005. jfb added a comment. Add memmove and memset (but still missing the codegen tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-07-01 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2416 - // Double and long long should be naturally aligned if possible. + // Double, long double (only when the target supports AIX power alignment) and + // long long should be

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-07-01 Thread Johel Ernesto Guerrero Peña via Phabricator via cfe-commits
JohelEGP added a comment. Using parameter packs within non-parenthesized requires-clauses results in weird formatting: template requires std::invocable < F, std::invoke_result_t ... > struct constant; vs template requires(std::invocable...>) struct constant; CHANGES

[PATCH] D83009: [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

2020-07-01 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. I cherry picked this change and retried the case that was failing. This change addresses the issue I was seeing. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83009/new/ https://reviews.llvm.org/D83009

[PATCH] D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang

2020-07-01 Thread Lei Huang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG88874f074644: [PowerPC]Implement Vector Shift Double Bit Immediate Builtins (authored by biplmish, committed by lei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[clang] 88874f0 - [PowerPC]Implement Vector Shift Double Bit Immediate Builtins

2020-07-01 Thread Lei Huang via cfe-commits
Author: Biplob Mishra Date: 2020-07-01T20:34:53-05:00 New Revision: 88874f07464467f3852dd662d180f7738756649b URL: https://github.com/llvm/llvm-project/commit/88874f07464467f3852dd662d180f7738756649b DIFF: https://github.com/llvm/llvm-project/commit/88874f07464467f3852dd662d180f7738756649b.diff

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

2020-07-01 Thread Keith Smiley via Phabricator via cfe-commits
keith accepted this revision. keith added a comment. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83015/new/ https://reviews.llvm.org/D83015 ___ cfe-commits mailing list

[PATCH] D82906: [flang][openmp] Use common Directive and Clause enum from llvm/Frontend

2020-07-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D82906#2127047 , @clementval wrote: > Fix for warning I find clang better at -Wswitch related warnings than GCC. Might be nice building llvm-project with clang and testing with `check-clang`. If you don't mind `curl | sh`,

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

2020-07-01 Thread whitequark via Phabricator via cfe-commits
whitequark added a comment. Thank you for making this change. IIRC I introduced `-fuse-ld=` out of frustration with the inability to change the linker path in any way other than with a shell script on `PATH`. It was not a good design. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

2020-07-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I got pinged for my GCC -fuse-ld=path patch today. On GCC side, Martin Liška is fine with clang's choice if we can reach a reasonable consensus: https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549236.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

2020-07-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: echristo, jyknight, martell, theraven, whitequark. Herald added a project: clang. Herald added a subscriber: cfe-commits. Supersedes D80225 . Add -fld-path= to avoid strange target specific prefixes and make

[PATCH] D82930: [HIP] Fix rocm detection

2020-07-01 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > yaxunl wrote: > > arsenm wrote: > > > I don't

[PATCH] D82930: [HIP] Fix rocm detection

2020-07-01 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) yaxunl wrote: > arsenm wrote: > > I don't think the detection

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

2020-07-01 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 274961. vabridgers added a comment. update for pre-merge lint checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83006/new/ https://reviews.llvm.org/D83006 Files:

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

2020-07-01 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. I confirmed that a crash was seen when the change for https://reviews.llvm.org/D82882 was reverted, then the unittests pass with the change associated with https://reviews.llvm.org/D82882. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82992: clang CoverageMapping tests bot cleanup

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82992#2126898 , @MaskRay wrote: > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > >

[PATCH] D82992: clang CoverageMapping tests bot cleanup

2020-07-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[clang] ac8d059 - typo fixes to cycle bots

2020-07-01 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-07-01T19:20:05-04:00 New Revision: ac8d059c8e80fc84d16ad79d08e25010ffa114c2 URL: https://github.com/llvm/llvm-project/commit/ac8d059c8e80fc84d16ad79d08e25010ffa114c2 DIFF: https://github.com/llvm/llvm-project/commit/ac8d059c8e80fc84d16ad79d08e25010ffa114c2.diff

[PATCH] D82992: clang CoverageMapping tests bot cleanup

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9fc877213e07: clang CoverageMapping tests bot cleanup (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82992/new/

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-01 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik marked an inline comment as done. shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1190 if (UseExternalLayout) { -// FIXME: This appears to be reversed. if (Base->IsVirtual)

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-07-01 Thread JF Bastien via Phabricator via cfe-commits
jfb updated this revision to Diff 274948. jfb added a comment. This builtin doesn't return anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/include/clang/Basic/Builtins.def Index:

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-07-01 Thread JF Bastien via Phabricator via cfe-commits
jfb updated this revision to Diff 274949. jfb added a comment. Arcanist ate the rest of my commit and I am confused. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files:

[PATCH] D83009: [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

2020-07-01 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno created this revision. riccibruno added reviewers: vabridgers, martong, aaron.ballman. riccibruno added a project: clang. Herald added subscribers: cfe-commits, rnkovacs. 05843dc6ab97a00cbde7aa4f08bf3692eb83109d

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

2020-07-01 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 274945. vabridgers added a comment. Updated commit header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83006/new/ https://reviews.llvm.org/D83006 Files: clang/unittests/AST/ASTImporterTest.cpp Index:

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-01 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik created this revision. shafik added reviewers: teemperor, jingham, jasonmolenda, friss. Herald added a subscriber: kristof.beyls. shafik marked an inline comment as done. shafik added a subscriber: rsmith. shafik added inline comments. Comment at:

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

2020-07-01 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. > Yes, I think that my patch just traded-off a bug for another bug. What about > the following instead: > > Initially zero the `Stmt *` for the body, then when the body is needed > (either with `getBody` or with `children`) > populate it if needed from the call

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

2020-07-01 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers created this revision. vabridgers added a reviewer: martong. Herald added subscribers: cfe-commits, teemperor, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. vabridgers updated this revision to Diff 274945. vabridgers added

[clang] 9fc8772 - clang CoverageMapping tests bot cleanup

2020-07-01 Thread Xun Li via cfe-commits
Author: Xun Li Date: 2020-07-01T16:06:56-07:00 New Revision: 9fc877213e075a76831fe71291d7c072c64c27e3 URL: https://github.com/llvm/llvm-project/commit/9fc877213e075a76831fe71291d7c072c64c27e3 DIFF: https://github.com/llvm/llvm-project/commit/9fc877213e075a76831fe71291d7c072c64c27e3.diff LOG:

[PATCH] D50229: [ARM][AArch64] Add feature +fp16fml

2020-07-01 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Herald added a subscriber: danielkiss. Comment at: test/Driver/aarch64-cpus.c:518 +// RUN: %clang -target aarch64 -march=armv8.4-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV84A-NO-FP16FML %s +// GENERICV84A-NO-FP16FML-NOT:

[PATCH] D82807: [clang-tidy] Allows the prevailing include header guard in Flang ...

2020-07-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Would you be able to add some unit tests for this in a follow up. `clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp` is where they live. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82807/new/

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

2020-07-01 Thread Nathan James via Phabricator via cfe-commits
njames93 marked 5 inline comments as done. njames93 added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:124 +llvm::Optional getRegexFlag(llvm::StringRef Flag) { + for (auto : RegexMap) { +if (Flag == StringFlag.first)

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing temporaries created in conditional expressions

2020-07-01 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. ahatanak added reviewers: rsmith, rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. The temporary of the true operand shouldn't be destructed when the false operand is evaluated and throws. rdar://problem/64829372

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

2020-07-01 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. New files are missing standard license header blurb. Also probably missing some tests. Comment at: clang/lib/Driver/Driver.cpp:3754 + // We don't need to count the assembler as a job since it doesn't + // cause the memory issue that requires

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

2020-07-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:969 + // Do not warn for non-closed stream at program exit. + if (Pred && Pred->getCFGBlock() && Pred->getCFGBlock()->hasNoReturnElement()) +return Pred; balazske

[PATCH] D82967: [analyzer][tests] Measure peak memory consumption for every project

2020-07-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/SATestUtils.py:113 +peak_mem = max(peak_mem, get_memory(process)) +time.sleep(.5) + Do i understand correctly that this basically adds roughly 0.25 second delay to every

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82986#2126479 , @thakis wrote: > That's not enough, you also need to add an rm to remove the stale .LL file > still on disk, see my comment on your original change. It's in https://reviews.llvm.org/D82992 if you could help

[PATCH] D82901: [libTooling] Fix `maybeExtendRange` to support `CharRange`s.

2020-07-01 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa0b24189a: [libTooling] Fix `maybeExtendRange` to support `CharRange`s. (authored by gmatute, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. That's not enough, you also need to add an rm to remove the stale .LL file still on disk, see my comment on your original change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.org/D82986

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

2020-07-01 Thread Nathan Huckleberry via Phabricator via cfe-commits
Nathan-Huckleberry created this revision. Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya, mgorny. Herald added projects: clang, LLVM. Nathan-Huckleberry edited the summary of this revision. Nathan-Huckleberry edited the summary of this revision. Nathan-Huckleberry edited

[clang] ecfa0b2 - [libTooling] Fix `maybeExtendRange` to support `CharRange`s.

2020-07-01 Thread Yitzhak Mandelbaum via cfe-commits
Author: Gabriel Matute Date: 2020-07-01T20:40:48Z New Revision: ecfa0b24189abf4bb172a8860048af05fa17daee URL: https://github.com/llvm/llvm-project/commit/ecfa0b24189abf4bb172a8860048af05fa17daee DIFF: https://github.com/llvm/llvm-project/commit/ecfa0b24189abf4bb172a8860048af05fa17daee.diff

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

2020-07-01 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a subscriber: majnemer. riccibruno added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > davidstone wrote: > > riccibruno wrote: > > > `i128` and

[PATCH] D82992: clang CoverageMapping tests bot cleanup

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind created this revision. lxfind added a reviewer: thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. D82928 generated unexpected tmp files in the CoverageMapping test directory. This patch cleans it up and remove the file in the

[PATCH] D82807: [clang-tidy] Allows the prevailing include header guard in Flang ...

2020-07-01 Thread Eric Schweitz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe1581540876f: [clang-tidy] Allows the prevailing include header guard in Flang to be… (authored by schweitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/test/CoverageMapping/coroutine.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fcoroutines-ts -std=c++14 -emit-llvm -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping %s | FileCheck %s +

[PATCH] D82908: [SVE] ACLE: Fix builtins for svdup_lane_bf16 and svcvtnt_bf16_f32_x

2020-07-01 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you. Comment at: clang/utils/TableGen/SveEmitter.cpp:1265-1279 + OS << "#if defined(__ARM_FEATURE_SVE_BF16)\n"; + OS << "#define svcvtnt_bf16_x

[clang-tools-extra] e158154 - [clang-tidy] Allows the prevailing include header guard in Flang to be recognized rather than flagged as a violation in phabricator.

2020-07-01 Thread Eric Schweitz via cfe-commits
Author: Eric Schweitz Date: 2020-07-01T12:47:36-07:00 New Revision: e1581540876f51af1aa1389bdb21388ae88c1b90 URL: https://github.com/llvm/llvm-project/commit/e1581540876f51af1aa1389bdb21388ae88c1b90 DIFF: https://github.com/llvm/llvm-project/commit/e1581540876f51af1aa1389bdb21388ae88c1b90.diff

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

2020-07-01 Thread Momchil Velikov via Phabricator via cfe-commits
chill added a comment. Needs a regression test. This patch and the dependent patch clash, better with a single patch. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:288 +static void appendNoFPUnsupportedFeatures(const arm::FloatABI ABI, +

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

2020-07-01 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. In D82940#2125939 , @martong wrote: > In D82940#2125183 , @riccibruno > wrote: > > > > I'm not certain I understand, but I'm removing my LG while we figure it > > > out. Can you

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-07-01 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Thank you I see now... super subtle but I'll take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

2020-07-01 Thread Aaron Smith via Phabricator via cfe-commits
asmith added a comment. Thanks for all the helpful feedback. Before we commit this just want to double check there are no final comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

2020-07-01 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This introduces a non-uniformity between `RecursiveASTVisitor` and `StmtVisitor`. `StmtVisitor` contains matching logic to treat the various kinds of unary and binary operators as if they were distinct AST node kinds, and that

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-07-01 Thread Johel Ernesto Guerrero Peña via Phabricator via cfe-commits
JohelEGP added a comment. In D79773#2125040 , @MyDeveloperDay wrote: > Just so I'm clear for this and your Allman coment would you show me what you > are seeing and what you expect to see? just so I understand. Sure, thank you. This is what I have,

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGddcf063dd52f: [Coroutines] Fix test breakage in D82928 (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Brian Gesiak via Phabricator via cfe-commits
modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.org/D82986

[PATCH] D82984: Revert "[Coroutines] Fix code coverage for coroutine"

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind abandoned this revision. lxfind added a comment. Fix up in https://reviews.llvm.org/D82986 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82984/new/ https://reviews.llvm.org/D82984 ___

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind created this revision. lxfind added reviewers: modocache, fhahn. Herald added a project: clang. Herald added a subscriber: cfe-commits. modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks for the fix! The test file in

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82928#2126018 , @fhahn wrote: > Looks like this causes a bunch of build bot failures, e.g > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b > > It would be great if you could take a look. Fix patch

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

2020-07-01 Thread Zoe Carver via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe7c5da57a5f3: [CodeGen] Add public function to emit C++ destructor call. (authored by zoecarver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82928#2126018 , @fhahn wrote: > Looks like this causes a bunch of build bot failures, e.g > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b > > It would be great if you could take a look. Let me

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

2020-07-01 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Can the missing bit just be added? It seems to me that frontends ought to be able to emit the obvious intrinsic for the semantic operation here rather than having to second-guess the backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

2020-07-01 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Seems like you shouldn't do it earlier if the type is dependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82781/new/ https://reviews.llvm.org/D82781 ___ cfe-commits

[PATCH] D82984: Revert "[Coroutines] Fix code coverage for coroutine"

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind created this revision. lxfind added reviewers: fhahn, modocache. Herald added a project: clang. Herald added a subscriber: cfe-commits. lxfind abandoned this revision. lxfind added a comment. Fix up in https://reviews.llvm.org/D82986 This reverts commit

[clang] ddcf063 - [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Xun Li via cfe-commits
Author: Xun Li Date: 2020-07-01T11:17:21-07:00 New Revision: ddcf063dd52ff1f30ac27d6f9abce6a45685a2b2 URL: https://github.com/llvm/llvm-project/commit/ddcf063dd52ff1f30ac27d6f9abce6a45685a2b2 DIFF: https://github.com/llvm/llvm-project/commit/ddcf063dd52ff1f30ac27d6f9abce6a45685a2b2.diff LOG:

[clang] e7c5da5 - [CodeGen] Add public function to emit C++ destructor call.

2020-07-01 Thread via cfe-commits
Author: zoecarver Date: 2020-07-01T11:01:23-07:00 New Revision: e7c5da57a5f3fdb6649ff92cb8ba0ce3c4978668 URL: https://github.com/llvm/llvm-project/commit/e7c5da57a5f3fdb6649ff92cb8ba0ce3c4978668 DIFF: https://github.com/llvm/llvm-project/commit/e7c5da57a5f3fdb6649ff92cb8ba0ce3c4978668.diff

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82928#2126018 , @fhahn wrote: > Looks like this causes a bunch of build bot failures, e.g > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b > > It would be great if you could take a look. Looks

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. Looks like this causes a bunch of build bot failures, e.g http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b It would be great if you could take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

2020-07-01 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/ https://reviews.llvm.org/D82392

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-07-01 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple updated this revision to Diff 274865. varungandhi-apple added a comment. Rebase after changes in D82808 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82791/new/ https://reviews.llvm.org/D82791

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

2020-07-01 Thread Max Moroz via Phabricator via cfe-commits
Dor1s added a comment. If we still decide to proceed with this, would it make sense to expand it to `sanitizer_coverage` based on any sancov instrumentation being enabled? As you mentioned in the description, there might be users who manually enable certain sancov flags. I think it's good to

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

2020-07-01 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added a comment. In D82926#2125950 , @hctim wrote: > So - the `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` flag is a property of the > build system and not that of the compiler. There are some places (android) > where enabling

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

2020-07-01 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added a comment. So - the `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` flag is a property of the build system and not that of the compiler. There are some places (android) where enabling `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` globally changes the behaviour of large amounts of libraries

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG565e37c7702d: [Coroutines] Fix code coverage for coroutine (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

2020-07-01 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D82940#2125183 , @riccibruno wrote: > > I'm not certain I understand, but I'm removing my LG while we figure it > > out. Can you expound a bit further? > > Take a look at the AST dump of a small modification of the reduced

[clang] 565e37c - [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via cfe-commits
Author: Xun Li Date: 2020-07-01T10:11:40-07:00 New Revision: 565e37c7702d181804c12d36b6010c513c9b3417 URL: https://github.com/llvm/llvm-project/commit/565e37c7702d181804c12d36b6010c513c9b3417 DIFF: https://github.com/llvm/llvm-project/commit/565e37c7702d181804c12d36b6010c513c9b3417.diff LOG:

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

2020-07-01 Thread Ellis Hoag via Phabricator via cfe-commits
ellis updated this revision to Diff 274855. ellis added a comment. Add `isLanguageVersionSupported` for Objective-C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files:

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-07-01 Thread JF Bastien via Phabricator via cfe-commits
jfb updated this revision to Diff 274847. jfb edited the summary of this revision. jfb added a comment. Overload a new builtin instead. For now I only did memcpy, to get feedback on the approach. I'll add other mem* functions if this makes sense. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

2020-07-01 Thread Pierre Habouzit via Phabricator via cfe-commits
MadCoder added a comment. So the risk with that one is that if someone had say the `-didSomething` direct selector and that some UIKit/Apple SDK API now adds this as a thing that you use with CFNotification center for example, where you _need_ dynamism, then the uses of the API would warn all

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

2020-07-01 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a subscriber: aaron.ballman. riccibruno added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; davidstone wrote: > riccibruno wrote: > > `i128` and `Ui128` are not

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

2020-07-01 Thread Pierre Habouzit via Phabricator via cfe-commits
MadCoder added inline comments. Comment at: clang/lib/Sema/SemaExprObjC.cpp:1230 } - -static void HelperToDiagnoseDirectSelectorsExpr(Sema , SourceLocation AtLoc, -Selector Sel, +static void

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

2020-07-01 Thread Pierre Habouzit via Phabricator via cfe-commits
MadCoder added inline comments. Comment at: clang/test/SemaObjC/potentially-direct-selector.m:84 + (void)@selector(inBaseCat); + (void)@selector(inBaseCatImpl); + (void)@selector(inDerived); I think this might be too weak, if we add a warning then maybe what

[PATCH] D82930: [HIP] Fix rocm detection

2020-07-01 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > I don't

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

2020-07-01 Thread Max Moroz via Phabricator via cfe-commits
Dor1s added a comment. What usecase(s) do you have for this in mind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82926/new/ https://reviews.llvm.org/D82926 ___ cfe-commits mailing list

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

2020-07-01 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 274846. njames93 added a comment. Small refactor based on comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

2020-07-01 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. The problem is that `PathDiagnostic::Profile` does not use the uniqueing locations. Two `PathDiagnostic` objects with different uniqueing location but otherwise same data are counted as "same" and only one is kept (`BugReporter::FlushReport`). How to fix this? - Add

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

2020-07-01 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/AST/ExprCXX.cpp:82 + default: +return getNumArgs() == 1; + } riccibruno wrote: > This will be true for `operator->`. Thank you ! I had missed that! I'll

[PATCH] D82388: move "basic" builtins to TableGen

2020-07-01 Thread Nathan Froyd via Phabricator via cfe-commits
froydnj added a comment. FWIW, an in-progress tree for the proposed move for all the architecture-specific builtins is: https://github.com/froydnj/llvm-project/tree/move-builtins-to-tablegen I don't know if the ARM/NEON/SVE builtins will be easily movable. It looks like they are separately

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82314#2124662 , @junparser wrote: > In D82314#2124661 , @junparser wrote: > > > @lxfind This patch causes some mismatch when variable is used in both > > resume and destroy function.

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 274836. lxfind added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/ https://reviews.llvm.org/D82928 Files: clang/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-01 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham added a comment. [facepalm] Thank you. I carefully //wrote// a revised description, but forgot to upload it to this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-01 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham added a comment. In D82659#2125618 , @clementval wrote: > LGTM. So later the DEPENDS omp_gen that are in clang subdirectories could be > removed right? That seems likely. I'm thinking what I should probably do is to polish up my checking

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Brian Gesiak via Phabricator via cfe-commits
modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Excellent, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/ https://reviews.llvm.org/D82928

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-01 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. @simon_tatham Can you just update the description so it is consistent with your fix when it lands? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

2020-07-01 Thread David Stone via Phabricator via cfe-commits
davidstone marked an inline comment as done. davidstone added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > `i128` and `Ui128` are not valid integer literal

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

2020-07-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Just my 2 cents, but would it not be wise to introduce a test case that runs the 2 aforementioned checks together demonstrating how they interact with each other. This will also force compliance if either check is updated down the line. CHANGES SINCE LAST ACTION

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

2020-07-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:125 +CheckFactories.registerCheck( +"bugprone-no-escape"); CheckFactories.registerCheck( ellis wrote: > Not sure if we want to lint this

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-01 Thread Valentin Clement via Phabricator via cfe-commits
clementval accepted this revision. clementval added a comment. LGTM. So later the DEPENDS omp_gen that are in clang subdirectories could be removed right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D82891: [clangd] Fix race in FileIndex that sometimes temporarily lost updates.

2020-07-01 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGc5263a4e84cc: [clangd] Fix race in FileIndex that sometimes temporarily lost updates. (authored by sammccall). Changed prior to commit:

[PATCH] D82967: [analyzer][tests] Measure peak memory consumption for every project

2020-07-01 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. Repository: rG LLVM

[PATCH] D82968: [VE] Rename VE toolchain source files

2020-07-01 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Rename VE.cpp and VE.h to VEToolchain.cpp and VEToolchain.h respectively in order to avoid link warning message.

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

2020-07-01 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. The Provider extension point is designed to also be implemented by ClangdLSPServer (to

  1   2   3   >