[PATCH] D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option

nridge added a comment. Herald added a project: clang-tools-extra. It would be nice to update the code example in the LibTooling documentation as well Repository: rG LLVM Github Monorepo

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8a2afb244da: [clang][analyzer] Add modeling of errno. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d8a2afb - [clang][analyzer] Add modeling of 'errno'.

Author: Balázs Kéri Date: 2022-03-01T08:20:33+01:00 New Revision: d8a2afb244da6cd1c8753115610c74ed0312f2e2 URL: https://github.com/llvm/llvm-project/commit/d8a2afb244da6cd1c8753115610c74ed0312f2e2 DIFF: https://github.com/llvm/llvm-project/commit/d8a2afb244da6cd1c8753115610c74ed0312f2e2.diff

[PATCH] D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library

saiislam created this revision. saiislam added reviewers: yaxunl, jdoerfert, JonChesterfield. Herald added a subscriber: guansong. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. `hip-openmp-compatible` flag treats hip

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

VincentWu accepted this revision. VincentWu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD added a comment. Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. Hey @NoQ and @steakhal , can i land this patch ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 ___ cfe-commits mailing list

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 411959. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Address @craig.topper's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

jyknight added a comment. In D119051#3316026 , @dblaikie wrote: > Ah, looks like this is the existing > https://github.com/itanium-cxx-abi/cxx-abi/issues/66 If you're going to change the ABI, you might as well tackle the rest of the differences

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/zfinx-types.ll:5 +; RUN:| FileCheck --check-prefix=RV32IF %s +; RUN: llc -mtriple=riscv32 -mattr=+zfh -target-abi=ilp32f < %s \ +; RUN:| FileCheck --check-prefix=RV32IF %s I'm not

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Are there any other errors now? @krasimir @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a59eefd3a0: [Clang] Remove redundant init-parens in AST print (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d1a59ee - [Clang] Remove redundant init-parens in AST print

Author: Zhihao Yuan Date: 2022-02-28T19:31:16-06:00 New Revision: d1a59eefd3a09f08ba425a20899fbd1766babc45 URL: https://github.com/llvm/llvm-project/commit/d1a59eefd3a09f08ba425a20899fbd1766babc45 DIFF: https://github.com/llvm/llvm-project/commit/d1a59eefd3a09f08ba425a20899fbd1766babc45.diff

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG136b29312920: [c++2b] Implement P0849R8 auto(x) (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 136b293 - [c++2b] Implement P0849R8 auto(x)

Author: Zhihao Yuan Date: 2022-02-28T19:21:08-06:00 New Revision: 136b2931292083c8d69c09de9b952c86417b2c5d URL: https://github.com/llvm/llvm-project/commit/136b2931292083c8d69c09de9b952c86417b2c5d DIFF: https://github.com/llvm/llvm-project/commit/136b2931292083c8d69c09de9b952c86417b2c5d.diff

[PATCH] D111457: [test] Add lit helper for windows paths

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111457: [test] Add lit helper for windows paths

keith added a comment. For reference here's an example of a test that uses this https://reviews.llvm.org/D111579 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added a comment. I would structure this as a LangOpt, and feed the target checks and ABI compat checks into the default setting for it. It could be something like `DefaultedSMFArePOD` / `-f[no-]defaulted-smf-are-pod` (smf being special member functions). The LangOpt default is true, and

[PATCH] D111457: [test] Add lit helper for windows paths

keith added inline comments. Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +if kIsWindows: +fs_root = 'C:\\' +substitutions.extend([ probinson wrote: > rnk wrote: > > It is pretty common to run the LLVM test suite on secondary drives, > >

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411926. keith added a comment. Fix parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411923. keith added a comment. Update test with new variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 411922. keith added a comment. Update tests with new syntax and FileCheck variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files:

[PATCH] D111457: [test] Add lit helper for windows paths

keith updated this revision to Diff 411921. keith marked 3 inline comments as done. keith edited the summary of this revision. keith added a comment. Use the actual drive on windows, split out into fssrcroot and fstmproot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120132: [HIP] Fix HIP include path

tra added a comment. In D120132#3349936 , @yaxunl wrote: > Users may use clang driver to compile HIP program and C++ program with one > clang driver invocation, e.g. > > clang --offload-arch=gfx906 a.hip b.cpp > > Clang driver will create job actions

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire added a comment. In D119949#3338818 , @junaire wrote: > Gentle ping~ Gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 411912. ZarkoCA retitled this revision from "[Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function" to "[Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function".

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl added a comment. In D120132#3349538 , @tra wrote: > In D120132#3345534 , @yaxunl wrote: > >> I just found one issue with the current patch. It adds HIP include path for >> non-HIP programs. >> >> We

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

yaxunl added a comment. There seem to be regressions on Windows: https://buildkite.com/llvm-project/premerge-checks/builds/81394#c0e8e7e4-1f70-47d3-852a-e65469d70c41 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/lifetime-sanitizer.c:9 +// RUN: %clang -target aarch64-linux-gnu -S -emit-llvm -o /dev/null -O0 \ +// RUN: -fsanitize=hwaddress

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray marked 4 inline comments as done. lichray added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } aaron.ballman wrote: > lichray wrote: > > aaron.ballman wrote: > > > We're

[PATCH] D120557: [HIP] File device library ABI version file name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG092f15ac40ce: [HIP] File device library ABI version file name (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 092f15a - [HIP] File device library ABI version file name

Author: Yaxun (Sam) Liu Date: 2022-02-28T16:24:50-05:00 New Revision: 092f15ac40ce35d077e0225a4462bc4dfa379391 URL: https://github.com/llvm/llvm-project/commit/092f15ac40ce35d077e0225a4462bc4dfa379391 DIFF:

[clang-tools-extra] de9611b - [NFC] Don't pass temporary LangOptions to Lexer

Author: Jorge Gorbe Moya Date: 2022-02-28T12:53:59-08:00 New Revision: de9611befeebeb85324062cb1ae8978a82a09e26 URL: https://github.com/llvm/llvm-project/commit/de9611befeebeb85324062cb1ae8978a82a09e26 DIFF:

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1315c61a03e: [docs] Add note about interaction between clang plugins and -clear-ast-before… (authored by aeubanks). Repository: rG LLVM Github

[clang] f1315c6 - [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

Author: Arthur Eubanks Date: 2022-02-28T12:53:09-08:00 New Revision: f1315c61a03ea6ef72ec11522f9abecd782f4856 URL: https://github.com/llvm/llvm-project/commit/f1315c61a03ea6ef72ec11522f9abecd782f4856 DIFF:

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

HazardyKnusperkeks added a comment. I have a similar structure to Qt regarding the headers and use clangd trough the QtCreator, so for my own libraries I cannot use the auto completion. In D112996#3102782 , @sammccall wrote: >> the files are located in

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } lichray wrote: > aaron.ballman wrote: > > We're also missing `\?` right? > `?` does not seem to need

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

urnathan added inline comments. Comment at: clang/test/Modules/inconsist-export-template.cpp:26-34 +export template +class C { + +}; + +template<> +class C { I think you'll need a member fn to have something to check the linkage of? Might be worth checking

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

urnathan added a comment. In D120397#3340256 , @erichkeane wrote: > Linkage stuff is where I get lost quickly, hopefully @urnathan can comment > here. Codewise I think this looks right. looks right to me too -- take the linkage from the most general

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111457: [test] Add lit helper for windows paths

probinson added inline comments. Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +if kIsWindows: +fs_root = 'C:\\' +substitutions.extend([ rnk wrote: > It is pretty common to run the LLVM test suite on secondary drives, > especially on

[PATCH] D119061: [Clang] noinline call site attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG223b82402235: [Clang] noinline call site attribute (authored by xbolva00). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] 223b824 - [Clang] noinline call site attribute

Author: Dávid Bolvanský Date: 2022-02-28T21:21:17+01:00 New Revision: 223b8240223541d3feb0c96b7f9bac114cd72f46 URL: https://github.com/llvm/llvm-project/commit/223b8240223541d3feb0c96b7f9bac114cd72f46 DIFF:

[PATCH] D111457: [test] Add lit helper for windows paths

rnk added inline comments. Comment at: llvm/docs/TestingGuide.rst:577 +``${fssep}`` + Exp``ands to the file system separator, i.e. ``/`` or ``\`` on Windows. + Stray backticks in "Expands"? Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +

[clang] 96dea20 - [NFC] Make 1st param to getTemplateInstantiationArgs const correct

Author: Erich Keane Date: 2022-02-28T12:14:14-08:00 New Revision: 96dea2015554d1bf1e095ea82bc57d9229bd5fd5 URL: https://github.com/llvm/llvm-project/commit/96dea2015554d1bf1e095ea82bc57d9229bd5fd5 DIFF: https://github.com/llvm/llvm-project/commit/96dea2015554d1bf1e095ea82bc57d9229bd5fd5.diff

[PATCH] D120132: [HIP] Fix HIP include path

tra added a comment. In D120132#3345534 , @yaxunl wrote: > I just found one issue with the current patch. It adds HIP include path for > non-HIP programs. > > We should only add HIP include path for JobAction with HIP offloading kind. > However,

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 ___

[clang] b3e2dac - [NFC] Don't pass temporary LangOptions to Lexer

Author: Dawid Jurczak Date: 2022-02-28T20:43:28+01:00 New Revision: b3e2dac27c0cd4562e4ece5d5e24a1e59705c746 URL: https://github.com/llvm/llvm-project/commit/b3e2dac27c0cd4562e4ece5d5e24a1e59705c746 DIFF: https://github.com/llvm/llvm-project/commit/b3e2dac27c0cd4562e4ece5d5e24a1e59705c746.diff

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray marked 3 inline comments as done. lichray added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } aaron.ballman wrote: > We're also missing `\?` right? `?` does not seem to

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai added inline comments. Comment at: clang/test/Modules/merge-anon-record-definition-in-objc.m:5 +// RUN: %clang_cc1 -fsyntax-only -F%t/Frameworks %t/test.m -Wno-objc-property-implementation -Wno-incomplete-implementation \ +// RUN:-fmodules

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 411856. lichray added a comment. - Revert some auto's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added inline comments. Comment at: clang/test/Analysis/bstring.c:310 - clang_analyzer_eval(p == [4]); // expected-warning{{TRUE}} + clang_analyzer_eval(p == [4]); // no-warning (above is fatal) } NoQ wrote: > Hmm, given that your change

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks updated this revision to Diff 411851. aeubanks added a comment. reword Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index: clang/docs/ClangPlugins.rst

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

rjmccall added a comment. This is one of those patches that's difficult to review because it's so hard to foresee the consequences of changing the concepts. That said, I think the basic idea here seems reasonable. Comment at:

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D120159#3349271 , @jyknight wrote: > In D120159#3349069 , @aaron.ballman > wrote: > >> Ah, okay, that's a good point. I was thinking

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } We're also missing `\?` right? Comment at: clang/lib/AST/APValue.cpp:658 + for (auto :

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

lichray updated this revision to Diff 411845. lichray added a comment. Restore the right diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120589/new/ https://reviews.llvm.org/D120589 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

lichray updated this revision to Diff 411843. lichray marked 2 inline comments as done. lichray added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120608/new/ https://reviews.llvm.org/D120608 Files: clang/lib/AST/StmtPrinter.cpp

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

lichray updated this revision to Diff 411842. lichray added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120589/new/ https://reviews.llvm.org/D120589 Files: clang/lib/AST/StmtPrinter.cpp

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 411839. lichray added a comment. Use the right copy of clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

dblaikie added inline comments. Comment at: clang/test/Modules/inconsist-export-template.cpp:1-2 +// RUN: %clang_cc1 -std=c++20 %s -fsyntax-only -verify +// expected-no-diagnostics +export module m; This test doesn't appear to test anything - it verifies that

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight marked 8 inline comments as done. jyknight added a comment. In D120159#3349069 , @aaron.ballman wrote: > Ah, okay, that's a good point. I was thinking this would show up in the AST > in places like: > > template > auto func() -> Ty; >

[clang] d5b2055 - [OpenMP] Add verbose output for linker wrapper

Author: Joseph Huber Date: 2022-02-28T13:28:19-05:00 New Revision: d5b2055769f40386a818e9df0a173eafa0e7dc5f URL: https://github.com/llvm/llvm-project/commit/d5b2055769f40386a818e9df0a173eafa0e7dc5f DIFF: https://github.com/llvm/llvm-project/commit/d5b2055769f40386a818e9df0a173eafa0e7dc5f.diff

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

jsji added inline comments. Comment at: clang/lib/Headers/ppc_wrappers/xmmintrin.h:1332 +#ifdef _ARCH_PWR10 + return vec_extractm ((__vector unsigned int) __A); +#else Can we have some pwr10 tests to test all these P10 specific codegen? Repository: rG LLVM

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

erichkeane accepted this revision. erichkeane added a comment. Just did a pass through, nothing suspicious, I think this looks good. Mild preference to merge 2 or 3 diagnostics based on how similar they all are, but that can be done without further review, or as a separate commit (or not at

Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

I agree, but clearly this person chose a particular style, and I wasn't trying to revise their code style, just to fix some the Bazel build, which uses -Werror. The way that `assert` can affect a lambda's capture list seems like a particularly good argument for having a project wide style

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2155 - CXXNewExpr::InitializationStyle InitStyle = E->getInitializationStyle(); - if (InitStyle) { -if (InitStyle == CXXNewExpr::CallInit) + auto InitStyle = E->getInitializationStyle(); +

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

rnk added a comment. Thanks for writing docs, apologies for bikeshedding. Comment at: clang/docs/ClangPlugins.rst:207 + +If the main AST action is codegen, having any plugins that run after the +codegen action automatically turns off ``-clear-ast-before-backend``.

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

aaron.ballman added reviewers: erichkeane, Quuxplusone. aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes here LGTM, but I'd appreciate a second set of eyes on it in case I missed anything before this lands.

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski updated this revision to Diff 411835. awarzynski added a comment. Update how target IR analysis passes are initialised (use `TargetMachine::getTargetIRAnalysis()` instead of calling the constructor directly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

lichray added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2155 - CXXNewExpr::InitializationStyle InitStyle = E->getInitializationStyle(); - if (InitStyle) { -if (InitStyle == CXXNewExpr::CallInit) + auto InitStyle = E->getInitializationStyle(); + if

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

NoQ added inline comments. Comment at: clang/test/Analysis/bstring.c:310 - clang_analyzer_eval(p == [4]); // expected-warning{{TRUE}} + clang_analyzer_eval(p == [4]); // no-warning (above is fatal) } Hmm, given that your change suppresses some existing

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6216 - KindsEncountered.contains(OMPC_capture)) { -IsCompareCapture = true; Kind = OMPC_compare; tianshilei1992 wrote: > ABataev wrote: > > Can this be fixed in a

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang/lib/AST/StmtPrinter.cpp:2155 - CXXNewExpr::InitializationStyle InitStyle = E->getInitializationStyle(); - if

[PATCH] D119061: [Clang] noinline call site attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks updated this revision to Diff 411829. aeubanks added a comment. reword Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index: clang/docs/ClangPlugins.rst

Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

FWIW, I think it's probably simpler/more maintainable to default capture by reference ("[&]") if a lambda doesn't escape its scope (if it's never type erased/put in a std::function or equivalent). Avoids assert/non-assert unused issues, having to maintain/update the list when the code changes and

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

thakis added inline comments. Comment at: clang/docs/ClangPlugins.rst:209 +codegen action automatically turns off ``-clear-ast-before-backend``, which +saves peak memory by clearing the Clang AST after generating IR and before +running IR optimizations. Use

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks updated this revision to Diff 411825. aeubanks added a comment. add header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index:

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index: clang/docs/ClangPlugins.rst

[PATCH] D120629: [clang] Remove unused variable AllElementsInt. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3db74eadbfc: [clang] Remove unused variable AllElementsInt. (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] d3db74e - [clang] Remove unused variable AllElementsInt.

Author: Arthur O'Dwyer Date: 2022-02-28T12:27:34-05:00 New Revision: d3db74eadbfc06425668b39c41eeeca22f747978 URL: https://github.com/llvm/llvm-project/commit/d3db74eadbfc06425668b39c41eeeca22f747978 DIFF:

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. I have reverted the buildbot configuration change as well: https://github.com/llvm/llvm-zorg/commit/c01d0787c4a11e40d0fed81b0df6841bebc16f7f Now that everything is back to the original state, we can discuss how to proceed. Repository: rG LLVM Github Monorepo

[PATCH] D120629: [clang] Remove unused variable AllElementsInt. NFC.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120629/new/ https://reviews.llvm.org/D120629 ___

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 added a comment. Hi Marco, Yes I need help landing it. Please use Tong Zhang Thanks, - Tong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119816/new/ https://reviews.llvm.org/D119816 ___

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a comment. In D120159#3348927 , @jyknight wrote: > In D120159#3341224 , @aaron.ballman > wrote: > >> Btw, I think there may be some functionality missing for AST dumping, so I'd >> like to

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2917-2920 Create(const ASTContext , SourceLocation StartLoc, SourceLocation EndLoc, ArrayRef Clauses, Stmt *AssociatedStmt, Expr *X, Expr *V, - Expr *E, Expr *UE, Expr *D,

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

Meinersbur added a comment. This patch also caused https://github.com/llvm/llvm-project/issues/54082. I noticed due to the revert making the openmp-offload-cuda-project bot green again (https://lab.llvm.org/staging/#/builders/155/builds/2482)

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. LGTM Let me know if you need help landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119816/new/ https://reviews.llvm.org/D119816

[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116439/new/ https://reviews.llvm.org/D116439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan created this revision. scchan added a reviewer: yaxunl. Herald added subscribers: asavonic, kerbowa, jvesely. Herald added a reviewer: alexander-shaposhnikov. scchan requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski updated this revision to Diff 411812. awarzynski added a comment. Fix formatting and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120568/new/ https://reviews.llvm.org/D120568 Files: clang/include/clang/Driver/Options.td

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight added a comment. In D120159#3341224 , @aaron.ballman wrote: > Btw, I think there may be some functionality missing for AST dumping, so I'd > like to see some additional tests for that. I'm not sure what test would actually show a problem (or

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight updated this revision to Diff 411811. jyknight marked 15 inline comments as done. jyknight added a comment. Update per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 Files:

[clang] cd1489b - Clarify documentation of cpu_dispatch/cpu_specific

Author: Erich Keane Date: 2022-02-28T07:03:55-08:00 New Revision: cd1489bb58bb61276e73c91ff42dcf6a3febe650 URL: https://github.com/llvm/llvm-project/commit/cd1489bb58bb61276e73c91ff42dcf6a3febe650 DIFF: https://github.com/llvm/llvm-project/commit/cd1489bb58bb61276e73c91ff42dcf6a3febe650.diff

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

colavitam added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119063/new/ https://reviews.llvm.org/D119063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114903: [clang] Support array placement new in constant expressions

erichkeane added a comment. In D114903#3285144 , @Quuxplusone wrote: > I have no special knowledge of this. Seems like "it can't be that easy," but > I don't know. I agree with this. I have a little knowledge of the constant evaluator, but not

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa64d3c602fb7: [NFC][Lexer] Make Lexer::LangOpts const reference (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   >