[PATCH] D123567: [clang][AVR] add more builtin macros

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D123567#3444613 , @benshi001 wrote: > In D123567#3444579 , @MaskRay wrote: > >> `avr-gcc -E

[PATCH] D123571: [clang-format] Clean up unit tests for AlignArrayOfStructures

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks, feg208. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422128. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D123235: atomic compare fail : Parser & AST support

koops added a comment. Can I please have the detailed log for the build failures? I do not have the necessary setup to test those builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235

[clang] c2dafea - [CodeGen][test] Fix disable-tail-calls.c if CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL is off

Author: Fangrui Song Date: 2022-04-11T22:27:40-07:00 New Revision: c2dafea7588417b7ef131f27f8757d17f8e3679c URL: https://github.com/llvm/llvm-project/commit/c2dafea7588417b7ef131f27f8757d17f8e3679c DIFF: https://github.com/llvm/llvm-project/commit/c2dafea7588417b7ef131f27f8757d17f8e3679c.diff

[clang] fe02896 - [Driver] -fno-optimize-sibling-calls: use the same spelling for its -cc1 counterpart

Author: Fangrui Song Date: 2022-04-11T22:21:24-07:00 New Revision: fe02896a79174af089600d9ea13bb0f7a446cb8f URL: https://github.com/llvm/llvm-project/commit/fe02896a79174af089600d9ea13bb0f7a446cb8f DIFF: https://github.com/llvm/llvm-project/commit/fe02896a79174af089600d9ea13bb0f7a446cb8f.diff

[PATCH] D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault

brad updated this revision to Diff 422125. brad added a comment. Update after CSKy addition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123438/new/ https://reviews.llvm.org/D123438 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D123567: [clang][AVR] add more builtin macros

benshi001 added a comment. In D123567#3444579 , @MaskRay wrote: > `avr-gcc -E -dM -xc /dev/null -dM | grep __avr` has no result, so I am not > sure this is correct. The reason I added these little case macros, is that I find other backend targets

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 marked an inline comment as done. benshi001 added a comment. In D123200#3444520 , @MaskRay wrote: > Initial support for a new target has a high standard. It needs to show decent > support, otherwise it may just invite fixups which may in the

[PATCH] D123567: [clang][AVR] add more builtin macros

MaskRay added a comment. `avr-gcc -E -dM -xc /dev/null -dM | grep __avr` has no result, so I am not sure this is correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123567/new/ https://reviews.llvm.org/D123567

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:380 Builder.defineMacro("__AVR"); + Builder.defineMacro("__avr"); Builder.defineMacro("__AVR__"); MaskRay wrote: > The clang

[PATCH] D123567: [clang][AVR] add more builtin macros

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl, dylanmckay. Herald added subscribers: StephenFan, Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang.

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:380 Builder.defineMacro("__AVR"); + Builder.defineMacro("__avr"); Builder.defineMacro("__AVR__"); The clang preprocessor changes are unrelated to compiler-rt and should be

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

MaskRay added a comment. Initial support for a new target has a high standard. It needs to show decent support, otherwise it may just invite fixups which may in the end waste review resources. Showing that these files buildable is far from enough. You'd need to show that the run-time tests

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50b1faf5c188: [Clang] CWG 1394: Incomplete types as parameters of deleted functions (authored by rZhBoYao). Repository: rG LLVM Github Monorepo

[clang] 50b1faf - [Clang] CWG 1394: Incomplete types as parameters of deleted functions

Author: PoYao Chang Date: 2022-04-12T11:10:10+08:00 New Revision: 50b1faf5c188956fb59ea7d9f9d470591771aedb URL: https://github.com/llvm/llvm-project/commit/50b1faf5c188956fb59ea7d9f9d470591771aedb DIFF: https://github.com/llvm/llvm-project/commit/50b1faf5c188956fb59ea7d9f9d470591771aedb.diff

[clang] 369c5fa - [NFC][Clang] Use previously declared variable instead of calling function redundantly

Author: PoYao Chang Date: 2022-04-12T11:10:10+08:00 New Revision: 369c5fa17be0105cbe801a78aa8419d06aad184a URL: https://github.com/llvm/llvm-project/commit/369c5fa17be0105cbe801a78aa8419d06aad184a DIFF: https://github.com/llvm/llvm-project/commit/369c5fa17be0105cbe801a78aa8419d06aad184a.diff

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:1156-1157 - TemplateParmPosition(unsigned D, unsigned P) : Depth(D), Position(P) {} + static constexpr unsigned MaxDepth = (1l << DEPTH_BITWIDTH) -

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

ChuanqiXu updated this revision to Diff 422104. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123298/new/ https://reviews.llvm.org/D123298 Files: clang/include/clang/AST/DeclTemplate.h Index: clang/include/clang/AST/DeclTemplate.h

[PATCH] D123431: [CSKY] Remove redundant enabling of IAS for Clang, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee4c235386a3: [CSKY] Remove redundant enabling of IAS for Clang, NFC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] ee4c235 - [CSKY] Remove redundant enabling of IAS for Clang, NFC

Author: Brad Smith Date: 2022-04-11T22:34:44-04:00 New Revision: ee4c235386a36f65aa378f62889439c2fa3412b6 URL: https://github.com/llvm/llvm-project/commit/ee4c235386a36f65aa378f62889439c2fa3412b6 DIFF: https://github.com/llvm/llvm-project/commit/ee4c235386a36f65aa378f62889439c2fa3412b6.diff

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

MaskRay added a comment. The main user of the feature is the the Linux kernel. Does it still work with the change? If so, LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/new/ https://reviews.llvm.org/D123544

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. In D121556#3444260 , @void wrote: > In D121556#3444221 , @MaskRay wrote: > >> In D121556#3444131 , @void wrote: >> >>> In D121556#3444021

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. I've tried my best to review this one and it looks good to me basically. Since @aaron.ballman plans to review this one. I think it'd better to wait for this respond.

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire added a comment. In D123447#3442780 , @aaron.ballman wrote: > Thank you for the fix! Can you add a release note for it as well? > > LGTM aside from a minor nit with some comment wording and a testing > suggestion. Hey Aaron, thanks for your

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 422096. junaire added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/docs/ReleaseNotes.rst

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122981/new/ https://reviews.llvm.org/D122981 ___ cfe-commits mailing list

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 422094. junaire added a comment. Run test in C2x mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/include/clang/Parse/Parser.h

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik updated this revision to Diff 422081. shafik added a comment. Adding test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/no_auto_return_lambda.cpp Index:

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3444221 , @MaskRay wrote: > In D121556#3444131 , @void wrote: > >> In D121556#3444021 , @MaskRay >> wrote: >> >>>

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. In D121556#3444131 , @void wrote: > In D121556#3444021 , @MaskRay wrote: > >> 7aa8c38a9e190aea14116028c38b1d9f54cbb0b3 >>

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3444021 , @MaskRay wrote: > 7aa8c38a9e190aea14116028c38b1d9f54cbb0b3 > still > uses `std::shuffle`, not incorporating the `llvm::shuffle` fixes I

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3444026 , @MaskRay wrote: > In D121556#3444015 , @void wrote: > >> In D121556#3444006 , @MaskRay >> wrote: >> >>> The relanded form

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. In D121556#3444015 , @void wrote: > In D121556#3444006 , @MaskRay wrote: > >> The relanded form still lacks the -f option testing I requested. > > The unit test tests the

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. 7aa8c38a9e190aea14116028c38b1d9f54cbb0b3 still uses `std::shuffle`, not incorporating the `llvm::shuffle` fixes I did. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3444006 , @MaskRay wrote: > The relanded form still lacks the -f option testing I requested. The unit test tests the `-frandomize-layout-seed=` option already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:154-158 +#ifdef _WIN32 + const field_names Expected = {"lettuce", "bacon", "mayonnaise", "tomato"}; +#else + const field_names Expected = {"mayonnaise", "bacon", "tomato", "lettuce"}; +#endif

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. The relanded form still lacks the -f option testing I requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 ___ cfe-commits

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw added a comment. Would you have a look at the parent revision namely D121756 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 422049. sstwcw marked 2 inline comments as done. sstwcw added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files:

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

jhuber6 added a comment. In D123460#3443925 , @tianshilei1992 wrote: > If we'd like it to be used by CUDA or other programming models, > `llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp` is not a good place. Other than > that, the patch looks good to me. I

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:374 + /// Verilog we want to treat the backtick like a hash. + tok::TokenKind AliasToken = tok::unknown; + HazardyKnusperkeks wrote: > Can't we do

[PATCH] D121556: [randstruct] Add randomize structure layout support

jyknight added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:154-158 +#ifdef _WIN32 + const field_names Expected = {"lettuce", "bacon", "mayonnaise", "tomato"}; +#else + const field_names Expected = {"mayonnaise", "bacon", "tomato", "lettuce"}; +#endif

[PATCH] D123398: [VFS] RedirectingFileSystem only replace path if not already mapped

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe2478d44e4f: [VFS] RedirectingFileSystem only replace path if not already mapped (authored by bnbarham). Repository: rG LLVM Github Monorepo

[clang] fe2478d - [VFS] RedirectingFileSystem only replace path if not already mapped

Author: Ben Barham Date: 2022-04-11T14:52:48-07:00 New Revision: fe2478d44e4f7f191c43fef629ac7a23d0251e72 URL: https://github.com/llvm/llvm-project/commit/fe2478d44e4f7f191c43fef629ac7a23d0251e72 DIFF: https://github.com/llvm/llvm-project/commit/fe2478d44e4f7f191c43fef629ac7a23d0251e72.diff

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. If we'd like it to be used by CUDA or other programming models, `llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp` is not a good place. Other than that, the patch looks good to me.

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

aeubanks added a comment. I tried regenerating ClangCommandLineReference.rst and it's a little out of date. I'll regenerate it in a separate change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123547/new/ https://reviews.llvm.org/D123547

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

aeubanks updated this revision to Diff 422038. aeubanks added a comment. remove help text instead of modifying generated docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123547/new/ https://reviews.llvm.org/D123547 Files:

[clang] a1d57fc - [OpenMP] Do not use the default pipeline without optimizations

Author: Joseph Huber Date: 2022-04-11T17:27:38-04:00 New Revision: a1d57fc22587173c928ed5d82bc6b182d2465eb7 URL: https://github.com/llvm/llvm-project/commit/a1d57fc22587173c928ed5d82bc6b182d2465eb7 DIFF: https://github.com/llvm/llvm-project/commit/a1d57fc22587173c928ed5d82bc6b182d2465eb7.diff

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

void added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17982 + +// Maybe randomize the field order. We automatically randomize a structure +// of function pointers, unless it has the "no_randomize_layout" attribute. xbolva00 wrote: > Is this

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:910 -.. option:: -flegacy-pass-manager, -fno-legacy-pass-manager - This is generated by clang-tblgen. You can drop the help message from

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

nikic added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:4 NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by hand!! ---

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

aeubanks created this revision. aeubanks added reviewers: nikic, MaskRay. Herald added subscribers: StephenFan, awarzynski. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang,

[PATCH] D122673: Add kcfi_unchecked attribute

joaomoreira added a comment. > In the previous discussion, @joaomoreira pointed out that this is very > similar to `nocf_check` and proposed reusing that attribute. In an offline > discussion, @pcc was concerned that an attribute may not be the right > approach here and suggested a

[clang] 06285fc - [test][clang] Use -clear-ast-before-backend instead of -flegacy-pass-manager in CommandLineTest

Author: Arthur Eubanks Date: 2022-04-11T14:06:40-07:00 New Revision: 06285fc9fd522b5ab99f607b8123f4056d97e289 URL: https://github.com/llvm/llvm-project/commit/06285fc9fd522b5ab99f607b8123f4056d97e289 DIFF:

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

ekieri accepted this revision. ekieri added a comment. One nit/question inline, otherwise LGTM. Comment at: flang/lib/Frontend/FrontendActions.cpp:491 + // Create and configure `TargetMachine` + std::unique_ptr TM; + Is there a reason why use TM.reset

[clang] 29363f8 - [test] Remove various legacy pass manager tests

Author: Arthur Eubanks Date: 2022-04-11T14:02:17-07:00 New Revision: 29363f80a80685fcab6b963ec128a923d05dc151 URL: https://github.com/llvm/llvm-project/commit/29363f80a80685fcab6b963ec128a923d05dc151 DIFF:

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2958 /// ArgPos will have the parameter index of the first different parameter. +/// If `Reversed` is true, exactly one of FT1 and FT2 is an overload +/// candidate with a reversed parameter order.

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17982 + +// Maybe randomize the field order. We automatically randomize a structure +// of function pointers, unless it has the "no_randomize_layout" attribute. Is this allowed by C

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

void created this revision. void added reviewers: aaron.ballman, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Strutures of function pointers are a good

[PATCH] D123182: [Concepts] Fix issue #53640

royjacobson updated this revision to Diff 422030. royjacobson added a comment. Formatting + clarify docs a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: clang/docs/ReleaseNotes.rst

[clang] 8eb6741 - [docs] Remove outdated -fexperimental-new-pass-manager for profile data remapping support

Author: Fangrui Song Date: 2022-04-11T13:49:06-07:00 New Revision: 8eb6741fa0c42c8ca601294bfc40cefc7f2bf36e URL: https://github.com/llvm/llvm-project/commit/8eb6741fa0c42c8ca601294bfc40cefc7f2bf36e DIFF: https://github.com/llvm/llvm-project/commit/8eb6741fa0c42c8ca601294bfc40cefc7f2bf36e.diff

[clang] 98574aa - [test] Remove references to -fno-legacy-pass-manager in tests

Author: Arthur Eubanks Date: 2022-04-11T13:40:27-07:00 New Revision: 98574aa1d24a310ddbabdc668cafee4d499b51e7 URL: https://github.com/llvm/llvm-project/commit/98574aa1d24a310ddbabdc668cafee4d499b51e7 DIFF:

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added a comment. In D123471#3443612 , @yaxunl wrote: > Is OpenMP runtime able to find these entries without registering them through > some API functions? If so, do you have a pointer to the code doing that? Yes, the linker will define

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rsmith added a comment. The patch description doesn't match the patch: we have `__remove_cv` in the description but `__remove_cv_qualifiers` in the patch. It seems unfortunate to me to use a long-term bad name for our trait to work around a (likely) short-term problem with a specific version

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd563c2d0e52a: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum (authored by LegalizeAdulthood). Repository: rG LLVM Github

[clang-tools-extra] d563c2d - [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

Author: Richard Date: 2022-04-11T14:06:48-06:00 New Revision: d563c2d0e52a738ab2038db02a76dc4c27ec7124 URL: https://github.com/llvm/llvm-project/commit/d563c2d0e52a738ab2038db02a76dc4c27ec7124 DIFF: https://github.com/llvm/llvm-project/commit/d563c2d0e52a738ab2038db02a76dc4c27ec7124.diff LOG:

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3957 switch (T->getUTTKind()) { case UnaryTransformType::EnumUnderlyingType: I'd prefer that you restructure this to first compute a `StringRef` corresponding to the name of

[PATCH] D123535: [clang-format] Allow empty .clang-format file

owenpan added a comment. In D123535#3443604 , @curdeius wrote: > I have stumbled on it myself several times but never really needed a fix. > Out of curiosity, what motivates you to do this change? I was playing with adding/removing some options in a

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:456 if (IncStdLib && IncDefLibs) { +addBitIntRuntime(HTC, CmdArgs, Args); + The runtime library order matters and roughly reflects a topological order. For instances, -lc

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

yaxunl added a comment. Is OpenMP runtime able to find these entries without registering them through some API functions? If so, do you have a pointer to the code doing that? most CUDA/HIP programs assume -fno-gpu-rdc mode, which have multiple sections containing these entries merged by

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

aaron.ballman added a comment. In D122874#3442887 , @ldionne wrote: > I actually think that `[[no_unique_address]]` and > `__attribute__((no_unique_address))` should be equivalent. Similarly, we > should be able to do `[[msvc::no_unique_address]]` and

[PATCH] D123535: [clang-format] Allow empty .clang-format file

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. I have stumbled on it myself several times but never really needed a fix. Out of curiosity, what motivates you to do this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123300: [Clang] Enable opaque pointers by default

vitalybuka added a comment. https://lab.llvm.org/buildbot/#/builders/74/builds/10288/steps/14/logs/stdio FAILED: tools/clang/lib/Tooling/ASTNodeAPI.json cd /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm_build_msan_track_origins/tools/clang/lib/Tooling &&

[clang] aefa4b6 - [Driver] Simplify hasFlag pattern with addOptInFlag/addOptOutFlag helpers

Author: Fangrui Song Date: 2022-04-11T12:29:25-07:00 New Revision: aefa4b60cebaeada796a161bab036bf145790b00 URL: https://github.com/llvm/llvm-project/commit/aefa4b60cebaeada796a161bab036bf145790b00 DIFF: https://github.com/llvm/llvm-project/commit/aefa4b60cebaeada796a161bab036bf145790b00.diff

[PATCH] D123468: [Driver] Simplify hasFlag pattern with addOptInFlag/addOptOutFlag helpers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaefa4b60ceba: [Driver] Simplify hasFlag pattern with addOptInFlag/addOptOutFlag helpers (authored by MaskRay). Repository: rG LLVM Github

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl updated this revision to Diff 422001. yaxunl retitled this revision from "[HIP] Fix mangling number for local struct" to "[CUDA][HIP] Fix mangling number for local struct". yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: carlosgalvezp. Use

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt

aaron.ballman added a comment. This looks generally correct to me, but precommit CI is currently failing with a relevant issue (what a nice change of pace): Failed Tests (1): Clang :: Driver/linux-ld.c Comment at: clang/include/clang/Basic/TargetInfo.h:603 +if

[PATCH] D122673: Add kcfi_unchecked attribute

aaron.ballman added a comment. In D122673#3443518 , @samitolvanen wrote: > In D122673#3443498 , @aaron.ballman > wrote: > >> I tend to be very wary of modifying the type system with attributes -- >> questions

[PATCH] D123535: [clang-format] Allow empty .clang-format file

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

aaron.ballman added a comment. In D123479#3443467 , @LegalizeAdulthood wrote: > In D123479#3443401 , @aaron.ballman > wrote: > >> In D123479#3442968 , >>

[PATCH] D122673: Add kcfi_unchecked attribute

samitolvanen added a comment. In D122673#3443498 , @aaron.ballman wrote: > I tend to be very wary of modifying the type system with attributes -- > questions always arise of what the type system effects are of the attribute. > e.g., does it impact

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

zixuw added inline comments. Comment at: clang/test/ExtractAPI/enum.c:684 +}, +"uri": "file:///Users/dgrumberg/VersionControlledDocuments/oss/llvm-project/build/tools/clang/test/ExtractAPI/Output/enum.c.tmp/input.h" + }, nit: normalize

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim created this revision. hctim added reviewers: echristo, cmtice. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An upcoming patch will extend llvm-symbolizer to provide the source line information

[PATCH] D122673: Add kcfi_unchecked attribute

aaron.ballman added a comment. In D122673#3414650 , @samitolvanen wrote: > Note that this was split from D119296 . > > In the previous discussion, @joaomoreira pointed out that this is very > similar to `nocf_check`

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Anonymous enums without a typedef should have a "(anonymous)" identifier.

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 421991. LegalizeAdulthood added a comment. - Update documentation to reflect multiple pairs of matching parens CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123479/new/ https://reviews.llvm.org/D123479 Files:

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added subscribers: jansvoboda11, vsapsai, Bigcheese. dexonsmith added a comment. In D123104#3443448 , @dexonsmith wrote: > I wonder if > https://github.com/apple/llvm-project/commit/67c70038bcc0d771e2e39c875ad7d69e329c7fc4 > could be

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 421990. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123479/new/ https://reviews.llvm.org/D123479 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. In D123479#3443401 , @aaron.ballman wrote: > In D123479#3442968 , > @LegalizeAdulthood wrote: > >> In D123479#3442062

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added a comment. In D123104#3439261 , @bnbarham wrote: > Looks like there's more changes required for modulemap-collision.m to > actually pass. I'll try figure those out when I have the time. Capturing `clang -check` error since the build

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D123479#3442968 , @LegalizeAdulthood wrote: > In D123479#3442062 , @njames93 > wrote: >

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dang marked an inline comment as done. Closed by commit rG236b6a0eb41a: [clang][extract-api] Emit functionSignature in SGF for ObjC methods. (authored by dang).

[clang] 236b6a0 - [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

Author: Daniel Grumberg Date: 2022-04-11T19:05:24+01:00 New Revision: 236b6a0eb41a163510e65664e2160f599287326b URL: https://github.com/llvm/llvm-project/commit/236b6a0eb41a163510e65664e2160f599287326b DIFF:

[PATCH] D123526: [clang][ExtractAPI][NFC] Fix sed delimiter in test

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix path replacement in sed (properly this time) using lit regex_replacement. Repository: rG

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

aaron.ballman added inline comments. Comment at: llvm/include/llvm/ADT/StringExtras.h:329 +std::string to_hexString(uint64_t Value, bool UpperCase = true); + cor3ntin wrote: > aaron.ballman wrote: > > `utohexstr()` already exists on line 152 -- any reason we

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:238 + diag::err_delimited_escape_missing_brace) +<< std::string(1, 'o'); aaron.ballman wrote: > Can you use `"o"` instead of constructing a `std::string` for

[PATCH] D123398: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123398/new/ https://reviews.llvm.org/D123398

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123304/new/ https://reviews.llvm.org/D123304 ___

[PATCH] D123398: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith added a comment. In D123398#3439946 , @bnbarham wrote: > Does `clang/test/VFS/external-names-multi-overlay.c` need to be formatted or > is it fine? It uses split-file so I'd really like to avoid the format here > (makes it pretty silly).

  1   2   >