[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

This revision was automatically updated to reflect the committed changes. Closed by commit rG6882ca9aff07: [Clang] Adjust extension warnings for delimited sequences (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129664/new/

[clang] 6882ca9 - [Clang] Adjust extension warnings for delimited sequences

Author: Corentin Jabot Date: 2022-07-14T07:50:58+02:00 New Revision: 6882ca9aff076738bbffd68f73892187519554f8 URL: https://github.com/llvm/llvm-project/commit/6882ca9aff076738bbffd68f73892187519554f8 DIFF:

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. Wasn't there a discussion about this before, or some other patch? If so, could we please link such things (e.g., in the commit message) so people don't have to remember and

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

glandium added a comment. FWIW, this change also broke this check in Firefox's clang plugin: https://searchfox.org/mozilla-central/rev/0d11f3660945ce35c49501bb44bc4f82bb2b503c/build/clang-plugin/NoPrincipalGetURI.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

sameerds added a comment. The current set of reviewers is mostly loaded with HIP engineers who are familiar with the issue and the proposed solution. But this solution affects all languages with convergent functions, which is visible from the affected tests. It will be good to seek comments

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu added a comment. @iains @rsmith @MaskRay gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127187/new/ https://reviews.llvm.org/D127187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson added a comment. In D129170#3650618 , @glandium wrote: > From the commit message: > >> This patch adds deprecation warnings for the usage of those builtins, except >> for __has_trivial_destructor which doesn't have a GCC alternative. > > The

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. Why was this reverted? Please make extensive tests especially for something dealing with the build system. When reverting a commit, briefly describe what happened. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

glandium added a comment. From the commit message: > This patch adds deprecation warnings for the usage of those builtins, except > for __has_trivial_destructor which doesn't have a GCC alternative. This doesn't seem to be true, FWIW. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

NoQ added a comment. In D129498#3647348 , @ASDenysPetrov wrote: > In D129498#3644222 , @NoQ wrote: > >> Maybe `clang_analyzer_range()` instead? > > This was its first name. I refused. First, because it emits

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

3405691582 added a comment. In D129654#3650534 , @brad wrote: > In D129654#3650412 , @3405691582 > wrote: > >> Tested change on OpenBSD resolves downstream issues. > > What issues? As mentioned, this replicates

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232 +path::remove_filename(P); +addSystemInclude(DriverArgs, CC1Args, P); } shchenz wrote: > Can we use `path::parent_path(P)` directly in `addSystemInclude()`? >

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. In D129654#3650412 , @3405691582 wrote: > Tested change on OpenBSD resolves downstream issues. What issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu added a reviewer: ychen. ChuanqiXu added a comment. @jyknight @nikic @rjmccall @efriedma @nhaehnle gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 ___ cfe-commits mailing list

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:10621-10626 // Compute the hash of the method as if it has no body. -auto ComputeCXXMethodODRHash = [](const CXXMethodDecl *D) { - Hash.clear(); -

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcef07169ec9f: [llvm] add zstd to `llvm::compression` namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 89. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd - [Support] update zstd interface to use uint8_t * and ArrayRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

3405691582 accepted this revision. 3405691582 added a comment. This revision is now accepted and ready to land. LGTM. Tested change on OpenBSD, was not able to check FreeBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/

[clang] b370be3 - [CUDA] Allow the new driver to compile CUDA in non-RDC mode

Author: Joseph Huber Date: 2022-07-13T21:49:15-04:00 New Revision: b370be37cca760122903f1e202952fecf5182cc1 URL: https://github.com/llvm/llvm-project/commit/b370be37cca760122903f1e202952fecf5182cc1 DIFF: https://github.com/llvm/llvm-project/commit/b370be37cca760122903f1e202952fecf5182cc1.diff

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

This revision was automatically updated to reflect the committed changes. jhuber6 marked an inline comment as done. Closed by commit rGb370be37cca7: [CUDA] Allow the new driver to compile CUDA in non-RDC mode (authored by jhuber6). Changed prior to commit:

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad added a comment. In D129714#3650371 , @MaskRay wrote: > Thanks! This is trivially correct but consider giving folks one day to > respond. Sure thing. No problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. There is already the initial --sysroot test in test/Driver/openbsd.c. It would be preferable to modify what is there. For FreeBSD a test should be added to test/Driver/freebsd.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! This is trivially correct but consider giving folks one day to respond. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad created this revision. brad added reviewers: MaskRay, emaste, zhmu, mgorny, phosek. brad added a project: clang. Herald added subscribers: abrachet, StephenFan. Herald added a project: All. brad requested review of this revision. As mentioned in commit

[PATCH] D129563: [docs] Document git-clang-format

This revision was automatically updated to reflect the committed changes. Closed by commit rG422e6e762935: [docs] Document git-clang-format (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 422e6e7 - [docs] Document git-clang-format

Author: Nico Weber Date: 2022-07-13T21:06:00-04:00 New Revision: 422e6e762935b4466c2ef1871df6917ab1c31262 URL: https://github.com/llvm/llvm-project/commit/422e6e762935b4466c2ef1871df6917ab1c31262 DIFF: https://github.com/llvm/llvm-project/commit/422e6e762935b4466c2ef1871df6917ab1c31262.diff

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3284-3286 // Hidden or internal symbols on the device are not externally visible. We // should not attempt to register them by creating an offloading entry. if (auto *GV =

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:107 +// CHECK-GCOV: @__llvm_gcov_init() unnamed_addr [[EXTERNGCOV]] +// CHECK-ASAN: @asan.module_ctor() [[EXTERNASAN:#[0-9]+]] +// CHECK-TSAN: @tsan.module_ctor() [[EXTERNTSAN:#[0-9]+]]

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, void. Herald added subscribers: jsji, StephenFan, jdoerfert, pengfei, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10790 Flags = OffloadEntriesInfoManagerTy::OMPTargetGlobalVarEntryTo; -VarName = CGM.getMangledName(VD); +// We don't need to mangle the host side of declare target global variables

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/Support/Compression.h:54 + +void compress(StringRef InputBuffer, SmallVectorImpl , + int Level = DefaultCompression);

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d7e58cfade1: [analyzer] Fix use of length in CStringChecker (authored by einvbri vince.a.bridg...@ericsson.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1d7e58c - [analyzer] Fix use of length in CStringChecker

Author: einvbri Date: 2022-07-13T19:19:23-05:00 New Revision: 1d7e58cfade1dd4236efba59ce969698bb05a039 URL: https://github.com/llvm/llvm-project/commit/1d7e58cfade1dd4236efba59ce969698bb05a039 DIFF: https://github.com/llvm/llvm-project/commit/1d7e58cfade1dd4236efba59ce969698bb05a039.diff LOG:

[PATCH] D129691: [clang][test] fix typo in fn attr

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:18 // CHECK: @keep2() [[KEEP:#[0-9]+]] [[gnu::function_return("keep")]] void keep2(void) {} probably don't want to reset `KEEP` Comment at:

[PATCH] D129456: [lldb] Add image dump pcm-info command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5ccfeb6bfbb: [lldb] Add image dump pcm-info command (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b5ccfeb - [lldb] Add image dump pcm-info command

Author: Dave Lee Date: 2022-07-13T16:56:53-07:00 New Revision: b5ccfeb6bfbbc5436b91a1e317f88e2c499c9306 URL: https://github.com/llvm/llvm-project/commit/b5ccfeb6bfbbc5436b91a1e317f88e2c499c9306 DIFF: https://github.com/llvm/llvm-project/commit/b5ccfeb6bfbbc5436b91a1e317f88e2c499c9306.diff

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

kees added a comment. Example of the bug I want to block: struct foo { int stuff; u32 data[0]; }; struct foo *deserialize(u8 *str, int len) { struct foo *instance; size_t bytes; bytes = sizeof(*instance) + sizeof(instance->data) * (len / sizeof(u32));

[PATCH] D129706: [NFCI][clang-tidy] Reimplement GlobList without relying on Regex.

njames93 updated this revision to Diff 57. njames93 added a comment. Fix comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129706/new/ https://reviews.llvm.org/D129706 Files: clang-tools-extra/clang-tidy/GlobList.cpp

[PATCH] D129466: [clang-format][NFC] Replace most of std::vector with SmallVector

This revision was automatically updated to reflect the committed changes. Closed by commit rG36229fa3886b: [clang-format][NFC] Replace most of std::vector with SmallVector (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 36229fa - [clang-format][NFC] Replace most of std::vector with SmallVector

Author: owenca Date: 2022-07-13T16:45:22-07:00 New Revision: 36229fa3886be7d3c864642fad021c9fe4afda38 URL: https://github.com/llvm/llvm-project/commit/36229fa3886be7d3c864642fad021c9fe4afda38 DIFF: https://github.com/llvm/llvm-project/commit/36229fa3886be7d3c864642fad021c9fe4afda38.diff LOG:

[PATCH] D129706: [NFCI][clang-tidy] Reimplement GlobList without relying on Regex.

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Regex is

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

kees added a comment. In D126864#3646854 , @jyknight wrote: > In D126864#3645994 , @kees wrote: > >> I should clarify: I still need the =3 mode. Since sizeof([0]) == 0 and >> sizeof([]) == error, they are being

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 updated this revision to Diff 49. ziqingluo-90 added a comment. Added a test to `unittests/ASTMatchers/Dynamic/RegistryTest.cpp` and confirms that the overloaded `callee` still works with dynamic matchers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129398/new/

[clang-tools-extra] e690137 - [Support] Change compression::zlib::{compress,uncompress} to use uint8_t *

Author: Fangrui Song Date: 2022-07-13T16:26:54-07:00 New Revision: e690137dde1c9b037e0c987d393da054d86eeeab URL: https://github.com/llvm/llvm-project/commit/e690137dde1c9b037e0c987d393da054d86eeeab DIFF: https://github.com/llvm/llvm-project/commit/e690137dde1c9b037e0c987d393da054d86eeeab.diff

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3648624 , @JDevlieghere wrote: > This breaks all the LLDB tests that import the std module: > > Given that the bot has been red for 14 hours I went ahead and reverted this > change. Please keep an eye on this bot

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks created this revision. aeubanks added reviewers: pcc, tejohnson. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

abrahamcd added a comment. In D109701#3648168 , @vaibhav.y wrote: > In D109701#3646856 , @abrahamcd > wrote: > >> Hi! I'm interning with @cjdb and @denik this summer and I was working on >> adding a

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 32. ckissane added a comment. - Merge branch main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt llvm/cmake/config-ix.cmake

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added inline comments. Comment at: llvm/lib/Support/Compression.cpp:63 __msan_unpoison(CompressedBuffer.data(), CompressedSize); - CompressedBuffer.truncate(CompressedSize); + if (CompressedSize < CompressedBuffer.size()) +

[PATCH] D129583: [DOC] Add DR1734 and DR1496 Clang's cxx_dr_status as not implemented

royjacobson added a comment. Thanks for the suggestions and for the quick review! @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129583/new/ https://reviews.llvm.org/D129583 ___

[PATCH] D129583: [DOC] Add DR1734 and DR1496 Clang's cxx_dr_status as not implemented

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG202b327f5d29: [DOC] Add DR1734 and DR1496 Clangs cxx_dr_status as not implemented (authored by royjacobson). Repository: rG LLVM Github Monorepo

[clang] 202b327 - [DOC] Add DR1734 and DR1496 Clang's cxx_dr_status as not implemented

Author: Roy Jacobson Date: 2022-07-14T00:48:35+03:00 New Revision: 202b327f5d293a6f795a01933835b5ad53d8ed42 URL: https://github.com/llvm/llvm-project/commit/202b327f5d293a6f795a01933835b5ad53d8ed42 DIFF: https://github.com/llvm/llvm-project/commit/202b327f5d293a6f795a01933835b5ad53d8ed42.diff

[PATCH] D129583: [DOC] Add DR1734 and DR1496 Clang's cxx_dr_status as not implemented

royjacobson updated this revision to Diff 22. royjacobson added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129583/new/ https://reviews.llvm.org/D129583 Files: clang/test/CXX/drs/dr14xx.cpp

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jhuber6 added a comment. Thanks for the patch. I still think this is a silly feature to support, but users will probably expect it. See comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10790 Flags = OffloadEntriesInfoManagerTy::OMPTargetGlobalVarEntryTo; -

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>; python3kgae wrote: > beanz wrote: >

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added inline comments. Comment at: llvm/lib/Support/Compression.cpp:63 __msan_unpoison(CompressedBuffer.data(), CompressedSize); - CompressedBuffer.truncate(CompressedSize); + if (CompressedSize < CompressedBuffer.size()) +

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>;

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>; python3kgae wrote: > pow2clk wrote:

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 created this revision. ssquare08 added a reviewer: jhuber6. Herald added subscribers: mattd, asavonic, guansong, yaxunl. Herald added a project: All. ssquare08 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald

[clang] 779ba43 - [clang][deps] Silence a GCC warning about missing returns after a fully covered switch. NFC.

Author: Martin Storsjö Date: 2022-07-13T23:57:01+03:00 New Revision: 779ba43234cc9eb747018d2fe86d7d4a16d283d9 URL: https://github.com/llvm/llvm-project/commit/779ba43234cc9eb747018d2fe86d7d4a16d283d9 DIFF:

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>;

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 13. python3kgae marked 3 inline comments as done. python3kgae added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 Files:

[PATCH] D129691: [clang][test] fix typo in fn attr

nickdesaulniers created this revision. nickdesaulniers added reviewers: aaron.ballman, erichkeane, MaskRay. Herald added subscribers: jsji, StephenFan, pengfei. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D129607: [clang][deps] Fix handling of -MT in module command-line

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ce78cbd2392: [clang][deps] Fix handling of -MT in module command-line (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129607/new/

[clang] 3ce78cb - [clang][deps] Fix handling of -MT in module command-line

Author: Ben Langmuir Date: 2022-07-13T13:36:15-07:00 New Revision: 3ce78cbd2392d7c98f97d1d424cd7ff582fc28f8 URL: https://github.com/llvm/llvm-project/commit/3ce78cbd2392d7c98f97d1d424cd7ff582fc28f8 DIFF: https://github.com/llvm/llvm-project/commit/3ce78cbd2392d7c98f97d1d424cd7ff582fc28f8.diff

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added a comment. I don't have push credentials so If everything is okay with the patch, can you push it for me. My email is omarpiratee2...@gmail.com Comment at: clang/include/clang/Format/Format.h:3555 AfterFunctionDefinitionName(false),

[PATCH] D129594: [InstrProf] Add options to profile function groups

ianlevesque accepted this revision. ianlevesque added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129594/new/ https://reviews.llvm.org/D129594

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane marked 6 inline comments as done. ckissane added a comment. Mark handled comments from @MaskRay as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[PATCH] D129607: [clang][deps] Fix handling of -MT in module command-line

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129607/new/ https://reviews.llvm.org/D129607

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. In D128090#3649579 , @tra wrote: > In D128090#3649235 , @jhuber6 wrote: > >> Interesting, may be worthwhile to query that if it exists, though AMD does >> this with `amdgpu-arch` which

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7009 + // Host-side offloading compilation receives all device-side outputs. Include + // them in the host compilation depending on the target. if

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7009 + // Host-side offloading compilation receives all device-side outputs. Include + // them in the host compilation

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 00. ckissane added a comment. tidy some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt llvm/cmake/config-ix.cmake

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

tra added a comment. In D128090#3649235 , @jhuber6 wrote: > Interesting, may be worthwhile to query that if it exists, though AMD does > this with `amdgpu-arch` which has led to problems for me in the past. But > even if it could be wrong it will still

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 updated this revision to Diff 444398. jhuber6 marked an inline comment as done. jhuber6 added a comment. Updating and making suggested changes. I removed the old `fgpu-rdc` in rG6abaa8e2103760025cee76528f555de7cf6698e6

[clang] 6abaa8e - [CUDA][HIP][NFC] Do not add `-fgpu-rdc` flag twice

Author: Joseph Huber Date: 2022-07-13T15:57:53-04:00 New Revision: 6abaa8e2103760025cee76528f555de7cf6698e6 URL: https://github.com/llvm/llvm-project/commit/6abaa8e2103760025cee76528f555de7cf6698e6 DIFF: https://github.com/llvm/llvm-project/commit/6abaa8e2103760025cee76528f555de7cf6698e6.diff

[PATCH] D126735: [clang-tidy] Silence modernize-redundant-void-arg in the case of vexing parses

george.burgess.iv updated this revision to Diff 444397. george.burgess.iv added a comment. Rebased on top of 891319f654c102572cf7028ed04bbaf6c59e7bff as requested; `ninja check-clang-extra docs-clang-tools-html` passes

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 marked an inline comment as done. jhuber6 added a comment. It's also worth noting that this doesn't include the `PTX` output for JIT in the fatbinary, it would be relatively easy to include that but I wanted to ask how we should handle that. Comment at:

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

kimgr added a comment. This patch also broke IWYU, not exactly sure how or why yet. We run around the AST quite a bit, so structural changes like this often bite us. Can you expand on what happened here? Before/after kind-of thing? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D119296: KCFI sanitizer

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Worth waiting a bit and checking whether @pcc has more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:332 + + Register AddrReg = MI.getOperand(0).getReg(); + MaskRay wrote: > Add const. Delete blank line after the declaration. Deleted the blank line, but this can't be

[clang] 1a5c1ee - [LinkerWrapper] Fix deleted constructor error on older compilers

Author: Joseph Huber Date: 2022-07-13T15:45:35-04:00 New Revision: 1a5c1ee5b8bb580ce35e660f9ea907148c6bf627 URL: https://github.com/llvm/llvm-project/commit/1a5c1ee5b8bb580ce35e660f9ea907148c6bf627 DIFF: https://github.com/llvm/llvm-project/commit/1a5c1ee5b8bb580ce35e660f9ea907148c6bf627.diff

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG07df9e918e3f: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums (authored by jolanta.jensen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 07df9e9 - [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

Author: Jolanta Jensen Date: 2022-07-13T20:44:06+01:00 New Revision: 07df9e918e3f6b8d99eaae0243a17e18a7bdd860 URL: https://github.com/llvm/llvm-project/commit/07df9e918e3f6b8d99eaae0243a17e18a7bdd860 DIFF:

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

MaskRay added a comment. The patch looks mostly good but please fix the subject and the summary. Note: if you fix the local commit message, you can use ` arc diff --head=HEAD 'HEAD^' --verbatim` to update the subject and the summary. Comment at:

[clang] c70db40 - [LinkerWrapper] Support time tracing in the linker wrapper

Author: Joseph Huber Date: 2022-07-13T15:38:39-04:00 New Revision: c70db40ceb65ef5ad4549a0ad4665ed88a5e2224 URL: https://github.com/llvm/llvm-project/commit/c70db40ceb65ef5ad4549a0ad4665ed88a5e2224 DIFF: https://github.com/llvm/llvm-project/commit/c70db40ceb65ef5ad4549a0ad4665ed88a5e2224.diff

[clang] 96f16a6 - [LinkerWrapper] Add support for timescope tracing

Author: Joseph Huber Date: 2022-07-13T15:38:39-04:00 New Revision: 96f16a6867f78e42e67807cbd357546a95b2a9b6 URL: https://github.com/llvm/llvm-project/commit/96f16a6867f78e42e67807cbd357546a95b2a9b6 DIFF: https://github.com/llvm/llvm-project/commit/96f16a6867f78e42e67807cbd357546a95b2a9b6.diff

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

tra added a comment. Nice. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6999 +if (IsRDCMode) + CmdArgs.push_back("-fgpu-rdc"); + } else if (IsCuda && !HostOffloadingInputs.empty() && !IsRDCMode) { This should not be necessary -- we've already

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

This revision was automatically updated to reflect the committed changes. Closed by commit rGa61b202d4e3b: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a61b202 - [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

Author: Zarko Todorovski Date: 2022-07-13T15:32:29-04:00 New Revision: a61b202d4e3b00bf6bfd71dc1ea354d37f73b791 URL: https://github.com/llvm/llvm-project/commit/a61b202d4e3b00bf6bfd71dc1ea354d37f73b791 DIFF:

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! If for some very surprising reason either of these papers fail in plenary, we can easily revert this as necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6998-6999 +CmdArgs.push_back(CudaDeviceInput->getFilename()); +if (IsRDCMode) + CmdArgs.push_back("-fgpu-rdc"); + } else if (IsCuda && !HostOffloadingInputs.empty() && !IsRDCMode) {

[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

SebastianPerta added a comment. >> Additionally, the type of a character constant in C is int. This means that char32_t c4 = U'\U00064321'; is invalid in C. I know that is clang more strict with the standard than GCC, however I would like to mention that in GCC the value is not truncated to 16

[PATCH] D129683: [Sema] Move Diags.isIgnored() checks off hot paths, it's not free. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: usaxena95. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This speeds up clangd's

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. ok. I will take care of this next time. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 ___ cfe-commits mailing list

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 444374. ckissane added a comment. - Trim CMAKE modifications to minimum needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes here LGTM aside from one thing (which I'll take care of when I land the changes on your behalf). ParseDeclCXX.cpp still has a bunch of unrelated whitespace changes

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5444 + if (Better1 && Better2) { +bool ClangABICompat14 = S.Context.getLangOpts().getClangABICompat() <= +LangOptions::ClangABI::Ver14;

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. In D128090#3649202 , @tra wrote: > In D128090#3649125 , @jhuber6 wrote: > >> It just defaults to `sm_35` if CUDA isn't present on the system IIRC. >> Alternatively we could ship a tool

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444361. cassanova added a comment. Updated the ProtobufMutator CMake module and expression fuzzer CMakeLists file so that the expression fuzzer will create its own target name in its CMake file, and the ProtobufMutator will not attempt to create another

  1   2   3   >