[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

uabelho added a comment. Hello, The new testcase added in this patch fails for me all the time. I'm compiling on a linux RHEL 7 machine. When I run the clang-repl command in the test I get JIT session error: Symbols not found: [ _ZTIPKc ] error: Failed to materialize symbols: { (main, {

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

MaskRay added a comment. Making the behavior different for different Linux distributions is not great, but if it matches the practice, I think it is fine. I don't know Sparc enough to suggest anything for 32-bit, though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ChuanqiXu closed this revision. ChuanqiXu added a comment. This is not automated closed by https://github.com/llvm/llvm-project/commit/4d9251bd780d20eebbcb124608b36a69787d5575 due to a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130614/new/ https://reviews.llvm.org/D130614

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a reviewer: aaron.ballman. barannikov88 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 ___ cfe-commits mailing list

[PATCH] D128695: [ODRHash diagnostics] Move `ODRDiagsEmitter` to libAST in separate files. NFC.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. If the code motion is helpful for further changes, it should be good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128695/new/

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9577-9584 +static std::string getOwningModuleNameForDiagnostic(const Decl *D) { + // If we know the owning module, use it. + if (Module *M = D->getImportedOwningModule()) +return

[clang] 4d9251b - [C++20] [Modules] Merge same concept decls in global module fragment

Author: Chuanqi Xu Date: 2022-07-29T10:50:27+08:00 New Revision: 4d9251bd780d20eebbcb124608b36a69787d5575 URL: https://github.com/llvm/llvm-project/commit/4d9251bd780d20eebbcb124608b36a69787d5575 DIFF: https://github.com/llvm/llvm-project/commit/4d9251bd780d20eebbcb124608b36a69787d5575.diff

[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ChuanqiXu added a comment. In D130614#3685142 , @ilya-biryukov wrote: > Thanks for the thorough explanation and testing. > LGTM. Thanks for reviewing! Comment at: clang/lib/Sema/SemaDecl.cpp:1747 + + Module *NewM =

[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ChuanqiXu updated this revision to Diff 448504. ChuanqiXu marked 3 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130614/new/ https://reviews.llvm.org/D130614 Files: clang/include/clang/Basic/Module.h

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

This revision was automatically updated to reflect the committed changes. Closed by commit rGa35c64ce23b7: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which… (authored by skc7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a35c64c - [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

Author: skc7 Date: 2022-07-29T02:27:26Z New Revision: a35c64ce23b7c7e4972c89b224b9363639dddea2 URL: https://github.com/llvm/llvm-project/commit/a35c64ce23b7c7e4972c89b224b9363639dddea2 DIFF: https://github.com/llvm/llvm-project/commit/a35c64ce23b7c7e4972c89b224b9363639dddea2.diff LOG:

[PATCH] D130018: [HLSL] Add HLSLResource attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc47db673704: [HLSL] Add HLSLResource attribute (authored by beanz). Changed prior to commit:

[clang] cc47db6 - [HLSL] Add HLSLResource attribute

Author: Chris Bieneman Date: 2022-07-28T20:54:51-05:00 New Revision: cc47db6737049f0c30e9c092de65e40823eb14be URL: https://github.com/llvm/llvm-project/commit/cc47db6737049f0c30e9c092de65e40823eb14be DIFF:

[PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. It'd be nice if this was landed opt-in behind some cmake variable at first, so that folks could try it out on their bots and see how well things work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/

[PATCH] D88299: [clang-format] Add MacroUnexpander.

sstwcw added a comment. It looks like some of the braces in the code should be removed for example those surrounding one-line for bodies. Sorry if it is not my job to point this out, but MyDeveloperDay has not said anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

aidengrossman added a comment. Thanks for the review and your suggestions. Do you mind pushing this commit? I don't currently have commit access to LLVM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130620/new/

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130620/new/ https://reviews.llvm.org/D130620

[PATCH] D128709: [clang-format] Handle Verilog attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG60e12068ffeb: [clang-format] Handle Verilog attributes (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D128709?vs=443611=448491#toc Repository: rG LLVM Github Monorepo

[PATCH] D128714: [clang-format] Handle Verilog case statements

This revision was automatically updated to reflect the committed changes. Closed by commit rGc88719483c69: [clang-format] Handle Verilog case statements (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128714/new/

[PATCH] D128713: [clang-format] Handle Verilog user-defined primitives

This revision was automatically updated to reflect the committed changes. Closed by commit rGb67ee18e85f3: [clang-format] Handle Verilog user-defined primitives (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D128713?vs=443607=448489#toc Repository: rG LLVM Github

[PATCH] D128712: [clang-format] Handle Verilog modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG6db0c18b1af6: [clang-format] Handle Verilog modules (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128712/new/

[PATCH] D128711: [clang-format] Handle Verilog blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67480b360ca0: [clang-format] Handle Verilog blocks (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 60e1206 - [clang-format] Handle Verilog attributes

Author: sstwcw Date: 2022-07-29T00:38:30Z New Revision: 60e12068ffeb96aa4e56c8dcff3442e516b27ab6 URL: https://github.com/llvm/llvm-project/commit/60e12068ffeb96aa4e56c8dcff3442e516b27ab6 DIFF: https://github.com/llvm/llvm-project/commit/60e12068ffeb96aa4e56c8dcff3442e516b27ab6.diff LOG:

[clang] c887194 - [clang-format] Handle Verilog case statements

Author: sstwcw Date: 2022-07-29T00:38:30Z New Revision: c88719483c69f7f34be4487f6623b06c37475e5a URL: https://github.com/llvm/llvm-project/commit/c88719483c69f7f34be4487f6623b06c37475e5a DIFF: https://github.com/llvm/llvm-project/commit/c88719483c69f7f34be4487f6623b06c37475e5a.diff LOG:

[clang] b67ee18 - [clang-format] Handle Verilog user-defined primitives

Author: sstwcw Date: 2022-07-29T00:38:30Z New Revision: b67ee18e85f30334792e33a71c883fcfdcb83436 URL: https://github.com/llvm/llvm-project/commit/b67ee18e85f30334792e33a71c883fcfdcb83436 DIFF: https://github.com/llvm/llvm-project/commit/b67ee18e85f30334792e33a71c883fcfdcb83436.diff LOG:

[clang] 6db0c18 - [clang-format] Handle Verilog modules

Author: sstwcw Date: 2022-07-29T00:38:30Z New Revision: 6db0c18b1af653f33dd4629d6155f6cf334a975e URL: https://github.com/llvm/llvm-project/commit/6db0c18b1af653f33dd4629d6155f6cf334a975e DIFF: https://github.com/llvm/llvm-project/commit/6db0c18b1af653f33dd4629d6155f6cf334a975e.diff LOG:

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf93182a88788: [clang-format] Handle Verilog numbers and operators (authored by sstwcw). Changed prior to commit:

[clang] 67480b3 - [clang-format] Handle Verilog blocks

Author: sstwcw Date: 2022-07-29T00:38:30Z New Revision: 67480b360ca0dcc33fe3126d0602b3d358dfbc6f URL: https://github.com/llvm/llvm-project/commit/67480b360ca0dcc33fe3126d0602b3d358dfbc6f DIFF: https://github.com/llvm/llvm-project/commit/67480b360ca0dcc33fe3126d0602b3d358dfbc6f.diff LOG:

[clang] f93182a - [clang-format] Handle Verilog numbers and operators

Author: sstwcw Date: 2022-07-29T00:38:29Z New Revision: f93182a887889828fc6c963174afd7d7b3625e5a URL: https://github.com/llvm/llvm-project/commit/f93182a887889828fc6c963174afd7d7b3625e5a DIFF: https://github.com/llvm/llvm-project/commit/f93182a887889828fc6c963174afd7d7b3625e5a.diff LOG:

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

aidengrossman updated this revision to Diff 448477. aidengrossman added a comment. Rebased against main and adjusted unit tests to check directly for the cc1 flag in CmdArgs which is directly consumed by the bitcode writer while creating the .llvmcmd section. Also changed the flags to better

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, mstorsjo, compnerd, beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[libunwind] 520d29f - Update references to mailing lists that have moved to Discourse.

Author: tlattner Date: 2022-07-28T16:54:58-07:00 New Revision: 520d29f38108e60bff3f10ffec9443745e3217c5 URL: https://github.com/llvm/llvm-project/commit/520d29f38108e60bff3f10ffec9443745e3217c5 DIFF: https://github.com/llvm/llvm-project/commit/520d29f38108e60bff3f10ffec9443745e3217c5.diff

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 added a comment. I tested this in my distro build setup, and reread the LLVM source to make sure the list was as I expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130553/new/ https://reviews.llvm.org/D130553

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc56a5022c94: [clang][lld][cmake] Simplify header dirs (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cc56a50 - [clang][lld][cmake] Simplify header dirs

Author: John Ericson Date: 2022-07-28T19:36:40-04:00 New Revision: cc56a5022c94710d8393f1505f925494f7d2cc1c URL: https://github.com/llvm/llvm-project/commit/cc56a5022c94710d8393f1505f925494f7d2cc1c DIFF: https://github.com/llvm/llvm-project/commit/cc56a5022c94710d8393f1505f925494f7d2cc1c.diff

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 448473. ckissane added a comment. - fix usage of CompressionAlgorithmFromId Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 448469. ckissane added a comment. - make compression singletons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:100 set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) - set(LLVM_LIBRARY_OUTPUT_INTDIR

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448459. Ericson2314 added a comment. Rebase so libcxx and friends are hopefully fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files:

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448458. Ericson2314 added a comment. `WARNING` -> `DEPRECATION` in `message` call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files:

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3684022 , @joaomoreira wrote: > Some minor suggestions/not so relevant: > > - Change the name of CFIType to CFIHash, as it is probably more descriptive. My thinking here was that Type is more generic than a

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3963 +TEST(TransferTest, ContextSensitiveSetBothTrueAndFalse) { + std::string Code = R"( samestep wrote: > ymandel wrote: > > Are there more scenarios testable

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

This revision was automatically updated to reflect the committed changes. Closed by commit rG4977fd2192fc: [clang-format] Missing space between trailing return type auto and left brace (authored by denis-fatkulin, committed by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 4977fd2 - [clang-format] Missing space between trailing return type 'auto' and left brace

Author: Denis Fatkulin Date: 2022-07-29T00:30:22+03:00 New Revision: 4977fd2192fc13e17ea162da15ddbe17cd623757 URL: https://github.com/llvm/llvm-project/commit/4977fd2192fc13e17ea162da15ddbe17cd623757 DIFF:

[PATCH] D130709: MSVC compatibility mode: fix error on unqualified templated base class initialization in case of partial specialization

rnk added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4316 + for (auto const : ClassDecl->bases()) { +QualType BT = cast(Base.getType())->getNamedType(); +const auto *BaseTemplate = dyn_cast(BT); Is this cast

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

samestep updated this revision to Diff 448438. samestep added a comment. Address some of Yitzie's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130726/new/ https://reviews.llvm.org/D130726 Files:

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:227 + +const VarDecl *Param = *ParamIt; +auto = Env.createStorageLocation(*Param); ymandel wrote: > maybe mention in the patch description that it also

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 448435. python3kgae marked 2 inline comments as done. python3kgae added a comment. Remove useless comment. Use llvm::Optional. Use real type instead of auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 added a comment. @sebastian-ne Thanks. Your commit 100% makes it better than it was (straight typo on my part), so I cherry-picked it to `release/15.x`: 2647f7274782e4a529d7c3a9920de86ddfe72324 @sylvestre.ledru

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

jansvoboda11 added a comment. Thanks for adding the tests. They are failing in CI though, and I don't think they're entirely correct. My understanding is that the goal is to make sure Clang doesn't drop the `-cc1` flag when embedding command-lines into object files. During normal compilation,

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

ymandel added a comment. Looks great! Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:227 + +const VarDecl *Param = *ParamIt; +auto = Env.createStorageLocation(*Param); maybe mention in the patch description that it also improves

[PATCH] D130416: [Clang] Add support for Unicode identifiers (UAX31) in C2x mode.

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1490-1492 static const llvm::sys::UnicodeCharSet XIDStartChars(XIDStartRanges); // '_' doesn't have the XID_Start property but is allowed in C++. return C == '_' || XIDStartChars.contains(C);

[PATCH] D130593: [clang][dataflow] Separate context by frame

samestep added a comment. Here is the new patch: D130726 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130593/new/ https://reviews.llvm.org/D130593 ___ cfe-commits

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 448414. python3kgae marked an inline comment as done. python3kgae added a comment. Add test for nested cbuffer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://reviews.llvm.org/D130131

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

beanz added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:46 +0, // ptr64 +// HLSL address space values for this map are dummy and they can't be used +0, // hlsl_cbuffer I don’t think you need this comment. Most of those adds space

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

This revision was automatically updated to reflect the committed changes. Closed by commit rG028717014002: [clang][deps] Include canonical invocation in ContextHash (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129884/new/

[clang] 0287170 - [clang][deps] Include canonical invocation in ContextHash

Author: Ben Langmuir Date: 2022-07-28T12:24:06-07:00 New Revision: 02871701400253a49de502a5fef770f92772f6bc URL: https://github.com/llvm/llvm-project/commit/02871701400253a49de502a5fef770f92772f6bc DIFF: https://github.com/llvm/llvm-project/commit/02871701400253a49de502a5fef770f92772f6bc.diff

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:142 + if (!Inner) { +DiagnosticsEngine = CGM.getDiags(); +unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error,

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130224/new/ https://reviews.llvm.org/D130224 ___ cfe-commits mailing

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:142 + if (!Inner) { +DiagnosticsEngine = CGM.getDiags(); +unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error, python3kgae wrote: > python3kgae wrote:

[PATCH] D130416: [Clang] Add support for Unicode identifiers (UAX31) in C2x mode.

tahonermann added a comment. Apologies for the much delayed review (I know this already landed). I added a comment, but I don't know if there is actually an issue to be fixed. This looks good to me otherwise. Comment at: clang/lib/Lex/Lexer.cpp:1490-1492 static const

[PATCH] D130017: [HLSL] Add RWBuffer default constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66eabeb65dc9: [HLSL] Add RWBuffer default constructor (authored by beanz). Changed prior to commit:

[clang] 66eabeb - [HLSL] Add RWBuffer default constructor

Author: Chris Bieneman Date: 2022-07-28T14:07:40-05:00 New Revision: 66eabeb65dc9dc53fa791e444fa228a406bd304e URL: https://github.com/llvm/llvm-project/commit/66eabeb65dc9dc53fa791e444fa228a406bd304e DIFF:

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. All changes from my end are in. Please review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mailing list

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. @jdoerfert With this patch, additional remarks are being generated. Please check whether the new OMP121 remarks in the following tests are OK. Clang :: OpenMP/remarks_parallel_in_multiple_target_state_machines.c Clang ::

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:142 + if (!Inner) { +DiagnosticsEngine = CGM.getDiags(); +unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error,

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. Rebased on top of a recent commit. Both check-clang and check-openmp (on amdgpu) pass. Testing Time: 30.73s Skipped : 4 Unsupported : 1480 Passed : 29554 Expectedly Failed:27 [100%] Built target check-clang On amdgpu:

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 448407. python3kgae added a comment. Add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://reviews.llvm.org/D130131 Files: clang/include/clang/Basic/AddressSpaces.h

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:103 if (Value *MergedVal = MergedEnv.createValue(Type)) if (Model.merge(Type, *Val1, Env1, *Val2, Env2, *MergedVal, MergedEnv)) return MergedVal;

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

samestep updated this revision to Diff 448405. samestep added a comment. Add FIXME about passing `TookSecondBranch` to `merge` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130270/new/ https://reviews.llvm.org/D130270 Files:

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak updated this revision to Diff 448404. dhruvachak added a comment. Regenerated clang tests, make check-clang passes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files:

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 448403. python3kgae added a comment. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, kerbowa, jvesely, jholewinski. Take care alignment when layout CBuffer. Add hlsl_cbuffer/tbuffer to clang::LangAS. Change CGHLSLRuntime::CBuffer to

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

owenpan added reviewers: owenpan, curdeius, HazardyKnusperkeks, MyDeveloperDay, sridhar_gopinath. owenpan added a comment. Can you open an issue at https://github.com/llvm/llvm-project/issues? See https://github.com/llvm/llvm-project/issues/56736 for an example. Repository: rG LLVM Github

[PATCH] D130516: [llvm] compression classes

leonardchan added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:193-194 } -if (llvm::compression::zlib::isAvailable()) { +llvm::compression::CompressionAlgorithm *CompressionScheme = +new

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added inline comments. Comment at: clang/test/SemaCXX/enum-scoped.cpp:330 namespace PR35586 { - enum C { R, G, B }; + enum C { R=-1, G, B }; enum B { F = (enum C) -1, T}; // this should compile cleanly, it used to assert. shafik wrote: >

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

denis-fatkulin updated this revision to Diff 448396. denis-fatkulin added a comment. Conflict with 'main' branch was solved CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130417/new/ https://reviews.llvm.org/D130417 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik added inline comments. Comment at: clang/test/Analysis/cfg.cpp:227 +enum MyEnum : int { A, B, C }; static const enum MyEnum D = (enum MyEnum) 32; This is undefined behavior unless the enum has a fixed type, using `: int` above does that.

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik updated this revision to Diff 448390. shafik added a comment. - dyn_cast was not seeing through type sugar switch to `isEnumeralType()` - `APInt` requires the bit widths to be the same when comparing and so switched to obtaining the value from `Result` from just `getInt()` to

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

akyrtzi added a comment. In D130710#3685509 , @v.g.vassilev wrote: > In D130710#3685470 , @akyrtzi wrote: > >> @v.g.vassilev is the functionality of "write `ORIGINAL_PCH_DIR` and resolve >> headers relative to

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:61 + +GlobalVariable *replaceCBuffer(CGHLSLRuntime::CBuffer ) { + const unsigned CBufferAddressSpace = 4; Anastasia wrote: > I don't think I understand the intent of this

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

v.g.vassilev added a comment. In D130710#3685470 , @akyrtzi wrote: > @v.g.vassilev is the functionality of "write `ORIGINAL_PCH_DIR` and resolve > headers relative to it if PCH file and headers moved together" used by > `Cling`? We currently use

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

akyrtzi added a subscriber: rmaz. akyrtzi added a comment. Also pinging @rmaz who made a related change , is this used by Facebook? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130710/new/

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5b21680d122: [AMDGPU] Add amdgcn_sched_group_barrier builtin (authored by kerbowa). Changed prior to commit:

[clang] f5b2168 - [AMDGPU] Add amdgcn_sched_group_barrier builtin

Author: Austin Kerbow Date: 2022-07-28T10:43:14-07:00 New Revision: f5b21680d1221d7acaa1b174d0b86fa907c71eb8 URL: https://github.com/llvm/llvm-project/commit/f5b21680d1221d7acaa1b174d0b86fa907c71eb8 DIFF: https://github.com/llvm/llvm-project/commit/f5b21680d1221d7acaa1b174d0b86fa907c71eb8.diff

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

akyrtzi added a subscriber: v.g.vassilev. akyrtzi added a comment. @v.g.vassilev is the functionality of "write `ORIGINAL_PCH_DIR` and resolve headers relative to it if PCH file and headers moved together" used by `Cling`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c619d4f - [clang-repl] Support destructors of global objects.

Author: Sunho Kim Date: 2022-07-29T02:38:40+09:00 New Revision: c619d4f840dcba54751ff8c5aaafce0f173a4ad5 URL: https://github.com/llvm/llvm-project/commit/c619d4f840dcba54751ff8c5aaafce0f173a4ad5 DIFF: https://github.com/llvm/llvm-project/commit/c619d4f840dcba54751ff8c5aaafce0f173a4ad5.diff

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

benlangmuir added a comment. Is the functionality provided by `ORIGINAL_PCH_DIR` still useful for making it possible to move a PCH and its referenced headers? It's not completely clear to me when this feature is used in practice. It would be nice to remove it or change the default behaviour

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp added a comment. Great feedback, thanks! I had some ideas on how to go around the issues, looking forward to your thoughts. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp:103-104 +struct WithAlias {

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/Sparc.cpp:139 + if (Triple.getArch() == llvm::Triple::sparc && + (Triple.isOSSolaris() || Distro(D.getVFS(), Triple).IsDebian())) return "v9"; glaubitz wrote: > Can we do it

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

benlangmuir updated this revision to Diff 448370. benlangmuir added a comment. - Added comments to tests - Added a missing test that I accidentally deleted - Rebased on latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129884/new/

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

ldionne accepted this revision as: libc++, libc++abi, ldionne. ldionne added a comment. I'm happy with this from the libc++/libc++abi side of things. You can ignore the failing CI job, it's been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 added inline comments. Comment at: clang/test/CodeGen/attr-maybeundef.c:48 + +// CHECK: declare void @VariadicFunction(i32 noundef, ...) + aaron.ballman wrote: > It looks like dso_local is missing here on Windows and expected to be missing > on Linux? Not

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 updated this revision to Diff 448361. skc7 added a comment. Fix windows tests failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130224/new/ https://reviews.llvm.org/D130224 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1334 + bool IsWide) const { // void *memmove(void *dst, const void *src, size_t n); // The return value is the address of the destination

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

balazske added a comment. It is still not perfect, analysis of qtbase is not better than before and some of the unreachable assertions were encountered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130705/new/ https://reviews.llvm.org/D130705

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

balazske updated this revision to Diff 448356. balazske added a comment. Change of bool argument to enum, added inline function to get char type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130470/new/ https://reviews.llvm.org/D130470 Files:

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2091-2097 + if (auto *CE = dyn_cast(E)) +if (CE->getCastKind() == CK_NoOp) + E = CE->getSubExpr()->IgnoreParens(); + if (auto *CE = dyn_cast(E)) +if (CE->getCastKind() ==

[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:555 if (BuiltPreamble) { -vlog("Built preamble of size {0} for file {1} version {2} in {3} seconds", +

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. In D129752#3682977 , @aaron.ballman wrote: > Do you think this warrants a release note (or did it close any open issues in > the tracker)? It's probably too technical/minor

  1   2   >