[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. @aaron.ballman, @rsmith, @mizvekov, @shafik, has the mankind any chance to get this reviewed and merged? Btw, FYI, I've investigated the Chromium compilation crash that caused the rollback in 8ba442bc2136

[PATCH] D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb90bb986611: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning (authored by tuliom, committed by qiucf). Repository: rG LLVM

[clang] cb90bb9 - [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning

Author: Tulio Magno Quites Machado Filho Date: 2023-02-14T15:03:58+08:00 New Revision: cb90bb986611bab58dbe05cefb0903e0a07f3cca URL: https://github.com/llvm/llvm-project/commit/cb90bb986611bab58dbe05cefb0903e0a07f3cca DIFF:

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 497206. VincentWu marked 19 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files:

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. > `uint32_t Size; // = sizeof(struct CIndexOptions), used for option versioning` `uint32_t` was introduced in C99. Can/should it be used in //Index.h//? Only built-in `[unsigned] (int|long)` types are currently used in this file. Repository: rG LLVM Github Monorepo

[clang] 9c4f0d8 - [docs] Add document for clang-scan-deps -format=p1689

Author: Chuanqi Xu Date: 2023-02-14T14:00:12+08:00 New Revision: 9c4f0d83f64ea64d662bb0c670bb5ca5d21a63fe URL: https://github.com/llvm/llvm-project/commit/9c4f0d83f64ea64d662bb0c670bb5ca5d21a63fe DIFF: https://github.com/llvm/llvm-project/commit/9c4f0d83f64ea64d662bb0c670bb5ca5d21a63fe.diff

[PATCH] D143971: [clang-tidy] Flag code with both string constructor arguments implicitly casted

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/string-constructor.cpp:40 + + std::string swapped('x', 4); + // CHECK-MESSAGES: [[@LINE-1]]:15: warning: string constructor arguments are probably swapped; expecting string(count,

[PATCH] D143971: [clang-tidy] Flag code with both string constructor arguments implicitly casted

ccotter updated this revision to Diff 497189. ccotter added a comment. - Add more cases to swapped params Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files:

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added a comment. Corresponding client-side support is implemented for vscode in the latest version of https://github.com/clangd/vscode-clangd/pull/193. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143974/new/

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge created this revision. nridge added reviewers: sammccall, kadircet, hokein. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

yaxunl added inline comments. Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:90 +#if __OPENCL_C_VERSION__ <= CL_VERSION_1_2 typedef struct FooImage2D // expected-note{{within field of type 'FooImage2D' declared here}} Ayal wrote: > yaxunl

[PATCH] D143971: [clang-tidy] Flag code with both string constructor arguments implicitly casted

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/string-constructor.cpp:58 + // CHECK-MESSAGES: [[@LINE-1]]:15: warning: string constructor arguments might be incorrect; + std::string s7(kText[1], 10); + // CHECK-MESSAGES:

[PATCH] D143971: Flag code with both string constructor arguments implicitly casted

ccotter created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Calls to the fill constructor

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG235e90c1d760: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis (authored by eopXD). Repository: rG LLVM Github Monorepo

[clang] 235e90c - [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

Author: eopXD Date: 2023-02-13T18:07:00-08:00 New Revision: 235e90c1d760ea38f2af6bf4de2cc9355b89d24c URL: https://github.com/llvm/llvm-project/commit/235e90c1d760ea38f2af6bf4de2cc9355b89d24c DIFF: https://github.com/llvm/llvm-project/commit/235e90c1d760ea38f2af6bf4de2cc9355b89d24c.diff LOG:

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. Personally happy with the concept then, seems consistent and overall helpful, just some nits Comment at: llvm/lib/Target/RISCV/RISCVFeatures.td:83-86 +

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. In D143953#4124649 , @jrtc27 wrote: > In D143953#4124636 , @reames wrote: > >> @jrtc27 Not sure if this changes your take, but I realized the variant being >> introduced is maybe much

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

jrtc27 added a comment. In D143953#4124636 , @reames wrote: > @jrtc27 Not sure if this changes your take, but I realized the variant being > introduced is maybe much less interesting than I'd first thought. We > generally make no effort to make sure

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. @jrtc27 Not sure if this changes your take, but I realized the variant being introduced is maybe much less interesting than I'd first thought. We generally make no effort to make sure an extension was defined in the spec version corresponding to our base revision.

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter updated this revision to Diff 497146. ccotter added a comment. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 Files: clang/include/clang/AST/IgnoreExpr.h

[PATCH] D140123: [TLS] Clamp the alignment of TLS global variables if required by the target

efriedma added a comment. There are subsections for individual flags. Maybe we could mess with the markup to make that a bit more clear... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140123/new/ https://reviews.llvm.org/D140123

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

jrtc27 added a comment. I'm fine with this approach but I think they should be filtered out of the ELF attributes, maybe also preprocessor macros? That is, treating them as a redundant no-op in the driver rather than like a true extension. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

aprantl added a comment. In D143921#4123218 , @fdeazeve wrote: > Any testing suggestions here? I can use what we have on GH (cpp -> codegen > test), but I'm not sure if there's a finer grained test we could use. I was thinking of a very small IR test

[PATCH] D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets '/winsysroot' flag when building

[PATCH] D140123: [TLS] Clamp the alignment of TLS global variables if required by the target

wolfgangp added a comment. In D140123#4124512 , @efriedma wrote: >> no separate section for module flags > > https://llvm.org/docs/LangRef.html#module-flags-metadata ? That seems to be the description of the metadata for module flags, not the

[PATCH] D143794: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bc9dc26bc9b: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143794/new/

[clang] 7bc9dc2 - [Fuchsia] Add FUCHSIA_ENABLE_LLDB option.

Author: Daniel Thornburgh Date: 2023-02-13T15:49:45-08:00 New Revision: 7bc9dc26bc9beb159547f7160d852543bc52 URL: https://github.com/llvm/llvm-project/commit/7bc9dc26bc9beb159547f7160d852543bc52 DIFF:

[PATCH] D140123: [TLS] Clamp the alignment of TLS global variables if required by the target

efriedma added a comment. > no separate section for module flags https://llvm.org/docs/LangRef.html#module-flags-metadata ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140123/new/ https://reviews.llvm.org/D140123

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. Realistically, I'm not sure if this change is all that valuable aside from abiding by the CppCoreGuidelines from the readability and consistency standpoint. The only impact this change would have that I can think of is allowing an object with an `&&` (or other

[PATCH] D140123: [TLS] Clamp the alignment of TLS global variables if required by the target

wolfgangp added a comment. In D140123#4123625 , @efriedma wrote: > In D140123#4113536 , @efriedma > wrote: > >> Missing LangRef change? > > Ping? Added a LangRef entry with 776b7499ea813c06b

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal added inline comments. Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:90 +#if __OPENCL_C_VERSION__ <= CL_VERSION_1_2 typedef struct FooImage2D // expected-note{{within field of type 'FooImage2D' declared here}} yaxunl wrote: > we should

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal updated this revision to Diff 497128. Ayal added a comment. Updated version merges the `if`'s and checks tests for both 1.2 and 2.0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143849/new/ https://reviews.llvm.org/D143849 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D143533: [clang] Allow gnu::aligned attribute to work with templated type alias declarations

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2154 + if (uint64_t Result = SubstTypeVisitor(Ctx, SubType->getReplacementType()) +.TryEval(Attr->getAlignmentExpr())) { +TI.Align = Result; I don't think

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

dblaikie added a comment. > I think /maybe/ we had some design principle that DWARF features wouldn't be > solely controlled by debugger tuning, the tuning only indicates defaults but > tehy can be controlled by flags? Not sure if I'm remembering that quite > right, though - maybe @probinson

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

dblaikie added a comment. any chance this is testable, maybe in a unit test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-commits mailing list

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames created this revision. reames added reviewers: asb, frasercrmck, kito-cheng, jrtc27, craig.topper. Herald added subscribers: luke, VincentWu, vkmr, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:174 const PragmaIncludes *PI) { + if (auto Headers = specialStandardSymbols(S); !Headers.empty()) +return Headers;

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

hokein updated this revision to Diff 497110. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143906/new/ https://reviews.llvm.org/D143906 Files:

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:326 +unsigned Val; +bool IsRV64; + }; Is this IsRV64 field used? Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:331 +

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 497097. jacobly added a comment. Fix bad diff update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/docs/ReleaseNotes.rst

[PATCH] D143806: [Clang][Test] Add llvm-lto, llvm-lto2 and llvm-profdata to the tool substitutions list

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems a bit unfortunate that clang tests are using these tools, but fair enough - they clearly are, so suitable to include them here, I guess. Repository: rG LLVM Github Monorepo

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

dblaikie added a comment. In D143803#412 , @0xdc03 wrote: > Note that as it stands currently, this patch cannot be committed because the > test `clang/test/SemaCXX/externc-ifunc-resolver.cpp` fails to run. The > contents of the test are as follows:

[libclc] f11ab83 - libclc: remove sqrt/rsqrt from clspv SOURCES

Author: Kévin Petit Date: 2023-02-13T21:27:40Z New Revision: f11ab8353f972647f276b07c24d1308859fbde0d URL: https://github.com/llvm/llvm-project/commit/f11ab8353f972647f276b07c24d1308859fbde0d DIFF: https://github.com/llvm/llvm-project/commit/f11ab8353f972647f276b07c24d1308859fbde0d.diff LOG:

[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

Febbe added a comment. @HazardyKnusperkeks thank you for the review, I would add another option, but I don't know a good name. I would propose a `boolean` `IncludeDeduplicateInAllBlocks` which defaults to zero. First an `Include`, to keep include-sorting related options together in the

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe added a comment. I've added some elaborations and justifications for the criticized changes. Comment at: clang/lib/Format/Format.cpp:1379 LLVMStyle.IncludeStyle.IncludeCategories = { - {"^\"(llvm|llvm-c|clang|clang-c)/", 2, 0, false}, -

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/IR/Verifier.cpp:1404 +CheckDI(!N.getRawDeclaration(), +"subprogram declaration must not have a declaration field"); }

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

efriedma added a comment. If the parameter attributes are relevant, should we change the CHECK lines in the tests to check for them? At least for some of the tests. Once we fix these tests to enable opaque pointer types, you won't actually be checking for anything. Repository: rG LLVM

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

rjmccall added a comment. In D143919#4123712 , @sepavloff wrote: > In D143919#4123616 , @efriedma > wrote: > >> We have code somewhere to generically copy attributes from function >> templates to

[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. I can see that this is maybe useful, but that have to be behind a new option, which is turned off by default. And a big no to changing the existing tests,

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:1379 LLVMStyle.IncludeStyle.IncludeCategories = { - {"^\"(llvm|llvm-c|clang|clang-c)/",

[PATCH] D143794: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143794/new/ https://reviews.llvm.org/D143794

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `(DRE.data() + any)`

ziqingluo-90 updated this revision to Diff 497057. ziqingluo-90 added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143128/new/ https://reviews.llvm.org/D143128 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D143781: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f5d81585aa9: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64 (authored by alexander-shaposhnikov). Changed prior to commit:

[clang] 8f5d815 - [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64

Author: Alexander Shaposhnikov Date: 2023-02-13T19:26:11Z New Revision: 8f5d81585aa9261342d5304e460925916ea1f851 URL: https://github.com/llvm/llvm-project/commit/8f5d81585aa9261342d5304e460925916ea1f851 DIFF:

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 497052. jacobly added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/docs/ReleaseNotes.rst

[PATCH] D143680: [WIP][-Wunsafe-buffer-usage] Improve fix-its for local variable declarations with null pointer initializers

ziqingluo-90 updated this revision to Diff 497051. ziqingluo-90 added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143680/new/ https://reviews.llvm.org/D143680 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added a comment. In D143919#4123616 , @efriedma wrote: > We have code somewhere to generically copy attributes from function templates > to instantiations, right? Why do we need to explicitly copy StrictFPAttr in > particular, separate from

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

aaron.ballman added a reviewer: efriedma. aaron.ballman added a comment. Please be sure to add release notes to clang/docs/ReleaseNotes.rst Things look reasonable to me, but it'd be nice if someone with more Windows ABI experience could take a look as well. Comment at:

[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Personally I don't think such a small change is worth mentioning in the Release Notes, but maybe other reviewers think differently, let's give them a

[PATCH] D143794: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option.

mysterymath updated this revision to Diff 497048. mysterymath added a comment. _FUCHSIA_DISTRIBUTION_COMPONENTS should not be a CACHE variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143794/new/ https://reviews.llvm.org/D143794 Files:

[PATCH] D142316: [clang] Add test for CWG2396

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51a07fc24cb9: [clang] Add test for CWG2396 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 51a07fc - [clang] Add test for CWG2396

Author: Vlad Serebrennikov Date: 2023-02-13T21:53:00+03:00 New Revision: 51a07fc24cb909011e0b16793800aab4b93031ed URL: https://github.com/llvm/llvm-project/commit/51a07fc24cb909011e0b16793800aab4b93031ed DIFF:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 497045. TIFitis added a comment. Fixing build errors. Added mlir/lib/Target/LLVMIR/Dialect/Utils.cpp, made it part of the MLIRTargetLLVMIRExport lib. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D140123: [TLS] Clamp the alignment of TLS global variables if required by the target

efriedma added a comment. In D140123#4113536 , @efriedma wrote: > Missing LangRef change? Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140123/new/ https://reviews.llvm.org/D140123

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma added a comment. We have code somewhere to generically copy attributes from function templates to instantiations, right? Why do we need to explicitly copy StrictFPAttr in particular, separate from that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142316: [clang] Add test for CWG2396

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142316/new/ https://reviews.llvm.org/D142316

[PATCH] D143781: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64

alexander-shaposhnikov added a comment. sure, will do! thanks for the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143781/new/ https://reviews.llvm.org/D143781 ___ cfe-commits mailing list

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4123468 , @vedgy wrote: > In D143418#4122821 , @aaron.ballman > wrote: > >>> How about including existing options, which //should// be set in >>> constructor, in the

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

hoy added inline comments. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1169-1171 + // On PowerPC and ARM/Thumb, if the address of a branch is the same as + // the target, it means that it's a function call. Do not mark the label + // for this case.

[PATCH] D143260: [clangd] Add semantic token for labels

nridge added a comment. Another potential consideration here is the GNU "labels as values " language extension, which clang seems to support, and which allows referencing a `LabelDecl` from a context other than a goto-statement (and

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

royjacobson added inline comments. Comment at: clang/lib/AST/Type.cpp:2495 + // FIXME: We should merge this definition of triviality into + // CXXRecordDecl::isTrivial. Currently it computes the wrong thing. + return ClassDecl->hasTrivialDefaultConstructor() &&

[PATCH] D143260: [clangd] Add semantic token for labels

nridge added a comment. FWIW, I agree that switch labels and goto labels are conceptually quite different: the thing before a switch label is an expression, and if it's an identifier it references an already-declared entity with its own kind (e.g. enumerator), whereas a goto label basically

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 497024. madanial added a comment. Addressing the review comments relating to the test case. Thanks for the catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files:

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. In D143418#4122821 , @aaron.ballman wrote: >> How about including existing options, which //should// be set in >> constructor, in the initial struct version and deprecating the corresponding >> setters? > > I think that makes a

[clang] 756395f - [clang] fix DR status in cxx_status.html

Author: Corentin Jabot Date: 2023-02-13T09:30:57-08:00 New Revision: 756395f61b90e30c9087b5efa8b4809ab03aff6e URL: https://github.com/llvm/llvm-project/commit/756395f61b90e30c9087b5efa8b4809ab03aff6e DIFF:

[PATCH] D141698: doc: Rewrite opening paragraph of CFI Design Doc

sunshaoce added a comment. I tend to keep it as it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141698/new/ https://reviews.llvm.org/D141698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141808: [Driver] Add --vfsoverlay flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5beebc98bb: [Driver] Add --vfsoverlay flag (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed

[clang] df5beeb - [Driver] Add --vfsoverlay flag

Author: Alex Brachet Date: 2023-02-13T17:25:45Z New Revision: df5beebc98bbe76312e3a416d5fbc563c037923c URL: https://github.com/llvm/llvm-project/commit/df5beebc98bbe76312e3a416d5fbc563c037923c DIFF: https://github.com/llvm/llvm-project/commit/df5beebc98bbe76312e3a416d5fbc563c037923c.diff LOG:

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6259eca16f6: [Clang] Export CanPassInRegisters as a type trait (authored by royjacobson). Changed prior to commit:

[clang] b6259ec - [Clang] Export CanPassInRegisters as a type trait

Author: Roy Jacobson Date: 2023-02-13T19:16:23+02:00 New Revision: b6259eca16f6c923d87a1ca1d424931e37d6871a URL: https://github.com/llvm/llvm-project/commit/b6259eca16f6c923d87a1ca1d424931e37d6871a DIFF: https://github.com/llvm/llvm-project/commit/b6259eca16f6c923d87a1ca1d424931e37d6871a.diff

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

shafik added a comment. In D143891#4122731 , @aaron.ballman wrote: > In D143891#4122668 , @royjacobson > wrote: > >> In D143891#4122660 , >> @aaron.ballman wrote: >>

[PATCH] D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4021ed3d79d: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem` (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d4021ed - [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`

Author: Younan Zhang Date: 2023-02-14T01:07:39+08:00 New Revision: d4021ed3d79d8823317d894b55f4e6a30cfc3614 URL: https://github.com/llvm/llvm-project/commit/d4021ed3d79d8823317d894b55f4e6a30cfc3614 DIFF: https://github.com/llvm/llvm-project/commit/d4021ed3d79d8823317d894b55f4e6a30cfc3614.diff

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a subscriber: aaron.ballman. aaronmondal added a comment. Ok so I went over https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations#testing-for-the-presence-of-a-header-__has_include (thanks, @aaron.ballman ) and through the commit history for the

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 497011. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

reames added a comment. JFYI, I have a change out which just documents current status while we wait for a resolution. https://reviews.llvm.org/D143924 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich marked 4 inline comments as done. philipp.tomsich added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:315 + if (Subtarget.hasVendorXTHeadBb()) { +setOperationAction({ISD::CTLZ}, XLenVT, Legal); + inclyc wrote: > It

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

inclyc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:320 +if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } inclyc wrote: > And this one Ah, this is my fault :(.

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

inclyc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:315 + if (Subtarget.hasVendorXTHeadBb()) { +setOperationAction({ISD::CTLZ}, XLenVT, Legal); + It looks like this line of code will cause compilation warning. ```

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve added a comment. Any testing suggestions here? I can use what we have on GH (cpp -> codegen test), but I'm not sure if there's a finer grained test we could use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 2 inline comments as done. pmatos added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7269 + } + Attrs[NewAttrKind] = true; + aaron.ballman wrote: > aaron.ballman wrote: > > This seems like it's not used. > Still wondering about this

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 497004. pmatos added a comment. Remove unnecessary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/DeclBase.h

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 497002. pmatos marked 2 inline comments as done. pmatos added a comment. Further refinement of the patch with more diagnostics tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 4 inline comments as done. pmatos added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6696 +bool Sema::BuiltinWasmRefNullFunc(CallExpr *TheCall) { + if (TheCall->getNumArgs() != 0) +return true; erichkeane wrote: > Does this

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve created this revision. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: All. fdeazeve requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. The

[PATCH] D143920: [clang][dataflow] Change `transfer` API to take a reference.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The provided `CFGElement` is never null,

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson updated this revision to Diff 496998. royjacobson added a comment. Address CR comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143851/new/ https://reviews.llvm.org/D143851 Files:

[PATCH] D143763: [Clang] Add clangMinimumVersion to multilib.yaml

peter.smith added a comment. No objections to MaskRay's suggestion to merge with an earlier patch. I've made some suggestions to make the error messages be a bit more specific about what is wrong. Comment at: clang/lib/Driver/Multilib.cpp:185 +if

  1   2   >