[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Alright, sounds good, thanks for the clarification! Then I misunderstood the change in the tests and indeed it belonged together in this patch, sorry for the confusion. I have

[PATCH] D144594: [clang-tidy] Fix bugprone-copy-constructor-init documentation

PiotrZSL updated this revision to Diff 499733. PiotrZSL added a comment. Update doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144594/new/ https://reviews.llvm.org/D144594 Files:

[PATCH] D144594: [clang-tidy] Fix bugprone-copy-constructor-init documentation

PiotrZSL updated this revision to Diff 499732. PiotrZSL added a comment. Update doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144594/new/ https://reviews.llvm.org/D144594 Files:

[clang] 6ed67cc - [Coroutines] Remove -fcoroutines-ts

Author: Chuanqi Xu Date: 2023-02-23T14:40:58+08:00 New Revision: 6ed67ccba7e4699e9e42302f2f9b7653444258ba URL: https://github.com/llvm/llvm-project/commit/6ed67ccba7e4699e9e42302f2f9b7653444258ba DIFF: https://github.com/llvm/llvm-project/commit/6ed67ccba7e4699e9e42302f2f9b7653444258ba.diff

[PATCH] D144616: Skip generating this[:1] map info for non-member variable.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added a project: clang. This fix runtime

[clang-tools-extra] 3fac87b - [NFC] Remove the use of '-fcoroutines-ts' in a test of clang-tidy

Author: Chuanqi Xu Date: 2023-02-23T14:16:00+08:00 New Revision: 3fac87b67749ece892fa6e797236eddc22c69ff6 URL: https://github.com/llvm/llvm-project/commit/3fac87b67749ece892fa6e797236eddc22c69ff6 DIFF: https://github.com/llvm/llvm-project/commit/3fac87b67749ece892fa6e797236eddc22c69ff6.diff

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

animeshk-amd added a comment. In D144544#4144563 , @jdoerfert wrote: > I guess this is fine. We should try to run V tests, this is really just > checking if we generate (some) code. Thanks for accepting. Right. By running V tests, do you mean to

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG265ea1c7459d: [OpenMP] Improve LIT tests on composite target constructs (authored by animeshk-amd). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144613: [RISCV] Properly diagnose mixing RVV scalable vectors with GNU vectors.

craig.topper created this revision. craig.topper added reviewers: kito-cheng, reames, frasercrmck, eopXD, rogfer01, c-rhodes. Herald added subscribers: luke, VincentWu, ctetreau, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas

denizevrenci added a comment. @NoQ I don't have commit access. Should I leave landing the diff to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144352/new/ https://reviews.llvm.org/D144352 ___

[PATCH] D144611: [PowerPC] Adding test coverage for vector compatibility warning

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is to test D143210 patch to have the

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 ___

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:110 + const auto *MoveCall = Result.Nodes.getNodeAs("move-call"); + if (!MoveCall) { +

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked 4 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:64-74 + hasAncestor(compoundStmt(hasParent(lambdaExpr( +

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 499681. ccotter marked 4 inline comments as done. ccotter added a comment. - More matcher simplification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[PATCH] D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Makes sense to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144352/new/ https://reviews.llvm.org/D144352

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a comment. @pcc does this lgty? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144447: [Clang] Teach buildFMulAdd to peek through fneg to find fmul.

lhames added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3738 - assert(!(negMul && negAdd) && "Only one of negMul and negAdd should be set."); - Value *MulOp0 = MulOp->getOperand(0); craig.topper wrote: > kpn wrote: > > If I'm reading

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When using compiler caching program

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

MaskRay accepted this revision. MaskRay added a comment. > `[llvm] ` `[SCEV]` is a more common tag for ScalarEvolution patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a comment. In D144035#4145662 , @MaskRay wrote: >> Full context at https://github.com/llvm/llvm-project/issues/60668. > > Best to leave a simplified description in the summary so that a reader > doesn't have to go to the external link

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

leonardchan updated this revision to Diff 499668. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 Files: llvm/lib/Analysis/ScalarEvolution.cpp

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. @JonChesterfield I don't think we should be putting any Fedora specific logic into clang's build system or the driver, if that's what you are suggesting. Fedora can always patch the compiler or install a config file to change the default behavior, even though this is

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

MatzeB added a comment. I need this change to fix compilation in our environment which uses `grpc-1.42.0`... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144599/new/ https://reviews.llvm.org/D144599

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

MatzeB created this revision. MatzeB added reviewers: kbobyrev, kuganv. Herald added subscribers: modimo, wenlei, kadircet, arphaman, mcrosier. Herald added a project: All. MatzeB requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

JonChesterfield added a comment. If fedora has a specific set of paths it rejects in DT_RUNPATH - and libomptarget is on one of those by default - and user executables find it there - and we can detect we're building on fedora then we can disable the rpath for fedora installs to system root,

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath marked an inline comment as done. mysterymath added inline comments. Comment at: clang/lib/Headers/limits.h:55 #define UCHAR_MAX (__SCHAR_MAX__*2 +1) -#define USHRT_MAX (__SHRT_MAX__ *2 +1) +#define USHRT_MAX (__SHRT_MAX__ * 2U + 1U) #define UINT_MAX

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 499659. mysterymath added a comment. Corrected type of USHRT_MAX. Added tests and release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://reviews.llvm.org/D144218 Files:

[PATCH] D144595: [WIP] Experimenting building Windows runtimes when cross compiling LLVM toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: kristof.beyls. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is a working in progress

[PATCH] D144594: [clang-tidy] Fix bugprone-copy-constructor-init documentation

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/copy-constructor-init.rst:37 + +In summary check detects cases where the copy constructor of a derived class +doesn't properly call or initialize the copy constructor of the base

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL added a comment. PiotrZSL updated this revision to Diff 499306. Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp. PiotrZSL marked

[PATCH] D144594: [clang-tidy] Fix bugprone-copy-constructor-init documentation

PiotrZSL created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Correct example, and add information

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou marked an inline comment as done. zhouyizhou added a comment. Thank you all for your guidance! Now I am starting to learn C2X N2997, this is a fruitful process of learning for me ;-) Cheers Zhouyi Comment at: clang/lib/Sema/SemaDecl.cpp:19571-19573 - // TODO: If

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

jdoerfert added a comment. In D143306#4145603 , @tstellar wrote: > In D143306#4145432 , @MaskRay wrote: > >> This is the point. Specifying a driver option to use >> libc++/libc++abi/libunwind doesn't magically

[PATCH] D144590: Fix shared memory allocation on AMDGPU

nlopes added a comment. Please use poison values as place holders instead of undef values as we're trying to get rid of Undef. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144590/new/ https://reviews.llvm.org/D144590

[PATCH] D144590: Fix shared memory allocation on AMDGPU

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. I think this looks reasonable to me. @jdoerfert WDYT? I'm not sure if you need to fix some clang tests. Let's see if Buildbot is happy. Repository: rG LLVM Github Monorepo

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

PiotrZSL updated this revision to Diff 499643. PiotrZSL added a comment. Removed include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144217/new/ https://reviews.llvm.org/D144217 Files:

[PATCH] D144590: Fix shared memory allocation on AMDGPU

ZwFink added a comment. Full details and reproducer at this GitHub issue: https://github.com/llvm/llvm-project/issues/60345 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144590/new/ https://reviews.llvm.org/D144590

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

PiotrZSL updated this revision to Diff 499642. PiotrZSL added a comment. Review fixes + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144217/new/ https://reviews.llvm.org/D144217 Files:

[PATCH] D144590: Fix shared memory allocation on AMDGPU

ZwFink created this revision. Herald added subscribers: nlopes, kosarev, tpr, dstuttard, yaxunl, kzhuravl. Herald added a project: All. ZwFink requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D144586: [PS4/PS5] Specify no or

probinson added a comment. That's correct, I do see in our SDK. I don't see a need for a release note; we're not actually removing anything that we used to support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144586/new/ https://reviews.llvm.org/D144586

[clang] 437727d - [AST] Add 'break; ' to the last case in two switches. NFC

Author: Craig Topper Date: 2023-02-22T13:42:40-08:00 New Revision: 437727d5865af01cf1c901eff931f5113008831c URL: https://github.com/llvm/llvm-project/commit/437727d5865af01cf1c901eff931f5113008831c DIFF: https://github.com/llvm/llvm-project/commit/437727d5865af01cf1c901eff931f5113008831c.diff

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

MaskRay added a comment. > Full context at https://github.com/llvm/llvm-project/issues/60668. Best to leave a simplified description in the summary so that a reader doesn't have to go to the external link and summarize the discussions themselves. This SCEV function is invoked by `FunctionPass

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

royjacobson added a comment. In D144572#4145614 , @cor3ntin wrote: > @aaron.ballman is the plan to backport that to clang 16? I think it probably > should. > We ought to try to improve the situation for clang 17 cxx_status.html is always updated from

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

MaskRay added a comment. LG Comment at: clang/test/CodeGenCXX/pr60668.cpp:1 +// RUN: %clang --target=aarch64-unknown-linux-gnu -O1 -fvisibility=hidden \ +// RUN: -fsanitize=hwaddress -fsanitize=undefined -std=c++17 -fno-exceptions \ We try avoiding .cc to

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rG000ec50ef511: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases. (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D143891?vs=496884=499635#toc

[clang] 000ec50 - [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

Author: Roy Jacobson Date: 2023-02-22T23:27:09+02:00 New Revision: 000ec50ef511243ec46c249c06d7a82cedf6d538 URL: https://github.com/llvm/llvm-project/commit/000ec50ef511243ec46c249c06d7a82cedf6d538 DIFF: https://github.com/llvm/llvm-project/commit/000ec50ef511243ec46c249c06d7a82cedf6d538.diff

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

cor3ntin added a comment. @aaron.ballman is the plan to backport that to clang 16? I think it probably should. We ought to try to improve the situation for clang 17 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144572/new/

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. In D143306#4145432 , @MaskRay wrote: > This is the point. Specifying a driver option to use > libc++/libc++abi/libunwind doesn't magically change `DT_RUNPATH`. This is > exactly the behavior a user wants for a system Clang. >

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. +1 from me, at least as long as we don't define the feature test macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144572/new/

[PATCH] D144586: [PS4/PS5] Specify no or

aaron.ballman added a comment. Just to double-check, no to threads but yes to atomics? (Checking whether you also need `__STDC_NO_ATOMICS__` or not.) Should this have a release note? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144586/new/ https://reviews.llvm.org/D144586

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

aaron.ballman added a comment. The changes need some test coverage and a release note. Comment at: clang/lib/Headers/limits.h:55 #define UCHAR_MAX (__SCHAR_MAX__*2 +1) -#define USHRT_MAX (__SHRT_MAX__ *2 +1) +#define USHRT_MAX (__SHRT_MAX__ * 2U + 1U) #define UINT_MAX

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/lambda-expressions.cpp:675-676 +StringLiteral(const char ()[N]) +__attribute__((enable_if(__builtin_strlen(array) == 2, + "invalid string literal"))); +};

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

MyDeveloperDay added a comment. maybe we should cherry pick into 16? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144537/new/ https://reviews.llvm.org/D144537 ___ cfe-commits mailing list

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thanks for doing this @rymiel, LGTM.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144537/new/ https://reviews.llvm.org/D144537

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19113 +// parameter appertaining to the same declaration as that attribute. +if(auto* Parm = dyn_cast(Var); Parm && Parm->getDeclContext() == DC) + return true; cor3ntin

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

jhuber6 added a comment. In D143306#4145482 , @jdoerfert wrote: > @jhuber6 Can you look into the last part, creating such a clang.cfg as part > of the build/install process? > > The fact that rpath is always set is a difference but I doubt it's that

[PATCH] D144586: [PS4/PS5] Specify no or

probinson created this revision. probinson added a reviewer: aaron.ballman. Herald added a project: All. probinson requested review of this revision. We've never provided these headers so set the preprocessor toggles to reflect that. https://reviews.llvm.org/D144586 Files:

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

jdoerfert added a comment. In D143306#4145465 , @MaskRay wrote: > In D143306#4144541 , @jdoerfert > wrote: > >> I'm worried this makes use of LLVM on HPC machines even harder. That said, >> I'm open to

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay added a comment. In D143306#4144541 , @jdoerfert wrote: > I'm worried this makes use of LLVM on HPC machines even harder. That said, > I'm open to suggestions and I am not well versed in all the ways we can make > it work. > Our problem is that

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay added a comment. In D143306#4144518 , @JonChesterfield wrote: > Marking this as "no" because as far as I can tell it'll stop anyone running > openmp built from source which constitutes a severe regression and I am > struggling to find

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay added a comment. In D143306#4144396 , @JonChesterfield wrote: > So what is this configuration file? Joseph found a Gentoo blog post > https://blogs.gentoo.org/mgorny/2022/10/07/clang-in-gentoo-now-sets-default-runtimes-via-config-file/ > and I

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau marked an inline comment as done. amurzeau added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation2/.clang-tidy:115 value: On - - key:

[PATCH] D144582: [include-cleaner] Always treat constructor calls as implicit

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Treating constructor calls when the type name isn't explicitly spelled can

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19113 +// parameter appertaining to the same declaration as that attribute. +if(auto* Parm = dyn_cast(Var); Parm && Parm->getDeclContext() == DC) + return true; aaron.ballman

[PATCH] D144579: [include-cleaner] Check macros against stdlib database

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144579

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:284-285 +// However, `const Bar::*` remains the same. +while (Next && Next->isOneOf(tok::identifier,

[clang] 2893d55 - [Serialization] Don't warn when a deserialized category is equivalent to an existing one.

Author: Volodymyr Sapsai Date: 2023-02-22T11:01:40-08:00 New Revision: 2893d55f8f61edb2c253b960cab1107ea6c163c2 URL: https://github.com/llvm/llvm-project/commit/2893d55f8f61edb2c253b960cab1107ea6c163c2 DIFF:

[PATCH] D144149: [Serialization] Don't warn when a deserialized category is equivalent to an existing one.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2893d55f8f61: [Serialization] Dont warn when a deserialized category is equivalent to an… (authored by vsapsai). Repository: rG LLVM Github

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 499583. TIFitis marked an inline comment as done. TIFitis added a comment. Addressed reviewer comments, fixed error in MLIR translation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 4 inline comments as done. TIFitis added a comment. In D142914#4144475 , @kiranchandramohan wrote: > Please add tests for the MLIR portion. Can you please tell me where to add these? > Could you also post the full LLVM IR for a

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

erichkeane added a comment. We've discussed this offline, and I think this is the right thing to do, but I'll let others comment before approving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144572/new/ https://reviews.llvm.org/D144572

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19113 +// parameter appertaining to the same declaration as that attribute. +if(auto* Parm = dyn_cast(Var); Parm && Parm->getDeclContext() == DC) + return true; Formatting

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

jhuber6 added inline comments. Comment at: clang/test/Driver/amdgpu-toolchain.c:7 // RUN: %clang -### -g --target=amdgcn-mesa-mesa3d -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=DWARF_VER %s // AS_LINK: "-cc1as" arsenm wrote: > should add a test for

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

arsenm added inline comments. Comment at: clang/test/Driver/amdgpu-toolchain.c:7 // RUN: %clang -### -g --target=amdgcn-mesa-mesa3d -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=DWARF_VER %s // AS_LINK: "-cc1as" should add a test for thinlto?

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 499569. Mordante added a comment. Herald added a subscriber: mstorsjo. Try to fix AIX CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files:

[PATCH] D144157: Add 128-bit integer support to enum element

aaron.ballman added a comment. I think this needs additional test coverage around `_BitInt` as those can be arbitrarily large depending on the target. Also, C2x made changes in this area to how we calculate what type to represent the enumerations in; we don't have to implement that support as

[PATCH] D144149: [Serialization] Don't warn when a deserialized category is equivalent to an existing one.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144149/new/ https://reviews.llvm.org/D144149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

aaron.ballman created this revision. aaron.ballman added reviewers: cor3ntin, erichkeane, royjacobson, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. During Clang 15, 3d2629dd3aab17098813c68b5b76bb864bc5e285

[PATCH] D143052: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag

phosek updated this revision to Diff 499561. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143052/new/ https://reviews.llvm.org/D143052 Files:

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 499555. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments! I should have addressed everything apart from testing. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:523 +TransformedInc.Angled = WrittenRef.starts_with("<"); +if (auto FE =

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499553. VitaNuo marked 24 inline comments as done. VitaNuo added a comment. Address review comments (apart from testing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/

[PATCH] D144540: [Clang] [Doc] Explicitly note noreturn bug as a miscompilation

thesamesam closed this revision. thesamesam added a comment. Thanks! Merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144540/new/ https://reviews.llvm.org/D144540 ___ cfe-commits mailing list

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

doru1004 created this revision. doru1004 added reviewers: jdoerfert, jhuber6, ronl, carlo.bertolli, arsenm, gregrodgers, ABataev. doru1004 added a project: OpenMP. Herald added subscribers: kosarev, kerbowa, guansong, yaxunl, jvesely. Herald added a project: All. doru1004 requested review of this

[PATCH] D142569: [OpenMP] Introduce kernel environment

jdoerfert added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:583 + if (!KernelEnvOrError) +return KernelEnvOrError.takeError(); + tianshilei1992 wrote: > jdoerfert wrote: > > We used to default

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

xazax.hun added a comment. I think at this point it is ok to merge. Any other comments can be addressed in follow-up commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits mailing

[PATCH] D143210: [PowerPC] Include vector bool and pixel when emitting lax warning

kamaub added a comment. We may also need an associated test case for the changed behaviour for using `areCompatibleVectorTypes()` instead of `areSameVectorElemTypes()`. The test coverage should display when warnings are emitted now that we account for vector bool, vector pixel and type

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:83 + } + // The universal integral type to use in value range descriptions. This enum is moved here from other location, and `negateKind` is added.

[PATCH] D144497: [clang][doc] Removes obsolete comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b6978285c1: [clang][doc] Removes obsolete comment. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144497/new/

[clang] a7b6978 - [clang][doc] Removes obsolete comment.

Author: Mark de Wever Date: 2023-02-22T17:17:36+01:00 New Revision: a7b6978285c1c07600d1762b206c1dcec35fe6c8 URL: https://github.com/llvm/llvm-project/commit/a7b6978285c1c07600d1762b206c1dcec35fe6c8 DIFF: https://github.com/llvm/llvm-project/commit/a7b6978285c1c07600d1762b206c1dcec35fe6c8.diff

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aqjune abandoned this revision. aqjune added a comment. Closing this as D142388 added a function that can be used instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136737/new/

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45d2df05e0e: [Clang] Add options in LTO mode when cross compiling for AMDGPU (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c45d2df - [Clang] Add options in LTO mode when cross compiling for AMDGPU

Author: Joseph Huber Date: 2023-02-22T10:14:05-06:00 New Revision: c45d2df05e0e7b6f2517aa2933a24928b4942a3f URL: https://github.com/llvm/llvm-project/commit/c45d2df05e0e7b6f2517aa2933a24928b4942a3f DIFF: https://github.com/llvm/llvm-project/commit/c45d2df05e0e7b6f2517aa2933a24928b4942a3f.diff

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:545 +addLTOOptions(getToolChain(), Args, CmdArgs, Output, Inputs[0], + C.getDriver().getLTOMode() == LTOK_Thin); CmdArgs.push_back("-shared");

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. NVM the above, all the other call sites to addLTOOptions have that test in them so it must be fine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:545 +addLTOOptions(getToolChain(), Args, CmdArgs, Output, Inputs[0], + C.getDriver().getLTOMode() == LTOK_Thin); CmdArgs.push_back("-shared");

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

animeshk-amd updated this revision to Diff 499513. animeshk-amd added a comment. Removed a pragma line which was not required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144544/new/ https://reviews.llvm.org/D144544 Files:

[PATCH] D143587: [Docs] Multilib design

michaelplatings added inline comments. Comment at: clang/docs/Multilib.rst:237 + +Stable API +-- MaskRay wrote: > What does "API" refer to? A function defined in llvm-project/clang/lib? Changed "API" to "interface" and reworded to hopefully make it

  1   2   >