[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:92 + // FIXME: Diagnostics. + if (*ToT == PT_Ptr) +return false; One of the problems here is that right now, //all// diagnostics are emitted during interpretation time.

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafi.ahmad. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements bitcasts by traversing the

[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

tstellar added a comment. Would this make more sense in a config file rather than a CMake option? @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144853/new/ https://reviews.llvm.org/D144853

[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

pcwang-thead added a comment. In D144853#4155482 , @asb wrote: > If this is a useful thing to have, would it make more sense as a > target-independent option? Yes, I agree. I need to do some researches here to figure out if all targets have the same

[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

pcwang-thead updated this revision to Diff 501035. pcwang-thead added a comment. Simplify code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144853/new/ https://reviews.llvm.org/D144853 Files: clang/CMakeLists.txt

[clang] e76e3a0 - [NFC] Add a test about template pack for C++20 Modules

Author: Chuanqi Xu Date: 2023-02-28T14:38:46+08:00 New Revision: e76e3a091961ee4e5b01825527832f05234011d6 URL: https://github.com/llvm/llvm-project/commit/e76e3a091961ee4e5b01825527832f05234011d6 DIFF: https://github.com/llvm/llvm-project/commit/e76e3a091961ee4e5b01825527832f05234011d6.diff

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:79 +Opts.PreambleStoragePath = NULL; +Opts.InvocationEmissionPath = getenv("CINDEXTEST_INVOCATION_EMISSION_PATH"); + aaron.ballman wrote: > vedgy wrote: > > When a libclang

[PATCH] D144272: [clang][Interp] Ignore StaticAssertDecls

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144272/new/ https://reviews.llvm.org/D144272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:324 - return Triple.isRISCV64() ? "generic-rv64" : "generic-rv32"; + std::string DefaultCPU = Triple.isRISCV64() ? CLANG_RISCV64_DEFAULT_CPU +

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

Arsenic created this revision. Herald added a reviewer: ributzka. Herald added a project: All. Arsenic edited the summary of this revision. Arsenic added reviewers: dang, zixuw. Arsenic published this revision for review. Arsenic added inline comments. Herald added a project: clang. Herald added a

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144680/new/ https://reviews.llvm.org/D144680

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144934/new/ https://reviews.llvm.org/D144934

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 500996. ccotter added a comment. fix bad 'arc diff' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 Files: clang/docs/ReleaseNotes.rst

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 500995. ccotter added a comment. - update release note, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 Files: clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D144894: [clang] Documents clang-scan-deps requirements.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144894/new/ https://reviews.llvm.org/D144894

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

Allen added inline comments. Herald added a project: All. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3386 +FMulAdd = Builder.CreateConstrainedFPCall( +CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd, +

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144889: [C2x] Support in freestanding

jyknight added a comment. In D144889#4156974 , @rsmith wrote: > Likely because of GCC's perspective on this, the set of C headers provided by > GCC, Clang, ICC, etc. has included the complete list of freestanding headers > and more or less no others,

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

ChuanqiXu added a comment. This is another revision (https://reviews.llvm.org/D144707) which shouldn't be related with libcxx's modular build. So the failures should be irrelevant with the revision. @erichkeane @royjacobson Do you think it makes sense to land this revision in this case?

[clang] abafc86 - [AArch64] Use isSVESizelessBuiltinType instead of isSizelessBuiltinType in SVE specific code.

Author: Craig Topper Date: 2023-02-27T17:39:50-08:00 New Revision: abafc869cb656a81ac35a4002627045a6fb37ff2 URL: https://github.com/llvm/llvm-project/commit/abafc869cb656a81ac35a4002627045a6fb37ff2 DIFF: https://github.com/llvm/llvm-project/commit/abafc869cb656a81ac35a4002627045a6fb37ff2.diff

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks updated this revision to Diff 500987. aeubanks added a comment. move HasHiddenLTOVisibility DLL code to AlwaysHasLTOVisibilityPublic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 Files:

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG58ec6e09abe8: [NFC] [clang] Forward forwarding reference (authored by ccotter, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 58ec6e0 - [NFC] [clang] Forward forwarding reference

Author: Chris Cotter Date: 2023-02-28T01:27:21Z New Revision: 58ec6e09abe8083709802833572bca931b2d15d9 URL: https://github.com/llvm/llvm-project/commit/58ec6e09abe8083709802833572bca931b2d15d9 DIFF: https://github.com/llvm/llvm-project/commit/58ec6e09abe8083709802833572bca931b2d15d9.diff LOG:

[PATCH] D144931: DebugInfo: Disable ctor homing for types with only deleted (non copy/move) ctors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8a1a559f300: DebugInfo: Disable ctor homing for types with only deleted (non copy/move) ctors (authored by dblaikie). Repository: rG LLVM Github

[clang] d8a1a55 - DebugInfo: Disable ctor homing for types with only deleted (non copy/move) ctors

Author: David Blaikie Date: 2023-02-28T01:25:22Z New Revision: d8a1a559f3009a31c517f864156db91d2ae3012c URL: https://github.com/llvm/llvm-project/commit/d8a1a559f3009a31c517f864156db91d2ae3012c DIFF: https://github.com/llvm/llvm-project/commit/d8a1a559f3009a31c517f864156db91d2ae3012c.diff

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

ashay-github created this revision. ashay-github added reviewers: ChuanqiXu, jansvoboda11, ben.boeckel. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `-serialize-diagnostics` flag requires a

[PATCH] D144931: DebugInfo: Disable ctor homing for types with only deleted (non copy/move) ctors

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. Thanks for adding this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144931/new/ https://reviews.llvm.org/D144931

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. I don't have commit access - could you use `Author: Chris Cotter `? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___

[PATCH] D144931: DebugInfo: Disable ctor homing for types with only deleted (non copy/move) ctors

dblaikie created this revision. dblaikie added a reviewer: akhuang. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Such a type is never going to have a ctor home, and may be used for type punning or

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

sammccall added a comment. It seems pretty weird to me that the two child edges from functiondecl -> coroutinebodystmt -> compoundstmt are both called "body". However that *is* what they're called in the AST today, and having the matchers correspond to the AST's names seems important. So this

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

MaskRay added a comment. Herald added a project: All. The used code sequence has 2 bugs so the output will crash. I fixed them in 7198c87f42f6c15d76b127c1c63530e9b4d5dd39 and added my notes to

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

dblaikie added a comment. I think "mangled name" is probably the closest without being overly verbose for the average user. We do use "mangled name" in a few places already, some which look not too unrelated to this one: clang/include/clang/Basic/DiagnosticSemaKinds.td: "mangled name of %0

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang updated this revision to Diff 500958. weiwang edited the summary of this revision. weiwang added a comment. add test case and some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144680/new/ https://reviews.llvm.org/D144680 Files:

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Can you commit this yourself, or would you like me to commit it on your behalf? (what name/email address would you like it attributed to?) Repository: rG LLVM

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

Amir added a comment. Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

Amir updated this revision to Diff 500956. Amir added a comment. Rebase, reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

pcc added a comment. Can't the code in CodeGenModule::HasHiddenLTOVisibility be moved here instead of duplicating it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added a comment. In D144309#4156971 , @bob80905 wrote: > add int support for max/min. Sorry didn't check more :(. Now i16/u16/i32/u32/i64/u64/f16/f32/f64 are all supported for min/max in hlsl. Repository: rG LLVM Github Monorepo

[PATCH] D144889: [C2x] Support in freestanding

rsmith added a comment. Do we know what GCC intends to do about this C change? Per their documentation , they intend for GCC to be / eventually become a complete freestanding implementation without need for a separate libc: > GCC aims towards

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 500953. bob80905 added a comment. add int support for max/min. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144889: [C2x] Support in freestanding

efriedma added a comment. > perhaps because they did char buf[256] = {0} though Right, we need memcpy and memset to emit reasonable code for struct/array initialization and assignment. We don't provide any library that includes memcpy/memset/memmove because of a combination of legacy, and

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Updated with buildable patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144926: darwin platforms do not support static-lsan with TSan or ASan but were "silently failing" in that they would just ignore the flag and link in the dynamic runtimes instead.

dmaclach abandoned this revision. dmaclach added a comment. Accidentally uploaded Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144926/new/ https://reviews.llvm.org/D144926 ___ cfe-commits mailing list

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 500942. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files:

[PATCH] D144926: darwin platforms do not support static-lsan with TSan or ASan but were "silently failing" in that they would just ignore the flag and link in the dynamic runtimes instead.

dmaclach created this revision. Herald added a project: All. dmaclach requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This matches the pre-existing UBSan failure path. Repository: rG LLVM Github Monorepo

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

dblaikie added a comment. In D143877#4156769 , @dblaikie wrote: >> Although we may not agree such ideas, we should offer an option for the >> users to give them the right to choose. > > I think @iains was bemoaning the large number of module flags

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:181-187 +- Changed hungarian prefixes for enums in C files to match C++ files (ie. + always use the enum type letters, for example `rt` prefix for enum tags of + `enum REV_TYPE`) in

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

dblaikie added a subscriber: iains. dblaikie added a comment. > Although we may not agree such ideas, we should offer an option for the users > to give them the right to choose. I think @iains was bemoaning the large number of module flags recently - perhaps he'd have some thoughts on this,

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

jdoerfert added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

dblaikie added a comment. Haven't followed the patch in detail - but why does this require changes to the RecordLayout code? (I'd expect this to only require charnges to the debug info code - maybe with a shared helper utility function that both the AMDGPU ABI implementation, and the debug

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin updated this revision to Diff 500928. cor3ntin added a comment. Remove the #error / #warning tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144285/new/ https://reviews.llvm.org/D144285 Files: clang/docs/ReleaseNotes.rst

Re: [clang] 6ed67cc - [Coroutines] Remove -fcoroutines-ts

> I understand that the name "coroutines-ts" isn't meaningful these > days, but it also sounds like this commit does more than remove the > flag, it caps useful functionality. How are users supposed to use > c++17 with coroutines now? It's very common in our codebase and we > have users relying on

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr25xx.cpp:5-14 +#error one +// expected-error@-1 {{one}} +#if 0 +#error skip +#warning skip // expected-error {{skip}} +#endif +#error two cor3ntin wrote: > aaron.ballman wrote: > > What do

[PATCH] D144889: [C2x] Support in freestanding

bcraig added a comment. > 1. A normal operating system target with a "hosted" libc. > 2. A baremetal target with an "embedded" libc; basically a stripped down libc > which only includes stuff that doesn't require an operating system. What > exactly this includes varies; may include some form

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new/ https://reviews.llvm.org/D144914

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

michaelmaitland added a comment. In D144914#4156567 , @reames wrote: > Code and description appear out of sync. (help != list) Personally, I like > the help naming a lot better. Thanks for catching this. I meant to write `help` instead of `list`.

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

michaelmaitland updated this revision to Diff 500907. michaelmaitland added a comment. Change `list` -> `help`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new/ https://reviews.llvm.org/D144914 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau updated this revision to Diff 500905. amurzeau added a comment. Update the release notes too, to notify of this changes with C files. Suggest the user to use `EnumConstantPrefix` instead of `EnumConstantHungarianPrefix` to keep the previous behavior of using `i` for all enum tags.

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

kiranchandramohan added a comment. Could you update the discourse thread (https://discourse.llvm.org/t/rfc-omp-module-and-omp-function-vs-dialect-attributes-to-encode-openmp-properties/67998) with the chosen approach and reasons before proceeding? Repository: rG LLVM Github Monorepo

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

reames added a comment. Code and description appear out of sync. (help != list) Personally, I like the help naming a lot better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new/ https://reviews.llvm.org/D144914

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

michaelmaitland created this revision. michaelmaitland added reviewers: craig.topper, reames. Herald added a project: All. michaelmaitland requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang currently uses `-mcpu=?`. The `?` causes

[PATCH] D144889: [C2x] Support in freestanding

efriedma added a comment. In D144889#4156120 , @bcraig wrote: > A freestanding implementation doesn't necessarily mean that everything is > header-only. It's fine to require linking against a (freestanding) C runtime > library. All header-only is

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

aaron.ballman added a comment. This seems to cause precommit CI failures that should be addressed, and it should also have a release note about the fix. Also, should this cover things like `clang -U__cplusplus -D__STDC__=1 foo.cpp` as well? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144889: [C2x] Support in freestanding

bcraig added a comment. > Okay, so this is potentially ignorance on my part. I was under the impression > that folks using freestanding mode did not want any library to be linked in. > Are there freestanding libc implementations out there that the user would > link in instead that we defer to

[PATCH] D144889: [C2x] Support in freestanding

bcraig added a comment. > Okay, so this is potentially ignorance on my part. I was under the impression > that folks using freestanding mode did not want any library to be linked in. > Are there freestanding libc implementations out there that the user would > link in instead that we defer to

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

PiotrZSL added a comment. consider adding testcase like this: for (auto I = Obj.begin(5), E = obj.end(5); I != E; ++I) { ... } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added a comment. max/min does work on integers in HLSL. And __builtin_elementwise_max/min support both integers and floats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

erichkeane accepted this revision. erichkeane added a comment. I don't see much compile-time concerns myself, and this seems to fix a pretty serious regression, I think this is acceptable once Aaron and the author think so as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

jhuber6 updated this revision to Diff 500872. jhuber6 added a comment. Add test for case in https://github.com/llvm/llvm-project/issues/59473 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144884/new/ https://reviews.llvm.org/D144884 Files:

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel added a comment. Friendly review ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141008/new/ https://reviews.llvm.org/D141008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:871 +return false; +} else if (Nodes.getNodeAs(EndCallName)) { + return true; ccotter wrote: > PiotrZSL wrote: > > ``else return

[PATCH] D144889: [C2x] Support in freestanding

aaron.ballman added a comment. In D144889#4156068 , @efriedma wrote: > Historically, the required functions for a "freestanding" C implementation > were very restricted. Freestanding headers didn't export library functions, > just constants and types.

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fecac18ffad: [Clang] [AVR] Fix USHRT_MAX for 16-bit int. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 0fecac1 - [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

Author: Daniel Thornburgh Date: 2023-02-27T12:04:26-08:00 New Revision: 0fecac18ffad476b5a4682770f6d8b1f0f176b40 URL: https://github.com/llvm/llvm-project/commit/0fecac18ffad476b5a4682770f6d8b1f0f176b40 DIFF:

[PATCH] D144291: [clang-format-diff] Correctly parse start-of-file diffs

This revision was automatically updated to reflect the committed changes. Closed by commit rG50563944ab96: [clang-format-diff] Correctly parse start-of-file diffs (authored by tamird, committed by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5056394 - [clang-format-diff] Correctly parse start-of-file diffs

Author: Tamir Duberstein Date: 2023-02-27T20:02:51Z New Revision: 50563944ab962b58a1e00763ce16d8c712965c6d URL: https://github.com/llvm/llvm-project/commit/50563944ab962b58a1e00763ce16d8c712965c6d DIFF: https://github.com/llvm/llvm-project/commit/50563944ab962b58a1e00763ce16d8c712965c6d.diff

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

brad added a comment. In D144232#4155966 , @adalava wrote: > I agree with D144321 , sorry for the late > reply. @pkubaj and @brad , thanks for pushing it. I think D144232 > can be

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr25xx.cpp:5-14 +#error one +// expected-error@-1 {{one}} +#if 0 +#error skip +#warning skip // expected-error {{skip}} +#endif +#error two aaron.ballman wrote: > What do these tests have to do with

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

iliya-diyachkov added inline comments. Comment at: clang/lib/CodeGen/CGOpenCLRuntime.cpp:100-112 +llvm::Type *CGOpenCLRuntime::getSamplerType(const Type *T) { + if (!SamplerTy) { +if (llvm::Type *TransTy = CGM.getTargetCodeGenInfo().getOpenCLType( +CGM,

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin updated this revision to Diff 500866. cor3ntin marked an inline comment as done. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144285/new/ https://reviews.llvm.org/D144285 Files:

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:319 + */ + size_t Size; + /** vedgy wrote: > The type is `size_t` instead of the agreed upon `unsigned`, because the > addition of `unsigned GlobalOptions` below means that

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

jhuber6 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1279 + if (State.Line->InPragmaDirective) { +FormatToken *PragmaType = State.Line->First->Next->Next; +if (PragmaType && PragmaType->TokenText.equals("omp"))

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1279 + if (State.Line->InPragmaDirective) { +FormatToken *PragmaType = State.Line->First->Next->Next; +if (PragmaType && PragmaType->TokenText.equals("omp"))

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

HazardyKnusperkeks added a comment. In D144884#4155739 , @jhuber6 wrote: > In D144884#4155730 , @jdoerfert > wrote: > >> I'm assuming they have tests? > > I could add a test for the comment case in the bug

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito created this revision. ManuelJBrito added a reviewer: RKSimon. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Ignoring

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath added a comment. Thanks for your help in getting this right! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://reviews.llvm.org/D144218 ___ cfe-commits mailing list

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 500861. mysterymath marked an inline comment as done. mysterymath added a comment. Add C++ version of test for AVR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/

[PATCH] D144889: [C2x] Support in freestanding

bcraig added a comment. A freestanding implementation doesn't necessarily mean that everything is header-only. It's fine to require linking against a (freestanding) C runtime library. All header-only is fine too though, if you want to make that work. Architecturally, I don't feel it is

Re: [clang] 6ed67cc - [Coroutines] Remove -fcoroutines-ts

Hi Chuanqi, I know the warning mentions it to be removed in clang-17, but a heads up "landing in a week" or so would have been great :) I understand that the name "coroutines-ts" isn't meaningful these days, but it also sounds like this commit does more than remove the flag, it caps useful

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang added a comment. In D144680#4149149 , @ChuanqiXu wrote: > BTW, what is the conclusion for the concern about sanitizers? Would change > make sanitizers to perform false positive diagnostics? This change is limited to the `await.suspend` block,

[PATCH] D144889: [C2x] Support in freestanding

efriedma added a comment. Historically, the required functions for a "freestanding" C implementation were very restricted. Freestanding headers didn't export library functions, just constants and types. As a practical matter, we actually do need a few functions to support code generation for

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16824-16841 if (InnerCond && isa(InnerCond)) { // Drill down into concept specialization expressions to see why they // weren't satisfied. Diag(StaticAssertLoc,

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small change to the test coverage. Comment at: clang/test/Headers/limits.cpp:8 +// Specifically test 16-bit int platforms. +// RUN: %clang_cc1

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143415/new/ https://reviews.llvm.org/D143415

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

adalava added a comment. In D144232#4137367 , @dim wrote: > In D144232#4136787 , @brad wrote: > >> I noticed this review. I have provided a more complete diff for review at >> D144321

[PATCH] D144878: __builtin_FILE_NAME()

shafik added inline comments. Comment at: clang/lib/AST/Expr.cpp:2283 + case SourceLocExpr::FileName: { +SmallString<256> Path; +// builtin_FILE_NAME() is a Clang-specific extension that expands to the It looks like a copy of the code from

[PATCH] D143524: Make the -Wunused-template default.

ldionne added inline comments. Comment at: clang/test/SemaCXX/warn-func-not-needed.cpp:13 namespace test1_template { -template static void f() {} +template static void f() {} // expected-warning {{unused function template}} template <> void f() {} // expected-warning

[PATCH] D144894: [clang] Documents clang-scan-deps requirements.

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was discussed in https://llvm.org/PR61006. Repository: rG LLVM Github

  1   2   >