[PATCH] D148767: Restore CodeGen/LowLevelType

chapuni added a comment. In D148767#4311529 , @MaskRay wrote: > Add some information why this is restored? Assume that people may not read > the depended patches (`Depends on D145937, D146352, and D148768.`). Yes sure. This was just an isolated diff

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

This revision was automatically updated to reflect the committed changes. Closed by commit rG74c1fa60b5f5: [RISCV] Add Smaia and Ssaia extensions support (authored by 4vtomat). Changed prior to commit: https://reviews.llvm.org/D148066?vs=516137=518634#toc Repository: rG LLVM Github Monorepo

[clang] 74c1fa6 - [RISCV] Add Smaia and Ssaia extensions support

Author: 4vtomat Date: 2023-05-01T22:30:08-07:00 New Revision: 74c1fa60b5f5c1d079e08a2e409a649a26da41d1 URL: https://github.com/llvm/llvm-project/commit/74c1fa60b5f5c1d079e08a2e409a649a26da41d1 DIFF: https://github.com/llvm/llvm-project/commit/74c1fa60b5f5c1d079e08a2e409a649a26da41d1.diff LOG:

[PATCH] D148767: Restore CodeGen/LowLevelType

barannikov88 added a comment. Adding CodeGen dependency to MCTargetDesc layer does not seem right. Why is it necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/ https://reviews.llvm.org/D148767

[PATCH] D149495: [RISCV] Add sifive-x280 processor and support V extension in SiFive7

craig.topper added a comment. All CPU name additions should be mentioned in the RISC-V section of llvm/docs/ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/ https://reviews.llvm.org/D149495

[PATCH] D149495: [RISCV] Add sifive-x280 processor and support V extension in SiFive7

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:169 +def SIFIVE_X280 : RISCVProcessorModel<"sifive-x280", SiFive7Model, + [Feature64Bit, I would prefer that we add sifive-x280 in a

[PATCH] D149334: [RISCV] Enable strict fp for RISC-V in clang.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149334/new/ https://reviews.llvm.org/D149334

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak updated this revision to Diff 518630. ahatanak added a comment. Enable llvm-symbolizer when running disable-crash-reports.test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 Files:

[clang] 9ec5423 - [clang][Interp][NFC] Add documentation for SetLocal

Author: Timm Bäder Date: 2023-05-02T06:16:49+02:00 New Revision: 9ec5423b90c888d9ec4206c18b728946be5f1368 URL: https://github.com/llvm/llvm-project/commit/9ec5423b90c888d9ec4206c18b728946be5f1368 DIFF: https://github.com/llvm/llvm-project/commit/9ec5423b90c888d9ec4206c18b728946be5f1368.diff

[clang] 7d0938b - [clang][Interp][NFC] Make OptionScope final

Author: Timm Bäder Date: 2023-05-02T06:16:49+02:00 New Revision: 7d0938bf2c2a35d4eb4b8c4c728aaa85d1dd428e URL: https://github.com/llvm/llvm-project/commit/7d0938bf2c2a35d4eb4b8c4c728aaa85d1dd428e DIFF: https://github.com/llvm/llvm-project/commit/7d0938bf2c2a35d4eb4b8c4c728aaa85d1dd428e.diff

[PATCH] D148767: Restore CodeGen/LowLevelType

MaskRay added a comment. > This is rework of; > > D30046 (LLT) Add some information why this is restored? Assume that people may not read the depended patches (`Depends on D145937, D146352, and D148768.`). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

MaskRay added a comment. I have read prior discussions and https://discourse.llvm.org/t/rfc-improving-clangs-middle-and-back-end-diagnostics/69261 . The current approach seems reasonable. The summary should incorporate more information. `inlined.from` isn't mentioned at all.

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

aeubanks added a comment. In D149187#4311354 , @chapuni wrote: > I am afraid this would be incompatible to bazel due to deep symlinks for > sandbox. I assume bazel would use `-no-canonical-prefixes`? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D149631: [NFC][CLANG] Fix static analyzer codes concerns about large copies by value

Manna created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: aaron.ballman. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan,

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added a comment. bump? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:863 + InliningDecisions.push_back(D.getCaller().str()); + for (size_t i = 0, e = InliningDecisions.size(); i != e; ++i) { +std::string S = llvm::demangle(InliningDecisions[i]);

[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Comment at: llvm/docs/ReleaseNotes.rst:289 +* ``llvm::demangle`` now takes a ``std::string_view`` rather than a + ``const std::string&``. Be careful

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

This revision was automatically updated to reflect the committed changes. Closed by commit rGecad12100927: [clang][Driver] Fix crash with unsupported architectures in MinGW and… (authored by k-mana, committed by MaskRay). Changed prior to commit:

[clang] ecad121 - [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows

Author: KOMATA Manabu Date: 2023-05-01T18:34:09-07:00 New Revision: ecad1210092764592ca9ee0670dd15831e54b770 URL: https://github.com/llvm/llvm-project/commit/ecad1210092764592ca9ee0670dd15831e54b770 DIFF: https://github.com/llvm/llvm-project/commit/ecad1210092764592ca9ee0670dd15831e54b770.diff

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

chapuni added a comment. I am afraid this would be incompatible to bazel due to deep symlinks for sandbox. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149187/new/ https://reviews.llvm.org/D149187 ___

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

MaskRay accepted this revision. MaskRay added a comment. Looks great! Comment at: clang/test/Driver/unsupported-target-arch.c:33 +// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-NOARCH-CROSSWINDOWS %s +// CHECK-NOARCH-CROSSWINDOWS: error: unknown target triple

[clang] ea7e69f - [Driver] Drop incorrect hint from err_target_unknown_triple

Author: Fangrui Song Date: 2023-05-01T18:22:49-07:00 New Revision: ea7e69f392b29201502cdcb8cfa83f0f3704da34 URL: https://github.com/llvm/llvm-project/commit/ea7e69f392b29201502cdcb8cfa83f0f3704da34 DIFF: https://github.com/llvm/llvm-project/commit/ea7e69f392b29201502cdcb8cfa83f0f3704da34.diff

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak updated this revision to Diff 518610. ahatanak added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Disable llvm-symbolizer when running lit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

yaxunl added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318 Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE", Twine(WavefrontSize)); + Builder.defineMacro("__AMDGCN_CUMODE", Twine(CUMode)); } arsenm wrote: > Why do we sometimes use __ on

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. Herald added a subscriber: jplehr. @dmgreen I've been looking at this test again trying to see what's missing. The problem now is that only a VF of 4 is chosen. In the good case, instcombine/simplifyCFG runs so that it simplifies down to an `smin` intrinsic. After

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 518608. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Sema/AnalysisBasedWarnings.h clang/lib/Sema/AnalysisBasedWarnings.cpp clang/lib/Sema/Sema.cpp

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

jhuber6 updated this revision to Diff 518604. jhuber6 added a comment. Add option to allow overriding the global hash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149451/new/ https://reviews.llvm.org/D149451 Files:

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

efriedma added a comment. I guess I should note both the examples in https://github.com/llvm/llvm-project/issues/49305 could probably be fixed in other ways... we have heuristics to, for example, sink logic ops into loops when it's profitable. But that requires someone to notice the specific

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149182/new/ https://reviews.llvm.org/D149182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149380: [clang] Add -Wunused-result-always warning

dblaikie added a comment. Seems more stylistic/unlikely to meet the diagnostic bar (certtainly couldn't be on-by-default for instance) for clang to me (but could go into something like clang-tidy), at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

philnik removed a reviewer: libc++abi. philnik added a comment. In D149573#433 , @codemzs wrote: > In D149573#4310601 , @philnik wrote: > >> In D149573#4310009 ,

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

dblaikie accepted this revision. dblaikie added a comment. I wouldn't mind a follow-up commit that creates a new/separate directory (llvm/{lib,include/llvm}/CodeGenTypes) but that's probably a lot of unnecessary churn too, so I can appreciate the argument against it - if folks reckon it's

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

efriedma added a reviewer: dmgreen. efriedma added subscribers: bsmith, paulwalker-arm, lenary. efriedma added a comment. The primary tradeoff here is that existing optimizations won't understand the intrinsic... for example, we can't constant-fold, or automatically invert the mask. But making

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added a comment. > probably too much, but then I wonder "how do we make Fortify work?". (I'm still sort of on the side of "if the compile-time costs to get more verbose diagnostics is high, we could have a low-quality default-on diagnostic and it could mention/recommend a

[PATCH] D149364: [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa50e54fbeb48: [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h (authored by tra). Repository: rG LLVM Github

[clang] a50e54f - [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h

Author: Artem Belevich Date: 2023-05-01T16:27:13-07:00 New Revision: a50e54fbeb48fb8a218a2914d827e1087bae2f8d URL: https://github.com/llvm/llvm-project/commit/a50e54fbeb48fb8a218a2914d827e1087bae2f8d DIFF:

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs added a comment. In D149573#4310601 , @philnik wrote: > In D149573#4310009 , @codemzs wrote: > >> My change to libcxxabi/test/test_demangle.pass.cpp (last file in the change) >> is only one line i.e

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

jhuber6 added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" + getHash(M.getName()) + "_" + + std::to_string(Priority))

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" + getHash(M.getName()) + "_" + + std::to_string(Priority)) tra

[PATCH] D149492: [clang] makes built-in traits match their stdlib counterparts' names

cjdb added a comment. Looks like I need to special-case `__is_null_pointer` as a function for libstdc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149492/new/ https://reviews.llvm.org/D149492 ___

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 added inline comments. Comment at: llvm/test/Transforms/OpenMP/always_inline_device.ll:11 -; Function Attrs: norecurse nounwind +@kernel_environment = local_unnamed_addr constant %struct.KernelEnvironmentTy { %struct.ConfigurationEnvironmentTy { i8 1, i8 0, i8

[PATCH] D149618: [clang][NFC] documents recent type trait primitives

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D149492 . Repository:

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

dexonsmith added subscribers: iana, ributzka. dexonsmith added a comment. In D103930#4310061 , @ivanmurashko wrote: > Friendly ping > > @arphaman, @jansvoboda11, I have made the patch buildable on all platforms > and have all tests passed. There was

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - thanks! I'll send a diff for the release notes ~soon (~this week). (P.S. just in case - I'll be out of office for ~2 weeks) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka accepted this revision. vitalybuka added 2 blocking reviewer(s): eugenis, MaskRay. vitalybuka added a comment. In D143675#4310734 , @rsundahl wrote: > @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality > is under the

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

eugenis added a comment. I'm fine with it in general. Is asan_abi.cpp meant as a temporary stub? It's not even link anywhere in the current version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

rsmith added a comment. There's some corresponding code in `lib/CodeGen` that can be deleted too: case Builtin::BI__builtin_assume_aligned: { const Expr *Ptr = E->getArg(0); Value *PtrValue = EmitScalarExpr(Ptr); - if (PtrValue->getType() != VoidPtrTy) - PtrValue

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG771ad1691ac3: [Clang] Fix a crash when recursively callig a default member initializer. (authored by cor3ntin). Changed prior to commit:

[clang] 771ad16 - [Clang] Fix a crash when recursively callig a default member initializer.

Author: Corentin Jabot Date: 2023-05-01T23:21:14+02:00 New Revision: 771ad1691ac3057df2220dd327d7cdc73ef6c6f5 URL: https://github.com/llvm/llvm-project/commit/771ad1691ac3057df2220dd327d7cdc73ef6c6f5 DIFF:

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

xazax.hun added a subscriber: dcoughlin. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:616 + bool erased = DeclToLoc.erase(); + if (!erased) +D.dump(); Would we dump this in release builds? Do we want

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked an inline comment as done. rsundahl added a comment. @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality is under the added flag so not expecting any surprises. Rename asabi->asan_abi as suggested. Comment at:

[PATCH] D148654: Modify BoundsSan to improve debuggability

smeenai added a comment. You should upload this with full context and add some test cases :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 ___ cfe-commits

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

jhuber6 updated this revision to Diff 518553. jhuber6 added a comment. Changing to use source filename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149451/new/ https://reviews.llvm.org/D149451 Files: clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 518552. rsundahl added a comment. Rename asabi->asan_abi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files: clang/include/clang/Driver/Options.td

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" + getHash(M.getName()) + "_" + + std::to_string(Priority))

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cc0c0de8021: [MemProf] Recognize hot/cold operator new as replaceable allocations (authored by tejohnson). Repository: rG LLVM Github Monorepo

[clang] 2cc0c0d - [MemProf] Recognize hot/cold operator new as replaceable allocations

Author: Teresa Johnson Date: 2023-05-01T13:37:40-07:00 New Revision: 2cc0c0de802178dc7e5408497e2ec53b6c9728fa URL: https://github.com/llvm/llvm-project/commit/2cc0c0de802178dc7e5408497e2ec53b6c9728fa DIFF:

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

jhuber6 added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" + getHash(M.getName()) + "_" + + std::to_string(Priority))

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added a comment. No, I don't have commit access. You could use just `Bolshakov ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://reviews.llvm.org/D146386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM overall. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" +

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM. It may not be the end step and may be annoying to make further changes from this point, but on its own this isn't worse than before Comment at:

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks marked an inline comment as done. aeubanks added a comment. In D146764#4310398 , @aaron.ballman wrote: > I think you're missing changes in ASTReaderStmt.cpp and ASTWriterStmt.cpp, so > serialization through modules or PCH won't work without

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 518548. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include/clang/AST/Expr.h

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi updated this revision to Diff 518547. bazuzi added a comment. Use LLVM_DEPRECATED in place of comments indicating deprecation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149464/new/ https://reviews.llvm.org/D149464 Files:

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

arsenm added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318 Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE", Twine(WavefrontSize)); + Builder.defineMacro("__AMDGCN_CUMODE", Twine(CUMode)); } Why do we sometimes use __ on both sides, and

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 518546. void added a comment. Improve error message to use the unknown field's name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files:

[PATCH] D149613: [NFC] fix clang-tidy `prefer-isa-or-dyn-cast-in-conditionals` and `namespace-comment`

HerrCai0907 created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D149613

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518543. Ris-Bali added a comment. Added test for function type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:91 return true; - case tok::annot_cxxscope: // Check if this is a dtor. -if (NextToken().is(tok::tilde)) Are you sure you can remove this? Wouldn't this be

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4310464 , @craig.topper wrote: > In D145088#4308840 , @akyrtzi wrote: > >> `CodeGen` has the same issue: >> >> $ ninja >>

[PATCH] D149606: [RISCV] Move RISCV::RVVBitsPerBlock to be a static member of RISCVISAInfo class.

craig.topper abandoned this revision. craig.topper added a comment. fa42e7b made this unnecessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149606/new/

[clang] fa42e7b - [RISCV] Merge RISCV::parseCPUKind and RISCV::checkCPUKind.

Author: Craig Topper Date: 2023-05-01T13:00:05-07:00 New Revision: fa42e7b6bc430941f42cf50b5c4e55b3c19ccc08 URL: https://github.com/llvm/llvm-project/commit/fa42e7b6bc430941f42cf50b5c4e55b3c19ccc08 DIFF: https://github.com/llvm/llvm-project/commit/fa42e7b6bc430941f42cf50b5c4e55b3c19ccc08.diff

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

philnik added a comment. In D149573#4310009 , @codemzs wrote: > My change to libcxxabi/test/test_demangle.pass.cpp (last file in the change) > is only one line i.e {"_ZNK5clang4Type16isArithmeticTypeERNS_10ASTContextE", >

[clang] 578a471 - Reland [clang] Canonicalize system headers in dependency file when -canonical-prefixes

Author: Arthur Eubanks Date: 2023-05-01T12:44:52-07:00 New Revision: 578a4716f549167165a2ec3bac89c86706136d4e URL: https://github.com/llvm/llvm-project/commit/578a4716f549167165a2ec3bac89c86706136d4e DIFF:

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 created this revision. HerrCai0907 added reviewers: aaron.ballman, rjmccall, shafik. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fixed:

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

k-mana added a comment. I don't have commit access. Please commit at KOMATA Manabu . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148944/new/ https://reviews.llvm.org/D148944 ___ cfe-commits mailing

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

aaron.ballman added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x())

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM (Do you have commit access? If not, please specify the name/email you want for the "author" field.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

tejohnson updated this revision to Diff 518526. tejohnson added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149600/new/ https://reviews.llvm.org/D149600 Files: clang/lib/AST/Decl.cpp

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

aaron.ballman added a comment. Thank you for working on this! The Clang changes are mostly all good, but I think we should hold off on changing the value of `__cplusplus` for the moment as it's not set in stone in the standard yet (I thought it was though, so I'm checking with the editor).

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:189 + /// Deprecated. Use *getDataflowAnalysisContext().getOptions().Log instead. Logger () const { return *DACtx->getOptions().Log; } bazuzi

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4308840 , @akyrtzi wrote: > `CodeGen` has the same issue: > > $ ninja > tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/TargetInfo.cpp.o > In file included from

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

rsmith added a comment. This looks like a nice improvement to me. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:162 + if (P->getCurToken().is(tok::annot_repl_input_end)) { +P->ConsumeAnyToken(); // FIXME: Clang does not call ExitScope on finalizing the

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: All. Someone else ultimately fixed this (slightly differently) last month: https://reviews.llvm.org/D146875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/new_hot_cold.cpp:16 + +enum class __hot_cold_t : uint8_t; +namespace malloc_namespace { snehasish wrote: > Can we skip the typedef and just say `enum class __hot_cold_t : unsigned > char;`? > >

[PATCH] D149606: [RISCV] Move RISCV::RVVBitsPerBlock to be a static member of RISCVISAInfo class.

craig.topper created this revision. craig.topper added reviewers: reames, asb, luismarques, frasercrmck, kito-cheng, rogfer01, pcwang-thead. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman added a comment. I think you're missing changes in ASTReaderStmt.cpp and ASTWriterStmt.cpp, so serialization through modules or PCH won't work without that. Comment at: clang/include/clang/AST/Expr.h:1996 PredefinedExpr(SourceLocation L, QualType FNTy,

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

HazardyKnusperkeks added a comment. I don't see the problem, could you elaborate a bit more? (Keep in mind, I have no idea about Verilog.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149562/new/ https://reviews.llvm.org/D149562

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

snehasish accepted this revision. snehasish added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/CodeGenCXX/new_hot_cold.cpp:16 + +enum class __hot_cold_t : uint8_t; +namespace malloc_namespace { Can we skip the typedef

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

tejohnson created this revision. tejohnson added reviewers: rsmith, snehasish. Herald added a project: All. tejohnson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow up to LLVM-side change to allow conversion to hot/cold hinted

[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149104/new/ https://reviews.llvm.org/D149104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] f9fbda7 - Revert "[clang] Canonicalize system headers in dependency file when -canonical-prefixes"

Author: Arthur Eubanks Date: 2023-05-01T10:55:53-07:00 New Revision: f9fbda7102fb6da79dedf9b15694d7a61e8c49b7 URL: https://github.com/llvm/llvm-project/commit/f9fbda7102fb6da79dedf9b15694d7a61e8c49b7 DIFF:

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x())

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f0dd4ef3ed2: [clang] Canonicalize system headers in dependency file when -canonical-prefixes (authored by aeubanks). Repository: rG LLVM Github

[clang] 8f0dd4e - [clang] Canonicalize system headers in dependency file when -canonical-prefixes

Author: Arthur Eubanks Date: 2023-05-01T10:40:18-07:00 New Revision: 8f0dd4ef3ed2137d1e2554204127434fc46ee190 URL: https://github.com/llvm/llvm-project/commit/8f0dd4ef3ed2137d1e2554204127434fc46ee190 DIFF:

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] f762798 - Fix ReleaseNotes.rst unresolved merge conflict

Author: Alan Zhao Date: 2023-05-01T10:26:15-07:00 New Revision: f762798599171efca03964f4371cc8104d2392f9 URL: https://github.com/llvm/llvm-project/commit/f762798599171efca03964f4371cc8104d2392f9 DIFF: https://github.com/llvm/llvm-project/commit/f762798599171efca03964f4371cc8104d2392f9.diff

[PATCH] D149596: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

amyk created this revision. amyk added reviewers: PowerPC, stefanp, kamaub, nemanjai. amyk added projects: LLVM, PowerPC, clang. Herald added a reviewer: aaron.ballman. Herald added a project: All. amyk requested review of this revision. Herald added a subscriber: cfe-commits. This patch relaxes

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b4faa11c68b: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate… (authored by ayzhao). Repository: rG LLVM Github

[clang] 9b4faa1 - [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

Author: Alan Zhao Date: 2023-05-01T10:02:15-07:00 New Revision: 9b4faa11c68be4b45ddf29acd575bb52a3c2fad7 URL: https://github.com/llvm/llvm-project/commit/9b4faa11c68be4b45ddf29acd575bb52a3c2fad7 DIFF: https://github.com/llvm/llvm-project/commit/9b4faa11c68be4b45ddf29acd575bb52a3c2fad7.diff

  1   2   >