[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:1972 +// Control Flow Integerity +include "RISCVInstrInfoZicfiss.td" Put this with the other RISCVInstrInfoZi* files under "Integer" Comment at:

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 546323. evelez7 added a comment. Add test for overloaded operator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D156851: [RISCV] Merge rv32 and rv64 Zvb* intrinsic tests. NFC

craig.topper created this revision. craig.topper added reviewers: asb, wangpc, kito-cheng, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[clang] 244fd4d - [RISCV] Run mem2reg on more scalar C builtin tests to remove allocas and simplify checks. NFC

Author: Craig Topper Date: 2023-08-01T22:10:54-07:00 New Revision: 244fd4dfc56a0d59655c65adac6a7258114b8af2 URL: https://github.com/llvm/llvm-project/commit/244fd4dfc56a0d59655c65adac6a7258114b8af2 DIFF: https://github.com/llvm/llvm-project/commit/244fd4dfc56a0d59655c65adac6a7258114b8af2.diff

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:770 +template <> +struct has_function_signature : public std::true_type {}; + dang wrote: > Does `CXXInstanceMethodRecord` need one of these as well? `CXXInstanceMethodRecord`

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 546317. evelez7 marked 4 inline comments as done. evelez7 added a comment. Address review feedback, add tests, and small refactors. - Add tests for destructors, constructors, and conversion methods. - Remove redundant check-nots in existing tests. - Properly

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper updated this revision to Diff 546315. craig.topper added a comment. Add riscv_bitmanip.h to cover all of Zbb and Zbkb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 Files:

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

bcain updated this revision to Diff 546314. bcain added a comment. Changed test to use `-Werror -###` instead of `-fdriver-only -v -Werror`. Fixed indentation / `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

jcsxky updated this revision to Diff 546309. jcsxky added a comment. update patch for pass unittests and test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

poelmanc abandoned this revision. poelmanc added a comment. Herald added a project: All. We eventually updated our coding standards and our fairly massive code base to change only the very top "main" include from `#include ` to `#include "Foo.h"`. For all include statements after that, we

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

This revision was automatically updated to reflect the committed changes. Closed by commit rG91b7952afc82: [ASTImporter] Fix corrupted RecordLayout caused by circular referenced fields (authored by dingfei fd...@feysh.com). Changed prior to commit:

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f2157f8fcae: [clang][ASTImporter] Fix friend class template import within dependent context (authored by dingfei fd...@feysh.com). Changed prior to commit:

[clang] 91b7952 - [ASTImporter] Fix corrupted RecordLayout caused by circular referenced fields

Author: dingfei Date: 2023-08-02T11:21:10+08:00 New Revision: 91b7952afc82f90e7b810701d9d5c776a8e21688 URL: https://github.com/llvm/llvm-project/commit/91b7952afc82f90e7b810701d9d5c776a8e21688 DIFF: https://github.com/llvm/llvm-project/commit/91b7952afc82f90e7b810701d9d5c776a8e21688.diff LOG:

[clang] 5f2157f - [clang][ASTImporter] Fix friend class template import within dependent context

Author: dingfei Date: 2023-08-02T11:21:09+08:00 New Revision: 5f2157f8fcaede27ccf4ab215fcb1a4725a36b2a URL: https://github.com/llvm/llvm-project/commit/5f2157f8fcaede27ccf4ab215fcb1a4725a36b2a DIFF: https://github.com/llvm/llvm-project/commit/5f2157f8fcaede27ccf4ab215fcb1a4725a36b2a.diff LOG:

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

vsapsai added a comment. In D156749#4551596 , @jansvoboda11 wrote: > What are the performance implications of making VFS overlays part of the > context hash? I don't have specific measurements but for Xcode projects different targets have different

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

jcsxky updated this revision to Diff 546301. jcsxky added a comment. update patch for pass unittests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

danix800 added a comment. In D156201#4551464 , @aaron.ballman wrote: > LGTM! > > In D156201#4551332 , @danix800 > wrote: > >> In D156201#4551270 , @steakhal >> wrote:

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

danix800 added a comment. In D155661#4550340 , @balazske wrote: > The fix looks OK, but the test could be improved and cleaned up (for example > `FromClass` is the same as `FromD` in the test, and DeclContext is not > checked, can be done like in the

[PATCH] D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1066797c5b: [AST] Simplify Type::isSizelessBuiltinType(). NFC. (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156686/new/

[clang] 1c10667 - [AST] Simplify Type::isSizelessBuiltinType(). NFC.

Author: Jim Lin Date: 2023-08-02T10:46:42+08:00 New Revision: 1c1066797c5bb56616dc485b596fd40d5f03ece2 URL: https://github.com/llvm/llvm-project/commit/1c1066797c5bb56616dc485b596fd40d5f03ece2 DIFF: https://github.com/llvm/llvm-project/commit/1c1066797c5bb56616dc485b596fd40d5f03ece2.diff LOG:

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

MaskRay added a comment. (After D156363 , newer tests can use `-### -Werror` instead of `-fdriver-only -v -Werror` :) ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/ https://reviews.llvm.org/D156771

[PATCH] D156806: [Modules] Add test for merging of template member parent

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156806/new/ https://reviews.llvm.org/D156806 ___ cfe-commits mailing list

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

wrotki accepted this revision. wrotki added a comment. Yes, it looks good. I downloaded the patch and ran the test - had some doubts about 'otool -L %t |grep -q "dynamic.dylib"' - but verified with other ASAN tests binaries and convinced myself that it's the right thing to do. CHANGES SINCE

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:233 +def uimm10 : Operand, ImmLeaf(Imm);}]> { + let ParserMatchClass = UImmAsmOperand<10>; Is this used? Comment at:

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

This revision was automatically updated to reflect the committed changes. Closed by commit rGed83797f3cbf: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn. (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ed83797 - [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

Author: Jon Roelofs Date: 2023-08-01T18:02:00-07:00 New Revision: ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a URL: https://github.com/llvm/llvm-project/commit/ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a DIFF: https://github.com/llvm/llvm-project/commit/ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a.diff

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added a comment. Please update llvm/docs/RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 ___ cfe-commits mailing list

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added a comment. OOo down to ±300, I love this!! I'll take a closer look tomorrow. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1891-1892 + for (unsigned i = 0; i < NumParms; i++) { +if (!ParmsMask[i]) + continue; + Speaking of [[

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

craig.topper added a comment. I think another option could be to do this in SemaChecking.cpp where we implement __builtin_riscv_ntl_load and __builtin_riscv_ntl_store. We already do custom type checking there. We could detect the missing argument and give it a default. Repository: rG LLVM

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2219 + // cannot be fixed... + eraseVarsForUnfixableGroupMates(FixItsForVariable, VarGrpMgr); + // Now `FixItsForVariable` gets further reduced: a variable is in NoQ wrote: >

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2219 + // cannot be fixed... + eraseVarsForUnfixableGroupMates(FixItsForVariable, VarGrpMgr); + // Now `FixItsForVariable` gets further reduced: a variable is in Architecturally

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 546269. artem added a comment. typo fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. Hi @dblaikie Thank you for the detailed response! > So you get some bunch of annotations from the BTFTagAttributedType, then you > build the underlying type (which might already be built/needed/fine because > it's used without attributes in other places/needs to exist

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

NoQ added a comment. Looks like rG910450a28ba9c has independently addressed both issues. But at least we had a chance to deal with the injustice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

NoQ added a comment. I really like this! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2178 + // `FixItsForVariable` will map each variable to a set of fix-its directly + // associated to the variable itself. Fix-its of distict variables in + // `FixItsForVariable`

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 546261. artem added a comment. Fixed comments and failing test. Added a new compiler-rt test for ubsan CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

ziqingluo-90 added a comment. Hi @AMP999 I have committed this patch on behalf of you. Unfortunately, I cannot amend an old commit for you as it will cause rewriting a bunch of the history. I made a correction message along with the commit. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao marked an inline comment as done. SlaterLatiao added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3289-3290 + Fields.push_back(PackedField); + if (NewMember->isInvalidDecl()) +Instantiation->setInvalidDecl();

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82b94a9f7be9: Fix the linting problems in UnsafeBufferUsage.cpp (authored by AMP999, committed by ziqingluo-90). Changed prior to commit:

[clang] 82b94a9 - Fix the linting problems in UnsafeBufferUsage.cpp

Author: Amirreza Ashouri Date: 2023-08-01T16:17:40-07:00 New Revision: 82b94a9f7be9474acd0a950ce521c439057066be URL: https://github.com/llvm/llvm-project/commit/82b94a9f7be9474acd0a950ce521c439057066be DIFF:

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 546257. SlaterLatiao added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 Files:

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:832 + +inline float __ovld __cnfn sqrt(float __x) { + return __builtin_elementwise_sqrt(__x); Is this a generic implementation enough? Would some targets not need to do something

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1143 + // order is deterministic: + CompareNode> + byVar; t-rasmud wrote: > NoQ wrote: > > ziqingluo-90 wrote: > > > To make the order of variables in every

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

Anastasia added a comment. > We also are tied to OpenCL semantic of future versions. This is what I would like to avoid aliasing to OpenCL and then starting to change it in a way that is not conforming or documented. Maybe there is a need for something like an address space for the group of

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

MaskRay added a comment. I glanced at the patch. The code seems reasonable. Comment at: clang/test/lit.cfg.py:383 -# The llvm-nm tool supports an environment variable "OBJECT_MODE" on AIX OS, which +# Some tool support an environment variable "OBJECT_MODE" on AIX OS, which

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1143 + // order is deterministic: + CompareNode> + byVar; NoQ wrote: > ziqingluo-90 wrote: > > To make the order of variables in every group

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1143 + // order is deterministic: + CompareNode> + byVar; ziqingluo-90 wrote: > To make the order of variables in every group deterministic. Would it make

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4551721 , @cor3ntin wrote: > I think the test we want is a set of classes and virtuaal fuc > > In D155809#4551686 , @philnik wrote: > >> @aaron.ballman I think what @danlark

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers added inline comments. Comment at: clang/docs/ReleaseNotes.rst:74-76 +- ``structs``, ``unions``, and ``arrays`` that are const may now be used as + constant expressions. This change is more consistent with the behavior of + GCC. Note to self:

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2179 + if (FixItsForVariable.count(GrpMate)) +FinalFixItsForVariable[Var].insert(FinalFixItsForVariable[Var].end(), +

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

rsundahl accepted this revision. rsundahl added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for the additional clean-up @thetruestblue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156718/new/ https://reviews.llvm.org/D156718

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 546219. jroelofs added a comment. Rebase. Avoid the dependency on D156735 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 Files:

[PATCH] D155870: [Clang][CodeGen] Another follow-up for `vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155870/new/ https://reviews.llvm.org/D155870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. AlexVlx marked an inline comment as done. Closed by commit rG51a014cb2d9c: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces (authored by AlexVlx).

[clang] 51a014c - [Clang][CodeGen] `__builtin_alloca`s should care about address spaces

Author: Alex Voicu Date: 2023-08-01T21:55:36+01:00 New Revision: 51a014cb2d9c6f8303f9b11ffc035d69cbeb9e21 URL: https://github.com/llvm/llvm-project/commit/51a014cb2d9c6f8303f9b11ffc035d69cbeb9e21 DIFF: https://github.com/llvm/llvm-project/commit/51a014cb2d9c6f8303f9b11ffc035d69cbeb9e21.diff

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

cor3ntin added a comment. I think the test we want is a set of classes and virtuaal fuc In D155809#4551686 , @philnik wrote: > @aaron.ballman I think what @danlark means is that when building clang > against a libc++ which has debug assertions enabled,

[PATCH] D156705: [clang-format] Fix braced initializer formatting with templated base class initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG400da115c58a: [clang-format] Fix braced initializer with templated base class (authored by galenelias, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 400da11 - [clang-format] Fix braced initializer with templated base class

Author: Galen Elias Date: 2023-08-01T13:53:22-07:00 New Revision: 400da115c58ae19445cfdc871a3f559f160fc5c6 URL: https://github.com/llvm/llvm-project/commit/400da115c58ae19445cfdc871a3f559f160fc5c6 DIFF: https://github.com/llvm/llvm-project/commit/400da115c58ae19445cfdc871a3f559f160fc5c6.diff

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; hubert.reinterpretcast wrote:

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

cjdb added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3270-3339 +// Instantiate packed data members. +if (FieldDecl *Field = dyn_cast(Member); +Field && isa(Field->getType().getTypePtr())) { + QualType PatternType =

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

probinson added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; Would you mind changing this cast from `uint8_t` to

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; aaron.ballman

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

philnik added a comment. @aaron.ballman I think what @danlark means is that when building clang against a libc++ which has debug assertions enabled, the clang tests he mentioned result in an assertion firing within libc++. i.e. the libc++ debug mode catches the non-strict weak ordering that it

[PATCH] D156643: [clang-format][NFC] Remove superfluous code in UnwrappedLineParser

This revision was automatically updated to reflect the committed changes. Closed by commit rGadece4e452e8: [clang-format][NFC] Remove superfluous code in UnwrappedLineParser (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] adece4e - [clang-format][NFC] Remove superfluous code in UnwrappedLineParser

Author: Owen Pan Date: 2023-08-01T13:31:24-07:00 New Revision: adece4e452e88f47e1b2b7971286906ae5246fb8 URL: https://github.com/llvm/llvm-project/commit/adece4e452e88f47e1b2b7971286906ae5246fb8 DIFF: https://github.com/llvm/llvm-project/commit/adece4e452e88f47e1b2b7971286906ae5246fb8.diff

[PATCH] D156788: [clang][dataflow] Rename `AggregateStorageLocation` to `RecordStorageLocation` and `StructValue` to `RecordValue`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ecdbe3855a8: [clang][dataflow] Rename `AggregateStorageLocation` to `RecordStorageLocation`… (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D156788?vs=546021=546201#toc

[clang] 9ecdbe3 - [clang][dataflow] Rename `AggregateStorageLocation` to `RecordStorageLocation` and `StructValue` to `RecordValue`.

Author: Martin Braenne Date: 2023-08-01T20:29:40Z New Revision: 9ecdbe3855a8048989a507ff8d470aee4d407589 URL: https://github.com/llvm/llvm-project/commit/9ecdbe3855a8048989a507ff8d470aee4d407589 DIFF: https://github.com/llvm/llvm-project/commit/9ecdbe3855a8048989a507ff8d470aee4d407589.diff

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

thetruestblue updated this revision to Diff 546199. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156718/new/ https://reviews.llvm.org/D156718 Files: clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/ToolChains/Darwin.cpp compiler-rt/test/asan_abi/CMakeLists.txt

[clang] 63c648f - [Driver][test] Add --rocm-path or -nogpuinc/-nogpulib to some AMDGPU tests

Author: Fangrui Song Date: 2023-08-01T13:16:01-07:00 New Revision: 63c648f46dff8d21ade2b77515579b29421b5b69 URL: https://github.com/llvm/llvm-project/commit/63c648f46dff8d21ade2b77515579b29421b5b69 DIFF: https://github.com/llvm/llvm-project/commit/63c648f46dff8d21ade2b77515579b29421b5b69.diff

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

craig.topper added a comment. In D155145#4551526 , @anna wrote: > In D155145#4544068 , @pengfei wrote: > >> In D155145#4543326 , @anna wrote: >> >>> We see a crash

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. (I snipped off earlier context because it was starting to get hard to read.) In D155809#4550727 , @danlark wrote: > Okay, but I still don't understand how I can satisfy the following conditions > at the same time > > -

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

jansvoboda11 added a subscriber: benlangmuir. jansvoboda11 added a comment. CC @benlangmuir, since we've talked about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156749/new/ https://reviews.llvm.org/D156749

[PATCH] D156790: [clang][dataflow] Remove deprecated `Strict` accessors.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c1a519ee423: [clang][dataflow] Remove deprecated `Strict` accessors. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156790/new/

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

jansvoboda11 added a comment. > And it is build system's responsibility to provide `-ivfsoverlay` options > that don't cause observable differences. I wasn't aware of that. Do we document this anywhere? It surprises me that we'd impose such restriction on the build system. This seems fairly

[clang] 8c1a519 - [clang][dataflow] Remove deprecated `Strict` accessors.

Author: Martin Braenne Date: 2023-08-01T20:07:00Z New Revision: 8c1a519ee423f4097092095a44ba850bf0dd498d URL: https://github.com/llvm/llvm-project/commit/8c1a519ee423f4097092095a44ba850bf0dd498d DIFF: https://github.com/llvm/llvm-project/commit/8c1a519ee423f4097092095a44ba850bf0dd498d.diff

[clang] 8a9c51c - [Driver][test] Remove hipBundled before %clang

Author: Fangrui Song Date: 2023-08-01T12:55:00-07:00 New Revision: 8a9c51cdbb6d68a5526e4636090ee52ee3cf38f7 URL: https://github.com/llvm/llvm-project/commit/8a9c51cdbb6d68a5526e4636090ee52ee3cf38f7 DIFF: https://github.com/llvm/llvm-project/commit/8a9c51cdbb6d68a5526e4636090ee52ee3cf38f7.diff

[clang] b314d05 - [Driver][test] Remove invalid -fuse-ld=wasm-ld

Author: Fangrui Song Date: 2023-08-01T12:52:49-07:00 New Revision: b314d057e717b12d645b1a7542b2918e8c176a37 URL: https://github.com/llvm/llvm-project/commit/b314d057e717b12d645b1a7542b2918e8c176a37 DIFF: https://github.com/llvm/llvm-project/commit/b314d057e717b12d645b1a7542b2918e8c176a37.diff

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jhuber6 added a comment. In D156816#4551500 , @jdoerfert wrote: > Macros seems to be good enough. If we really need clang attributes, we need > new docs, and naming convention etc. Yeah an alternative would be a new set of attributes, then we make the

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1807 + + // Do not emit checks for disabled sanitizers to support recover + SmallVector, 2> Checks; recover -> recovery? Period at the end of the comment Repository: rG LLVM

[PATCH] D156192: [-Wunsafe-buffer-usage] Stop generating incorrect fix-its for variable declarations with unsupported specifiers

ziqingluo-90 added a comment. > Note that your patch doesn't actually address //type// attributes, only > //declaration// attributes. It does not address type attribute. We can address it in a follow-up patch. > So it's likely that we have to give up on unsupported type attributes very >

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; hubert.reinterpretcast

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. In D155145#4544068 , @pengfei wrote: > In D155145#4543326 , @anna wrote: > >> We see a crash bisected to this patch about using an illegal instruction. >> Here's the CPUInfo for the

[PATCH] D156781: Use the canonical path for the include header search.

felberj added a comment. Thanks a lot for your notes! Unfortunately I noticed that while the test that I created passed, my actual issue [0] still persists and I sent out the change too early. It seems you are right and the symlink handling is in fact more nuanced. Enjoy your vacation! I will

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jdoerfert added a comment. In D156816#4551417 , @jhuber6 wrote: > In D156816#4551409 , @Anastasia > wrote: > >> Why not to just use target address space and define it to some macro with >> desirable spelling?

[clang] 59a57ca - [clang][deps] NFC: Convert test to split-file

Author: Jan Svoboda Date: 2023-08-01T12:27:14-07:00 New Revision: 59a57ca6d3e801a90dcef7b4216f6baca6ca99b8 URL: https://github.com/llvm/llvm-project/commit/59a57ca6d3e801a90dcef7b4216f6baca6ca99b8 DIFF: https://github.com/llvm/llvm-project/commit/59a57ca6d3e801a90dcef7b4216f6baca6ca99b8.diff

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

cpsughrue updated this revision to Diff 546182. cpsughrue added a comment. Update llvm-lit test to use split-file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156234/new/ https://reviews.llvm.org/D156234 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! In D156201#4551332 , @danix800 wrote: > In D156201#4551270 , @steakhal > wrote: > >>

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jhuber6 added a comment. In D156816#4551409 , @Anastasia wrote: > Why not to just use target address space and define it to some macro with > desirable spelling? > > I don't think renaming OpenCL address space to something else makes sense. It > might

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

arsenm added a comment. In D156816#4551409 , @Anastasia wrote: > Why not to just use target address space and define it to some macro with > desirable spelling? If you mean the numbered address spaces, that's the broken thing this is specifically

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 added a comment. Hi @ziqingluo-90 ! I don't have commit privileges, could you commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814 ___ cfe-commits mailing list

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

Anastasia added a comment. In D156816#4551357 , @jhuber6 wrote: > In D156816#4551338 , @yaxunl wrote: > >>> FFI isn't the reason you'd use these, it's for generic access to the actual >>> backend. E.g. an

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

cpsughrue added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482 + bool Success = false; + if (FinalCommandLine[1] == "-cc1") { +Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr,

[clang] eb8c4b1 - [clang][deps] NFC: Convert test to split-file

Author: Jan Svoboda Date: 2023-08-01T11:48:25-07:00 New Revision: eb8c4b1d0f6154704af669c3f2f7514cb921 URL: https://github.com/llvm/llvm-project/commit/eb8c4b1d0f6154704af669c3f2f7514cb921 DIFF: https://github.com/llvm/llvm-project/commit/eb8c4b1d0f6154704af669c3f2f7514cb921.diff

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:291 + /// the frontend. + OpenMPDirectiveKind PrevMappedDirective = llvm::omp::OMPD_unknown; + koops wrote: > ABataev wrote: > > I don't see where this field is stored/loaded for

[PATCH] D156792: [Driver] Fix test usages of --rtlib= without --unwindlib=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5ca1602f641: [Driver] Fix test usages of --rtlib= without --unwindlib= (authored by abrachet). Herald added a project: clang. Herald added a

[clang] d5ca160 - [Driver] Fix test usages of --rtlib= without --unwindlib=

Author: Alex Brachet Date: 2023-08-01T18:39:40Z New Revision: d5ca1602f64114f612ad5630f04e4aa90591c78d URL: https://github.com/llvm/llvm-project/commit/d5ca1602f64114f612ad5630f04e4aa90591c78d DIFF: https://github.com/llvm/llvm-project/commit/d5ca1602f64114f612ad5630f04e4aa90591c78d.diff LOG:

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:291 + /// the frontend. + OpenMPDirectiveKind PrevMappedDirective = llvm::omp::OMPD_unknown; + ABataev wrote: > I don't see where this field is stored/loaded for PCH support. You

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

arsenm updated this revision to Diff 546164. arsenm retitled this revision from "[wip] clang/OpenCL: Add inline implementations of sqrt in builtin header" to "clang/OpenCL: Add inline implementations of sqrt in builtin header". arsenm edited the summary of this revision. arsenm added a comment.

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jhuber6 added a comment. In D156816#4551338 , @yaxunl wrote: >> FFI isn't the reason you'd use these, it's for generic access to the actual >> backend. E.g. an `addrspace(3)` global is local memory, if it's external >> it's dynamic. Having these named

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 546159. koops added a comment. 1. clang/test/OpenMP/loop_bind_enclosed.cpp : Converting main and function names within it to use regular expressions to accomodate windows platform. 2. i) Instead of calling setMappedDirective() after the the creation of the

  1   2   3   >