[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

nridge created this revision. nridge added reviewers: sammccall, hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

dexonsmith added a comment. In D158137#4597565 , @MaskRay wrote: > In D158137#4597491 , @dexonsmith > wrote: > >> In D158137#4597009 , @MaskRay >> wrote: >> >>> In

[clang] af7231d - [RISCV] Make the order of tests in riscv-target-features.c eqaul to the extensions listed in the table in RISCVISAInfo.cpp. NFC.

Author: Jim Lin Date: 2023-08-18T12:56:12+08:00 New Revision: af7231d1835b3dbfd938c7fdff8188ce49a3b58b URL: https://github.com/llvm/llvm-project/commit/af7231d1835b3dbfd938c7fdff8188ce49a3b58b DIFF: https://github.com/llvm/llvm-project/commit/af7231d1835b3dbfd938c7fdff8188ce49a3b58b.diff LOG:

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

HerrCai0907 updated this revision to Diff 551379. HerrCai0907 added a comment. update release-note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158244/new/ https://reviews.llvm.org/D158244 Files:

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd74186f1a08: [clangd] Avoid passing -xobjective-c++-header to the system include extractor (authored by nridge). Repository: rG LLVM Github

[clang-tools-extra] bd74186 - [clangd] Avoid passing -xobjective-c++-header to the system include extractor

Author: Nathan Ridge Date: 2023-08-18T00:40:11-04:00 New Revision: bd74186f1a0831b2c596e87ea056419379a223c1 URL: https://github.com/llvm/llvm-project/commit/bd74186f1a0831b2c596e87ea056419379a223c1 DIFF: https://github.com/llvm/llvm-project/commit/bd74186f1a0831b2c596e87ea056419379a223c1.diff

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

nridge updated this revision to Diff 551377. nridge added a comment. Rebase and address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147905/new/ https://reviews.llvm.org/D147905 Files:

[PATCH] D158246: [amdgpu] WIP variadics

JonChesterfield added inline comments. Comment at: llvm/lib/CodeGen/ExpandVAIntrinsics.cpp:159 +// conventions. Escape analysis on va_list values. +return false; + } Cut this from the WIP patch as the draft is noisy. Ran some tests through x64 with a

[PATCH] D157879: [clang] Report missing designated initializers in C++

tbaeder added a comment. In D157879#4595058 , @Fznamznon wrote: > In D157879#4594790 , @tbaeder wrote: > >> Tangentially related: Now that we have this `InitializedFields` set, would >> it be easy to add a

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

bnbarham added inline comments. Comment at: clang/test/Index/annotate-comments-objc.m:67-74 +#define DECLARE_ENUMS(name) \ + /** enumFromMacro IS_DOXYGEN_SINGLE */ \ + enum enumFromMacro { A }; \ + /** namedEnumFromMacro IS_DOXYGEN_SINGLE */ \ + enum name { B }; + +///

[PATCH] D157952: [clang] Support function pointer types with attributes when extracting parameter names for signature help

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9cb76bc4d5e: [clang] Support function pointer types with attributes when extracting… (authored by nridge). Repository: rG LLVM Github Monorepo

[clang-tools-extra] d9cb76b - [clang] Support function pointer types with attributes when extracting parameter names for signature help

Author: Nathan Ridge Date: 2023-08-18T00:27:15-04:00 New Revision: d9cb76bc4d5e903fe045c58a42fc791d0c70172b URL: https://github.com/llvm/llvm-project/commit/d9cb76bc4d5e903fe045c58a42fc791d0c70172b DIFF: https://github.com/llvm/llvm-project/commit/d9cb76bc4d5e903fe045c58a42fc791d0c70172b.diff

[PATCH] D157952: [clang] Support function pointer types with attributes when extracting parameter names for signature help

nridge updated this revision to Diff 551374. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157952/new/ https://reviews.llvm.org/D157952 Files:

[PATCH] D158246: [amdgpu] WIP variadics

JonChesterfield added a comment. The lowering pass is broadly right, missing a few edge cases. Comment at: libc/config/gpu/entrypoints.txt:88 +libc.src.stdio.vsnprintf libc.src.stdio.puts libc.src.stdio.fopen ^these try to build, but fail. I

[PATCH] D158247: [CUDA][HIP] Fix overloading resolution in global variable initializer

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, rsmith. Herald added subscribers: mattd, carlosgalvezp, kerbowa, jvesely. Herald added a reviewer: aaron.ballman. Herald added a project: All. yaxunl requested review of this revision. Currently, clang does not resolve certain

[PATCH] D158246: [amdgpu] WIP variadics

JonChesterfield created this revision. Herald added subscribers: libc-commits, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm. Herald added projects: libc-project, All. JonChesterfield requested review of this revision. Herald added subscribers: llvm-commits,

[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29f11e4fb704: [RISCV] Bump vector crypto to v1.0 RC2 (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 29f11e4 - [RISCV] Bump vector crypto to v1.0 RC2

Author: 4vtomat Date: 2023-08-17T21:19:59-07:00 New Revision: 29f11e4fb704ffe24c01204b035b2fe117bda7c1 URL: https://github.com/llvm/llvm-project/commit/29f11e4fb704ffe24c01204b035b2fe117bda7c1 DIFF: https://github.com/llvm/llvm-project/commit/29f11e4fb704ffe24c01204b035b2fe117bda7c1.diff LOG:

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc updated this revision to Diff 551367. wangpc added a comment. Rebase and fix failed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files:

[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158067/new/ https://reviews.llvm.org/D158067

[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

4vtomat updated this revision to Diff 551364. 4vtomat added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158067/new/

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:191 + ` check + to ignore predefined expression (e.g., __func__, ...). + Please enclose `__func__` in double back-ticks. Repository: rG LLVM Github Monorepo

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

HerrCai0907 created this revision. HerrCai0907 added reviewers: njames93, PiotrZSL, aaron.ballman, Eugene.Zelenko. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project:

[PATCH] D157485: [X86][RFC] Support new feature AVX10

e-kud added a comment. Just curious, in RFC we have `-mavx10.x-256/-mavx10.x-512` but here we refer to `-mavx10.x/-mavx10.x,-mavx10-512bit`. Is it compliant with GCC, or the revision is just for the illustrative purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge added a reviewer: sammccall. nridge added a comment. Adding Sam, since you're on a review roll ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149236/new/ https://reviews.llvm.org/D149236 ___

[PATCH] D158242: [Clang][Attribute] Introduce linkage attribute to specify the exact LLVM linkage type for functions or variables

strimo378 created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158242 Files:

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

MaskRay added a comment. In D158137#4597491 , @dexonsmith wrote: > In D158137#4597009 , @MaskRay wrote: > >> In D158137#4596948 , @dexonsmith >> wrote: >> >>> Can you

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: RKSimon wrote: > FreddyYe wrote: > > RKSimon wrote: > > > Why not handle this above (below tremont) as the next

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe updated this revision to Diff 551350. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158046/new/ https://reviews.llvm.org/D158046 Files:

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. In D86310#4597359 , @hvdijk wrote: >> I cannot reproduce that failure for some reason, but it would likely make a >> good run-pass test. > > It's reproducible online, https://godbolt.org/z/j918EeoMv, it would be > interesting to

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao added inline comments. Comment at: clang/test/CodeGenCXX/data_member_packs.cpp:73 + // CHECK: i32 @_Z3sumIJiiEEDaDpT_(i32 noundef %ts, i32 noundef %ts1) + sum_pack2(s6); + // Check instantiation of sum(int, long, float, double) cjdb wrote: > This

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao updated this revision to Diff 551348. SlaterLatiao marked an inline comment as done. SlaterLatiao added a comment. - Added test case for partial expansion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158006/new/

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

MaskRay added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s shenhan wrote: > MaskRay wrote:

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added a comment. Some nits. I'm assuming we're getting the code object in the backend now? We'll need to make sure that `-Wl,--amdhsa-code-object-version` is passed to the clang invocation inside of the `clang-linker-wrapper` to handle `-save-temps` mode. Comment

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 updated this revision to Diff 551344. HerrCai0907 added a comment. update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files:

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

dexonsmith added a comment. In D158137#4597009 , @MaskRay wrote: > In D158137#4596948 , @dexonsmith > wrote: > >> Can you explain the downside of leaving behind an alias? > > Two minor ones. (a) Existing

[clang] e03686f - Revert "[clang][Interp] Make sure we push integers of the correct size"

Author: Vitaly Buka Date: 2023-08-17T18:12:02-07:00 New Revision: e03686f4a399d7ebe8452d510452a72384261eaf URL: https://github.com/llvm/llvm-project/commit/e03686f4a399d7ebe8452d510452a72384261eaf DIFF: https://github.com/llvm/llvm-project/commit/e03686f4a399d7ebe8452d510452a72384261eaf.diff

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

vitalybuka added a comment. Reverted with D155568 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 ___ cfe-commits mailing

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao marked 4 inline comments as done. SlaterLatiao added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:4171 + if (CXXDependentScopeMemberExpr *MemberExpr = + dyn_cast(Pattern)) { dblaikie wrote: > Might be worth pulling

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao updated this revision to Diff 551342. SlaterLatiao added a comment. - Make transforming expressions for member packs a separate function. - Minor edits based on review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158006/new/

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

evelez7 added a comment. Note that this doesn't handle anonymous namespaces. Similar problems arise with anonymous classes/structs, being worked on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158239/new/ https://reviews.llvm.org/D158239

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

evelez7 updated this revision to Diff 551340. evelez7 added a comment. Remove unnecessary line break. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158239/new/ https://reviews.llvm.org/D158239 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Serialize namespaces, nested namespaces, and class

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao updated this revision to Diff 551337. SlaterLatiao added a comment. - Minor fix on comment. - Replace string '+' with Twine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158006/new/ https://reviews.llvm.org/D158006 Files:

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s MaskRay wrote: > `-target ` has

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551332. shenhan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

hvdijk added a comment. In D86310#4596932 , @tmgross wrote: > Was your failure in https://bugs.llvm.org/show_bug.cgi?id=50198 fixed with > these patches? Yes, it was (at least it was at the time that I initially commented). > I cannot reproduce that

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

jyu2 created this revision. jyu2 added reviewers: asmith, tentzen, rnk, efriedma, pengfei. jyu2 added a project: clang. Herald added a project: All. jyu2 requested review of this revision. When return out of __try block. In this test case, currently "false" is passed to the OutlinedFinally call,

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 551323. AntonRydahl added a comment. Avoided changing clang/lib/Frontend/CompilerInvocation.cpp by performing checks for OpenMP offloading to GPU devices in Sema instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ac9a76d - Revert "[-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code"

Author: Ziqing Luo Date: 2023-08-17T16:42:30-07:00 New Revision: ac9a76d7487b9af1ace626eb90064194cb12c53d URL: https://github.com/llvm/llvm-project/commit/ac9a76d7487b9af1ace626eb90064194cb12c53d DIFF: https://github.com/llvm/llvm-project/commit/ac9a76d7487b9af1ace626eb90064194cb12c53d.diff

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

MaskRay added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s `-target ` has been deprecated

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG843784764ab5: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code (authored by ziqingluo-90). Changed prior to commit:

[clang] 8437847 - [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

Author: Ziqing Luo Date: 2023-08-17T16:24:47-07:00 New Revision: 843784764ab58e35f8aa2da97f07dc5e810f4bcb URL: https://github.com/llvm/llvm-project/commit/843784764ab58e35f8aa2da97f07dc5e810f4bcb DIFF: https://github.com/llvm/llvm-project/commit/843784764ab58e35f8aa2da97f07dc5e810f4bcb.diff

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added a comment. Thanks all. Created D158231 to address the post-submit comments and added all as reviewers. @MaskRay @Hahnfeld @steelannelida Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan created this revision. shenhan added reviewers: MaskRay, Hahnfeld, steelannelida. Herald added subscribers: mattd, asavonic. Herald added a project: All. shenhan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D158113: [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5c8dea1e1d: [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug) (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] be5c8de - [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug)

Author: Justin Bogner Date: 2023-08-17T16:19:09-07:00 New Revision: be5c8dea1e1de5df98df656c6e4c92a3f6682661 URL: https://github.com/llvm/llvm-project/commit/be5c8dea1e1de5df98df656c6e4c92a3f6682661 DIFF: https://github.com/llvm/llvm-project/commit/be5c8dea1e1de5df98df656c6e4c92a3f6682661.diff

[PATCH] D158112: [-Wunsafe-buffer-usage] Fix assertion failure in case of BindingDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2afcda693acb: [-Wunsafe-buffer-usage] Fix assertion failure in case of BindingDecl (authored by t-rasmud). Herald added a project: clang. Herald

[clang] 2afcda6 - [-Wunsafe-buffer-usage] Fix assertion failure in case of BindingDecl

Author: Rashmi Mudduluru Date: 2023-08-17T16:18:38-07:00 New Revision: 2afcda693acba8d63887a6bb0605038b1563c64c URL: https://github.com/llvm/llvm-project/commit/2afcda693acba8d63887a6bb0605038b1563c64c DIFF:

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

NoQ accepted this revision. NoQ added a comment. LGTM! I have minor suggestions for comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1791-1794 // For a `VarDecl` of the form `T * var (= Init)?`, this -// function generates a fix-it for the declaration, which

[PATCH] D158155: [clang-format] Exclude kw_decltype in RemoveParentheses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3a79503a30f: [clang-format] Exclude kw_decltype in RemoveParentheses (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] e3a7950 - [clang-format] Exclude kw_decltype in RemoveParentheses

Author: Owen Pan Date: 2023-08-17T16:04:44-07:00 New Revision: e3a79503a30f8c9d8fba79f3e5427bb895f320cf URL: https://github.com/llvm/llvm-project/commit/e3a79503a30f8c9d8fba79f3e5427bb895f320cf DIFF: https://github.com/llvm/llvm-project/commit/e3a79503a30f8c9d8fba79f3e5427bb895f320cf.diff

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

smeenai added a comment. Conceptually this seems like a great direction to go in. We should just leave it up for a while so that anyone using these can comment on any potential issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158218/new/

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

dpaoliello added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2726-2729 +// FIXME: For non-dllimport functions, MSVC emits the same entry +// twice, for reasons I don't understand. I have to assume the linker +// ignores the

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

arsenm added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:438-446 + ConstantInt *getIntPtrSize(Value *Ptr, uint64_t Size) { +assert(BB && "Must have a basic block to retrieve the module!"); + +Module *M = BB->getParent()->getParent(); +auto *PtrType

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Herald added a project: All. I think any size type should be valid for the intrinsic. Legalization should have to cast the type to the target libcall if that's how it chooses to

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2719 + Strategy NaiveStrategy = getNaiveStrategy( + llvm::make_range(VisitedVars.begin(), VisitedVars.end())); VariableGroupsManagerImpl VarGrpMgr(Groups, VarGrpMap, GrpsUnionForParms);

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

Manna created this revision. Manna added reviewers: RKSimon, aaron.ballman, tahonermann. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/53426 Repository: rG LLVM Github Monorepo

[PATCH] D158188: [clang][AST] TextNodeDumper learned to output friend information for functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG110d141f12b7: [clang][AST] TextNodeDumper learned to output friend information for functions (authored by strimo378). Repository: rG LLVM Github

[clang] 110d141 - [clang][AST] TextNodeDumper learned to output friend information for functions

Author: Timo Stripf Date: 2023-08-17T22:41:41Z New Revision: 110d141f12b71c54005ad0919e18926b8895fd05 URL: https://github.com/llvm/llvm-project/commit/110d141f12b71c54005ad0919e18926b8895fd05 DIFF: https://github.com/llvm/llvm-project/commit/110d141f12b71c54005ad0919e18926b8895fd05.diff LOG:

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman added a comment. > I believe that /Ze has more in common with `-fms-compatibility` than > `-fms-extensions`, but I could be wrong. Also, they may just be completely > different things at this point. `/permissive` is closer in spirit to > `-fms-compatibility`. Better

[PATCH] D158226: [CUDA/NVPTX] Improve handling of memcpy for -Os compilations.

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, bixia, hiraditya, yaxunl. Herald added a project: All. tra published this revision for review. tra added a reviewer: alexfh. Herald added subscribers: llvm-commits, cfe-commits, wangpc, jholewinski. Herald added

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

MaskRay added a comment. In D158137#4596948 , @dexonsmith wrote: > Can you explain the downside of leaving behind an alias? Two minor ones. (a) Existing `-Wno-overriding-t-option` will not notice that they need to migrate and (b) Clang has accrued

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

rnk added a comment. > Also assuming that /Ze is similar to our -fms-extensions which I believe is > the case, but not completely sure I believe that /Ze has more in common with `-fms-compatibility` than `-fms-extensions`, but I could be wrong. Also, they may just be completely different

[PATCH] D156188: [-Wunsafe-buffer-usage] Refactor and improve for parameter fix-its

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked 2 inline comments as done. Closed by commit rG41279e870fa5: [-Wunsafe-buffer-usage] Refactor and improve for parameter fix-its (authored by

[clang] 41279e8 - [-Wunsafe-buffer-usage] Refactor and improve for parameter fix-its

Author: Ziqing Luo Date: 2023-08-17T15:27:38-07:00 New Revision: 41279e870fa577f8a7f7030b8e45da250d0def9e URL: https://github.com/llvm/llvm-project/commit/41279e870fa577f8a7f7030b8e45da250d0def9e DIFF: https://github.com/llvm/llvm-project/commit/41279e870fa577f8a7f7030b8e45da250d0def9e.diff

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added a comment. merging doesn't have to be done at link time, the optimizer can also do it. so I'd rule out any names with `icf` since that's specifically the name of a linker feature `no_unique_address` popped into my mind but that's already taken :). that's exactly what this is

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

dexonsmith added a comment. Can you explain the downside of leaving behind an alias? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158137/new/ https://reviews.llvm.org/D158137 ___ cfe-commits mailing

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. Was your failure in https://bugs.llvm.org/show_bug.cgi?id=50198 fixed with these patches? I cannot reproduce that failure for some reason, but it would likely make a good run-pass test. These two patches do not seem to fix varargs segfaulting, as documented in

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

rnk added a comment. So, I'm strongly in favor of the feature, but I want to get feedback on the name. The major pro is that it maps directly to LLVM IR: the attribute does exactly what it says. The major con is that the name isn't really related to what the user wants to do, which is to

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 abandoned this revision. strimo378 added a comment. Alright, thank you for the review... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158055/new/ https://reviews.llvm.org/D158055 ___

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added a comment. and naming can be bikeshed. `no_addrsig` follows https://llvm.org/docs/Extensions.html#sht-llvm-addrsig-section-address-significance-table, `unnamed_addr` follows the IR attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added a comment. unsure if this should have an RFC or not will add release notes if this is ok to go ahead with Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158223/new/ https://reviews.llvm.org/D158223

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This simply marks the global with the `unnamed_addr` IR attribute so it be merged

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman added a comment. In D157334#4596328 , @rnk wrote: > I don't think this is the right thing to do, I think I recall saying as much > on some other review. The MSVC docs >

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. In D86310#4596730 , @hvdijk wrote: > My understanding is that the code clang generates for `__int128` will still > allow it to be passed half-in-register, half-in-memory, exactly what D158169 >

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

MaskRay created this revision. MaskRay added reviewers: DavidSpickett, phosek, smeenai, tra, tstellar. Herald added subscribers: ekilmer, s.egerton, abidh, PkmX, atanasyan, simoncook, fedor.sergeev, kristof.beyls, krytarowski, arichardson, sdardis, emaste. Herald added a project: All. MaskRay

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

hvdijk added a comment. In D86310#4596712 , @tmgross wrote: > Is clang still doing something wrong? From my testing, it seems like clang > and GCC now agree with each other, I am not sure what would still be incorrect My understanding is that the code

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17143-17145 + llvm::LoadInst *LD; + Constant *Offset, *Offset1; + Value *DP, *DP1; arsenm wrote: > Move down to define and initialize There are multiple uses of the same identifier.

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 551266. saiislam marked 6 inline comments as done. saiislam added a comment. Updated the patch as per reviewers comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. Is clang still doing something wrong? From my testing, it seems like clang and GCC now agree with each other, I am not sure what would still be incorrect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86310/new/

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty added a comment. The crashes in complex-deinterleaving-f16-mul.ll and fp16_intrinsic_lane.ll seem to be caused by D156831 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

erichkeane added a comment. still on vaca, but doing a drive-by. Comment at: clang/include/clang/Basic/Attr.td:1798 +def NoUniqueAddressMSVC : InheritableAttr, TargetSpecificAttr { + let Spellings = [CXX11<"msvc", "no_unique_address", 201803>]; + let Subjects =

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao updated this revision to Diff 551253. SlaterLatiao marked 2 inline comments as done. SlaterLatiao added a comment. Remove changes in D156546 which doesn't belong to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao marked 6 inline comments as done. SlaterLatiao added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:523-524 + auto *TD = TST->getTemplateName().getAsTemplateDecl(); + assert(isa(TD) && + "template decl in member access is not

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao updated this revision to Diff 551249. SlaterLatiao added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158006/new/ https://reviews.llvm.org/D158006 Files: clang/include/clang/AST/ExprCXX.h

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. Herald added a subscriber: sunshaoce. In D146054#4587210 , @4vtomat wrote: > In D146054#4586067 , @MaskRay wrote: > >> I think the best place to test `RISCVISAInfo.cpp` is >>

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

akhuang updated this revision to Diff 551242. akhuang marked an inline comment as done. akhuang added a comment. Herald added a reviewer: shafik. Add function to check for no_unique_address attributes Some changes to layout code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

akhuang added inline comments. Comment at: clang/lib/AST/Decl.cpp:4523-4524 bool FieldDecl::isPotentiallyOverlapping() const { - return hasAttr() && getType()->getAsCXXRecordDecl(); + return (hasAttr() || + hasAttr()) && + getType()->getAsCXXRecordDecl();

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

MaskRay added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:16 +// causes a warning. +// RUN: %clang --target=x86_64-unknown-linux-gnu -nogpulib -nogpuinc \ +// RUN: --cuda-gpu-arch=sm_70 -x cuda -fsplit-machine-functions -S %s

  1   2   3   >