[PATCH] D31260: [libc++] Work around C1XX bug which breaks poisoned hash tests.

BillyONeal accepted this revision. BillyONeal added a comment. This revision is now accepted and ready to land. I mean, looks good to me, but you really don't need to go there :). (Though you might want something like this anyway if you try libc++ with MSVC++ on Windows...)

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

BillyONeal added a comment. In https://reviews.llvm.org/D32265#732657, @jfb wrote: > It looks like Billy is going to do something somewhat similar when he > rewrites it: https://twitter.com/jfbastien/status/855168230918307840 > For now it's kinda `#define IS_LOCK_FREE ¯\_(ツ)_/¯` Note that my

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

BillyONeal added a comment. In https://reviews.llvm.org/D32265#731709, @jfb wrote: > Is it a goal to support Microsoft's STL with this? If so, how does MSVC's STL > implement `is_always_lock_free` at the moment? CL 19 2017 RTW doesn't seem to > have anything ?

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

BillyONeal added a comment. (sorry for double post) And of course since you folks don't care about supporting pre-Vista you probably also don't care about supporting Opterons from 2005, in which case you'd want unconditional cmpxchg16b on amd64 :). In our next major version I added a

[PATCH] D32307: [libcxx] [test] Resolve everyone's favorite warning, unused local typedef

BillyONeal closed this revision. BillyONeal added a comment. Committed r300937 https://reviews.llvm.org/D32307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

BillyONeal added inline comments. Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:46 +std::gcd(static_cast(0), static_cast(0)))>::value, ""); +const bool result = static_cast>(out) == +

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

BillyONeal updated this revision to Diff 96231. BillyONeal added a comment. Stephan had some code review comments :) https://reviews.llvm.org/D32309 Files: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp test/std/numerics/numeric.ops/numeric.ops.lcm/lcm.pass.cpp Index:

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

BillyONeal added a comment. Hi folks, any update on this or is just fixing @rsmith's comment OK? Thanks! https://reviews.llvm.org/D32309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32574: [libcxx] [test] Fixed possible loss of data warnings in tests on amd64

BillyONeal created this revision. In T_size_size.pass, there is an explicit template argument to std::min to ask for unsigned, to avoid type deduction errors. However, C1XX' warnings still hate this use, because a 64 bit value (a size_t) is being passed to a function accepting an unsigned (a 32

[PATCH] D33021: [libcxx] [test] libc++ test changes for CWG 2094

BillyONeal updated this revision to Diff 98506. BillyONeal added a comment. Added spaces requested by Marshal. https://reviews.llvm.org/D33021 Files: test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp Index:

[PATCH] D33021: [libcxx] [test] libc++ test changes for CWG 2094

BillyONeal added a comment. In https://reviews.llvm.org/D33021#750831, @mclow.lists wrote: > FWIW, I think this is a language change that core got wrong, and it has > already come back to bite us. (https://bugs.llvm.org/show_bug.cgi?id=28527) Hmm we actually took steps to do the opposite

[PATCH] D33021: [libcxx] [test] libc++ test changes for CWG 2094

BillyONeal added a comment. In https://reviews.llvm.org/D33021#751145, @BillyONeal wrote: > Hmm we actually took steps to do the opposite in std::copy -- to use > memcpy even in the presence of volatile -- as a result of this change. ;) http://imgur.com/a/PMKPS

[PATCH] D33021: [libcxx] [test] libc++ test changes for CWG 2094

BillyONeal created this revision. Update is_trivially_copyable tests with CWG 2094 Clang 5.0 implements this here: https://github.com/llvm-mirror/clang/commit/87cd035326a39523eeb1b295ad36cff337141ef9 MSVC++ will implement it in the first toolset update for VS 2017.

[PATCH] D33021: [libcxx] [test] libc++ test changes for CWG 2094

BillyONeal updated this revision to Diff 98376. BillyONeal added a comment. Bill got confused. https://reviews.llvm.org/D33021 Files: test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp Index:

[PATCH] D33021: [libcxx] [test] libc++ test changes for CWG 2094

BillyONeal added inline comments. Comment at: test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp:25 + #define IMPLEMENTS_CWG_2094 false + #endif /* defined(_MSC_VER) && _MSC_VER >= 1911 */ +#endif Whoops, I fat fingered the

[PATCH] D33021: [libcxx] [test] libc++ test changes for CWG 2094

BillyONeal updated this revision to Diff 98370. BillyONeal edited the summary of this revision. BillyONeal added a comment. Eric asked to just nuke the offending lines. https://reviews.llvm.org/D33021 Files: test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp

[PATCH] D33340: [libcxx] [test] Add string nullptr asserts to erase functions.

BillyONeal created this revision. In my perf overhaul for MSVC++'s basic_string I wrote the null at data[oldsize] instead of data[newsize]; adding asserts to catch that bug. https://reviews.llvm.org/D33340 Files: test/std/strings/basic.string/string.modifiers/string_erase/iter.pass.cpp

[PATCH] D33708: [test] [libcxx] Disable MSVC++'s compare(a, b) implies !compare(b, a) assertion in predicate application count tests

BillyONeal created this revision. Turn off MSVC++'s comp(a, b) implies !comp(b, a) assertion in tests that are checking for predicate counts. There should be no functionality change for libcxx as it does not look for the _ITERATOR_DEBUG_LEVEL macro. While this assert is technically out of

[PATCH] D33708: [test] [libcxx] Disable MSVC++'s compare(a, b) implies !compare(b, a) assertion in predicate application count tests

BillyONeal abandoned this revision. BillyONeal added a comment. Stephan pointed out that the force include breaks this. Backing it out for now :( https://reviews.llvm.org/D33708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32574: [libcxx] [test] Fixed possible loss of data warnings in tests on amd64

BillyONeal added inline comments. Comment at: test/std/strings/basic.string/string.cons/T_size_size.pass.cpp:39 assert(pos <= sv.size()); -unsigned rlen = std::min(sv.size() - pos, n); +unsigned rlen = std::min(static_cast(sv.size()) - pos, n);

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

BillyONeal added inline comments. Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:146 +auto res = std::gcd(static_cast(1234), INT32_MIN); +static_assert(std::is_same>::value, "");

[PATCH] D32574: [libcxx] [test] Fixed possible loss of data warnings in tests on amd64

BillyONeal updated this revision to Diff 98214. BillyONeal marked 4 inline comments as done. BillyONeal edited the summary of this revision. BillyONeal added a comment. Instead, change the tests to pass around std::size_t instances, and explicitly narrow when constructing the string type under

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

BillyONeal added inline comments. Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:42 +constexpr bool test0(int in1, int in2, int out) { +static_assert(std::is_same Nit but this seems much cleaner and

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

BillyONeal updated this revision to Diff 98205. BillyONeal added a comment. Resolved CR comments https://reviews.llvm.org/D32309 Files: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp test/std/numerics/numeric.ops/numeric.ops.lcm/lcm.pass.cpp Index:

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

BillyONeal updated this revision to Diff 98219. BillyONeal marked 2 inline comments as done. BillyONeal edited the summary of this revision. BillyONeal added a comment. Do Eric's suggestions. https://reviews.llvm.org/D32309 Files: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp

[PATCH] D32927: [libc++] Implement exception_ptr on Windows

BillyONeal added inline comments. Comment at: include/exception:192 +#endif +void* __ptr1_; +void* __ptr2_; I hope you realize you are doing "evil" unsupported things :). (We won't go out of our way to break this, but if it does break we won't feel bad

[PATCH] D33340: [libcxx] [test] Add string nullptr asserts to erase functions.

BillyONeal closed this revision. BillyONeal added a comment. In https://reviews.llvm.org/D33340#764206, @EricWF wrote: > Sorry for the delay reviewing such a simple change. No problem! Their simplicity also means no likely merge conflicts :) In https://reviews.llvm.org/D33340#764213, @EricWF

[PATCH] D39080: [libcxx] [test] Tolerate even more [[nodiscard]] in the STL.

BillyONeal created this revision. STL reviewed my [[nodiscard]] changes and suggested a ton more places. These are the associated test changes in libcxx. https://reviews.llvm.org/D39080 Files: test/std/algorithms/alg.nonmodifying/alg.search/search_n.pass.cpp

[PATCH] D39033: [libcxx] [test] Tolerate [[nodiscard]] on STL functions in libcxx tests

BillyONeal created this revision. I applied [[nodiscard]] to lots of things in MSVC++'s STL, which trips up some tests in libcxx. This change adds (void) casts or assertions as necessary to make [[nodiscard]] happy. Repository: rL LLVM https://reviews.llvm.org/D39033 Files:

[PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

BillyONeal created this revision. Added the TEST_IGNORE_NODISCARD macro to `test_macros.h`. grep test/std for (void) casts that look like they're suppressing [[nodiscard]] and change them to TEST_IGNORE_NODISCARD. https://reviews.llvm.org/D40065 Files:

[PATCH] D41372: [libcxx] Fix transform_reduce mishandling move-only types, and nonstandard macro use in tests.

BillyONeal added a comment. Do you folks want me to port this test case for move-only T into libcxx? (I added this to our test harness) Note that discussion on validity is ongoing on lists. #define _SILENCE_PARALLEL_ALGORITHMS_EXPERIMENTAL_WARNING #include #include #include

[PATCH] D41372: [libcxx] Fix transform_reduce mishandling move-only types, and nonstandard macro use in tests.

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. - Remove _VSTD use and remove C++03-isms in C++17 tests for transform_reduce. - Add tests for all the transform_reduce overloads that pass in a move-only type. - Repair missing move in libc++ product code.

[PATCH] D41372: [libcxx] Fix transform_reduce mishandling move-only types, and nonstandard macro use in tests.

BillyONeal added inline comments. Comment at: test/std/numerics/numeric.ops/transform.reduce/transform_reduce_iter_iter_iter_init.pass.cpp:61 +inline MoveOnly operator+(const MoveOnly& lhs, const MoveOnly& rhs) +{ Should these go in MoveOnly.h ? Repository:

[PATCH] D41372: [libcxx] Fix transform_reduce mishandling move-only types, and nonstandard macro use in tests.

BillyONeal added inline comments. Comment at: include/numeric:245 for (; __first1 != __last1; ++__first1, (void) ++__first2) __init = __b1(__init, __b2(*__first1, *__first2)); return __init; It's arguable that this should be

[PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

BillyONeal closed this revision. BillyONeal added a comment. Committed r318804 https://reviews.llvm.org/D40065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40324: [libcxx] [test] Resolve C1XX warning in new vector::size tests caused by assert(true)

BillyONeal closed this revision. BillyONeal added a comment. Committed r318812 https://reviews.llvm.org/D40324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. If a standard library implements LWG 1203 (which I am implementing in MSVC++ right now) the return value of (istringstream() << A{}) is an rvalue, so it can't have an lvalue reference bound to it. Change this

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. I'm not sure if libcxx is asserting UTF-8 here; but on Windows the full char value is always passed through in its entirety, since the default codepage is something like Windows-1252. The replacement character is

[PATCH] D45294: [libcxx] [test] Remove non-portable assertions from filebuf tests

BillyONeal closed this revision. BillyONeal added a comment. D:\msvc\src\qa\VC\Libs\libcxx\upstream>git svn dcommit Committing to https://llvm.org/svn/llvm-project/libcxx/trunk ... Use of uninitialized value $rec in scalar chomp at /mingw64/share/perl5/Git.pm line 557, <$fh> chunk 4.

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

BillyONeal added subscribers: STL_MSFT, BillyONeal. BillyONeal added a comment. @mclow.lists @STL_MSFT Why did tests for this this go into std? [reentrancy]/1 says this isn't required to work. Moreover, assignments in the dtor like this *can't* work in the general case because they would try

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. - These tests use function objects from functional, back_inserter from iterator, and equal from algorithm, so add those headers. - The use of iota targeting vector with an int parameter triggers warnings on

[PATCH] D41372: [libcxx] Fix transform_reduce mishandling move-only types, and nonstandard macro use in tests.

BillyONeal updated this revision to Diff 128695. BillyONeal added a comment. Moved things to MoveOnly.h. https://reviews.llvm.org/D41372 Files: include/numeric test/std/numerics/numeric.ops/transform.reduce/transform_reduce_iter_iter_init_bop_uop.pass.cpp

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

BillyONeal updated this revision to Diff 128836. BillyONeal marked 3 inline comments as done. BillyONeal added a comment. Also change predicate from identity to add_ten. https://reviews.llvm.org/D41748 Files: test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

BillyONeal added a comment. > I hate your compiler. Seems like a valid warning to me :) Changed predicate to one that adds 10 to each input. https://reviews.llvm.org/D41748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added a comment. In https://reviews.llvm.org/D50549#1194852, @EricWF wrote: > We should add some TSAN folks to this review, since I think these are also > TSAN false negatives; perhaps correctly, perhaps not. Do you know who that is / can you add them?

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal updated this revision to Diff 159632. BillyONeal added a comment. Remove comma. https://reviews.llvm.org/D50421 Files: test/std/utilities/template.bitset/includes.pass.cpp Index: test/std/utilities/template.bitset/includes.pass.cpp

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal closed this revision. BillyONeal marked 2 inline comments as done. BillyONeal added a comment. Committed r339212 https://reviews.llvm.org/D50421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50420: [libcxx] [test] Add missing to several tests.

BillyONeal closed this revision. BillyONeal added a comment. Committed r339209 https://reviews.llvm.org/D50420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. [template.bitset] says only that and are included by , but libcxx tests are asserting that and are also included. Note that libcxx's nonstandard assertion of this is already handled by

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal added inline comments. Comment at: test/std/utilities/template.bitset/includes.pass.cpp:11 +// test that includes , and #include template void test_typedef() {} Quuxplusone wrote: > grammar nit: comma NP: Oxford Comma by Vampire Weekend

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

BillyONeal added a comment. Committed r339213 (If there are changes requested I'll do them in a follow up commit) https://reviews.llvm.org/D47395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

BillyONeal added a reviewer: ldionne. BillyONeal added a comment. Adding ldionne as suggested by Eric. https://reviews.llvm.org/D47395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

BillyONeal added a reviewer: ldionne. BillyONeal added a comment. Adding ldionne as suggested by Eric. https://reviews.llvm.org/D47400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50420: [libcxx] [test] Add missing to several tests.

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. https://reviews.llvm.org/D50420 Files: test/std/strings/basic.string/string.capacity/over_max_size.pass.cpp test/std/strings/string.conversions/stod.pass.cpp test/std/strings/string.conversions/stof.pass.cpp

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

BillyONeal added a comment. Committed r339214 (If there are changes requested I'll do them in a follow up commit) https://reviews.llvm.org/D47400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:75 assert(G::op_run); assert(G::n_alive == 1); } Actually I just realized that this assert is bogus too;

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); BillyONeal wrote: > dvyukov wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); dvyukov wrote: > BillyONeal wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); dvyukov wrote: > BillyONeal wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal updated this revision to Diff 160498. BillyONeal edited the summary of this revision. BillyONeal added a comment. Remove changes to detach tests. https://reviews.llvm.org/D50549 Files: test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp Index:

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); dvyukov wrote: > BillyONeal wrote: >

[PATCH] D50551: [libcxx] [test] Add missing to several tests.

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. https://reviews.llvm.org/D50551 Files: test/std/containers/associative/map/map.access/at.pass.cpp test/std/containers/unord/unord.map/unord.map.elem/at.pass.cpp Index:

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. Herald added a subscriber: jfb. - Repair thread-unsafe modifications of n_alive in F.pass.cpp In this example, the ctor of G runs in the main thread in the expression G(), and also in the copy ctor of G() in the

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); dvyukov wrote: > I don't immediately

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); BillyONeal wrote: > dvyukov wrote: >

[PATCH] D49774: [libc++] Use __int128_t to represent file_time_type.

BillyONeal added a comment. In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote: > Another problem (that Eric and I discussed last night) is that filesystem is > part of C++17, and `file_clock` is C++20. So we need a solution for C++17 as > well. It seems like we need to fix C++20

[PATCH] D49774: [libc++] Use __int128_t to represent file_time_type.

BillyONeal added a comment. In https://reviews.llvm.org/D49774#1175650, @ldionne wrote: > In https://reviews.llvm.org/D49774#1175543, @BillyONeal wrote: > > > In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote: > > > > > Another problem (that Eric and I discussed last night) is that

[PATCH] D45294: [libcxx] [test] Remove non-portable assertions from filebuf's seekoff.pass.cpp test

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. libc++'s tests are asserting things about the buffer passed to pubsetbuf. [filebuf.virtuals]/12 says that what the filebuf does with the buffer you give it is completely implementation defined. The MSVC++

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

BillyONeal added a comment. @EricWF / @mclow.lists Any chance you could take a look sometime soon? https://reviews.llvm.org/D41748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45294: [libcxx] [test] Remove non-portable assertions from filebuf tests

BillyONeal updated this revision to Diff 141433. BillyONeal retitled this revision from "[libcxx] [test] Remove non-portable assertions from filebuf's seekoff.pass.cpp test" to "[libcxx] [test] Remove non-portable assertions from filebuf tests". BillyONeal edited the summary of this revision.

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

BillyONeal accepted this revision. BillyONeal added a comment. This revision is now accepted and ready to land. It actually looks like I accidentally committed this back in January so I'm going to close this :) https://reviews.llvm.org/D41748 ___

[PATCH] D45294: [libcxx] [test] Remove non-portable assertions from filebuf tests

BillyONeal added a comment. @mclow.lists Are you OK with this one? It's conceptually similar to the previous review. https://reviews.llvm.org/D45294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

BillyONeal closed this revision. BillyONeal added a comment. D:\msvc\src\qa\VC\Libs\libcxx\upstream>git svn dcommit Committing to https://llvm.org/svn/llvm-project/libcxx/trunk ... Authentication realm: https://llvm.org:443 LLVM Subversion repository Password for 'bion': M

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

BillyONeal added a comment. In https://reviews.llvm.org/D45715#1075665, @mclow.lists wrote: > - if there are similar tests in the filesystem test suite, and you haven't > tripped over them because you spelled your error message the same as we did. Almost certainly. But we aren't running your

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

BillyONeal updated this revision to Diff 142733. BillyONeal added a comment. Added missing include in one of the tests. https://reviews.llvm.org/D45715 Files: test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/ctor_char_pointer_error_code.pass.cpp

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. Remove nonportable assumption in io_error tests that std::errc::is_a_directory has message "Is a directory". On MSVC++ it reports "is a directory" (with a lowercase I). https://reviews.llvm.org/D45715 Files:

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal closed this revision. BillyONeal added a comment. Committed r344820 https://reviews.llvm.org/D50549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53466: [libcxx] [test] Don't detect Windows' UCRT with TEST_COMPILER_C1XX

BillyONeal closed this revision. BillyONeal added a comment. Thank you! :D Committed r344829 https://reviews.llvm.org/D53466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53466: [libcxx] [test] Don't detect Windows' UCRT with TEST_COMPILER_C1XX

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. The test is trying to avoid saying aligned_alloc on Windows' UCRT, which does not (and can not) implement aligned_alloc. However, it's testing for c1xx, meaning clang on Windows will fail this test when using the

[PATCH] D53468: [libcxx] [test] Don't silence MSVC STL deprecation warnings when testing _LIBCPP_ENABLE_DEPRECATION_WARNINGS

BillyONeal abandoned this revision. BillyONeal added a comment. Actually this doesn't work -- because we /FI this thing, this file is included before the test gets to say _LIBCPP_ENABLE_DEPRECATION_WARNINGS. https://reviews.llvm.org/D53468 ___

[PATCH] D53468: [libcxx] [test] Don't silence MSVC STL deprecation warnings when testing _LIBCPP_ENABLE_DEPRECATION_WARNINGS

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. https://reviews.llvm.org/D53468 Files: test/support/msvc_stdlib_force_include.hpp Index: test/support/msvc_stdlib_force_include.hpp === ---

[PATCH] D50551: [libcxx] [test] Add missing to several tests.

BillyONeal closed this revision. BillyONeal added a comment. Committed r344821 https://reviews.llvm.org/D50551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53466: [libcxx] [test] Don't detect Windows' UCRT with TEST_COMPILER_C1XX

BillyONeal updated this revision to Diff 170294. BillyONeal added a comment. Also fixed cstdlib tests. https://reviews.llvm.org/D53466 Files: test/std/depr/depr.c.headers/stdlib_h.pass.cpp test/std/language.support/support.runtime/cstdlib.pass.cpp Index:

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal added a comment. Tim Song suggests that http://eel.is/c++draft/string.require#2 indicates that basic_string actually does need to provide the strong guarantee here. While I think that wording is a mess I think I'll fix our basic_string to do that instead of that part of this change.

[PATCH] D60104: [libcxx] [test] Use ptrdiff_t rather than int in splice_after_range.pass.cpp to avoid narrowing from pointer subtraction to int warnings.

BillyONeal closed this revision. BillyONeal added a comment. Committed r357546 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60104/new/ https://reviews.llvm.org/D60104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp.

BillyONeal updated this revision to Diff 193393. BillyONeal retitled this revision from "[libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp." to "[libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp.". BillyONeal edited the summary of this revision.

[PATCH] D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp.

BillyONeal closed this revision. BillyONeal added a comment. Committed r357545 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60023/new/ https://reviews.llvm.org/D60023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

BillyONeal added a comment. As an FYI, I committed this to subversion as r356632 since I haven't figured out the new git world order yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59621/new/ https://reviews.llvm.org/D59621 ___

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists, ldionne. Herald added a subscriber: jdoerfert. Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]]. This allows these tests to pass when compiled by MSVC++.

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

BillyONeal added a comment. This broke all the build bots, so I reverted the SVN change. I thought the nodiscard-ness was tested elsewhere but I'm not sure about interaction between this and -faligned-allocation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59621/new/

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal updated this revision to Diff 193216. BillyONeal added a comment. Fixed misspelled test macro. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60023/new/ https://reviews.llvm.org/D60023 Files: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp Index:

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal created this revision. BillyONeal added reviewers: EricWF, ldionne, mclow.lists. BillyONeal added a project: libc++. Herald added subscribers: jdoerfert, dexonsmith. copy_alloc.pass.cpp contains an allocator that tries to be rebindable; but if it actually does that it fails because

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal added inline comments. Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:123 imp2.deactivate(); test_assign(s1, s2); We still fail this test in debug mode because we need to allocate a new _Container_proxy from

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal marked 2 inline comments as done. BillyONeal added inline comments. Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:123 imp2.deactivate(); test_assign(s1, s2); BillyONeal wrote: > We still fail this test in debug

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal marked an inline comment as done. BillyONeal added inline comments. Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:125 test_assign(s1, s2); assert(s1 == p1); assert(s2 == p2); This particular assert tests that

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal updated this revision to Diff 193157. BillyONeal edited the summary of this revision. BillyONeal added a comment. Fix asserts for the strong EH guarantee. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60023/new/ https://reviews.llvm.org/D60023 Files:

[PATCH] D60104: [libcxx] [test] Use ptrdiff_t rather than int in splice_after_range.pass.cpp to avoid narrowing from pointer subtraction to int warnings.

BillyONeal created this revision. BillyONeal added reviewers: ldionne, mclow.lists, EricWF. Herald added a subscriber: dexonsmith. https://reviews.llvm.org/D60104 Files: test/std/containers/sequences/forwardlist/forwardlist.ops/splice_after_range.pass.cpp Index:

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

BillyONeal abandoned this revision. BillyONeal added a comment. This didn't work out, we'll just skip the tests for MSVC++ for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59621/new/ https://reviews.llvm.org/D59621 ___ cfe-commits

[PATCH] D61366: [libcxx] [test] Don't assert that moved-from containers with non-POCMA allocators are empty.

BillyONeal added a comment. In D61366#1502073 , @EricWF wrote: > I'm not sure I agree with your design decision, but this patch LGTM. I wouldn't object to a standards change to make this the case; though it is suboptimal to destroy all the elements

[PATCH] D61364: [libcxx] [test] Fix incorrect allocator::construct assertions in associative container tests

BillyONeal added a comment. In D61364#1502172 , @ldionne wrote: > Do you know *why* the tests are failing with libc++? I see this overload for > `insert` and it seems like it should be a better match? No, I haven't investigated. I avoid looking at

  1   2   >