[PATCH] D18860: [analyzer] Fix the "Zombie symbols" issue.

george.karpenkov added a comment. @NoQ can we get the evaluation re-done? https://reviews.llvm.org/D18860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45115: [analyzer] Fix assertion crash in CStringChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC328912: [analyzer] Fix assertion crash in CStringChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D45115 Fil

[PATCH] D45113: [analyzer] Cache computation of regionAsOffset

This revision was automatically updated to reflect the committed changes. Closed by commit rC328911: [analyzer] Cache offset computation for MemRegion (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D45113 Fi

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

george.karpenkov accepted this revision. george.karpenkov added a comment. LGTM. Sorry for the delay, I thought that a single acceptance was sufficient. https://reviews.llvm.org/D41938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D45417: [analyzer] Don't crash on printing ConcreteInt of size >64 bits

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/SVals.cpp:304 const nonloc::ConcreteInt& C = castAs(); - if (C.getValue().isUnsigned()) -os << C.getValue().getZExtValue(); - else -os << C.getValue().getSExtValue(); -

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

george.karpenkov requested changes to this revision. george.karpenkov added inline comments. This revision now requires changes to proceed. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:3082 +if (X.isUnknown()) { + // The value being casted to rvalue can be garbage-

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Right, sorry. LGTM, but maybe Artem has something to add as well. I don't have any suggestions, and trying to modifying lifetimes of expressions in environment for the sake

[PATCH] D45417: [analyzer] Don't crash on printing ConcreteInt of size >64 bits

george.karpenkov added a comment. > I have removed the FIXME at all 👍 Repository: rC Clang https://reviews.llvm.org/D45417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

george.karpenkov added a comment. @MTC what happens for this.j = 0; for (int i=0; i<100; i++) this.j++; ? Repository: rC Clang https://reviews.llvm.org/D45491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D39220: [Analyzer] Store BodyFarm in std::unique_ptr

george.karpenkov added inline comments. Comment at: include/clang/Analysis/AnalysisDeclContext.h:424 /// methods during the analysis. - BodyFarm *BdyFrm = nullptr; + std::unique_ptr BdyFrm; alexfh wrote: > george.karpenkov wrote: > > alexfh wrote: > > > Bd

[PATCH] D39220: [Analyzer] Store BodyFarm in std::unique_ptr

george.karpenkov added a comment. @dcoughlin OK, I'll commit that [I assuming not doing the review would be fine here] Repository: rL LLVM https://reviews.llvm.org/D39220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D39428: [Analyzer] As suggested, use value storage for BodyFarm

george.karpenkov created this revision. Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar, aemerson. I've also removed copy constructor to help clients not to shoot themselves in the foot with `BodyFarm stored = Manager.getBodyFarm()`. https://reviews.llvm.org/D39428 Fil

[PATCH] D39428: [Analyzer] As suggested, use value storage for BodyFarm

george.karpenkov updated this revision to Diff 120861. https://reviews.llvm.org/D39428 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analysis/BodyFarm.h lib/Analysis/AnalysisDeclContext.cpp Index: lib/Analysis/AnalysisDeclContext.cpp ===

[PATCH] D39269: [Analyzer] [Tests] Do not discard output from CmpRuns.py when running integration tests

george.karpenkov added a comment. @zaks.anna prints "XXX added / XXX removed" for every report which has appeared or disappeared. https://reviews.llvm.org/D39269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D39428: [Analyzer] As suggested, use value storage for BodyFarm

george.karpenkov added a comment. @xazax.hun I'm really not convinced: george@/Volumes/Transcend/code/llvm (master)≻ rg "\w+\&" tools/clang/include/clang/StaticAnalyzer tools/clang/include/clang/StaticAnalyzer/Core/Checker.h 31: static void _checkDecl(void *checker, const Decl *D, Analysi

[PATCH] D39428: [Analyzer] As suggested, use value storage for BodyFarm

This revision was automatically updated to reflect the committed changes. Closed by commit rL317065: [Analyzer] Use value storage for BodyFarm (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39428?vs=120861&id=121098#toc Repository: rL LLVM https://reviews

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

george.karpenkov created this revision. Herald added a reviewer: EricWF. Herald added subscribers: szepet, xazax.hun, javed.absar. Addresses https://bugs.llvm.org/show_bug.cgi?id=35075 https://reviews.llvm.org/D39518 Files: lib/Analysis/BodyFarm.cpp test/Analysis/call_once.cpp Index: test

[PATCH] D38986: [Analyzer] Better unreachable message in enumeration

george.karpenkov added a comment. @dcoughlin @NoQ so can this be committed? https://reviews.llvm.org/D38986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

george.karpenkov updated this revision to Diff 121371. george.karpenkov added a comment. Updated the diff, addressed review concerns. Made it more explicit in comments in tests that we do not crash on libcxx03 implementation, but that we don't model it either. @dcoughlin sorry I disagree on prev

[PATCH] D38986: [Analyzer] Better unreachable message in enumeration

george.karpenkov abandoned this revision. george.karpenkov added a comment. @dcoughlin OK, I guess you could theoretically come up with a scenario where an error in this code would lead to crashing-while-crashing which would obscure the original error. https://reviews.llvm.org/D38986 __

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. https://reviews.llvm.org/D39577 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp Index: lib/StaticAnalyzer/Core/ExprEngineC.cpp === --- lib/Static

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

george.karpenkov updated this revision to Diff 121418. https://reviews.llvm.org/D39518 Files: lib/Analysis/BodyFarm.cpp test/Analysis/call_once.cpp Index: test/Analysis/call_once.cpp === --- test/Analysis/call_once.cpp +++ test/

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL317293: [analyzer] do not crash on libcxx03 call_once implementation (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39518?vs=121418&id=121423#toc Repository: rL LL

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

george.karpenkov added a comment. @dcoughlin thanks for accepting quickly, actually the whole file has a very large amount of duplicated code, but I guess we can't do it right now. https://reviews.llvm.org/D39577 ___ cfe-commits mailing list cfe-co

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

This revision was automatically updated to reflect the committed changes. Closed by commit rL317294: [analyzer] [NFC] very minor ExprEngineC refactoring (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39577?vs=121401&id=121424#toc Repository: rL LLVM https

[PATCH] D39584: [analyzer] [NFC] another very minor ExprEngineC refactoring

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. couldn't resist adding a function here. I think this would be the last one. https://reviews.llvm.org/D39584 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp Index: lib/StaticAnalyzer/Core/ExprEngineC.cpp

[PATCH] D39620: [analyzer] [NFC] Remove unused typedef

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. https://reviews.llvm.org/D39620 Files: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h Index: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h ==

[PATCH] D39691: [analyzer] Model correct dispatch_once() 'done' value in BodyFarm

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Looks good to me. I really don't think the test format chosen in `unix-fns.c` is a good idea, as it is very large, auto-generated, and tightly coupled to chosen formatting.

[PATCH] D39707: [analyzer] assume bitwise arithmetic axioms

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. Patches the solver to assume that bitwise OR of an unsigned value with a constant always produces a value larger-or-equal than the constant, and bitwise AND with a constant always produces a value less-or-equal

[PATCH] D39584: [analyzer] [NFC] another very minor ExprEngineC refactoring

george.karpenkov updated this revision to Diff 121814. george.karpenkov edited the summary of this revision. george.karpenkov added a comment. Addressed review comments. https://reviews.llvm.org/D39584 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp Index: lib/StaticAnalyzer/Core/ExprEngineC

[PATCH] D39707: [analyzer] assume bitwise arithmetic axioms

george.karpenkov updated this revision to Diff 121825. https://reviews.llvm.org/D39707 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp test/Analysis/constant-folding.c Index: test/Analysis/constant-folding.c === --- t

[PATCH] D39709: [analyzer] [NFC] remove duplicated function

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. Two copies of `getSymLERange` in `RangeConstraintManager` are virtually identical, which is clearly bad. This patch uses lambdas to call one from another (assuming that we would like to avoid getting ranges from

[PATCH] D39620: [analyzer] [NFC] Remove unused typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rL317537: [analyzer] [NFC] Remove unused typedef from SVals.h (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39620?vs=121556&id=121827#toc Repository: rL LLVM https

[PATCH] D39711: [analyzer] ObjCGenerics: Don't warn on cast conversions involving explicit cast

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:587 if (TrackedType && + !isa(CE) && !ASTCtxt.canAssignObjCInterfaces(DestObjectPtrType, *TrackedType) && Should it check that we are actuall

[PATCH] D39707: [analyzer] assume bitwise arithmetic axioms

george.karpenkov updated this revision to Diff 122170. george.karpenkov added a comment. Handle non-zero case, more tests cases, cleaner code. https://reviews.llvm.org/D39707 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp test/Analysis/constant-folding.c Index: test/Analysis/con

[PATCH] D39803: [analyzer] pr34766: Fix a crash on explicit construction of std::initializer_list.

george.karpenkov added a comment. I think I lack context to completely get what is going on here: I assume we don't model the assignment here? Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:533 - if (isa(Init)) { + if (isa(Init) || isa(Init)) { // No work needed.

[PATCH] D39711: [analyzer] ObjCGenerics: Don't warn on cast conversions involving explicit cast

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:587 if (TrackedType && + !isa(CE) && !ASTCtxt.canAssignObjCInterfaces(DestObjectPtrType, *TrackedType) && dcoughlin wrote: > xazax.hun wrote:

[PATCH] D39584: [analyzer] [NFC] another very minor ExprEngineC refactoring

george.karpenkov added a comment. @dcoughlin OK to commit? https://reviews.llvm.org/D39584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39707: [analyzer] assume bitwise arithmetic axioms

This revision was automatically updated to reflect the committed changes. Closed by commit rL317820: [analyzer] assume bitwise arithmetic axioms (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39707?vs=122170&id=122278#toc Repository: rL LLVM https://revie

[PATCH] D39862: [analyzer] do not crash when trying to convert an APSInt to an unexpected type

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. This is the issue breaking the postgresql bot, purely by chance exposed through taint checker, somehow appearing after https://reviews.llvm.org/D38358 got committed. The backstory is that the taint checker requ

[PATCH] D39862: [analyzer] do not crash when trying to convert an APSInt to an unexpected type

george.karpenkov added a comment. > I'm curious if the crash would turn into an assertion failure during > getRawSVal() after https://reviews.llvm.org/D38801 is committed. I guess we would see? > If this problem is fixed on the checker side (it probably should be - the > checker , we can proba

[PATCH] D39862: [analyzer] do not crash when trying to convert an APSInt to an unexpected type

This revision was automatically updated to reflect the committed changes. Closed by commit rL317839: [analyzer] do not crash when trying to convert an APSInt to an unexpected type (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39862?vs=122306&id=122328#toc R

[PATCH] D39584: [analyzer] [NFC] another very minor ExprEngineC refactoring

This revision was automatically updated to reflect the committed changes. Closed by commit rL317849: [analyzer] [NFC] Minor ExprEngineC refactoring (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39584?vs=121814&id=122345#toc Repository: rL LLVM https://re

[PATCH] D41378: [analyzer] support a mode to only show relevant lines in HTML diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rC322612: [analyzer] support a mode to only show relevant lines in HTML diagnostics (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://rev

[PATCH] D42192: [analyzer] Assume that the allocated value is non-null before construction, not after.

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:514 + QualType Ty = FD->getType(); + if (const FunctionProtoType *ProtoType = Ty->getAs()) +if (!ProtoType->isNothrow(getContext())) auto? ==

[PATCH] D42140: [analyzer] Make isSubRegionOf reflexive

This revision was automatically updated to reflect the committed changes. Closed by commit rC322752: [analyzer] Make isSubRegionOf reflexive (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D42140 Files: inc

[PATCH] D42155: [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently

This revision was automatically updated to reflect the committed changes. Closed by commit rC322753: [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https:

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

george.karpenkov added inline comments. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:597 + // than or equal to the quarter of the maximum value of that type. + bool shouldAggressivelySimplifyRelationalComparison(); + High level comment: can y

[PATCH] D42320: [analyzer] Mark lines as relevant even if they weren't executed but have a label attached

This revision was automatically updated to reflect the committed changes. Closed by commit rC323251: [analyzer] Mark lines as relevant even if they weren't executed but have a… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://r

[PATCH] D42457: [analyzer] Don't communicate evaluation failures through memregion hierarchy.

george.karpenkov added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:570 + struct EvalCallFlags { +bool IsConstructorWithImproperlyModeledTargetRegion : 1; Those are not really flags. Perhaps options? =

[PATCH] D42560: [analyzer] dump() ExprEngine's internal traits into the ExplodedGraph view.

george.karpenkov added a comment. Looks good Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:392 + +auto InitTempSet = State->get(); +if (!InitTempSet.isEmpty()) { Actually I would put both of those into static functions: printInitializedTemporaries

[PATCH] D42560: [analyzer] dump() ExprEngine's internal traits into the ExplodedGraph view.

george.karpenkov added a comment. looks good otherwise. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:418 + for (auto I : NewAllocValsMap) { + std::pair Key = I.first; + SVal Value = I.second; indent? actually, an even better ver

[PATCH] D42560: [analyzer] dump() ExprEngine's internal traits into the ExplodedGraph view.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. But that's all bikeshedding though https://reviews.llvm.org/D42560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D42444: [analyzer] Extend SuppressInlineDefensiveChecksVisitor to all macros, including non-function-like ones

This revision was automatically updated to reflect the committed changes. Closed by commit rC323827: [analyzer] Extend SuppressInlineDefensiveChecksVisitor to all macros, including… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang htt

[PATCH] D42718: [analyzer] [tests] Show the number of removed/added bug reports

This revision was automatically updated to reflect the committed changes. Closed by commit rC323941: [analyzer] [tests] Show the number of removed/added bug reports (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.

[PATCH] D42819: [analyzer] [tests] [NFC] Remove dead code from CmpRuns

This revision was automatically updated to reflect the committed changes. Closed by commit rC324027: [analyzer] [tests] [NFC] Remove dead code from CmpRuns (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D4281

[PATCH] D42777: [analyzer] Fix yet-another-crash in body-farming std::call_once

This revision was automatically updated to reflect the committed changes. Closed by commit rC324046: [analyzer] Fix yet-another-crash in body-farming std::call_once (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.

[PATCH] D42404: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

This revision was automatically updated to reflect the committed changes. Closed by commit rC324161: [analyzer] Do not infer nullability inside function-like macros, even when… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://r

<    1   2   3   4   5   6