[PATCH] D102560: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae529d0db2d: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2761428 , @hubert.reinterpretcast wrote: > If you have some ideas, please let me know. Meanwhile, I am trying out > `system-aix` as the "feature" to XFAIL on. https://reviews.llvm.org/D102560 posted to

[PATCH] D102560: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: v.g.vassilev, lhames, daltenty, jasonliu, jsji. Herald added a subscriber: steven.zhang. hubert.reinterpretcast requested review of this revision. Herald added a project: clang. This patch replaces the

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. Once I add `-Xcc -fintegrated-as`, we get: $ cat /home/hstong/.Liodine/llvmproj/clang/test/Interpreter/execute.cpp | /home/hstong/.Nrtphome/.Liodine/llcrossbld/dev/build/bin/clang-repl -Xcc -fintegrated-as fatal error: error in backend: 64-bit XCOFF

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. @v.g.vassilev, thanks for working with me on this. I understand it is difficult to handle issues that appear on platforms and build configurations one does not have set up. I've added `-Xcc -v` and the output is below. It seems it has to do with the

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2759808 , @v.g.vassilev wrote: > Hi @hubert.reinterpretcast, > > Would you mind testing this patch: Does the test try to generate native object files in some way? There is functionality (with some

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2759808 , @v.g.vassilev wrote: > Hi @hubert.reinterpretcast, > > Would you mind testing this patch: Running it now. I've applied the first diff here to the base of my previously reported result to

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2758189 , @lhames wrote: > Ok, looks like the JIT is getting the layout right, but clang-repl is > constructing a module with an little-endian layout for some reason. `clang-repl` is generating a module

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2757342 , @lhames wrote: > Hi Hubert, > > Could you apply the following patch and let me know the output from the > failing test? I'm trying to work out whether the JIT is getting the triple or > the

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2757342 , @lhames wrote: > Hi Hubert, > > Could you apply the following patch and let me know the output from the > failing test? I'm trying to work out whether the JIT is getting the triple or > the

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2757179 , @v.g.vassilev wrote: > In D96033#2757107 , @v.g.vassilev > wrote: > >> In D96033#2757077 , >>

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. @v.g.vassilev, the test does not appear to be appropriately set up for builds that default to a non-native target: https://lab.llvm.org/staging/#/builders/126/builds/371/steps/5/logs/FAIL__Clang__execute_cpp Can you fix or revert until there is a fix?

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with comment. Comment at: clang/test/Parser/altivec-zvector-bool.c:20-23 +__vector _Bool char Bc; +__vector _Bool short Bsh; +__vector

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:7331-7332 } -if (Next.getIdentifierInfo() == Ident_bool) { +if ((Next.getIdentifierInfo() == Ident_bool) || +Next.getIdentifierInfo() == Ident_Bool) {

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/cmake/config-ix.cmake:285 +# The st_mtim.tv_nsec member of a `stat` structure is not reliable on some AIX +# environments. + set(HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC 0) jsji wrote: > Maybe add a warning

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rGbdc4ec04d42a: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX (authored by

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

hubert.reinterpretcast added a comment. In D101323#2717925 , @jsji wrote: > Have we considered workaround this in `llvm/lib/Support/Unix/Path.inc` > instead? Yes. I think this is a more general fix that would automatically apply in other situations

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: daltenty, Xiangling_L, jsji. Herald added a subscriber: mgorny. hubert.reinterpretcast requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The value observed

[PATCH] D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:727 +// The AIX library implementation of C11 atomics is not yet complete. +if (Opts.C11 || Opts.C17 || Opts.C2x) { + Builder.defineMacro("__STDC_NO_ATOMICS__");

[PATCH] D98554: Save strings for CC_PRINT env vars

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Comment at: clang/lib/Driver/Driver.cpp:4042 - if (!CCPrintStatReportFilename) { + if

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM (with the equal sign form as @daltenty requested if it works). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/bindings/python/clang/cindex.py:2061-2062 TypeKind.FLOAT128 = TypeKind(30) TypeKind.HALF = TypeKind(31) +TypeKind.IBM128 = TypeKind(32) TypeKind.COMPLEX = TypeKind(100) This looks suspiciously

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; jwakely wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; jwakely wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; qiucf wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D98554: Save strings for CC_PRINT env vars

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Driver/Driver.h:160 /// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled. - const char *CCPrintStatReportFilename; + std::string CCPrintStatReportFilename; I'm

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Retained `using` declarations look fine. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/ https://reviews.llvm.org/D98552 ___ cfe-commits

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. Thanks @Xiangling_L and also to the other reviewers for the great comments. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + sbc100 wrote: > hubert.reinterpretcast wrote: > > curdeius wrote: > > > hubert.reinterpretcast wrote: > > > > curdeius wrote: > > > > >

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + curdeius wrote: > hubert.reinterpretcast wrote: > > curdeius wrote: > > > curdeius wrote: > > > > hubert.reinterpretcast wrote: > > > > >

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + curdeius wrote: > curdeius wrote: > > hubert.reinterpretcast wrote: > > > sbc100 wrote: > > > > hubert.reinterpretcast wrote: > > > > > This

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98265/new/ https://reviews.llvm.org/D98265

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + sbc100 wrote: > hubert.reinterpretcast wrote: > > This seems to be assuming that the underlying C library's `stdalign.h` is > > C++ friendly.

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + This seems to be assuming that the underlying C library's `stdalign.h` is C++ friendly. A C11 `stdalign.h` //does// define `alignof` and

[PATCH] D46443: Add missing cstdalign header

hubert.reinterpretcast added a comment. Herald added a subscriber: wingo. The resolution of LWG 2828 means that `` exists in C++11 and C++14. The rationale from https://reviews.llvm.org/D96786#2566110 can be taken as saying that adding

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM. I think there would be more concern if the load/store actions were previously symmetric, but this patch is actually needed for the symmetry. Nevertheless, please wait a bit before committing this (since

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/global-init.cpp:84 // CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE - // CHECK-NEXT: store i64 1, i64* @_ZGVN5test41xE + // CHECK-NEXT: store i8 1, i8* bitcast (i64* @_ZGVN5test41xE to i8*)

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

hubert.reinterpretcast added inline comments. Comment at: guard.patch:1 +From 9c7d0afec1e634cdeaf3a2ca4273f5da07f6f946 Mon Sep 17 00:00:00 2001 +From: Xiangling Liao Looks like this file got added by accident. CHANGES SINCE LAST ACTION

[PATCH] D95822: [FE][AIX] Use i8 as guard variable type in both load and store operation

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/aix-static-init.cpp:143 // CHECK: init.check: -// CHECK: %1 = call i32 @__cxa_guard_acquire(i64* @_ZGVZN5test41fEvE11staticLocal) +// CHECK: %1 = call i32 @__cxa_guard_acquire(i8*

[PATCH] D95822: [FE][AIX] Use i8 as guard variable type in both load and store operation

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/aix-static-init-temp-spec-and-inline-var.cpp:193 // CHECK: %1 = call i32 @atexit(void ()* @__dtor__ZN5test12t1IiEE) -// CHECK: store i64 1, i64* @_ZGVN5test12t1IiEE // CHECK: br label

[PATCH] D95702: [AIX] Improve option processing for mabi=vec-extabi and mabi=vec=defaul

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95702/new/ https://reviews.llvm.org/D95702

[Diffusion] rGcaaaebcde462: [AIX] Actually push back "-mabi=vec-extabi" when option is on.

hubert.reinterpretcast added inline comments. BRANCHES main /clang/lib/Driver/ToolChains/Clang.cpp:4672-4678 This seems to be saying that `-maltivec` rather actively implies `-mabi=vec-default` (on AIX) even in cases where `-maltivec` really makes no difference. I suggest just removing this.

[Diffusion] rGcaaaebcde462: [AIX] Actually push back "-mabi=vec-extabi" when option is on.

hubert.reinterpretcast added subscribers: ZarkoCA, hubert.reinterpretcast, cfe-commits. BRANCHES main Users: ZarkoCA (Author) https://reviews.llvm.org/rGcaaaebcde462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63852: [Clang] Move assembler into a separate file

hubert.reinterpretcast added a comment. In D63852#2517500 , @aykevl wrote: > or maybe I've put `AssemblerInvocation` in the wrong directory/library. This seems to be a good design question. I think a lot of people consider `-cc1` functionality to be the

[PATCH] D63852: [Clang] Move assembler into a separate file

hubert.reinterpretcast added a comment. @aykevl, please check http://lab.llvm.org:8011/#/builders/57/builds/3704: it seems you are missing a change to `clang/lib/Frontend/CMakeLists.txt` to update the `LLVM_LINK_COMPONENTS`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4671 + D.Diag(diag::err_aix_default_altivec_abi); } Just to confirm, because the patch description confuses me a bit on this: The intent is to not complain

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4669 << A->getSpelling() << RawTriple.str(); -if (!Args.hasArg(options::OPT_maltivec)) - D.Diag(diag::err_aix_altivec); +if

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6ffe4d76fbf: [clang] Fix message text for `-Wpointer-sign` to account for plain char (authored by hubert.reinterpretcast). Changed prior to commit: https://reviews.llvm.org/D93999?vs=315648=315956#toc

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast updated this revision to Diff 315648. hubert.reinterpretcast added a comment. - Address review: Mention plain char only when it appears Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93999/new/ https://reviews.llvm.org/D93999

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7783-7784 "|%diff{casting $ to type $|casting between types}0,1}2" - " converts between pointers to integer types with different sign">, + " converts between pointers

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast added a comment. Ping, @aaron.ballman? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93999/new/ https://reviews.llvm.org/D93999 ___ cfe-commits mailing list

[PATCH] D93095: Introduce -Wreserved-identifier

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/reserved-identifier.cpp:40 + return foo__bar(); // no-warning +} serge-sans-paille wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > You should also have some tests for: > > >

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/ https://reviews.llvm.org/D93901

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added a comment. In D93377#2481312 , @rjmccall wrote: > Are you committed to the name `__ibm128`? Insofar as that's what GCC on Power (for example, `gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0` from 2017) has shipped with for several

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:65-67 + // The #pragma align/pack affected a record in an included file, so Clang + // should warn when that pragma was written in a file that included the + // included file.

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: aaron.ballman, rsmith. Herald added subscribers: jfb, jvesely. hubert.reinterpretcast requested review of this revision. Herald added a project: clang. The `-Wpointer-sign` warning text is inappropriate for

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6230 /// LHS < RHS, return -1. int ASTContext::getFloatingTypeOrder(QualType LHS, QualType RHS) const { FloatingRank LHSR = getFloatingRank(LHS); qiucf wrote: >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6230 /// LHS < RHS, return -1. int ASTContext::getFloatingTypeOrder(QualType LHS, QualType RHS) const { FloatingRank LHSR = getFloatingRank(LHS); nemanjai wrote: >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/ibm128-declarations.cpp:25 + +__ibm128 func4(__ibm128 a, __ibm128 b) { + return a + b; hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > There's a lot of missing

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6230 /// LHS < RHS, return -1. int ASTContext::getFloatingTypeOrder(QualType LHS, QualType RHS) const { FloatingRank LHSR = getFloatingRank(LHS); I think this function

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ MaskRay

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks. Comment at: llvm/test/CodeGen/PowerPC/aix-exception.ll:108-109 +; ASM: .byte 255 # @LPStart Encoding = omit +; ASM32: .byte 187

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:35 + // unsigned long lsda; /* Pointer to LSDA */ + // unsigned long personality; /* Pointerto the personality routine */ + // } Typo:

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-exception.ll:108-109 +; ASM: .byte 255 # @LPStart Encoding = omit +; ASM32: .byte 187 # @TType Encoding = +;

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast added a comment. > 2. AIX uses a new personality routine, named __xlcxx_personality_v1. It > doesn't use the GCC personality rountine, because the intractability is not > there yet on AIX. @jasonliu, is "intractability" a typo/autocorrect problem? CHANGES SINCE LAST

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

hubert.reinterpretcast added a comment. Reverting this patch makes va_arg with the default 128-bit (double-double) long double work again: #include void abort(void); void foo(int x, ...) { va_list ap; va_start(ap, x); long double ans = va_arg(ap, long double); if (ans

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames =

[PATCH] D90187: [NFC] Remove max_align.c LIT testcase

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90187/new/ https://reviews.llvm.org/D90187

[PATCH] D90063: [AIX] Also error on -G for link-only step

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90063/new/ https://reviews.llvm.org/D90063

[PATCH] D90063: [AIX] Also error on -G for link-only step

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-err-options.c:14-15 + // RUN: %clang -target powerpc64-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \ // RUN: FileCheck --check-prefix=CHECK64 %s +// RUN: %clang -target

[PATCH] D89986: [AIX]ignore the option -fvisibility-inlines-hidden when there is no option -fvisibility=*

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:20 +// RUN: FileCheck -check-prefixes=COMMON-IR,VISIBILITY-IR %s + +int x = 66; There's no testing for the interaction with

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89910/new/ https://reviews.llvm.org/D89910

[PATCH] D89897: [AIX] Emit error for -G option on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Comment at: clang/test/Driver/aix-err-options.c:1 +// RUN: %clang -target powerpc32-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/aix_alloca_align.c:11 +void foo() { + char *ptr1 = (char *)alloca(sizeof(char) * 9); +} I'm not entirely sure, but can we try for size 32 and see if we get 16? CHANGES SINCE LAST

[PATCH] D89897: [AIX] Emit error for -G option on AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4925 + if (RawTriple.isOSAIX()) +if (Arg *A = Args.getLastArg(options::OPT_G)) { + D.Diag(diag::err_drv_unsupported_opt_for_target) Either remove the braces

[PATCH] D89897: [AIX] Emit error for -G option on AIX

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-err-options.c:1 +// RUN: %clang -target powerpc32-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \ +// RUN: FileCheck -check-prefix=CHECK32 %s Does this need a call to `not`?

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/aix_alloca_align.c:2 +// RUN: %clang_cc1 -triple=powerpc-ibm-aix-xcoff -S -emit-llvm < %s | \ +// RUN: FileCheck -check-prefix 32BIT %s + Minor nit: Use double-hyphen for long option

[PATCH] D88659: [NFC] Fix the definition of SuitableAlign

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

hubert.reinterpretcast added a comment. In D89684#2341922 , @hubert.reinterpretcast wrote: > `-mabi=aixvecextabi` was suggested when I discussed this with someone who is > familiar with GCC. The choice of `extabi` at the end is to match the spelling >

[PATCH] D89612: NFC: Fix -Wsign-compare warnings on 32-bit builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG134ffa8138c3: NFC: Fix -Wsign-compare warnings on 32-bit builds (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

hubert.reinterpretcast added a comment. I have two concerns over the choice of the option form/name. Firstly, there's an `-mabi=` option that is used to select for ABI extensions. The choice of using an `-mabi=` suboption for selecting between the extended vector ABI and the default vector ABI

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

hubert.reinterpretcast added a comment. There's frontend changes anyway, so there should be changes for the predefined macros? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D89684

[PATCH] D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rG126094485ab9: [PowerPC][AIX] Make `__vector [un]signed long` an error (authored by hubert.reinterpretcast). Changed prior to commit:

[PATCH] D89612: NFC: Fix -Wsign-compare warnings on 32-bit builds

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: dantrushin, hokein, daltenty, stevewan, jasonliu. Herald added a subscriber: hiraditya. Herald added projects: clang, LLVM. hubert.reinterpretcast requested review of this revision. Comparing 32-bit `ptrdiff_t`

[PATCH] D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: nemanjai, ZarkoCA, cebowleratibm. Herald added a subscriber: shchenz. Herald added a project: clang. hubert.reinterpretcast requested review of this revision. The semantics associated with `__vector [un]signed

[PATCH] D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with suggestion. Comment at: clang/test/Layout/itanium-pack-and-align.cpp:19 // CHECK-NEXT: 1 | int y -// CHECK-NEXT:

[PATCH] D88659: [FE]Split SuitableAlign into two parts

hubert.reinterpretcast added a comment. In D88659#2323631 , @jyknight wrote: > ISTM that comment may be incorrect. At least, the precedent set by GCC > appears to be that BIGGEST_ALIGNMENT and alloca _both_ should follow vector > alignment requirements

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

hubert.reinterpretcast added a comment. In D89064#2322717 , @Xiangling_L wrote: > In D89064#2320133 , > @hubert.reinterpretcast wrote: > >> Can we use a regex to make this also work in AIX? > > Sure we can also do

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

hubert.reinterpretcast added a comment. Can we use a regex to make this also work in AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89064/new/ https://reviews.llvm.org/D89064 ___ cfe-commits mailing

[PATCH] D88659: [FE]Split SuitableAlign into two parts

hubert.reinterpretcast added a comment. In D88659#2318203 , @jyknight wrote: > It seems like on AIX, `__BIGGEST_ALIGNMENT__` should just be set to 16, then. > I'm not sure why you want it to be 8? /// Return the alignment that is suitable for

[PATCH] D88963: [SystemZ][z/OS] Add test of zero length bitfield type size larger than target zero length bitfield boundary

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88963/new/ https://reviews.llvm.org/D88963

[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/zos-alignment.c:114 +union u2 { + long :0; + short a; The testing for no-attribute potentially 8-byte aligning zero-width bitfields in a non-initial position is missing.

[PATCH] D88526: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast

This revision was automatically updated to reflect the committed changes. Closed by commit rG35ecc7fe49ba: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88526: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: pkubaj, nemanjai, jasonliu, aaron.ballman. Herald added a project: clang. hubert.reinterpretcast requested review of this revision. Fix premature decision in the presence of type-dependent expression operands

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments. Comment at: clang/test/Driver/aix-ld.c:406 // CHECK-LD32-NOSTDLIBXX-LCXX:

[PATCH] D88500: [AIX][Clang][Driver] Link libm along with libc++

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:165 +// Since libc++ has dependencies on libm, if we have one then add the other. +if (getToolChain().ShouldLinkCXXStdlib(Args)) Is that right? My check of

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

hubert.reinterpretcast added a comment. Off-list discussion seems to indicate that only the NFC portion of the patch was intended to be approved. That is, the scope of this patch is supposed to be https://reviews.llvm.org/D88105?id=293625 plus formatting changes. CHANGES SINCE LAST ACTION

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

hubert.reinterpretcast added a comment. Looks to me that this (since it is approved) completely replaces D88130 . The patch description needs to be changed of course. Not sure if the committer wants to try splitting out the non-AIX test as an NFC patch.

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https://reviews.llvm.org/D88182

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.c:215 // CHECK-LD64-NO-DEFAULT-LIBS: {{.*}}clang{{(.exe)?}}" "-cc1" "-triple" "powerpc64-ibm-aix7.1.0.0" +// CHECK-LD64-NO-STD-LIB: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" //

<    1   2   3   4   5   6   7   8   >