[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

jsji added a comment. Looks like this may cause some unexpected failures. See https://bugs.llvm.org/show_bug.cgi?id=41247 for more details. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59603/new/ https://reviews.llvm.org/D59603

[PATCH] D59924: [PowerPC][Clang] Port MMX intrinsics and basic test cases to Power

jsji requested changes to this revision. jsji added a comment. This revision now requires changes to proceed. Since we are adding new headers that is not originated by this patch, please also update the description (and commit message) to include who actually contributed to `mmintrin.h` and

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji requested changes to this revision. jsji added a comment. This revision now requires changes to proceed. Please make sure you run all test before updating patch! Comment at: clang/test/CodeGen/ppc-mmintrin.c:23 +// CHECK: i64 @_mm_packs_pu16(i64 [[REG1:[0-9a-zA-Z_%.]+]],

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for porting! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59924/new/ https://reviews.llvm.org/D59924

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 yes, it is currently Linux only. I think we can extend it to include other OS like AIX later if needed. https://reviews.llvm.org/rL358949 ___ cfe-commits mailing list

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for porting. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121 ___ cfe-commits mailing

[PATCH] D62569: [PowerPC] [Clang] Port SSE2 intrinsics to PowerPC

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for porting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62569/new/ https://reviews.llvm.org/D62569 ___ cfe-commits mailing

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji requested changes to this revision. jsji added a comment. This revision now requires changes to proceed. TEST 'Clang :: CodeGen/ppc-mm-malloc.c' FAILED Script: -- : 'RUN: at line 9';

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji reopened this revision. jsji added a comment. This revision is now accepted and ready to land. This has been reverted in https://reviews.llvm.org/rL361930 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63636/new/ https://reviews.llvm.org/D63636

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

jsji added a comment. A few questions. Comment at: lib/Headers/altivec.h:16364 signed short *__ptr) { - return *(unaligned_vec_sshort *)(__ptr + __offset); + signed char *Adjusted = (signed char *)__ptr + __offset; +

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji added subscribers: MaskRay, rjmccall, aaron.ballman, rnk, jyknight. jsji added a comment. Add more subscribers, reviews and comments are welcome and appreciated. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji added inline comments. Comment at: lib/Headers/ppc_wrappers/mmintrin.h:3 + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal jsji wrote: >

[PATCH] D64119: [PowerPC] Support constraint code "ww"

jsji added a comment. It is great to add `ww` for compatibility. However if we are going to add `ww`, looks like we should update `ws` as well? Comment at: clang/lib/Basic/Targets/PPC.h:211 + case 's': // VSX vector register to hold scalar double data + case 'w': //

[PATCH] D64119: [PowerPC] Support constraint code "ww"

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for investigating GCC behavior. Comment at: clang/lib/Basic/Targets/PPC.h:211 + case 's': // VSX vector register to hold scalar double data + case 'w': //

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji added a comment. In D59924#1475363 , @MaskRay wrote: > May I ask why the mmintrin.h emulation layer must be added to the clang > resource directory? Why can't it be provided as a standalone library like > https://github.com/intel/ARM_NEON_2_x86_SSE

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji added a comment. Thanks @MaskRay for help fixing and review! Comment at: lib/Headers/ppc_wrappers/mmintrin.h:3 + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to

[PATCH] D64024: [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. BTW, looks like we are missing test cases all `vector float` `vec_all*` and `vec_any*` and also non-vsx path? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

jsji marked 2 inline comments as done. jsji added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-error.c:78 +void testDSS(int index) { + vec_dss(index); //expected-error {{argument to '__builtin_altivec_dss' must be a constant integer}} + wuzish

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

jsji updated this revision to Diff 218479. jsji added a comment. Add range check and test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66699/new/ https://reviews.llvm.org/D66699 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

jsji updated this revision to Diff 218485. jsji added a comment. Add range check and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66748/new/ https://reviews.llvm.org/D66748 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

jsji created this revision. jsji added reviewers: nemanjai, hfinkel, echristo. Herald added subscribers: cfe-commits, shchenz, MaskRay, kbarton. Herald added a project: clang. jsji added a reviewer: PowerPC. Herald added a subscriber: wuzish. This is follow up of https://reviews.llvm.org/D66699.

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

jsji added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66699/new/ https://reviews.llvm.org/D66699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

jsji added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66748/new/ https://reviews.llvm.org/D66748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

jsji created this revision. jsji added reviewers: nemanjai, hfinkel. Herald added subscribers: cfe-commits, shchenz, MaskRay, kbarton. Herald added a project: clang. jsji added a reviewer: PowerPC. Herald added a subscriber: wuzish. This is similar to vec_ct* in https://reviews.llvm.org/rL304205.

[PATCH] D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

This revision was automatically updated to reflect the committed changes. Closed by commit rL370912: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst* (authored by jsji, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

jsji updated this revision to Diff 218696. jsji added a comment. Rebase to ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66748/new/ https://reviews.llvm.org/D66748 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

This revision was automatically updated to reflect the committed changes. jsji marked an inline comment as done. Closed by commit rL370902: [PowerPC][Altivec] Fix constant argument for vec_dss (authored by jsji, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D64849: Add platform guards to PPC vector intrinsics headers.

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64849/new/ https://reviews.llvm.org/D64849 ___ cfe-commits

[PATCH] D65630: [PowerPC] Port SSE3, SSSE3 and SSE4 intrinsics to PowerPC.

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65630/new/ https://reviews.llvm.org/D65630 ___ cfe-commits

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. In D74436#1875320 , @mibintc wrote: > @jsji Will your backend tolerate -ffp-contract=on if optimizations are not > disabled, e.g. -O2? We are proposing that the default floating point model > be -ffp-model=precise, and with

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. > We normally default to `-ffp-contract=on ` only for -O3 and above (for legacy > compilers XL/gcc on PowerPC). Correction: XL on PowerPC default to generate FMA at -O0 as well. The corresponding option is -qfloat=maf.

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. This is also breaking test-suites in our internal buildbots .. This change is actually changing the default behavior: if user does NOT supply `-ffp-contract`, it becomes `-ffp-contract=on`. So this means any code without explicitly add `-ffp-contract=off` will have

[PATCH] D72707: [clang][OpenCL] Fix covered switch warning

jsji created this revision. jsji added a reviewer: svenvh. Herald added subscribers: cfe-commits, Anastasia, yaxunl. Herald added a project: clang. jsji edited the summary of this revision. -Werror clang build is broken now. tools/clang/lib/Sema/OpenCLBuiltins.inc:11824:5: error: default label

[PATCH] D72707: [clang][OpenCL] Fix covered switch warning

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b8e2113a49: [clang][OpenCL] Fix covered switch warning (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72707/new/

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

jsji accepted this revision. jsji added a comment. LGTM. Since there is an improvement for multi errors, we should remove `[NFC]` in title and commit messages. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

jsji added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:243 + bool Passed = CheckVSXSubfeature("+power8-vector", "-mpower8-vector"); + Passed |= CheckVSXSubfeature("+direct-move", "-mdirect-move"); + Passed |= CheckVSXSubfeature("+float128", "-mfloat128");

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

jsji added a comment. Herald added a subscriber: wuzish. Looks like this is causing buildbot failure when built with `-DBUILD_SHARED_LIBS=ON`. http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio FAILED: lib/libclangDaemon.so.11git : &&

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

jsji added a comment. Thanks all, yes, it is passing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 ___ cfe-commits mailing list

[PATCH] D79653: [sanitizer] Enable whitelist/blacklist in new PM

This revision was automatically updated to reflect the committed changes. Closed by commit rGa72b9dfd45cd: [sanitizer] Enable whitelist/blacklist in new PM (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79653/new/

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

jsji added a comment. Herald added a subscriber: wuzish. NOTE that https://reviews.llvm.org/D79445 has committed a similar fix and fixed most of the failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77249/new/

[PATCH] D79653: [sanitizer] Enable whitelist/blacklist in new PM

jsji created this revision. jsji added reviewers: tuktuk, vitalybuka, morehouse, kcc. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. https://reviews.llvm.org/D63616 added `-fsanitize-coverage-whitelist` and

[PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP support

jsji added a comment. In D83915#2156346 , @jsji wrote: > In D83915#2155650 , > @hubert.reinterpretcast wrote: > > > Should we indicate planned removal in the Release Notes for version 11 and > > actual removal in

[PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP support

jsji added a comment. In D83915#2155650 , @hubert.reinterpretcast wrote: > Should we indicate planned removal in the Release Notes for version 11 and > actual removal in those for version 12? Good suggestion. https://reviews.llvm.org/D83968 for adding

[PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP support

jsji added a comment. Ping ... Any other comments? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83915/new/ https://reviews.llvm.org/D83915 ___ cfe-commits mailing list

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

jsji created this revision. Herald added subscribers: cfe-commits, dang, shchenz, kbarton, nemanjai. Herald added a project: clang. jsji requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Clean up QPX code in clang missed in

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

This revision was automatically updated to reflect the committed changes. Closed by commit rGb49b8f096c03: [PowerPC][Clang] Remove QPX support (authored by jsji). Changed prior to commit: https://reviews.llvm.org/D92329?vs=308405=309908#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

jsji updated this revision to Diff 308405. jsji added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fix llvm test as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92329/new/ https://reviews.llvm.org/D92329

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89242/new/ https://reviews.llvm.org/D89242

[PATCH] D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above

jsji added a comment. Done in https://reviews.llvm.org/D103707? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99483/new/ https://reviews.llvm.org/D99483 ___ cfe-commits mailing list

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/aix-vec-extabi.c:12 +/ +// NOEXTABI-NOT: "-mabi=vec-extabi" Why not use `--implicit-check-not`?

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:3 +// RUN: FileCheck %s --check-prefix=EXTABI // RUN: %clang -### -target powerpc-unknown-aix -S -maltivec -mabi=vec-default %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=DFLTABI

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:2 +// RUN: %clang -### -target powerpc-unknown-aix -S %s 2>&1 | \ +// RUN: FileCheck %s --implicit-check-not=-mabi=vec-extabi +// RUN: %clang -### -target powerpc-unknown-aix -S -maltivec %s 2>&1 | \

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added a comment. > The default Altivec ABI was implemented Please include the patches or commits that implement the default ABI. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4779 CmdArgs.push_back("-mabi=vec-extabi"); +else if (A->getOption().getID() ==

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-cas.c:19 +// CHECK-NEXT:[[TMP2:%.*]] = cmpxchg weak volatile i32* [[A]], i32 [[TMP1]], i32 [[TMP0]] monotonic monotonic, align 4 +// CHECK-NEXT:[[TMP3:%.*]] = extractvalue { i32, i1 }

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji updated this revision to Diff 354360. jsji added a comment. Add {} to case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104837/new/ https://reviews.llvm.org/D104837 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3ef4f5bff26: [PowerPC] Add XL compat __compare_and_swap builtins (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji updated this revision to Diff 354410. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104837/new/ https://reviews.llvm.org/D104837 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

This revision was automatically updated to reflect the committed changes. jsji marked an inline comment as done. Closed by commit rG7d6449322ecb: [DebugInfo][test] Check specific func name to ignore codegen differences (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102647: [Driver][test] Don't assume integrated-as

jsji added a comment. In D102647#2764376 , @thakis wrote: > Are there any platforms left that don't default to integrated as? Which ones? > Is there a tracking bug for switching them? Thanks! Oh, I should have mentioned that in description, this is

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

jsji created this revision. jsji added reviewers: PowerPC, dblaikie, shchenz. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We use `CHECK-LABEL: define` to divide input stream into functions, this works well on most platforms. But

[PATCH] D102647: [Driver][test] Don't assume integrated-as

jsji created this revision. jsji added reviewers: PowerPC, thakis, MaskRay, phosek, hubert.reinterpretcast. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tests of fdebug-compilation-dir and -ffile-compilation-dir for `-x

[PATCH] D102647: [Driver][test] Don't assume integrated-as

This revision was automatically updated to reflect the committed changes. Closed by commit rG82b52812471c: [Driver][test] Dont assume integrated-as (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102647/new/

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

jsji marked an inline comment as done. jsji added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-line.cpp:149 -// CHECK-LABEL: define +// CHECK-LABEL: f11 __complex double f11() { dblaikie wrote: > Probably flesh that out a bit. Maybe

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

jsji updated this revision to Diff 346011. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102654/new/ https://reviews.llvm.org/D102654 Files: clang/test/CodeGenCXX/debug-info-line.cpp Index:

[PATCH] D102560: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102560/new/ https://reviews.llvm.org/D102560

[PATCH] D102814: [AIX] Print printable byte list as quoted string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedf4d69d3888: [AIX] Print printable byte list as quoted string (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346907. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jsji added a comment. > because AIX now has an alias implementation. Can we please include the patches or commits that implement the alias? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji created this revision. jsji added reviewers: PowerPC, hubert.reinterpretcast, DiggerLin, xingxue, shchenz. Herald added subscribers: hiraditya, nemanjai. jsji requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. .byte

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jsji added a comment. In D102724#2769756 , @jasonliu wrote: > Good idea, fyi, this is the patch: https://reviews.llvm.org/D83252 Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346830. jsji added a comment. Update .string handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1008 + for (const unsigned char C : Data) { +if (!isPrint(C)) + return false; jsji wrote: > This still need some slight change to deal with the ending 0 so that we can > handle

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1008 + for (const unsigned char C : Data) { +if (!isPrint(C)) + return false; This still need some slight change to deal with the ending 0 so that we can handle .string.

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346794. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp

[PATCH] D99901: [Driver][test] Test intended target only

jsji added a comment. In D99901#2787034 , @ted wrote: > Why would we not want to support this on other targets, like Arm? Fixes for > AIX shouldn't impact other things. Feel free to update the triple to include arm , as long as the tests focus on gnu

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5043 + // option to disable integrated-as explictly. + if (!TC.useIntegratedAs() && !TC.parseInlineAsmUsingAsmParser()) CmdArgs.push_back("-no-integrated-as"); shchenz wrote: >

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG31d10ea10ee1: [AIX] Dont pass no-integrated-as by default (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105512/new/

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji created this revision. jsji added reviewers: PowerPC, lkail, w2yehia. Herald added subscribers: shchenz, jfb, kbarton, nemanjai. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prototype int __compare_and_swap (volatile int*

[PATCH] D104991: [PowerPC] Add XL Compat fetch builtins

jsji created this revision. jsji added reviewers: PowerPC, w2yehia, lkail, shchenz, Whitney. Herald added subscribers: jfb, kbarton, nemanjai. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prototype unsigned int __fetch_and_add

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

jsji created this revision. jsji added reviewers: PowerPC, shchenz. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D105314 added the abibility choose to use AsmParser for parsing inline asm.

[PATCH] D104991: [PowerPC] Add XL Compat fetch builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb237ffca821: [PowerPC] Add XL Compat fetch builtins (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104991/new/

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

jsji accepted this revision as: jsji. jsji added inline comments. Comment at: llvm/cmake/config-ix.cmake:285 +# The st_mtim.tv_nsec member of a `stat` structure is not reliable on some AIX +# environments. + set(HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC 0) Maybe add a

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

jsji added a comment. Have we considered workaround this in `llvm/lib/Support/Unix/Path.inc` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101323/new/ https://reviews.llvm.org/D101323 ___

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

jsji added inline comments. Comment at: clang/lib/Headers/altivec.h:3055 +#ifdef __XL_COMPAT_ALTIVEC__ +/* vec_ctf */ This only affects __VSX__ version right? If so, can we move `#ifdef __XL_COMPAT_ALTIVEC__` into `#ifdef __VSX__`？ Or even better only into

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

jsji added inline comments. Comment at: clang/lib/Headers/altivec.h:3065 + (__b)), \ + vector unsigned long long \ + :

[PATCH] D101918: [clang][Driver] Add -fintegrate-as to debug-pass-structure test

jsji created this revision. jsji added reviewers: evgeny777, tejohnson. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CGProfilePass is not always on, it will be disabled when using non-intergrated assemblers. // Only enable

[PATCH] D101918: [clang][Driver] Add -fintegrate-as to debug-pass-structure test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20d0aca43073: [clang][Driver] Add -fintegrate-as to debug-pass-structure test (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. > Our practice has been for a "tuning" option to, effectively, expand into > other options to control various bits of behavior. Basically, there should > never be behavior that can be controlled _only_ via the tuning option. This > is a design decision that was debated

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. I also agree that consumer *SHOULD* handle the unexpected value better. eg: newer DBX will handle such failures better. However, there are situations that the end user might not get up to date debugger, then the user experiences will be BAD. If updating these tags

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. In D99250#2651207 , @dblaikie wrote: > But if folks supporting previous builds of DBX are likely going to need a > bunch of other compatibility work - then maybe adding the debugger tuning may > be suitable/necessary/worthwhile at

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. In D99250#2651335 , @dblaikie wrote: > In D99250#2651294 , @jsji wrote: > >> In D99250#2651207 , @dblaikie wrote: >> >>> But if folks supporting

[PATCH] D99901: [Driver][test] Test intended target only

jsji created this revision. jsji added a reviewer: MaskRay. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 6fe7de90b9e4e466a5c2baadafd5f72d3203651d changed GNU

[PATCH] D99901: [Driver][test] Test intended target only

jsji added inline comments. Comment at: clang/test/Driver/nostdincxx.cpp:4 // RUN: not %clangxx -nostdlibinc %s 2>&1 | FileCheck %s -// RUN: not %clangxx -fsyntax-only -nostdinc -nostdinc++ %s 2>&1 | FileCheck /dev/null --implicit-check-not=-Wunused-command-line-argument +//

[PATCH] D99901: [Driver][test] Test intended target only

jsji updated this revision to Diff 335499. jsji added a comment. Use -arch instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99901/new/ https://reviews.llvm.org/D99901 Files: clang/test/Driver/nostdincxx.cpp Index:

[PATCH] D99901: [Driver][test] Test intended target only

jsji updated this revision to Diff 335500. jsji added a comment. Remove typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99901/new/ https://reviews.llvm.org/D99901 Files: clang/test/Driver/nostdincxx.cpp Index:

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

jsji added a comment. If we use this workaround, can we also revert 561fb7f60ab631e712c3fb6bbeb47061222c6818 and 8dc70bdcd0fe4efb65876dce0144d9c3386a2f07

[PATCH] D97823: Update default arch on AIX

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pwr7"; +} else if (T.getArch() == llvm::Triple::ppc64le) jsji wrote:

[PATCH] D97823: Update default arch on AIX

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" :

  1   2   3   >