[PATCH] D88002: [clang-cl] Always interpret the LIB env var as separated with semicolons

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d85444b317a: [clang-cl] Always interpret the LIB env var as separated with semicolons (authored by mstorsjo). Repository: rG LLVM Github Monorepo

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

mstorsjo added a comment. In D88005#2296254 , @dmajor wrote: > This change broke the configure step of Firefox mingw builds. > > The build bot won't give me the full details, so I'll need to set up a local > repro next week if needed, but my hunch is that

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

mstorsjo added a comment. Just FWIW, a similar change was made in libunwind earlier (c48974ffd7d1676f79d39d3b1e70f07d3a5e2e44 ), which then required workarounds for cmake issues on both mingw and macos (see b780df052dd2b246a7

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2445414 , @lebedev.ri wrote: > @mstorsjo please can you be more specific what kind of tests are starting to > fail? > Do those tests just check that the code compiled into an identical assembly? No, it's video/audio de

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2447958 , @lebedev.ri wrote: > Just to be sure, i just run the entire compilation of `vc1_block-aarch64.c` > through alive2, and as far as i can tell, it did not report any IR-level > miscompilations. > So either the o

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. FWIW, the issue is reproducible for an aarch64-linux-gnu target as well. If it would help someone, I could make a prepackaged build for that target, with object files + this single source function that breaks it + sample input files to run it with. Repository: rG L

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. (Also, for studying the effect of this one, on an IR level, the difference is already present in the output of `-S -emit-llvm` from clang, unless using `-Xclang -disable-llvm-passes`, but I'm sure you already took that into account.) Repository: rG LLVM Github Mono

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2461497 , @lebedev.ri wrote: > @mstorsjo i've bothered @dmajor to give this a try on some of mozilla's CI, > and unfortunately it came back green.. > I don't recall if i can reproduce it locally (on vanilla test suite,

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2461510 , @mstorsjo wrote: > In D87188#2461497 , @lebedev.ri > wrote: > >> @mstorsjo i've bothered @dmajor to give this a try on some of mozilla's CI, >> and unfortunately it ca

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2463566 , @lebedev.ri wrote: > Once again, thank you @mstorsjo and @dmgreen! Awesome, thanks guys! I'll let you know tomorrow in the unlikely case if this still caused some other regressions as well (or possibly later

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2463733 , @mstorsjo wrote: > In D87188#2463566 , @lebedev.ri > wrote: > >> Once again, thank you @mstorsjo and @dmgreen! > > Awesome, thanks guys! > > I'll let you know tomorrow

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

mstorsjo added a comment. This broke use of setjmp for mingw on x86_64. IIRC, in MSVC environments, the `_setjmp` function is considered built-in, which is given an implicit second argument by the compiler. In mingw targets on the other hand, the compiler normally doesn't know of any such extra

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

mstorsjo added a comment. In D88518#2309538 , @rsmith wrote: > In D88518#2308085 , @mstorsjo wrote: > >> This broke use of setjmp for mingw on x86_64. > > Thanks, should be fixed in rG8fb2a235b0f22dedba72b8b559ba331

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322325 , @mati865 wrote: > @ASDenysPetrov what CMake options do you use? > I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. How many exports does your DLL end up with - is it close to the

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322643 , @mati865 wrote: >> How many exports does your DLL end up with - is it close to the 64k limit, >> or far from it? Is there maybe some other library that is linked in, that >> increases the number of exported s

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322900 , @mati865 wrote: > With `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_C_COMPILER=clang > -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_RANLIB_COMPILER=llvm-ranlib > -DCMAKE_AR_COMPILER=llvm-ar -DCMAKE_LINKER=ld.lld -DLLVM_ENABL

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. Out of these, the second (only enable on mingw if libllvm is available) sounds sensible to me. Or maybe even make it into a cmake option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2323605 , @mati865 wrote: >> Or maybe even make it into a cmake option? > > I've considered it with default to true for unix and false for others but I'm > not sure if complicating Clang build options like that is worth

[PATCH] D89225: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled

mstorsjo added a reviewer: ASDenysPetrov. mstorsjo added a comment. +1, looks sensible to me - I can give it the formal approval a bit later, but leaving it open for a bit for others to comment on first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D89225: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b1d018c0dba: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled (authored by mati865, committed by mstorsjo). Repository: rG LL

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added a comment. I see that the llvm side of the patch lacks tests? Comment at: llvm/lib/IR/AsmWriter.cpp:379 +Out << "aarch64_darwincc"; +break; case CallingConv::SPIR_FUNC: Out << "spir_func"; break; The new code here has a different i

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added inline comments. Comment at: llvm/lib/IR/AsmWriter.cpp:379 +Out << "aarch64_darwincc"; +break; case CallingConv::SPIR_FUNC: Out << "spir_func"; break; aguinet wrote: > mstorsjo wrote: > > The new code here has a different indentation

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:876 SDValue LowerAAPCS_VASTART(SDValue Op, SelectionDAG &DAG) const; + SDValue LowerAAPCSFromDarwin_VASTART(SDValue Op, SelectionDAG &DAG) const; SDValue LowerDarwin_VASTART(SDValue O

[PATCH] D73156: [clang] Build clang-shlib on mingw

mstorsjo added a comment. This actually is done (almost) like this in current git master, see D87547 and D89225 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73156/new/ https://r

[PATCH] D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

mstorsjo created this revision. mstorsjo added reviewers: amccarth, rnk, chapuni. Herald added a project: clang. mstorsjo requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92570 Files: clang/lib/Headers/mm_malloc.h Index: clang/lib/Headers/mm_

[PATCH] D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

mstorsjo added inline comments. Comment at: clang/lib/Headers/mm_malloc.h:42 void *__mallocedMemory; #if defined(__MINGW32__) __mallocedMemory = __mingw_aligned_malloc(__size, __align); rnk wrote: > This has been here since 2011, and somehow nobody complai

[PATCH] D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

This revision was automatically updated to reflect the committed changes. Closed by commit rGc17fdca1883d: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt

mstorsjo created this revision. mstorsjo added reviewers: rnk, amccarth. Herald added a project: clang. mstorsjo requested review of this revision. If invoking clang-cl, both libcmt (or another lib, depending on the /M[TD](|d) options) and oldnames are passed as dependent libs. If compiling and l

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:238 + if (D->hasAttr()) +return IsDarwin ? CC_C : CC_AArch64Darwin; + aaron.ballman wrote: > Can you help me understand this change a bit better? If the declaration uses > the Darwin A

[PATCH] D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt

mstorsjo added a comment. In D89702#2339716 , @rnk wrote: > lgtm > > We need to invent spellings for /MD /MT for the GCC-style driver if we want > it to be usable in the MSVC environment. I don't think there's a precise > translation to the `-static-*` f

[PATCH] D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt

This revision was automatically updated to reflect the committed changes. Closed by commit rG5eece137bc76: [clang] Automatically link against oldnames just as linking against libcmt (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D90571: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added subscribers: Sanitizers, dberris. Herald added a project: Sanitizers. mstorsjo requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90571 Files: compiler-rt/lib/ubsan/ubsa

[PATCH] D90572: [clang] [MinGW] Allow using the vptr sanitizer

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a project: clang. mstorsjo requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90572 Files: clang/lib/Driver/ToolChains/MinGW.cpp clang/test/Driver/mingw-sanitizers.c

[PATCH] D90571: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets

mstorsjo updated this revision to Diff 302374. mstorsjo added a comment. Just checking `_MSC_VER` instead of checking `SANITIZER_WINDOWS && !__MINGW32__`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90571/new/ https://reviews.llvm.org/D90571 Files: compiler-rt/lib/ubsan/ubsan_type

[PATCH] D90571: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG076d351e8bdd: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D90572: [clang] [MinGW] Allow using the vptr sanitizer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaae6fdf67e1: [clang] [MinGW] Allow using the vptr sanitizer (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D90572: [clang] [MinGW] Allow using the vptr sanitizer

mstorsjo added a comment. In D90572#2370716 , @sberg wrote: > Smells like this breaks various bots due to a -fsanitize=...,... option now > listing 18 instead of 17 items, see > http://lab.llvm.org:8011/#builders/76/builds/363, > http://lab.llvm.org:801

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. I would request that this commit should be reverted. > This is a GNU as This is true > and Clang cc1as option, not a GCC option. Users should specify > -Wa,-mimplicit-it= instead. This is not true if you look at any existing stable release - Clang 12.0 doesn't suppo

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769053 , @nickdesaulniers wrote: >> But this change did break my build in these places: >> https://code.videolan.org/videolan/x264/-/blob/b684ebe04a6f80f8207a57940a1fa00e25274f81/configure#L855 >> https://chromium.go

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769267 , @MaskRay wrote: > I don't mind reverting this temporarily. > However, reverting this would break musl build. > musl (since 2018-09) detects both options and will add both if available: > `-Wa,-mimplicit-it=n

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769341 , @MaskRay wrote: > I think libvpx's ASFLAGS usage is about GNU as, not the driver option. It is indeed for calling a GNU as-like tool, but at https://chromium.googlesource.com/webm/libvpx/+/66c1ff6850fd53bcf

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769390 , @MaskRay wrote: > In D102568#2769340 , @mstorsjo > wrote: > >> In the meantime, wouldn't it be possible to detect the presence of the other >> one and check if they

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added inline comments. Comment at: clang/test/Driver/arm-target-as-mimplicit-it.s:18 /// Test comma separated -Wa,- arguments (latter wins). // RUN: %clang -target arm-linux-gnueabi -### -Wa,-mimplicit-it=never,-mimplicit-it=always %s 2>&1 | FileCheck %s --check-pref

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo created this revision. mstorsjo added reviewers: MaskRay, nickdesaulniers, raj.khem. Herald added a subscriber: kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. If multiple instances of the -arm-implicit-it option is passed to the backend, it error

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo updated this revision to Diff 346568. mstorsjo added a comment. Rebased on top of the revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102812/new/ https://reviews.llvm.org/D102812 Files: clang/lib/Driver/ToolChains/Clang.cpp clan

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2371 + return Value == "always" || Value == "never" || Value == "arm" || + Value == "thumb"; +} I guess this could be a `StringSwitch` too if you think that's nicer.

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2428 for (const Arg *A : Args.filtered(options::OPT_Wa_COMMA, options::OPT_Xassembler)) { A->claim(); We could also just add `options::OPT_mimplicit_it_EQ` into this

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo added a comment. In D102812#2770516 , @DavidSpickett wrote: >> If multiple instances of the -arm-implicit-it option is passed to >> the backend, it errors out. > > Does it make sense to fix that side too? I guess it could, although I didn't loo

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mstorsjo created this revision. mstorsjo added a reviewer: rnk. mstorsjo requested review of this revision. Herald added a project: clang. Actually compare each version to the version of the last chosen one. There's no guarantee that the added test case does showcase the previous issue (it depend

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mstorsjo updated this revision to Diff 346850. mstorsjo added a comment. Update another affected testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102873/new/ https://reviews.llvm.org/D102873 Files: clang/lib/Driver/ToolChains/MinGW.cpp

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo added a comment. In D102812#2770821 , @DavidSpickett wrote: > Given that using both options currently crashes clang (therefore no one is > relying on this yet) and GCC doesn't have `-mimplicit-it` I think what you > have is actually the best w

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo updated this revision to Diff 346856. mstorsjo added a comment. Updated to allow mismatches and just picking the value that is set last on the command line - what do you think of this version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo added a comment. In D102812#2773132 , @DavidSpickett wrote: >> Updated to allow mismatches and just picking the value that is set last on >> the command line - what do you think of this version? > > My initial reaction was that I'd prefer to ta

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4468e5b89992: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa… (authored by mstorsjo). Repository: rG LLVM Github Mono

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

mstorsjo created this revision. mstorsjo added reviewers: rnk, mati865. mstorsjo requested review of this revision. Herald added a project: clang. These actually can be automatically imported from another DLL. (This works properly as long as the actual implementation of emutls is linked dynamicall

[PATCH] D103086: [clang][ARM] When handling multiple -mimplicit-it mark all as used

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, and sorry for not testning this aspect in the updated version of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103086/new/

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mstorsjo added reviewers: MaskRay, mati865. mstorsjo added a comment. Adding some more reviewers, this is a trivial bug fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102873/new/ https://reviews.llvm.org/D102873 ___

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

mstorsjo added a comment. @rnk Does this seem ok to you too? Comment at: clang/lib/CodeGen/CodeGenModule.cpp:992 +// (and this actually happens in the public interface of libstdc++), so +// such variables can't be marked as DSO local. if (GV->isDeclarationForLinker

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4cf807aeaf: [clang] [MinGW] Don't mark emutls variables as DSO local (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D102970?vs=347216&id=348379#toc Repository: rG LLVM Gi

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mstorsjo added a comment. Also @mati865 FYI, phabricator has this odd behaviour, that if you press "accept" but don't write a textual message, the notification mail only gets sent to the person receivers but not to the mailing list - so readers of the list will only see the original messages an

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

This revision was automatically updated to reflect the committed changes. Closed by commit rGf59cd8a4a606: [clang] [MinGW] Fix gcc version detection/picking (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D102873?vs=346850&id=348464#toc Repository: rG LLVM Github Mo

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo created this revision. mstorsjo added reviewers: rnk, mati865. Herald added a subscriber: pengfei. mstorsjo requested review of this revision. Herald added a project: clang. On x86_64 mingw, long doubles are always passed indirectly as arguments (see an existing case in WinX86_64ABIInfo::

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4364-4365 // MS x64 ABI requirement: "Any argument that doesn't fit in 8 bytes, or is // not 1, 2, 4, or 8 bytes, must be passed by reference." if (isAggregateTypeForABI(Ty) || Ty->isMemberPoi

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4364-4365 // MS x64 ABI requirement: "Any argument that doesn't fit in 8 bytes, or is // not 1, 2, 4, or 8 bytes, must be passed by reference." if (isAggregateTypeForABI(Ty) || Ty->isMemberPoi

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo updated this revision to Diff 349491. mstorsjo added a comment. Updated to not require the types to be either `isAggregateTypeForABI(Ty)` or `Ty->isMemberPointerType()`, just check the size of the type, added a testcase for `__int128` (which I tested against GCC). Repository: rG LLV

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo updated this revision to Diff 349517. mstorsjo added a comment. Updated the CodeGenCXX/ext-int.cpp testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103452/new/ https://reviews.llvm.org/D103452 Files: clang/lib/CodeGen/TargetInfo.

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

mstorsjo added a comment. > "Windows Kits/10" has the drawback that it contains a space and yet another > number. Ideally the contents of that directory would be available under some > short name, so I went with /winsdkdir /win_sdk. I'm not married to this > though. Maybe /WinSdk looks move lik

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

mstorsjo added a comment. Ok for the fsanitize.c bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

mstorsjo added a comment. I'm not convinced that this is the right way of handling it. Libc++ can be used on top of a number of C++ ABI libraries (both libsupc++/libstdc++ and libcxxabi), and how they are linked varies with how a toolchain is assembled. In particular, if libcxx is built with `L

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

mstorsjo added a comment. In D96070#2544297 , @tbaeder wrote: > In D96070#2543172 , @mstorsjo wrote: > >> In particular, if libcxx is built with `LIBCXX_ENABLE_STATIC_ABI_LIBRARY` >> enabled, the libcxxabi static l

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

mstorsjo added a comment. As is, this breaks compilation for mingw. With the three modifications I suggest here, it no longer breaks compilation for me - I have no idea if it actually works in mingw configurations though, but not breaking compilation is at least the first step. =

[PATCH] D109960: [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows

mstorsjo created this revision. mstorsjo added reviewers: DavidSpickett, simon_tatham. Herald added subscribers: kristof.beyls, dschuff. mstorsjo requested review of this revision. Herald added a project: clang. Windows on armv7 is as alignment tolerant as Linux. The alignment considerations in t

[PATCH] D109960: [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows

mstorsjo updated this revision to Diff 373201. mstorsjo added a comment. Updated the comment too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109960/new/ https://reviews.llvm.org/D109960 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/

[PATCH] D109960: [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGd13d9da1fbe1: [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

mstorsjo added a comment. In D42225#3020688 , @CaseyCarter wrote: > In D42225#2963216 , @ldionne wrote: > >> In D42225#2963190 , @mstorsjo wrote: >> >>> In D42225#2962348

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a reviewer: mstorsjo. mstorsjo added a subscriber: cfe-commits. mstorsjo added a comment. (I’ll have a look and comment on the patch later.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 ___

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

mstorsjo added a comment. In D96120#2550876 , @russell.gallop wrote: > In D96120#2546077 , @mstorsjo wrote: > >> As is, this breaks compilation for mingw. With the three modifications I >> suggest here, it no long

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo added inline comments. Comment at: clang/test/CodeGen/mingw-long-double.c:56-58 + // GNU32: bitcast i8* %argp.cur to x86_fp80* + // GNU64: bitcast i8* %argp.cur to x86_fp80** + // MSC64: bitcast i8* %argp.cur to double* rnk wrote: > These tests will s

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo added inline comments. Comment at: clang/test/CodeGen/mingw-long-double.c:56-58 + // GNU32: bitcast i8* %argp.cur to x86_fp80* + // GNU64: bitcast i8* %argp.cur to x86_fp80** + // MSC64: bitcast i8* %argp.cur to double* mstorsjo wrote: > rnk wrote: >

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo added inline comments. Comment at: clang/test/CodeGen/mingw-long-double.c:56-58 + // GNU32: bitcast i8* %argp.cur to x86_fp80* + // GNU64: bitcast i8* %argp.cur to x86_fp80** + // MSC64: bitcast i8* %argp.cur to double* rnk wrote: > mstorsjo wrote: >

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

This revision was automatically updated to reflect the committed changes. Closed by commit rG6de45b9e6a2c: [clang] Fix reading long doubles with va_arg on x86_64 mingw (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D103452?vs=349517&id=350390#toc Repository: rG LLV

[PATCH] D103837: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms on x86_64

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a subscriber: pengfei. mstorsjo requested review of this revision. Herald added a project: clang. This fixes inconsistencies in the ms_abi.c testcase. Also add a couple cases of missing double pointers in the windows par

[PATCH] D103837: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms on x86_64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb34da6ff9c1d: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms… (authored by mstorsjo). Repository: rG LLVM Github Mo

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

mstorsjo added a comment. Thanks for looping me in; I don't have any objection to this, as far as I can see, the reasoning seems sensible, and the most brittle testcase I have (from what I remember offhand) seems to run fine with this change. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. Couldn’t this commit have been kept in, and just reverting the one for using it in the fuchsia cmake cache? (I’m not using this particular commit myself, just observing.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1014

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2813797 , @phosek wrote: > In D101479#2813724 , @mstorsjo > wrote: > >> Couldn’t this commit have been kept in, and just reverting the one for using >> it in the fuchsia cmak

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

mstorsjo added a comment. In D104556#2837104 , @rnk wrote: > In D104556#2837006 , @MaskRay wrote: > >> Is it possible to ask MSVC to add the 64-bit `IMAGE_REL_AMD64_REL64` and >> `IMAGE_REL_ARM64_REL64`? >> Newer

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo added a comment. In D104819#2837421 , @dexonsmith wrote: > Given how large this is, would it be reasonable to split this up a bit more? > > What I might do if this were my patch: get a review of the API change + the > manual changes in one patc

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo updated this revision to Diff 354178. mstorsjo added a comment. Reduced this patch only to updating of the StringRef class itself and its unit test, removing the mechanical changes. Removed superfluous method name duplication in doxygen comments. Repository: rG LLVM Github Monorepo

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo added a comment. In D104819#2839263 , @dexonsmith wrote: > LGTM, once @MaskRay is happy. I have a couple of minor comments inline too. > > (I also see that there are some clang-format suggestions in the unit tests; > not sure any of them are ac

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3eed57e7ef7d: [ADT] Rename StringRef case insensitive methods for clarity (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.or

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

mstorsjo added a subscriber: tstellar. mstorsjo added a comment. @tstellar, FYI there are still issues being reported with this commit (which was made before the branch). One fix is committed and a backport request was made in https://llvm.org/PR51261, but there’s still a couple other outstandin

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

mstorsjo added a comment. FYI, 13.0.0 rc1 is getting tagged on Monday, so it’d be good to have the branch in a usable state by then, either with all fixes we currently have in main, or reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

mstorsjo created this revision. mstorsjo added reviewers: v.g.vassilev, teemperor. Herald added a subscriber: mgorny. mstorsjo requested review of this revision. Herald added a project: clang. Use `clang_target_link_libraries` to avoid duplicate libraries when the same symbol is provided both by a

[PATCH] D107116: [ConstantFold] Get rid of special cases for sizeof etc.

mstorsjo added a comment. Thanks! Do you think this would be suitable for the 13.x release branch too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107116/new/ https://reviews.llvm.org/D107116 ___ cfe-c

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

This revision was automatically updated to reflect the committed changes. Closed by commit rG25a288b009f7: [clang-repl] Fix building with win32 dylibs (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

mstorsjo added a comment. In D107231#2918824 , @v.g.vassilev wrote: > Forgot to mention that we may need to backport this patch to the llvm13 > branch. That might be good yes, especially if you intend to enable it by default there too. (I only noticed

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

mstorsjo added a subscriber: tstellar. mstorsjo added a comment. In D107231#2918835 , @v.g.vassilev wrote: > In D107231#2918834 , @mstorsjo > wrote: > >> In D107231#2918824

[PATCH] D107261: [clang] [MinGW] Let the last of -mconsole/-mwindows have effect

mstorsjo created this revision. mstorsjo added reviewers: rnk, mati865, jeremyd2019. mstorsjo requested review of this revision. Herald added a project: clang. Don't just check for the existence of one, but check which one was specified last, if any. This fixes https://llvm.org/PR51296. Reposit

[PATCH] D107261: [clang] [MinGW] Let the last of -mconsole/-mwindows have effect

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce49fd024b43: [clang] [MinGW] Let the last of -mconsole/-mwindows have effect (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES

<    2   3   4   5   6   7   8   9   10   11   >