[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

mgorny added a comment. Is LLVM_CONFIG dropped from cache here? I suspect the warning might fire for everyone who has LLVM configured. Repository: rC Clang https://reviews.llvm.org/D51714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

mgorny added a comment. I don't have a strong opinion here. Repository: rC Clang https://reviews.llvm.org/D51714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D50171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47817: [sanitizer_common] Fix using libtirpc on Linux

mgorny added a comment. In https://reviews.llvm.org/D47817#1155637, @Lekensteyn wrote: > Hi, thank you for the patch. First a disclaimer, I am not familiar with this > RPC API at all. Me neither. I'm only familiar with this particular issue because it's what we're hitting a lot recently. >

[PATCH] D47817: [sanitizer_common] Fix using libtirpc on Linux

mgorny added a comment. In https://reviews.llvm.org/D47817#1155788, @Lekensteyn wrote: > In https://reviews.llvm.org/D47817#1155717, @mgorny wrote: > > > > This would be the first user of pkg-config here. I am not sure if this > > > would be the best fix. Usually you cannot (easily) recompile

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny updated this revision to Diff 164871. mgorny added a comment. Ai, sorry about that. Uploaded the proper diff now. I suppose it's not going to make it for 7.0.0 anymore, so it's not a priority. I'll try to bisect it today once I finish testing RC3. https://reviews.llvm.org/D50171

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

mgorny updated this revision to Diff 137227. mgorny added a comment. @rnk, could you confirm the rebased patch? I'm not sure if I should override `InputKind::RenderScript` as well. https://reviews.llvm.org/D34365 Files: CMakeLists.txt include/clang/Config/config.h.cmake

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

This revision was automatically updated to reflect the committed changes. Closed by commit rL326836: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Ok, that's a problem. I think we really ought to consider all possibilites of sysroot first, and either do not fall back to main system at all or do that only if sysroot doesn't have any install at all. Basically, it is important that we don't break non-Gentoo sysroots,

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Ok, I've tried it on top of clang-6.0.0 and I get the following test failures: Failing Tests (8): Clang :: Driver/android-ndk-standalone.cpp Clang :: Driver/constructors.c Clang :: Driver/cuda-detect.cu Clang :: Driver/env.c Clang ::

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. I'm sorry, I see the problem now — the diff generated by Phabricator does not include the empty files x_x (seriously, this thing keeps surprising me in how broken it could be). I'm going to try again with correct file set tonight or tomorrow. If you could send the

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. To be honest, I don't really know. But since we're not installing it straight to `/usr`, I suppose that's not a problem we need to solve right now. However, they do work with clang installed in `/usr/lib/llvm/*/bin`, and this patch must not regress that. So if your

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Well, it's better: Failing Tests (1): Clang :: Driver/linux-header-search.cpp It is apparently the new test failing: + /var/tmp/portage/sys-devel/clang-6.0.0-r1/work/x/y/cfe-6.0.0.src-abi_x86_32.x86/bin/clang -no-canonical-prefixes

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Works fine, thanks a lot! Note that I haven't tested crossdev or anything special, just regular multilib. Repository: rC Clang https://reviews.llvm.org/D45233

[PATCH] D45406: Document -std= values for different languages

mgorny added a comment. To be honest, I find those '(deprecated)' confusing — the user may mistakenly assume that it's about all values rather than the alias. Comment at: docs/CommandGuide/clang.rst:105 + + Supported options for the C language are: +

[PATCH] D45406: Document -std= values for different languages

mgorny added a comment. I think you'd want a definition list instead then. But I haven't tested if they can be nested inside option lists. Repository: rC Clang https://reviews.llvm.org/D45406

[PATCH] D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build

This revision was automatically updated to reflect the committed changes. Closed by commit rL329594: [cmake] Include LLVMTestingSupport when doing stand-alone build (authored by mgorny, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329594: [cmake] Include LLVMTestingSupport when doing stand-alone build (authored by mgorny, committed by ). Repository: rL LLVM https://reviews.llvm.org/D45409 Files: unittests/CMakeLists.txt

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. If that's not a problem, then the more tests, the merrier ;-). Preferably something specific to crossdev would be helpful, given this is a new use case, and/or something that would actually have directory mismatches with CURRENT entry name (i.e. that wouldn't have

[PATCH] D45406: Document -std= values for different languages

mgorny added a comment. Well, my idea was to list the standards one per line (like on GCC manpage), and then the '(deprecated)' comments would probably stand out enough to apply to a single line. Also, FWICS the gcc manpage simply lists which aliases are deprecated in the description text. But

[PATCH] D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build

mgorny added a comment. I've based this change on an earlier fix to lldb when that project started using LLVMTestingSupport. That change in turn was based on how we handle gtest across the projects. As for gtest, I think installing was not considered as an option since different projects may

[PATCH] D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build

mgorny created this revision. mgorny added reviewers: simark, ilya-biryukov. Herald added a subscriber: ioeric. Explicitly include and build lib/Testing/Support from LLVM sources when doing a stand-alone build. This is necessary since clangd tests started to depend on LLVMTestingSupport library

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Thanks. Besides that one tiny nit, looks good at a first glance. I'll test it tomorrow or the next day (but only for the most basic use, sorry). However, I do not feel confident enough with Clang code to ack change this large on my own. So let's wait for @chandlerc to

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny requested changes to this revision. mgorny added inline comments. This revision now requires changes to proceed. Comment at: lib/Driver/ToolChains/Gnu.cpp:2284 +// Test the path based on the version in /etc/env.d/gcc/config-{tuple}. +

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny marked 2 inline comments as done. mgorny added a comment. @eugenis, updated. https://reviews.llvm.org/D44645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny updated this revision to Diff 139135. mgorny edited the summary of this revision. https://reviews.llvm.org/D44645 Files: test/Driver/sanitizer-ld.c Index: test/Driver/sanitizer-ld.c === --- test/Driver/sanitizer-ld.c +++

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny created this revision. mgorny added a reviewer: eugenis. Herald added subscribers: dberris, srhines. mgorny added inline comments. Comment at: test/Driver/sanitizer-ld.c:517 // CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}" // CHECK-CFI-CROSS-DSO-ANDROID-NOT:

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny added inline comments. Comment at: test/Driver/sanitizer-ld.c:517 // CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}" // CHECK-CFI-CROSS-DSO-ANDROID-NOT: libclang_rt. (an alternative would be to replace this 'NOT' clause with more specific library

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny requested review of this revision. mgorny added a comment. Please review the new version, addressing the issue caught by buildbots. https://reviews.llvm.org/D52840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny updated this revision to Diff 169219. mgorny added a comment. v3: one more correction for stand-alone builds. https://reviews.llvm.org/D52840 Files: CMakeLists.txt bindings/python/tests/CMakeLists.txt Index: bindings/python/tests/CMakeLists.txt

[PATCH] D52840: Include Python binding tests in CMake rules

This revision was automatically updated to reflect the committed changes. Closed by commit rC344258: [tests] Include Python binding tests in CMake rules (authored by mgorny, committed by ). Repository: rC Clang https://reviews.llvm.org/D52840 Files: CMakeLists.txt

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny updated this revision to Diff 169218. mgorny added a comment. v2: fixed appending to check-all to make it compatible both with in-tree and standalone builds https://reviews.llvm.org/D52840 Files: CMakeLists.txt bindings/python/tests/CMakeLists.txt Index:

[PATCH] D53151: [python] [tests] Fix calling pytest on Windows (hopefully)

mgorny created this revision. mgorny added a reviewer: rnk. Fix passing arguments to the pytest command to use 'env' builtin CMake command, in order to fix compatibility with Windows. NB: I don't have a Windows environment to test it Repository: rC Clang https://reviews.llvm.org/D53151

[PATCH] D53151: [python] [tests] Fix calling tests on Windows (hopefully)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL344288: [python] [tests] Fix calling tests on Windows (authored by mgorny, committed by ). Herald added a subscriber:

[PATCH] D53202: [python] [tests] Remove cdb lookup failure test

This revision was automatically updated to reflect the committed changes. Closed by commit rL344364: [python] [tests] Remove cdb lookup failure test (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53202: [python] [tests] Remove cdb lookup failure test

mgorny added a comment. Thanks for the review! Repository: rC Clang https://reviews.llvm.org/D53202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53212: inhereit LLVM_ENABLE_LIBXML2

mgorny added inline comments. Comment at: CMakeLists.txt:92 option(CLANG_ENABLE_BOOTSTRAP "Generate the clang bootstrap target" OFF) + option(LLVM_ENABLE_LIBXM2 "Use libxml2 if available." ON) I suppose it will work better without typos. Repository: rC

[PATCH] D53202: [python] [tests] Remove cdb lookup failure test

mgorny created this revision. mgorny added reviewers: sammccall, bkramer, aadg. Herald added a subscriber: arphaman. Remove the test checking for compilation db lookup failure. Since r342228, JSONCompilationDatabasePlugin infers compile commands for missing files, therefore making the lookup

[PATCH] D53239: [python] [tests] Disable python binding tests when building with LLVM_USE_SANITIZER=Address

mgorny accepted this revision. mgorny added a comment. WFM. Thanks for analyzing the problem. Comment at: bindings/python/tests/CMakeLists.txt:27 +# with ASan. +if((NOT WIN32) AND (NOT LLVM_USE_ASAN)) set_property(GLOBAL APPEND PROPERTY Hmm, I don't think

[PATCH] D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files

mgorny added a comment. Unless my bisect is mistaken, this broke Clang Python binding test: https://github.com/llvm-mirror/clang/blob/master/bindings/python/tests/cindex/test_cdb.py#L34 The test apparently assumes that compilation database will not return anything for a file that does not

[PATCH] D53326: [python] [tests] Disable on known-broken arches

This revision was automatically updated to reflect the committed changes. Closed by commit rC344666: [python] [tests] Disable on known-broken arches (authored by mgorny, committed by ). Repository: rC Clang https://reviews.llvm.org/D53326 Files: bindings/python/tests/CMakeLists.txt

[PATCH] D53326: [python] [tests] Disable on known-broken arches

This revision was automatically updated to reflect the committed changes. Closed by commit rL344666: [python] [tests] Disable on known-broken arches (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53326: [python] [tests] Disable on known-broken arches

mgorny added a comment. Thanks for the review. I'm going to be away most of the day today, so if it breaks something (worse), feel free to revert. Repository: rL LLVM https://reviews.llvm.org/D53326 ___ cfe-commits mailing list

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny added a comment. The first one seems to indicate that your `libclang.so` is broken in release mode (optimization error?). The second one is correct (some of the tests test for errors, and apparently don't silence the messages). Repository: rC Clang https://reviews.llvm.org/D52840

[PATCH] D53326: [python] [tests] Disable on known-broken arches

mgorny created this revision. mgorny added reviewers: uweigand, yroux, kparzysz, steveire, aaron.ballman. Herald added a reviewer: javed.absar. Herald added a subscriber: kristof.beyls. Disable the Python binding tests on AArch64, Hexagon and SystemZ following reports on test failures. The first

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny added a comment. Thanks for all your reports. I have filed https://reviews.llvm.org/D53326 to disable the tests on all three known-broken arches. Repository: rC Clang https://reviews.llvm.org/D52840 ___ cfe-commits mailing list

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM, presuming the tests pass for you. https://reviews.llvm.org/D53125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

mgorny added a comment. @philip.pfaffe, did you establish whether this is still necessary or can be abandoned? https://reviews.llvm.org/D49486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47819: [test] Support using libtirpc on Linux

mgorny updated this revision to Diff 171647. mgorny added a comment. Rebased. https://reviews.llvm.org/D47819 Files: cmake/base-config-ix.cmake lib/sanitizer_common/CMakeLists.txt test/msan/lit.cfg test/msan/lit.site.cfg.in test/tsan/lit.cfg test/tsan/lit.site.cfg.in Index:

[PATCH] D47817: [sanitizer_common] Fix using libtirpc on Linux

mgorny updated this revision to Diff 171646. mgorny added a comment. Rebased. https://reviews.llvm.org/D47817 Files: lib/sanitizer_common/CMakeLists.txt lib/sanitizer_common/sanitizer_platform_limits_posix.cc Index: lib/sanitizer_common/sanitizer_platform_limits_posix.cc

[PATCH] D54120: [python] Support PathLike filenames and directories

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: bindings/python/clang/cindex.py:133 +except AttributeError: +def fspath(string): +return string Optionally: this is

[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. Could you please rebase? I'm pretty sure this breaks our use but I can't test since it no longer applies cleanly. https://reviews.llvm.org/D32595

[PATCH] D54120: [python] Support PathLike filenames and directories

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. Also please remember to submit patches with `-U`, so that Phab has full context. Comment at: bindings/python/tests/cindex/test_cdb.py:42 +if HAS_FSPATH:

[PATCH] D32577: CMake: Replace open-coded find_package

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D32577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32578: CMake: Set LLVM_MAIN_INCLUDE_DIR to LLVM_INCLUDE_DIR

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D32578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54120: [python] Support PathLike filenames and directories

mgorny added a comment. Merged. I will get back to you if something explodes ;-). Repository: rL LLVM https://reviews.llvm.org/D54120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54120: [python] Support PathLike filenames and directories

This revision was automatically updated to reflect the committed changes. Closed by commit rL346586: [python] Support PathLike filenames and directories (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny created this revision. mgorny added reviewers: jbcoe, arphaman, frutiger. Add a new CMake rule check-clang-python to run the Python bindings' test suite, and include it in check-all. Repository: rC Clang https://reviews.llvm.org/D52840 Files: CMakeLists.txt

[PATCH] D52806: [python] Support overriding library path via environment

mgorny added a reviewer: steveire. mgorny added a comment. Gentle ping. https://reviews.llvm.org/D52806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

mgorny added a comment. @bebuch, I agree with @mclow.lists here that the new errors are completely unrelated to the problem solved by this patch, and the fix to it belongs in a separate changeset. Can we get the original problem fixed first then? https://reviews.llvm.org/D42242

[PATCH] D52806: [python] Support overriding library path via environment

mgorny updated this revision to Diff 168042. mgorny added a comment. (also included README update) https://reviews.llvm.org/D52806 Files: bindings/python/README.txt bindings/python/clang/cindex.py Index: bindings/python/clang/cindex.py

[PATCH] D52806: [python] Support overriding library path via environment

mgorny created this revision. mgorny added reviewers: jbcoe, arphaman, frutiger. Support a new CLANG_LIBRARY_PATH environment variable within the Python bindings. This variable can be used to force the bindings to load libclang.* from a specific directory without having to explicitly read the

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

mgorny added inline comments. Comment at: lib/Driver/Distro.cpp:139 + File = VFS.getBufferForFile("/usr/lib/os-release"); + if (File) { Technically speaking, the spec says you are supposed to read `/etc/os-release` first and fall back to

[PATCH] D52840: Include Python binding tests in CMake rules

This revision was automatically updated to reflect the committed changes. Closed by commit rL344241: [tests] Include Python binding tests in CMake rules (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52806: [python] [tests] Support overriding library path via environment

This revision was automatically updated to reflect the committed changes. Closed by commit rL344240: [python] [tests] Support overriding library path via environment (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny added a comment. Yes, I've tested it on Linux. I'll commit it once the dep is approved, and hopefully build bots will answer if they work across all platforms. Repository: rC Clang https://reviews.llvm.org/D52840 ___ cfe-commits mailing

[PATCH] D52806: [python] Support overriding library path via environment

mgorny updated this revision to Diff 168079. mgorny added a comment. To avoid consumers of the bindings, I've changed the patch to set the path only through tests. As a result, the binding API is unchanged. https://reviews.llvm.org/D52806 Files: bindings/python/README.txt

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

mgorny added a comment. @mclow.lists , ping. Any chance to get a proper version upstream? I'd rather not pull patches from Fedora when we can have something official. https://reviews.llvm.org/D42242 ___ cfe-commits mailing list

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. Thank you! Repository: rL LLVM https://reviews.llvm.org/D50171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50171: [python] [tests] Update test_code_completion

This revision was automatically updated to reflect the committed changes. Closed by commit rL342897: [python] [tests] Update test_code_completion (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54641: [compiler-rt] [cmake] Fix detecting terminfo library

mgorny updated this revision to Diff 174534. mgorny edited the summary of this revision. mgorny added a comment. Updated for check order change in master. https://reviews.llvm.org/D54641 Files: cmake/config-ix.cmake Index: cmake/config-ix.cmake

[PATCH] D54641: [compiler-rt] [cmake] Fix detecting terminfo library

mgorny created this revision. mgorny added reviewers: krytarowski, dberris, labath. Herald added subscribers: Sanitizers, llvm-commits. Copy the fix for determining the correct terminfo library from LLVM -- use distinct variables for check_library_exists() calls. Otherwise, the first check (for

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Subject: [PATCH 5/5] [sanitizer_common] Add tests for remaining *putc and *getc variants Add tests for the remaining character-oriented functions, that

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny added a comment. (Do you have another idea how to reliably trigger `ferror`?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56136/new/ https://reviews.llvm.org/D56136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56153: [sanitizer_common] Add test for popen()

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D56153 Files: test/sanitizer_common/TestCases/Posix/popen.cc Index:

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:38 + + fclose(fp); + return 0; krytarowski wrote: > krytarowski wrote: > > `assert(!fclose(fp));` > alternatively `!= EOF` It will fail most likely, due to us

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny updated this revision to Diff 179679. mgorny marked an inline comment as done. mgorny added a comment. Moved variable definitions, and added asserts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56136/new/ https://reviews.llvm.org/D56136 Files:

[PATCH] D56149: [sanitizer_common] Rewrite fgets/fputs/puts tests to use asserts

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Rewrite the tests for fgets and for fputs/puts to verify results using assert instead of silently returning non-zero exit status. This is based on

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny updated this revision to Diff 179681. mgorny added a comment. Implemented `fileno_unlocked` as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

mgorny updated this revision to Diff 179696. mgorny added a comment. Fixed lint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56150/new/ https://reviews.llvm.org/D56150 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc Index:

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek, emaste. Update the interceptor for devname_r() to account for correct return types on different platforms. This function returns int on NetBSD but char*

[PATCH] D56149: [sanitizer_common] Rewrite more Posix tests to use asserts

mgorny updated this revision to Diff 179693. mgorny retitled this revision from "[sanitizer_common] Rewrite fgets/fputs/puts tests to use asserts" to "[sanitizer_common] Rewrite more Posix tests to use asserts". mgorny edited the summary of this revision. mgorny added a comment. Updated to

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:49 + + fclose(fp); + return 0; vitalybuka wrote: > why does this close file only on success? > I assume normal test

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny updated this revision to Diff 179691. mgorny added a comment. Added asserts for `fclose()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56136/new/ https://reviews.llvm.org/D56136 Files: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny updated this revision to Diff 179570. mgorny marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny added inline comments. Comment at: lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:2249 +CHECK_SIZE_AND_OFFSET(FILE, _offset); +CHECK_SIZE_AND_OFFSET(FILE, _flags); + krytarowski wrote: > Duplicate with L2231 Fixed. CHANGES SINCE LAST ACTION

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

mgorny updated this revision to Diff 179556. mgorny retitled this revision from "[compiler-rt] [sanitizer_common] Fix using libtirpc on Linux" to "[compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h". mgorny edited the summary of this revision. mgorny added reviewers:

[PATCH] D56158: [sanitizer_common] Implement funopen*() interceptors for NetBSD

mgorny updated this revision to Diff 179722. mgorny added a comment. Implemented wrappers as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56158/new/ https://reviews.llvm.org/D56158 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56158: [sanitizer_common] Implement funopen*() interceptors for NetBSD

mgorny updated this revision to Diff 179723. mgorny added a comment. Fixed accidental whitespace change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56158/new/ https://reviews.llvm.org/D56158 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Implement the interceptors for popen(), pclose() and popenve() functions. The first two are POSIX, the third one is specific to NetBSD. popen() spawns a

[PATCH] D56158: [sanitizer_common] Implement funopen*() interceptors for NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D56158 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56154: [sanitizer_common] Add tests for NetBSD funopen*()

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D56154 Files: test/sanitizer_common/TestCases/NetBSD/funopen.cc

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

mgorny updated this revision to Diff 179707. mgorny added a comment. Updated variable style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56150/new/ https://reviews.llvm.org/D56150 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc Index:

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

mgorny added a comment. In D56152#1342331 , @krytarowski wrote: > Are all the functions available for FreeBSD, NetBSD, Linux, Android, Solaris > an Darwin? I don't know. I suppose the easiest way to check would be to commit it and see what happens.

[PATCH] D56152: [sanitizer_common] Add tests for more *putc and *getc variants

mgorny updated this revision to Diff 179711. mgorny retitled this revision from "[sanitizer_common] Add tests for remaining *putc and *getc variants" to "[sanitizer_common] Add tests for more *putc and *getc variants". mgorny edited the summary of this revision. mgorny added a comment. Updated

[PATCH] D56153: [sanitizer_common] Add test for popen()

mgorny updated this revision to Diff 179712. mgorny added a comment. Added assertion verifying that `fileno(fp)` works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56153/new/ https://reviews.llvm.org/D56153 Files: test/sanitizer_common/TestCases/Posix/popen.cc Index:

[PATCH] D56154: [sanitizer_common] Add tests for NetBSD funopen*()

mgorny updated this revision to Diff 179713. mgorny added a comment. Added assertions for `fileno()` returning -1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56154/new/ https://reviews.llvm.org/D56154 Files: test/sanitizer_common/TestCases/NetBSD/funopen.cc

[PATCH] D56158: [sanitizer_common] Implement funopen*() interceptors for NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL350233: [sanitizer_common] Implement funopen*() interceptors for NetBSD (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

This revision was automatically updated to reflect the committed changes. Closed by commit rL350232: [sanitizer_common] Implement popen, popenve, pclose interceptors (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

<    1   2   3   4   5   6   7   8   9   >