Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D29151#657435, @Prazek wrote:
> In https://reviews.llvm.org/D29151#656887, @Eugene.Zelenko wrote:
>
> > General question: isn't Static Analyzer is better place for such workflow
> > checks?
>
>
> Probably yes, but it is much harder to
JDevlieghere updated this revision to Diff 85937.
JDevlieghere added a comment.
- Added missing instantiations in test
Repository:
rL LLVM
https://reviews.llvm.org/D28768
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
alexeagle added a comment.
confused, wasn't this committed last year? is this an extra check?
https://reviews.llvm.org/D29186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293197: Disable thread safety analysis for some functions in
__thread_support (authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D28520?vs=85794=85939#toc
Repository:
rL LLVM
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
As of r293254, the `-G=` and `-msmall-data-threshold=` flags are just aliases
of `-G`, so you don't need those parts of this patch any more. The PPC part
looks fine, but please add a
compnerd accepted this revision.
compnerd added a comment.
Thanks for adding this, diagnosing what was going on here the first time around
took a little bit of thinking.
https://reviews.llvm.org/D29198
___
cfe-commits mailing list
wristow added a comment.
When a class that has been tagged as dllexport (for an MSVC target) contains an
atomic data member via the C11 '_Atomic' approach, the front end crashes with a
null pointer dereference.
This patch fixes it by guarding the null dereference with the approach used by
wristow created this revision.
Guard against a null pointer dereference that caused Clang to crash
when processing a class containing an _Atomic() data member,
and that is tagged with 'dllexport'.
https://reviews.llvm.org/D29208
Files:
lib/CodeGen/CGClass.cpp
danalbert created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D29209
Files:
test/libcxx/compiler.py
test/libcxx/test/format.py
Index: test/libcxx/test/format.py
===
--- test/libcxx/test/format.py
+++
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
This really needs a new driver flag (`-unwinder`?) similar to `-rtlib`, as
there are multiple unwinders, and it is unclear which unwinder is the proper
one on a given target.
hintonda added a comment.
Thanks and sorry for the breakage. Unfortunately, I'm unable to reproduce
locally (OSX), but will try to get access to linux box this weekend.
Seems to be related to memory corruption wrt to improper StringRef usage, but I
can't say for sure yet.
mehdi_amini added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:452
+ if (CodeGenOpts.DebugInfoForProfiling)
+getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling",
1);
danielcdh wrote:
> mehdi_amini wrote:
> > Why should
mehdi_amini added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:452
+ if (CodeGenOpts.DebugInfoForProfiling)
+getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling",
1);
mehdi_amini wrote:
> danielcdh wrote:
> > mehdi_amini
danielcdh added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:452
+ if (CodeGenOpts.DebugInfoForProfiling)
+getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling",
1);
mehdi_amini wrote:
> Why should we warn on mismatch?
In
jackoalan updated this revision to Diff 86088.
jackoalan added a comment.
Herald added a subscriber: nemanjai.
Remove already-aliased option matchings; add test case for patch.
https://reviews.llvm.org/D26345
Files:
lib/Driver/Tools.cpp
test/Driver/ppc-eabi-small-data.c
Index:
davidb added a comment.
In https://reviews.llvm.org/D27985#660029, @mehdi_amini wrote:
> LGTM.
>
> Can you apply the patch in LLVM (libDemangle) as well please?
Thank you Mehdi. I have an LLVM (libDemangle) with an identical change (minus
the tests) waiting. Would you like my to submit it as
sammccall created this revision.
Revert r293455, which breaks v8 with a spurious error. Testcase added.
https://reviews.llvm.org/D29271
Files:
include/clang/AST/DeclTemplate.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaDecl.cpp
sberg added a comment.
Btw, ran into that with the even simpler test case
template struct S {
static typename T::t const n = 0;
};
struct U { using t = int; };
int main() { return S::n; }
https://reviews.llvm.org/D29271
___
sammccall added a comment.
In https://reviews.llvm.org/D29271#660169, @sberg wrote:
> Btw, ran into that with the even simpler test case
Thanks, I stole it :-)
https://reviews.llvm.org/D29271
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293473: Revert r293455, which breaks v8 with a spurious
error. Testcase added. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D29271?vs=86257=86259#toc
Repository:
rL
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
danielcdh updated this revision to Diff 86292.
danielcdh added a comment.
update
https://reviews.llvm.org/D29205
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CGDebugInfo.cpp
Index: lib/CodeGen/CGDebugInfo.cpp
===
---
hans added a comment.
Ping?
https://reviews.llvm.org/D29152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D29152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krystyna updated this revision to Diff 86298.
krystyna edited the summary of this revision.
krystyna added a comment.
Style fixes.
https://reviews.llvm.org/D29262
Files:
clang-tidy/modernize/UseUsingCheck.cpp
clang-tidy/modernize/UseUsingCheck.h
ahatanak added a comment.
I think this patch is an improvement, but Clang::ConstructJob is still one
giant function.
Do you have ideas to improve readability of this function or plans to further
reduce its size?
Repository:
rL LLVM
https://reviews.llvm.org/D28050
mehdi_amini added a comment.
In https://reviews.llvm.org/D27985#660354, @davidb wrote:
> In https://reviews.llvm.org/D27985#660029, @mehdi_amini wrote:
>
> > LGTM.
> >
> > Can you apply the patch in LLVM (libDemangle) as well please?
>
>
> Thank you Mehdi. I have an LLVM (libDemangle) with an
GorNishanov added a comment.
LGTM? Pretty please :)
https://reviews.llvm.org/D28835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Ping
https://reviews.llvm.org/D22955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall updated this revision to Diff 86337.
sammccall added a comment.
Oops, reverted noise :(
https://reviews.llvm.org/D29303
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
Index: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
sammccall added a comment.
I couldn't work out how to add a test for this, advice appreciated.
Closest I could get was adding something like this to
test/Analysis/virtualcall.cpp:
class F { public: F(); void foo(); };
F::F() { void (F::* ptr) = ::foo; (this->*ptr)(); }
which crashes, but
rsmith added inline comments.
Comment at: clang/test/SemaCXX/pr30306.cpp:5
+template
+void g(T) { int a[f(3)]; } // expected-no-diagnostics
+
Shouldn't we be (somehow) handling the cleanups from the array bound expression
here -- either discarding them or
sammccall updated this revision to Diff 86342.
sammccall added a comment.
Add regression test.
https://reviews.llvm.org/D29303
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
test/Analysis/virtualcall.cpp
Index: test/Analysis/virtualcall.cpp
mgorny created this revision.
Include a path hint for find_package() in ClangConfig.cmake to ensure
that CMake prefers LLVM installed alongside clang over the default
search path.
If two versions of LLVM are installed in the system, and one of them is
in PATH, CMake's find_package() magic
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293539: [clang-format] Separate line comment sections after
a right brace from comment… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29291?vs=86316=86317#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293548: [clang-format] Fix regression that breaks comments
without a comment prefix (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29298?vs=86328=86331#toc
Repository:
rL
bkramer added a comment.
Your test case is fine, it crashes with assertions enabled.
https://reviews.llvm.org/D29303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall created this revision.
In VirtualCallChecker, handle indirect calls.
getDirectCallee() can be nullptr, and dyn_cast(nullptr) is UB
https://reviews.llvm.org/D29303
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
Index: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/UnwrappedLineParser.cpp:2095
+ const FormatToken *MinColumnToken = Line.Tokens.front().Tok;
+ {
+// Scan for '{//'. If found, use the
djasper created this revision.
The main motivation behind this is to cleanup the WhitespaceManager and make it
more extensible for future alignment etc. features. Specifically,
WhitespaceManager has started to copy more and more code that is already
present in FormatToken. Instead, I think it
krasimir updated this revision to Diff 86316.
krasimir added a comment.
- Remove scope
https://reviews.llvm.org/D29291
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Driver/MSVCToolChain.cpp:34
+ #if 0
+#define USE_VS_SETUP_CONFIG
+ #endif
hamzasood wrote:
> rnk wrote:
> > What are the outstanding
mkuper resigned from this revision.
mkuper added a comment.
I admit it would be nice if someone reviewed this, but I'm really the wrong
person for this code area. :-)
https://reviews.llvm.org/D16135
___
cfe-commits mailing list
timshen updated this revision to Diff 86375.
timshen added a comment.
Fix in the right way as rsmith pointed out.
https://reviews.llvm.org/D24333
Files:
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang/lib/Sema/TreeTransform.h
clang/test/Sema/pr30306.cpp
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293585: Add better ODR checking for modules. (authored by
rtrieu).
Changed prior to commit:
https://reviews.llvm.org/D21675?vs=86142=86376#toc
Repository:
rL LLVM
https://reviews.llvm.org/D21675
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D29304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
timshen updated this revision to Diff 86377.
timshen added a comment.
ActOnFinishFullExpr after exiting the expression evaluation context.
https://reviews.llvm.org/D24333
Files:
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang/lib/Sema/TreeTransform.h
clang/test/Sema/pr30306.cpp
hfinkel added inline comments.
Comment at: lib/Driver/Driver.cpp:172
+NumConfigArgs = static_cast(NumCfgArgs);
+ }
+
sepavloff wrote:
> bruno wrote:
> > If `NumCfgArgs == 0` it would be nice to warn that the config file is empty?
> Not sure if it makes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293604: In VirtualCallChecker, handle indirect calls
(authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D29303?vs=86342=86385#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293343: [ubsan] Sanity-check shift amounts before truncation
(fixes PR27271) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D29234?vs=86130=86134#toc
Repository:
rL LLVM
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/AST/ASTContext.cpp:8909
+
+// Itanium ABI (& MSVC seems to do similarly) requires static locals in
+// inline functions to be emitted
dblaikie updated this revision to Diff 86137.
dblaikie added a comment.
Improve comment/mention Itanium ABI
https://reviews.llvm.org/D29233
Files:
lib/AST/ASTContext.cpp
test/CodeGenCXX/explicit-instantiation.cpp
Index: test/CodeGenCXX/explicit-instantiation.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293344: Fix linkage of static locals in available_externally
functions to be… (authored by dblaikie).
Changed prior to commit:
https://reviews.llvm.org/D29233?vs=86137=86138#toc
Repository:
rL LLVM
dblaikie updated this revision to Diff 86140.
dblaikie added a comment.
- More test coverage (for local static variables)
https://reviews.llvm.org/D28845
Files:
include/clang/AST/ASTContext.h
include/clang/AST/ExternalASTSource.h
include/clang/Basic/LangOptions.def
rtrieu updated this revision to Diff 86142.
rtrieu added a comment.
Changes made to the ODR hash algorithm:
Separated Decl and Type pointers into their own DenseMap's.
Removed the queue of pointers to process at the end. Instead, process pointers
at first use.
Save Boolean values and add them
rsmith added a comment.
Comment at: include/clang/AST/ASTContext.h:2490
/// it is not used.
- bool DeclMustBeEmitted(const Decl *D);
+ bool DeclMustBeEmitted(const Decl *D, bool WritingModule = false);
I think the name of this flag might be out of sync
rsmith added a comment.
Another "fun" testcase:
struct S {
void operator++(int n) _diagnose_if(n, "wat", "warning");
};
void f(S s) {
s++; // no warning
s.operator++(1); // warning
}
Comment at: include/clang/Sema/Sema.h:2638
- /// Check the diagnose_if
rsmith added a comment.
LGTM
https://reviews.llvm.org/D26345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie created this revision.
As Mehdi put it, entities should either be
available_externally+weak_odr, or linkonce_odr+linkonce_odr. While some
functions are emitted a_e/weak, their local variables were emitted
a_e/linkonce_odr.
While it might be nice to emit them a_e/weak, the Itanium ABI (&
vsk created this revision.
Ubsan does not report UB shifts in some cases where the shift exponent
needs to be truncated to match the type of the shift base. We perform a
range check on the truncated shift amount, leading to false negatives.
Fix the issue (PR27271) by performing the range check
ddcc added a comment.
> Regarding incremental solving with Z3 (or with most SMT solvers in general),
> let me just lower the expectations a bit:
Ok, that is good to know. It seems that the performance benefits of incremental
solving are unclear, and would be nontrivial to implement (maybe
steven_wu added a comment.
Sorry I just notice that when I look at driver today.
Comment at: cfe/trunk/lib/Driver/Tools.cpp:6464
if (C.getDriver().isSaveTempsEnabled() &&
- !C.getDriver().embedBitcodeInObject() && isa(JA))
+ !C.getDriver().embedBitcodeInObject()
mehdi_amini added inline comments.
Comment at: cfe/trunk/lib/Driver/Tools.cpp:6464
if (C.getDriver().isSaveTempsEnabled() &&
- !C.getDriver().embedBitcodeInObject() && isa(JA))
+ !C.getDriver().embedBitcodeInObject() && !C.getDriver().isUsingLTO() &&
+ isa(JA))
nlopes added a comment.
Let me give just 2 more Z3-related suggestions:
- instead of re-creating the solver, it might be faster to do Z3_solver_reset
- "once in a while" it might be helpful to delete everything (all solvers,
asts, context) and call Z3_reset_memory. Z3's small object pool is
Prazek added a comment.
I have read the patch, but I don't have enough knowledge about C++ rules and
fronted to accept it. Richard?
Comment at: lib/Sema/Sema.cpp:684
+ for (auto PII : Pending)
+if (FunctionDecl *Func = dyn_cast(PII.first))
+
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/AST/ExternalASTSource.cpp:33
+ExternalASTSource::hasExternalDefinitions(unsigned ID) {
+ return EK_ReplyHazy;
+}
dblaikie wrote:
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293444: [OpenMP][NVPTX][CUDA] Adding support for printf for
an NVPTX OpenMP device. (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D17890?vs=49832=86222#toc
Repository:
rL
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
Can you apply the patch in LLVM (libDemangle) as well please?
Repository:
rL LLVM
https://reviews.llvm.org/D27985
___
aaboud added a comment.
Kindly reminder, I am still waiting for a review on this new patch.
Thanks
https://reviews.llvm.org/D16135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:60
-The improvements are...
+Added a safety module for safety-critical checks like those from High
Integrity C++.
+
Please take look on Release Notes format in previous
This revision was automatically updated to reflect the committed changes.
dblaikie marked 2 inline comments as done.
Closed by commit rL293456: Prototype of modules codegen (authored by dblaikie).
Changed prior to commit:
https://reviews.llvm.org/D28845?vs=86200=86239#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293055: [clang-format] Implement comment reflowing.
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D28764?vs=85739=85740#toc
Repository:
rL LLVM
klimek added inline comments.
Comment at: lib/Format/BreakableToken.cpp:279-280
+ return Content.size() >= 2 &&
+ Content != "clang-format on" &&
+ Content != "clang-format off" &&
+ !Content.endswith("\\") &&
Can we now use delimitsRegion here?
mboehme created this revision.
This enables the test to run on systems where output cannot be written.
https://reviews.llvm.org/D29123
Files:
test/Driver/no-arc-exception-silence.m
Index: test/Driver/no-arc-exception-silence.m
krasimir updated this revision to Diff 85739.
krasimir marked 2 inline comments as done.
krasimir added a comment.
- Address review comments.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:747
+Split SplitBefore, WhitespaceManager ) {
+ // If this is the first line of a token, we need to inform Whitespace Manager
+ // about it: either adapt the whitespace range preceding it, or mark it
delesley added a comment.
The big question for me is whether these functions are exposed as part of the
public libcxx API, or whether they are only used internally. (Again, I'm not a
libcxx expert.) If they are part of the public API, then users may want to
switch them on and off in their
hubert.reinterpretcast updated this revision to Diff 85752.
hubert.reinterpretcast added a comment.
Address review comments; update to revision 292996
Fix possibly ill-formed NDR case
Test template-dependent cases for class redeclaration
Address review comment: use lambda instead of do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293043: [analyzer] Fix MacOSXAPIChecker fp with static
locals seen from nested blocks. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D28946?vs=85588=85722#toc
Repository:
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159
+CommentPragmasRegex.match(Current.TokenText.substr(2)) ||
+Current.TokenText.substr(2).ltrim().startswith("clang-format on") ||
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293052: [test] Port clang tests to canonicalized booleans
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28529?vs=83852=85736#toc
Repository:
rL LLVM
krasimir updated this revision to Diff 85737.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Address comments. Add a bunch of comments about various range computations.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
klimek added inline comments.
Comment at: lib/Format/BreakableToken.cpp:747
+Split SplitBefore, WhitespaceManager ) {
+ // If this is the first line of a token, we need to inform Whitespace Manager
+ // about it: either adapt the whitespace range preceding it, or mark it
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D28764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293049: [OpenMP] Support for thread_limit-clause on the
'target teams' directive. (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29087?vs=85592=85728#toc
Repository:
rL
Anastasia closed this revision.
Anastasia added a comment.
Committed in r293050!
https://reviews.llvm.org/D28860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293051: [Driver] Prevent no-arc-exception-silence.m test
from writing output. (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D29123?vs=85734=85735#toc
Repository:
rL LLVM
krasimir added a comment.
Tried to add some comments around range computations. Most of the time it's
about converting range offsets from local line-based values to
start-of-token-based offsets.
Comment at: lib/Format/BreakableToken.cpp:279-280
+ return Content.size() >= 2
nlopes added a comment.
Regarding incremental solving with Z3 (or with most SMT solvers in general),
let me just lower the expectations a bit:
In Z3, when you do push(), there are a few things that change immediately: 1)
it uses a different SAT solver (one that supports incremental reasoning),
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293048: [OpenMP] Support for num_teams-clause on the 'target
teams' directive. (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29085?vs=85587=85726#toc
Repository:
rL LLVM
krasimir updated this revision to Diff 85725.
krasimir marked 8 inline comments as done.
krasimir added a comment.
- Address review comments.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
m.ostapenko updated this revision to Diff 85756.
m.ostapenko added a comment.
Add a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D29077
Files:
lib/Driver/ToolChains.cpp
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293069: [OpenMP] Support for the proc_bind-clause on 'target
parallel' on the NVPTX… (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29128?vs=85759=85765#toc
Repository:
rL
Anastasia added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:723
+? CGM.getNSConcreteStackBlock()
+: llvm::Constant::getNullValue(
+ CGM.getNSConcreteStackBlock()->getType());
arpith-jacob created this revision.
Herald added a subscriber: jholewinski.
This patch adds support for the proc_bind clause on the Spmd construct
'target parallel' on the NVPTX device. Since the parallel region is created
upon kernel launch, this clause can be safely ignored on the NVPTX device
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:726
+ CGM.getNSConcreteStackBlock()->getType()),
+ QualType());
isa = llvm::ConstantExpr::getBitCast(isa, VoidPtrTy);
The
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:723
+? CGM.getNSConcreteStackBlock()
+: llvm::Constant::getNullValue(
+ CGM.getNSConcreteStackBlock()->getType());
smeenai created this revision.
When building libc++ with hidden visibility, we want explicit template
instantiations to export members. This is consistent with existing
Windows behavior, and is necessary for clients to be able to link
against a hidden visibility built libc++ without running into
1101 - 1200 of 262385 matches
Mail list logo
