[PATCH] D92797: APINotes: add initial stub of APINotesWriter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf806be5eaae1: APINotes: add initial stub of APINotesWriter (authored by Saleem Abdulrasool abdul...@google.com, committed by compnerd). Changed

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d613ea931b: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations (authored by compnerd). Repository: rG LLVM Github Monorepo

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

compnerd added a comment. In D152051#4392612 , @tstellar wrote: > I was not sure what to do with inline functions and also functions that were > implemented in the headers, so I did not add the LLVM_EXTERNAL_VISIBILITY > macro to most of those

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Could you add a test case for the inverted order of attributes on a template as well? I don't think that there is a test case for that. CHANGES SINCE LAST ACTION

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0677964c46: Headers: use C++ inline semantics in C++ mode (authored by compnerd). Changed prior to commit:

[PATCH] D146165: docs: add some documentation on Windows SDK search

This revision was automatically updated to reflect the committed changes. Closed by commit rG893ce5759fe2: docs: add some documentation on Windows SDK search (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D146165?vs=506978=507346#toc Repository: rG LLVM Github

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd updated this revision to Diff 506978. compnerd added a comment. Update to include additional behaviour and reference `INCLUDE` and `LIB`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146165/new/ https://reviews.llvm.org/D146165 Files:

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd marked an inline comment as not done. compnerd added inline comments. Comment at: clang/docs/UsersManual.rst:4504 +programs against the Windows system packages. Underlying the Windows SDK is the +UCRT, the universal C runtime. + hans wrote: >

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd added a comment. > Looks reasonable I guess - but I think it would be good to mention the env > variables INCLUDE and LIB too, for alternative ways of finding the same > things - even if it's not strictly the same as what this new section talks > about. Yes, I agree, I did miss that

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd created this revision. compnerd added reviewers: hans, rnk, mstorsjo. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. Add some documentation on the flags and the process by which clang identifies the headers and libraries for the

[PATCH] D145517: MSVC: support version preference with search

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf5f46822847: MSVC: support version preference with search (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145517: MSVC: support version preference with search

compnerd added a comment. Sure thing, I can try to write up some details about that @hans! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145517/new/ https://reviews.llvm.org/D145517 ___ cfe-commits

[PATCH] D145517: MSVC: support version preference with search

compnerd created this revision. compnerd added reviewers: mstorsjo, rnk. Herald added a subscriber: hiraditya. Herald added a project: All. compnerd requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald added projects: clang, LLVM. Extend the logic for the

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1440bf6fd22: Driver: introduce GNU spellings to control MSVC paths (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

compnerd added a comment. Just a friendly reminder, I'd like to get this merged to do a follow up change to improve some of the usability of these flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145007/new/ https://reviews.llvm.org/D145007

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

compnerd added a comment. Yeah, I suspect that would be difficult. Additionally, these are aliases, so they should already have testing coverage through the existing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145007/new/

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

compnerd created this revision. compnerd added reviewers: rnk, mstorsjo. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. Add a set of `-Xmicrosoft` flags to control the Windows SDK and VisualC tools directories. This allows control over the

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG179d24d764ac: Parse: handle another case of invalid handling for attributes (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

compnerd added a comment. I think that the current release note should be sufficient. This is handling the same scenario in a different path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140507/new/ https://reviews.llvm.org/D140507

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. clang would improperly disallow GNU attributes before C++ standard attributes

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd added a comment. @thakis and https://github.com/llvm/llvm-project/issues/59640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 ___ cfe-commits mailing

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0c3142af075: Headers: tweak inclusion condition for stdatomic.h (authored by compnerd). Changed prior to commit:

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

compnerd added a comment. Thanks @fsb4000 (and @CaseyCarter)! I think that due to the shipped version, it makes sense to do this still. Using standard semantics in general I think is preferable, since nothing prevents another compiler implementation to still do something similar. CHANGES

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

compnerd updated this revision to Diff 483081. compnerd retitled this revision from "Headers: make a couple of builtins non-static" to "Headers: use C++ inline semantics in C++ mode". compnerd edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139749/new/

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd added a comment. Seems that this alone is insufficient as some build does run into issues, so I may need to refine this further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139749/new/ https://reviews.llvm.org/D139749

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd added a subscriber: STL_MSFT. compnerd added a comment. @fsb4000 is my reading correct that MSVC will look into trying to handle `static inline` even though it is a GNUism? I wonder if we should consider limiting the use of `static inline` to C mode rather than including C++. I also

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. When building with the 17.5.0 preview toolset for MSVC and building with modules, the definition of `_addcarry_u64`

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

compnerd added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. (Accepting Revision for Closing) I missed the trailing number of the differential revision, and it failed to tie it to this. The commit is at

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

compnerd added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd updated this revision to Diff 480531. compnerd added a comment. Update to avoid use of the `-0` trick. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 Files: clang/lib/Headers/stdatomic.h Index: clang/lib/Headers/stdatomic.h

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd added inline comments. Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l) # include_next Mordante wrote: > Is `__cplusplus-0`

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd updated this revision to Diff 480523. compnerd added a comment. Add a test case for member data. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138514/new/ https://reviews.llvm.org/D138514 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd created this revision. compnerd added reviewers: aaron.ballman, Mordante, fsb4000. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. MSVC requires that C++23 be available (`_HAS_CXX23`) else the entire content is elided.

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:381 +if (!Context.getTargetInfo().getCXXABI().isMicrosoft()) + if (const auto *UO = dyn_cast(InputExpr)) +if (UO->getOpcode() == UO_AddrOf) rnk wrote: > compnerd wrote: >

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd updated this revision to Diff 479752. compnerd marked an inline comment as done. compnerd added a comment. Address feedback from review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138514/new/ https://reviews.llvm.org/D138514 Files:

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/test/Sema/gnu-asm-pmf.cpp:1-34 +// RUN: %clang_cc1 -triple x86_64-unknown-windows-msvc -std=c++2b -fsyntax-only -verify %s -DMICROSOFT_ABI +// RUN: %clang_cc1 -triple

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:381 +if (!Context.getTargetInfo().getCXXABI().isMicrosoft()) + if (const auto *UO = dyn_cast(InputExpr)) +if (UO->getOpcode() == UO_AddrOf) aaron.ballman wrote: > rnk

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. The itanium ABI represents the PMF as a pair of pointers. As such the structure cannot be passed through a single

[PATCH] D138122: Lift EHPersonalities from Analysis to IR (NFC)

compnerd accepted this revision. compnerd added a comment. Additional validation is never a bad thing :). Please do sort the headers before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138122/new/ https://reviews.llvm.org/D138122

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb78d5380da11: parse: process GNU and standard attributes on top-level decls (authored by compnerd). Changed prior to commit:

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 476949. compnerd marked an inline comment as done. compnerd added a comment. Address review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd marked 5 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1605-1606 // C99 6.9: External Definitions. DeclGroupPtrTy ParseExternalDeclaration(ParsedAttributes , +

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 476163. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Parse/ParseHLSL.cpp clang/lib/Parse/ParseObjc.cpp

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 475570. compnerd edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 475530. compnerd added a comment. Add unsupported test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd added inline comments. Comment at: clang/unittests/Tooling/SourceCodeTest.cpp:249-258 Visitor.runOverAnnotated(R"cpp( - #define ATTR __attribute__((deprecated("message"))) - $r[[ATTR + $r[[__attribute__((deprecated("message"))) int x;]])cpp");

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd created this revision. compnerd added reviewers: aaron.ballman, sammccall. Herald added a subscriber: jdoerfert. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. We would previously reject valid input where GNU attributes preceded

[PATCH] D133890: [CMake] Do these replacements to make use of D132608

compnerd added a comment. I don't see anything wrong with this change per se, but I'm conflicted on the name of the variable. These are not standard variables but are encroaching on the CMake namespace. What happens if upstream decides to use these names? I think that we should keep the

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

compnerd added inline comments. Comment at: cmake/Modules/GNUBinaryDirs.cmake:3 + get_filename_component(CMAKE_LIBDIR_BASENAME "${CMAKE_INSTALL_LIBDIR}" NAME) +endif() + Should this perhaps be moved further down near the usage? Comment at:

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Since it has been deprecated for 2 releases, it seems reasonable to cleanup. This seems good to me from the build side, please do wait a bit for anyone else to chime in on this.

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

compnerd added inline comments. Comment at: clang/include/clang/Config/config.h.cmake:57 +/* Multilib basename for libdir. */ +#define CLANG_INSTALL_LIBDIR_BASENAME "${CLANG_INSTALL_LIBDIR_BASENAME}" Does this not potentially break downstreams? Repository:

[PATCH] D130446: [apinotes] Upstream changes to `APINotesYAMLCompiler.cpp`.

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Can you please add a round trip test as well? Additionally, please add a proper commit message to describe the change here. Comment at:

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) + D.Diag(clang::diag::err_drv_riscv_unsupported_with_linker_relaxation) MaskRay

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) +

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:10 #include "RISCV.h" +#include "../Clang.h" #include "ToolChains/CommonArgs.h" This feels like a layering violation. I suppose that as long as modular builds are okay ...

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. It seems that other docs are following the GitHub URLs as well. I wish we could do the relative document link instead of embedding the URL, but if that is not possible, then this makes

[PATCH] D126093: Sema: adjust assertion to account for deduced types

This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGb159108bc5eb: Sema: adjust assertion to account for deduced types (authored by compnerd). Changed prior to commit:

[PATCH] D126093: Sema: adjust assertion to account for deduced types

compnerd updated this revision to Diff 431084. compnerd added a comment. git-clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126093/new/ https://reviews.llvm.org/D126093 Files: clang/include/clang/Sema/DeclSpec.h clang/test/Sema/typerep-typespec.c Index:

[PATCH] D126093: Sema: adjust assertion to account for deduced types

compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. Previous changes for the BTF attributes introduced a new sub-tree visitation. That uncovered that when accessing the

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

compnerd added a comment. Herald added a project: All. The sema portions of this change are still causing an issue. Although the revert (rGf95bd18b5faa6a5af4b5786312c373c5b2dce687 ) and the subsequent re-application in

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

compnerd added a comment. I don't have an example module sadly. It was something that I ran into with Swift code import the WinSDK module defined in https://github.com/apple/swift/blob/main/stdlib/public/Platform/winsdk.modulemap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

compnerd added a comment. This was something that I was hitting an issue with. In particular, it was a module build for a module which pulled in intsafe.h. Now, given that it is a preprocessor macro, it would stand to reason that it will normally be dropped and thus won't matter if the

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/debug-prefix-map.c:7 +// RUN: %clang -g -fdebug-prefix-map=%p=%{fssrcroot}UNLIKELY_PATH%{fssep}empty -S -c %s -emit-llvm -o - |

[PATCH] D111457: [test] Add lit helper for windows paths

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable, though I'm not a fan of the variable names - they seem a bit difficult to read due to no separation (e.g., `%fs-src-root` or `%fs_src_root` vs `%fssrcroot`)

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. Herald added a subscriber: cfe-commits. The Windows SDK has occurrences of the `i128` and `ui128` suffix (at least in

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3204 if (StackProtectorLevel) { -CmdArgs.push_back("-stack-protector-buffer-size"); -// FIXME: Verify the argument is a valid integer. -

[PATCH] D111457: [clang][test] Add lit helper for windows paths

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: This isn't really a separator, this

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

compnerd added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:22 +constexpr llvm::StringLiteral DerefContainerExprName = "deref-container-expr"; +constexpr llvm::StringLiteral AddrofContainerExprName =

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

compnerd added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM .. Meinersbur wrote: > jhenderson wrote: > > RKSimon wrote: > > > aaron.ballman wrote: >

[PATCH] D112890: headers: optionalise some generated resource headers

compnerd added a comment. @craig.topper - ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ https://reviews.llvm.org/D112890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: llvm/CMakeLists.txt:289 +set(LLVM_TOOLS_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}" CACHE STRING +"Path for binary subdirectory (defaults to 'bin')")

[PATCH] D112890: headers: optionalise some generated resource headers

compnerd added a comment. In D112890#3099256 , @tschuett wrote: > If I understand you correctly, I would need to pass something ala `-target > riscv-xx` to enable `__riscv_vector`. However, this is impossible because > the risk target is disabled. So

[PATCH] D112890: headers: optionalise some generated resource headers

compnerd added a comment. In D112890#3099208 , @tschuett wrote: > I am undecided between this may break something and I cannot use the risc-v > headers on an x86 machine. This fundamentally cannot break something outside of the RISC-V //target//, it

[PATCH] D112890: headers: optionalise some generated resource headers

compnerd created this revision. compnerd added a reviewer: craig.topper. Herald added subscribers: luke957, luismarques, s.egerton, PkmX, simoncook, kristof.beyls, mgorny. compnerd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @thakis - thanks, seems that I had a part of the change sitting in my stash ... I had added a `-NOT` to verify the behaviour, and forgot to remove it. I'll revert the revert with the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @Eugene.Zelenko - sorry, I didn't see the additional comments before the commit. I'm happy to do a follow up depending on the resolution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGd0d9e6f0849b: clang-tidy: introduce readability-containter-data-pointer check (authored by compnerd). Changed prior to commit:

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-container-data-pointer.cpp:104 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd updated this revision to Diff 372285. compnerd added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 Files:

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd marked 7 inline comments as done. compnerd added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:63 +hasType(Container), +

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @Eugene.Zelenko I'd like to have @aaron.ballman weigh in on the naming, and assuming that he's okay with `modernize.container-data-pointer`, I'll change it to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd updated this revision to Diff 369453. compnerd marked 2 inline comments as done. compnerd added a comment. Update release notes to incorporate feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:87 + + Finds cases where code could use ``data`` rather than the address of an element. + Eugene.Zelenko wrote: > It'll be good idea

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd updated this revision to Diff 369343. compnerd edited the summary of this revision. compnerd added a comment. Add some documentation and release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. Hmm, one case that doesn't currently get handled properly is the following test case: c++ template void f(const T *); void g(const std::vector **v) { f(&(**v)[0]); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:18 +namespace tidy { +namespace readability { +ContainerDataPointerCheck::ContainerDataPointerCheck(StringRef Name, Eugene.Zelenko wrote: >

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. In D108893#2971410 , @Eugene.Zelenko wrote: > Thank you for implementing 26817 > ! But shouldn't this check > belong to `modernize` module? Oh, I was unaware of the PR, I'll tag

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd updated this revision to Diff 369340. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd updated this revision to Diff 369331. compnerd added a comment. Reflow the text using clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 Files:

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a subscriber: mgorny. compnerd requested review of this revision. Herald added a project: clang-tools-extra. This introduces a new check, readability-containter-data-pointer. This check is meant to catch the

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

compnerd added inline comments. Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html" +set(LLVM_INSTALL_OCAMLDOC_HTML_DIR

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105049/new/ https://reviews.llvm.org/D105049

[PATCH] D105368: Lex: add a callback for `#pragma mark`

compnerd updated this revision to Diff 356273. compnerd added a comment. Correct lifetime of data in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105368/new/ https://reviews.llvm.org/D105368 Files:

[PATCH] D105368: Lex: add a callback for `#pragma mark`

compnerd created this revision. compnerd added reviewers: dgoldman, rsmith, aaron.ballman. Herald added subscribers: usaxena95, kadircet, kbarton, nemanjai. compnerd requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang. Allow a preprocessor

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added a comment. Interesting, are the logs from the runs available? I have run the test ~1 times locally and its been stable. Perhaps the logs can show what is going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added a comment. I was able to play around with this further yesterday evening. You are correct - the issue is the load preventing the watcher thread from spinning up. I was able to reproduce this issue and resolve it by adding in a synchronization point (boolean + mutex + condition

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This is a pretty straightforward cleanup now, which adds additional functionality by deferring work to CMake. There are a couple of minor points about inconsistent quoting but this seems

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION

  1   2   3   4   5   6   7   >