[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. i added this bit because when we eventually store the result of evaluation in ConstantExpr we will probably want to trail-allocate the APValue's possible representations separately to limit memory consumption. but if we do this the ConstantExpr node will need to be

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. I checked how we can propagate the information about constant context through semantic checking. there are issues with using ConstantExpr to mark expressions as constant for semantic checking: - #1 multpile Expr::Ignore* operation remove ConstantExpr from the expression.

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker updated this revision to Diff 201535. Tyker marked 13 inline comments as done. Tyker retitled this revision from "[C++20] add consteval specifier" to "[C++20] add Basic consteval specifier". Tyker edited the summary of this revision. Tyker added a comment. Herald added a subscriber: eraman.

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10471 + bool IsConstantContext = S.ExprEvalContexts.back().isConstantEvaluated(); + rsmith wrote: > Are the changes to this file really specific to `consteval` evaluation? They > look

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker updated this revision to Diff 203115. Tyker marked an inline comment as done. Tyker edited the summary of this revision. Tyker added a comment. changed as requested. hasExplicitSpecifier now gives access to the expression if present. CHANGES SINCE LAST ACTION

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. @rsmith friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

Tyker added a comment. Herald added a subscriber: rnkovacs. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62399/new/ https://reviews.llvm.org/D62399 ___ cfe-commits mailing list

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2491 + if (DS.hasConstexprSpecifier() && DSC != DeclSpecContext::DSC_condition) { Diag(DS.getConstexprSpecLoc(), diag::err_typename_invalid_constexpr); DS.ClearConstexprSpec();

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker updated this revision to Diff 203551. Tyker marked 9 inline comments as done. Tyker added a comment. fixed requested changes except some i commented upon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 Files:

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. @rsmith ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker reclaimed this revision. Tyker added a comment. I closed it originally because it was inactive and i was working on other reviews. but i learned this is not how it is supposed to be done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62009: [clang] perform semantic checking in constant context

This revision was automatically updated to reflect the committed changes. Closed by commit rL363488: [clang] perform semantic checking in constant context (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL363493: [clang] Add storage for APValue in ConstantExpr (authored by Tyker, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker updated this revision to Diff 204916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63376/new/ https://reviews.llvm.org/D63376 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Expr.h clang/include/clang/AST/Stmt.h clang/include/clang/Sema/Sema.h

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker updated this revision to Diff 203725. Tyker marked 5 inline comments as done. Tyker added a comment. fixed requested changes. also adapted lldb to AST change. I will commit this when i have access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

Tyker updated this revision to Diff 203723. Tyker marked 4 inline comments as done. Tyker edited the summary of this revision. Tyker added a comment. fixed requested changes. i will commit it when i have access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62399/new/

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch improves diagnostic for invalid constexpr defaulted special members by adding notes explaining why the special member cannot be constexpr. example

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker updated this revision to Diff 204041. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63134/new/ https://reviews.llvm.org/D63134 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp Index: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 206121. Tyker edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 206464. Tyker edited the summary of this revision. Tyker added a comment. Change: - Add support for LValue, MemberPointer and AddrDiffExpr. - Add tests for importing. i wasn't able to test for some APValueKinds: FixePoint, ComplexInt, ComplexFloat,

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 206467. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

This revision was automatically updated to reflect the committed changes. Closed by commit rL363360: [clang] Dont segfault on incorrect using directive (PR41400) (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

This revision was automatically updated to reflect the committed changes. Closed by commit rL363361: [clang] Fixing incorrect implicit deduction guides (PR41549) (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61790: [C++20] add Basic consteval specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL363362: [C++20] add Basic consteval specifier (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker updated this revision to Diff 205645. Tyker marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61552/new/ https://reviews.llvm.org/D61552 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AST/DeclCXX.h

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6190 +/// cxxDeductionGuideDecl(isExplicit()) will match #6, but not #5. +/// cxxConstructorDecl(isExplicit()) will match #8, but not #7 or #9.

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker updated this revision to Diff 205602. Tyker added a comment. i was confuse because the log seemed like an error and it was happening in python2.7 and python3.7 but the actual error that was preventing generating the documentation only occurs in 3.7. it works in python2.7. CHANGES SINCE

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL363855: [clang] Adapt ASTMatcher to explicit(bool) specifier (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6190 +/// cxxDeductionGuideDecl(isExplicit()) will match #6, but not #5. +/// cxxConstructorDecl(isExplicit()) will match #8, but not #7 or #9. +AST_POLYMORPHIC_MATCHER(isExplicit,

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10298 + bool AllowFold = true, + bool StoreResult = true); ExprResult

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker updated this revision to Diff 205559. Tyker marked 3 inline comments as done. Tyker added a comment. fixed requested changes. > Are you getting errors from running it, or just incorrect output? the issue happens to me even on master so i suppose the input is correct. here is the error

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker updated this revision to Diff 205944. Tyker marked an inline comment as done. Tyker added a comment. made the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63376/new/ https://reviews.llvm.org/D63376 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10298 + bool AllowFold = true, + bool StoreResult = true); ExprResult VerifyIntegerConstantExpression(Expr *E,

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL364011: [clang] Small improvments after Adding APValue to ConstantExpr (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker edited the summary of this revision. Herald added a subscriber: rnkovacs. Changes: -

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63134/new/ https://reviews.llvm.org/D63134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. bug report Before this patch, implicit deduction guides were generated from the first declaration found by lookup.

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

Tyker updated this revision to Diff 203862. Tyker added a comment. fixed the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63072/new/ https://reviews.llvm.org/D63072 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch has multiple small improvements related to the APValue in ConstantExpr. changes: - APValue in ConstantExpr are now cleaned up using

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker updated this revision to Diff 204992. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63376/new/ https://reviews.llvm.org/D63376 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Expr.h clang/include/clang/AST/Stmt.h clang/include/clang/Sema/Sema.h

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: cfe/trunk/lib/Parse/ParseDecl.cpp:3939 + "both or neither of isAlreadyConsumed and " + "RangeEnd needs to be set"); +

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker updated this revision to Diff 200662. Tyker added a comment. most comments were fixed. but there is a few point on which the direction isn't clear. > I think all of the new warnings in the test cases here are undesirable (they > duplicate errors produced by the constant evaluator) in

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added projects: clang, LLVM. When using ConstantExpr we often need the result of the

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker updated this revision to Diff 200231. Tyker edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 Files: clang/include/clang/AST/Expr.h clang/include/clang/Sema/Sema.h clang/lib/AST/ExprConstant.cpp

[PATCH] D61790: [C++20] add consteval specifier

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. this revision adds the consteval specifier as specified by

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker updated this revision to Diff 199830. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Stmt.h clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaDecl.cpp

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. I changed the approach in the last revision. the information is now propagated using the expression evaluation context and then via booleans. I should have added a comment to make it clear. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2033 + + void setExplicitSpecifier(ExplicitSpecInfo ESI); + Tyker wrote: > Tyker wrote: > > rsmith wrote: > > > Generally we don't want to have setters in the AST; the AST is intended >

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2579 +assert( +!ES.getExpr() || +CXXConstructorDeclBits.HasTrailingExplicitSpecifier && Rakete wrote: > Your or needs parens or the disambiguation is wrong. i

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1539-1541 +uint64_t NumCtorInitializers : 64 - NumDeclContextBits - +NumFunctionDeclBits - +/*Other used bits in CXXConstructorDecl*/ 3;

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added a comment. could you commit this for me ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker created this revision. Tyker added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changes: - add an ast matcher for deductiong guide. - allow isExplicit matcher for deductiong guide. - add hasExplicitSpecifier matcher which matches for

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added a comment. yes i am on it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:9361 // Only consider converting constructors. -if (GD->isExplicit()) +if (!GD->isMaybeNotExplicit()) continue; rsmith wrote: > Tyker wrote: > > rsmith

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker marked an inline comment as done. Tyker added a comment. Fixed based on Feedback from @rsmith @martong @Rakete. feedback that weren't fixed have comment explaining why. Comment at: clang/include/clang/AST/DeclCXX.h:2033 + + void

[PATCH] D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture

Tyker added a comment. could you commit it for me please ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61556/new/ https://reviews.llvm.org/D61556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 208015. Tyker added a comment. fixed the comment for good, sorry for that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8503 +llvm::Expected ASTImporter::Import(const APValue ) { + APValue Result; martong wrote: > Tyker wrote: > > martong wrote: > > > Looks okay, but

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 207977. Tyker marked 2 inline comments as done. Tyker set the repository for this revision to rC Clang. Tyker added a comment. fixed comment typo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8503 +llvm::Expected ASTImporter::Import(const APValue ) { + APValue Result; martong wrote: > Looks okay, but could we have unit tests for this in ASTImporterTest.cpp? I tested importing

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker added a comment. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changes: - Calls to consteval function and constructors are not evaluated as soon as they are reached. - Add diagnostic for taking address of a consteval function

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker added a comment. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63134/new/ https://reviews.llvm.org/D63134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker marked 2 inline comments as done. Tyker added a comment. sorry i didn't realize the full complexity of immediate invocations. i am working on a patch fixing issues. Comment at: clang/lib/Sema/SemaExpr.cpp:5761-5762 // in ArgExprs. - if ((FDecl = -

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 217600. Tyker added a comment. Sorry for the long wait. Changes: - Rebased on current master - Duplicated test file so that it runs for both importing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files:

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker updated this revision to Diff 217615. Tyker added a comment. Rebased @rsmith Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker updated this revision to Diff 217694. Tyker added a comment. Rebased on current master @rsmith Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63134/new/ https://reviews.llvm.org/D63134 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @rsmith Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63960: [C++20] Add consteval-specifique semantic for functions

Tyker updated this revision to Diff 219205. Tyker retitled this revision from "[C++20] Add consteval-specifique semantic" to "[C++20] Add consteval-specifique semantic for functions". Tyker added a comment. Herald added a subscriber: mgrang. I narrowed the patch because it was getting quite big.

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 219240. Tyker added a comment. Changes: - Rebased - Fixed typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker added a comment. @rsmith ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 221169. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/AST/APValue.cpp:176 + (DataSize - sizeof(MemberPointerBase)) / sizeof(CXXRecordDecl *); + typedef CXXRecordDecl *PathElem; union { Tyker wrote: > aaron.ballman

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 221166. Tyker marked 24 inline comments as done. Tyker added a comment. Fixed most changes requested by @aaron.ballman test are currently no valid anymore see comments for why. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:275 - /// Used to cleanups APValues stored in the AST. - mutable llvm::SmallVector APValueCleanups; - aaron.ballman wrote: > Why are you getting rid of this? It seems like we would

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 222169. Tyker marked 3 inline comments as done. Tyker added a comment. made renamings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221384. Tyker marked 12 inline comments as done. Tyker retitled this revision from "[clang] Improve Serialization/Imporing of APValues" to "[clang] Improve Serialization/Imporing/Dumping of APValues". Tyker edited the summary of this revision. Tyker added a

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/include/clang/AST/APValue.h:618 } + const CXXRecordDecl **getMemberPointerPathPtr(); }; aaron.ballman wrote: > We're horribly inconsistent in this class, but because the other private > member functions go

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221568. Tyker marked 7 inline comments as done. Tyker added a comment. fixed most comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/lib/AST/APValue.cpp:599 Out << '[' << Path[I].getAsArrayIndex() << ']'; -ElemTy = Ctx.getAsArrayType(ElemTy)->getElementType(); +ElemTy = cast(ElemTy)->getElementType(); }

[PATCH] D67889: [clang] fixing conditional explicit for out-of-line definition PR42980

Tyker created this revision. Tyker added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. not every read in CXXConstructorDecl::getExplicitSpecifierInternal() was made on the canonical declaration. Repository: rC Clang

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 228197. Tyker added a comment. minor fixes improved tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 227909. Tyker added a comment. @rsmith Changes: - Rebased on recent master. - Adapted this patch to constexpr destructors. - Fixed issues with handling of temporaries. - Improve Tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker created this revision. Tyker added a reviewer: rsmith. Tyker added a project: clang. Herald added a subscriber: cfe-commits. Tyker added a parent revision: D69360: [NFC] Refactor representation of materialized temporaries. Add support for merging lifetime-extended temporaries Repository:

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker added a comment. > 2. Change the constant expression representation for a pointer or reference > for a materialized temporary to refer to the temporary declaration instead. I analyzed change 2 in this list and this require changing a very significant number of users many of them being

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker added inline comments. Comment at: clang/lib/AST/TextNodeDumper.cpp:1349-1350 + } + OS << " subexpr"; + dumpPointer(D); +} rsmith wrote: > We shouldn't need this: the address of the declaration is dumped anyway by > the infrastructure. (If you meant to

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker updated this revision to Diff 229176. Tyker added a comment. fixed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/TextNodeDumper.h

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/AST/TextNodeDumper.cpp:1349-1350 + } + OS << " subexpr"; + dumpPointer(D); +} Tyker wrote: > rsmith wrote: > > We shouldn't need this: the address of the declaration is

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker updated this revision to Diff 229156. Tyker marked 6 inline comments as done. Tyker added a comment. fixed most comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229718. Tyker added a comment. Herald added a reviewer: deadalnix. Herald added subscribers: llvm-commits, ormris, hiraditya. Herald added a project: LLVM. fixe the issue causing buildbot failure. node were visited multiple time by the RecursiveASTVisitor in

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 Files: clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG08ea1ee2db5f: [NFC] Refactor representation of materialized temporaries (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker marked 6 inline comments as done. Tyker added a comment. i did a few test on the linux kernel on prior version of this patchs and the mix of spaces and tabs caused some false positives. but i do believe there is still a bug here. for the mix of space and tabs. gcc has a -ftabstop=//X// to

  1   2   3   >