[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. Yes, please. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-comm

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

dim added a comment. In D148474#4490041 , @dim wrote: > FWIW, this fix works for the test cases I had via > https://bugs.freebsd.org/269067 and > https://github.com/llvm/llvm-project/issues/60182, but I got the following > failure This was with `llvmo

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

dim requested changes to this revision. dim added a comment. This revision now requires changes to proceed. FWIW, this fix works for the test cases I had via https://bugs.freebsd.org/269067 and https://github.com/llvm/llvm-project/issues/60182, but I got the following failure during check-all:

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim added a comment. In D152788#4439714 , @shafik wrote: > Thank you for this improvement! Well, it would still be nice to have the instantiation trace, as Aaron suggested. So that is probably one of those "exercise for the reader" things. :D Reposito

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69d42eef4bec: [Clang] Show type in enum out of range diagnostic (authored by dim). Changed prior to commit: https://reviews.llvm.org/D152788?vs=53

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2479-2486 +template struct Bitfield { + static constexpr T max = static_cast((1 << size) - 1); +}; + +void testValueInRangeOfEnumerationValuesViaTemplate() { + Bitfield good; + Bitfield bad

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim updated this revision to Diff 531013. dim added a comment. Squash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152788/new/ https://reviews.llvm.org/D152788 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.t

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim updated this revision to Diff 531011. dim added a comment. Add release note and test with template instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152788/new/ https://reviews.llvm.org/D152788 Files: clang/docs/ReleaseNotes.rst

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim created this revision. dim added reviewers: aaron.ballman, erichkeane, shafik, thakis. Herald added a project: All. dim requested review of this revision. Herald added a project: clang. When the diagnostic for an out of range enum value is printed, it currently does not show the actual enum ty

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dim added a subscriber: bsdjhb. dim added a comment. In D150226#4353911 , @aaron.ballman wrote: > One of the major selling points to `constexpr` functions in C++ is that they > cannot contain UB -- if your code compiles, it is correct. This bug that >

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dim added a comment. I submitted a similar workaround for the FreeBSD devel/gdb port, via https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271045 that also applies `-Wno-enum-constexpr-conversion`. As the upstream commit message said, they didn't see any other good way to get rid of the warnin

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb492316399a: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim added a comment. In D148822#4305188 , @simonbutcher wrote: > I can't see anything wrong with this patch and it looks pretty > straightforward to me, but is it necessary? > > '-Wtypedef-redefinition' is documented as not applying to system headers >

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim updated this revision to Diff 515409. dim added a comment. Also fix up arm_sve.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148822/new/ https://reviews.llvm.org/D148822 Files: clang/utils/TableGen/NeonEmitter.cpp clang/utils/TableGen/S

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim created this revision. dim added reviewers: t.p.northover, fpetrogalli, sdesmalen, az, LukeGeeson, stuij. Herald added a project: All. dim requested review of this revision. Herald added a project: clang. As of https://reviews.llvm.org/D79708, clang-tblgen generates both `arm_neon.h` and `arm

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

dim accepted this revision. dim added a comment. LGTM again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. I think this is fine. @emaste can you think of any objections? 8 and 9 are long gone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144823/new/ https

[PATCH] D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, are there no test cases which are affected by this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144778/new/ https://reviews.llvm.org/D144778

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim accepted this revision. dim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim added a comment. In D14#4142146 , @MaskRay wrote: > `isPPC32SecurePlt` is probably more accurate. I agree, good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llv

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. Yes, this is quite a bit nicer. Maybe run the isPPCSecurePlt() function through clang-format, just to be sure of the style? (I think you can ignore the weird libFuzzer Unit Test errors, they don't s

[PATCH] D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. In D144341#4140652 , @arichardson wrote: > LGTM, but I'll let @dim and @emaste decide if FreeBSD 8 code is still needed. No, these versions are ancient now

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

dim accepted this revision. dim added a comment. Yeah, this looks quite a bit nicer, and should be more maintainable. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144321/new/ https://reviews.llvm.org/D144321 __

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, some minor clang-format nits, but these aren't critical (to me at least :) Comment at: clang/lib/Basic/Targets/PPC.h:432 + Triple.getOSMajorVersion() >= 13)) || Trip

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

dim added a comment. In D144232#4136787 , @brad wrote: > I noticed this review. I have provided a more complete diff for review at > D144321 . Yeah I think that is probably the better option, hope @pkubaj and @adalava

[PATCH] D135171: FreeBSD: enable __float128 on x86

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-c

[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

dim added a comment. > GCC 12 -Wformat -pedantic emits a warning: > > warning: ISO C17 does not support the ‘%b’ gnu_printf format [-Wformat=] > > The behavior is not ported (and it's unclear to me how to implement it). If you really want this, I think it can be implemented by looking at `Lang

[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

dim accepted this revision. dim added a subscriber: emaste. dim added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131057/new/ https://reviews.llvm.org/D131057

[PATCH] D130063: [Driver] Enable sanitizers on FreeBSD AArch64

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, are there any tests that need to be enabled explicitly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130063/new/ https://reviews.llvm.org/D1300

[PATCH] D117388: [Driver][FreeBSD] -r: imply -nostdlib like GCC

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117388/new/ https://reviews.llvm.org/D117388

[PATCH] D94355: [Passes] Add relative lookup table converter pass

dim added subscribers: emaste, jrtc27, dim. dim added a comment. FWIW, this commit turned out to break the FreeBSD dns/bind916 port, see https://bugs.freebsd.org/259921. The short story is that the bind9 code on and after this line: https://gitlab.isc.org/isc-projects/bind9/-/blob/main/lib/isc/

[PATCH] D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf08b2fe8b35: [AArch64] Avoid crashing on invalid -Wa,-march= values (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values

dim updated this revision to Diff 390218. dim added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114677/new/ https://reviews.llvm.org/D114677 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp clang/test/D

[PATCH] D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values

dim created this revision. dim added reviewers: jcai19, ostannard, DavidSpickett, nickdesaulniers. Herald added subscribers: kristof.beyls, krytarowski, arichardson. dim requested review of this revision. Herald added a project: clang. As reported in https://bugs.freebsd.org/260078, the gnutls Mak

[PATCH] D114396: [Driver] Default to current FreeBSD profiling behaviour

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114396/new/ https://reviews.llvm.org/D114396 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

dim added a subscriber: emaste. dim added a comment. In D111863#3072023 , @housel wrote: > It's also worth noting that FreeBSD's version of libgcc exception handling is > actually based on the libunwind code, with a local patch >

[PATCH] D110213: [PowerPC] Define XL-compatible macros only for AIX and Linux

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. FWIW I think this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110213/new/ https://reviews.llvm.org/D110213 ___

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

dim added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9937 + if (E->isElidable() && !ZeroInit) { +// FIXME: This only handles the simples case, where the source object +//is passed directly as the first argument to the constructor. ---

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

dim added a comment. I can at least confirm that both the original test case for bug 51862 (from https://github.com/Macaulay2/frobby ) and the reduced test case compile successfully with this patch added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

dim added a comment. In D104386#2977302 , @nemanjai wrote: > The idea with putting all of these in a separate function was to: > > 1. Make it easy to limit it to specific targets as I suggested above > 2. Have them all in one place to easily identify whic

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

dim added a comment. Just encountered another similar error, apparently introduced in rGc8937b6cb9751807de1e69f0f0f70a9a58f8f5dc (as more additions to the `defineXLCompatMacros` function, by @lei): In file included from /h

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

dim added subscribers: adalava, jhibbits. dim added a comment. In D104386#2973372 , @nemanjai wrote: > In D104386#2973245 , @dim wrote: > >> Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've l

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

dim added subscribers: emaste, dim. dim added a comment. Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've long used the following in our `lib/libc/powerpc64/string/bcopy.S`: #ifndef FN_NAME #ifdef MEMMOVE #define FN_NAME __memmove WEAK_REFERE

[PATCH] D105594: cmake: Allow shared libraries to customize the soname using LLVM_ABI_REVISION

dim added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:5 +set(LLVM_ABI_REVISION 0) + # Building libclang-cpp.so fails if LLVM_ENABLE_PIC=Off Is this actually needed? This CMakeLists.txt calls `add_clang_library()` in `clang/cmake/modules/

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. I mostly agree with this, but for the "silent ignoring" of `-pg` which this achieves. What would be the consequence of producing an error instead, like `-pg not supported for FreeBSD >= 14` ? Too m

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

dim accepted this revision. dim added a comment. LGTM, but this would probably need some sort of test, at least that it correctly accepts the flag(s) now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98286/new/ https://reviews.llvm.org/D98286 __

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

dim added a comment. @sylvestre.ledru removed the minor version from the binary (on purpose, I think?) in rGa8b717fda42294d1c8e1f05d71280503e5839f14 : commit a8b717fda42294d1c8e1f05d71280503e5839f14 Author: Sylvestre Ledru

[PATCH] D44964: Change order of libclang_rt.profile link for freebsd

dim added a comment. Yes, this looks pretty fine to me, but indeed needs a test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44964/new/ https://reviews.llvm.org/D44964 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

dim added a comment. In D73425#2266446 , @Bdragon28 wrote: > Any chance of a backport to 11? I submitted https://bugs.llvm.org/show_bug.cgi?id=47485 for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc2dac4116df: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/ne

[PATCH] D44536: Avoid segfault when destructor is not yet known

dim added a comment. Hm, this review's still open after two years, and even as of 2020-08-02 clang still crashes on the sample. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44536/new/ https://reviews.llvm.org/D44536 _

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

dim added a comment. In D6#2187334 , @myfreeweb wrote: > In D6#2187273 , @dim wrote: > >>> +#ifdef __FreeBSD__ >>> + return __FreeBSD_version / 10; >>> +#else >>> + return 10; >>> +#endif >

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

dim added a comment. In D6#1993211 , @arichardson wrote: > I don't like the fact that this only changes one of the users of > `getTriple().getOSMajorVersion()`. Why not, if this is a one-off case, it's perfectly OK to put it in here. Maybe add a com

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

dim added a comment. In D83645#2160761 , @MaskRay wrote: > @dim > > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > > arc

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

This revision was automatically updated to reflect the committed changes. Closed by commit rG02cfa7530d9e: Bump the default target CPU for i386-freebsd to i686 (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83645/new/ https://revie

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

dim created this revision. dim added reviewers: emaste, brooks, rsmith. Herald added subscribers: jfb, krytarowski, arichardson. Herald added a project: clang. Similar to what we have done downstream, some time ago: https://svnweb.freebsd.org/changeset/base/353936 This followed some discussions o

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a subscriber: asbirlea. dim added a comment. Okay, after a long while of attempting to make a reproduction scenario, I finally managed one that consistently worked. As BSD make puts in different redirections for stderr when running in `-j` mode, it turned out that I could simply run t

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a comment. For completeness sake, here are the valgrind outputs of clang rGf7f1abdb889 (llvmorg-11-init-16778) built by gcc 9.3.0-10ubuntu2 (in RelWithDebInfo mode): F12078364: llvmorg-11-init-16778-gf7f1abdb889-gcc-

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a comment. In D69825#2071687 , @dim wrote: > Trying to reduce this now. Unfortunately this turned out to be a red herring, as the test case got reduced by `creduce` to just: a() { b(""); } The valgrind warnings are also different when you

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a comment. In D69825#2070926 , @hans wrote: > In D69825#2063979 , @dim wrote: > > > FWIW, this change causes > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630, see in particular > > https://bu

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a comment. FWIW, this change causes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630, see in particular https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630#c18. For some reason, not spawning a new process for the cc1 stage can lead to non-reproducible output. The exact c

[PATCH] D77776: [Driver] Drop support for FreeBSD < 10

dim added a comment. In D6#1971543 , @arichardson wrote: > Alternatively, the checks could be changed to also handle OSMajorVersion == 0 > and translate that to 10. > This seems to be what NetBSD.cpp does. Darwin.cpp also infers the version > from t

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

dim added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11180 +// Avoid emiting call for runtime decision on PowerPC 32-bit +// The lock free possibilities on this platform are covered by the lines `s/emiting/emitting/` Repository: r

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

dim added a comment. Aha, which version of clang-cl are you using? With the released version of clang-cl 9.0.1, I get a warning instead of an error: cleanup.cpp(15,5): warning: jump from this goto statement to its label is a Microsoft extension [-Wmicrosoft-goto] goto clean

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

dim added a comment. Eh, no it does not crash clang, at least not here? Instead it gives you a compile error, as it should: cleanup.cpp:15:5: error: cannot jump from this goto statement to its label goto clean_up; ^ cleanup.cpp:20:7: note: jump bypasses v

[PATCH] D71827: [clang] avoid strict aliasing violation in assert

dim added inline comments. Comment at: clang/include/clang/AST/DeclContextInternals.h:102 // at getLookupResult. -assert(*(NamedDecl **)&Data == ND && +assert(Data.getAddrOfPtr1() && *Data.getAddrOfPtr1() == ND && "PointerUnion mangles the NamedDecl point

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72014/new/ https://reviews.llvm.org/D72014 ___ cfe-

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee31adb7fa42: Populate CUDA flags on FreeBSD too, as many other toolchains do. (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/ h

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

dim added a comment. In D69990#1750348 , @tra wrote: > LGTM, though I'm curious if it's particularly useful. Last time I checked > NVIDIA didn't ship libcudart for FreeBSD and without it it's rather > cumbersome to use CUDA in practice. After extractin

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

dim added reviewers: tra, yaxunl, ABataev. dim added a comment. Adding a few people who might know a bit more about CUDA specific things. Please take a look if this review makes any sense, thanks. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

dim updated this revision to Diff 229883. dim added a comment. - Add cuda options test, copied from cuda-options.cu. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/ https://reviews.llvm.org/D69990 Files: clang/lib/Driver/ToolChains/Free

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

dim edited reviewers, added: dim, emaste; removed: clang. dim added a comment. I'll work on a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/ https://reviews.llvm.org/D69990 ___ cfe-comm

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

This revision was automatically updated to reflect the committed changes. Closed by commit rG3db6783d8a7d: Check result of emitStrLen before passing it to CreateGEP (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70143/new/ https://

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim updated this revision to Diff 229172. dim added a comment. Now `opt` supports `-disable-builtin`, move the test to `llvm/test/Transforms/InstCombine`. Also use code style of nearest preceding constructs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim added a comment. I submitted D70193 for adding a `-disable-builtin` option to `opt`. Once that is committed, this review can continue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70143/new/ https://reviews

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim marked an inline comment as done. dim added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:370 +: nullptr; +} return nullptr; jdoerfert wrote: > Consistent style please: > > ``` > if (Value *StrLen =

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim added a comment. In D70143#1742885 , @lebedev.ri wrote: > This should have a llvm ir test in `llvm/test/transforms/instcombine` i > think, not a clang test. Yes, I thought so too, but I could not get it to work (i.e. crash) with LLVM IR. I just do

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim created this revision. dim added reviewers: xbolva00, spatel, jdoerfert, efriedma. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This fixes PR43081, where the transformation of `strchr(p, 0) -> p + strlen(p)` can cause a segfault, if `-fno-builtin-strlen

[PATCH] D70110: [Driver][FreeBSD] Enable unwind tables on !amd64

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70110/new/ https://reviews.llvm.org/D70110 ___ cfe-c

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

dim added a comment. Hm, I would really say that `__isnan` and the other `__` prefixed functions are Linuxisms, or more accurately, glibc-isms. They also don't exist on e.g. macOS: $ cat check-isnan.cpp #include int check_isnan(double d) { return ::__isnan(d); } $ clang -

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

dim abandoned this revision. dim added a comment. Herald added a subscriber: libcxx-commits. Obsoleted by D58425 (and rCXX354515 ). Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47987/new/

[PATCH] D67992: [Sema] Add FunctionTypeUnwrapper

dim added a comment. This works for me, and also for the original test case from https://bugs.freebsd.org/240764. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67992/new/ https://reviews.llvm.org/D67992 _

[PATCH] D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher

This revision was automatically updated to reflect the committed changes. Closed by commit rL372261: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher (authored by dim, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[PATCH] D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher

dim created this revision. dim added reviewers: emaste, jhibbits, hfinkel. Herald added subscribers: steven.zhang, shchenz, jsji, MaskRay, kbarton, krytarowski, nemanjai. Herald added a project: clang. In https://svnweb.freebsd.org/changeset/base/349351, FreeBSD 13 and higher transitioned to Secu

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

dim abandoned this revision. dim added a comment. No longer needed after rC362328 and follow-ups. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62873/new/ https://reviews.llvm.org/D62873

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

dim created this revision. dim added reviewers: hintonda, dcoughlin, NoQ. Herald added subscribers: dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. Herald added a project: clang. Attempting to build clang with CLANG_ENABLE_STATIC_ANALYZER=OFF fails after rC362328

[PATCH] D60748: Fix i386 struct and union parameter alignment

dim added a comment. In fact, it is probably better to turn the OS check around, e.g. *only* increase the alignment for Linux, and nowhere else. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 ___ c

[PATCH] D60748: Fix i386 struct and union parameter alignment

dim added subscribers: emaste, dim. dim added a comment. Please also exclude FreeBSD from these changes, since we care a lot about backwards compatibility, and specifically about alignment requirements. (We have run into many issues in our ports collection where upstream assumes everything is

[PATCH] D55576: [libcxx] [test] [support] Use socket()+bind() to create unix sockets portably

dim added a comment. In D55576#1332370 , @mgorny wrote: > @dim, thanks for the review. Should I also try removing the following > restriction? > > #if !defined(__APPLE__) && !defined(__FreeBSD__) // No support for domain > sockets > {env.crea

[PATCH] D55576: [libcxx] [test] [support] Use socket()+bind() to create unix sockets portably

dim accepted this revision. dim added a comment. LGTM. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55576/new/ https://reviews.llvm.org/D55576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D54724: [Driver] Automatically include C++ library dependencies

dim added a comment. In https://reviews.llvm.org/D54724#1303844, @phosek wrote: > In https://reviews.llvm.org/D54724#1303809, @dim wrote: > > > I think this is the wrong direction, placing "common" code in > > `addCXXStdlibLinkDeps`, which then has all kinds of ugly ifs and switches > > for dif

[PATCH] D54724: [Driver] Automatically include C++ library dependencies

dim added a comment. I think this is the wrong direction, placing "common" code in `addCXXStdlibLinkDeps`, which then has all kinds of ugly ifs and switches for different OSes? Let different OSes handle this in their own way, maybe. Until now I have not encountered an issue where I needed to a

[PATCH] D52394: [libcxx] Fix the definition of the check-cxx-abilist target on Darwin

dim added a comment. Ah, sorry about that! I should have realized this, but my CMake-fu is weak. :) Repository: rL LLVM https://reviews.llvm.org/D52394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D50799: Fix for PR 38495: no longer compiles on FreeBSD, due to lack of timespec_get()

dim accepted this revision. dim added a comment. LGTM. https://reviews.llvm.org/D50799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

This revision was automatically updated to reflect the committed changes. Closed by commit rL336008: Request init/fini array on FreeBSD 12 and later (authored by dim, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D24867?vs=72282&id=15

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

dim created this revision. dim added reviewers: hiraditya, mclow.lists, EricWF. Herald added subscribers: christof, krytarowski, emaste. In https://reviews.llvm.org/rL279903, @hiraditya added a second declaration of `__throw_runtime_error` to `include/__locale`. The original declaration was in `_

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

dim added a comment. Brooks, I can commit this if you prefer. Maybe it can go into 6.0.2 still... https://reviews.llvm.org/D24867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45406: Document -std= values for different languages

This revision was automatically updated to reflect the committed changes. Closed by commit rL329827: Document -std= values for different languages (authored by dim, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45406?vs=141529&id=142

[PATCH] D45406: Document -std= values for different languages

dim added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D45406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >