[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

jroelofs added a comment. In D157283#4611447 , @PiotrZSL wrote: > I don't know how, but somehow this change breaks > clang-tidy/infrastructure/clang-tidy-mac-libcxx.cpp test. I think we have a patch for that... @ldionne WDYT about upstreaming

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283

[PATCH] D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a135bceb66b: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets. (authored by jroelofs). Repository: rG LLVM Github

[PATCH] D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

jroelofs created this revision. jroelofs added reviewers: aemerson, tellenbach. Herald added subscribers: ormris, inglorion. Herald added a project: All. jroelofs requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. ... that have the

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. In D157119#4564546 , @vitalybuka wrote: > I suspect one of your recent changes broke > https://lab.llvm.org/buildbot/#/builders/168/builds/14944 > Can you please take a look? Happy to take a look, but there are 28 commits in

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. missed one more: 3d756c32cdf005d0f4c05f561fec4a37b64b7ddd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. back-porting to the release branch: https://github.com/llvm/llvm-project/issues/64432 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fb1c1082c01: cmake: add missing dependencies on ClangDriverOptions tablegen (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. related discussion: https://discourse.llvm.org/t/rfc-permanently-fixing-the-missing-tablegen-dependency-issue/70442/14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs created this revision. jroelofs added a reviewer: steven_wu. Herald added subscribers: PiotrZSL, kadircet, steakhal, carlosgalvezp, abrachet, martong, arphaman, kbarton, nemanjai. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. Herald added a project: All. jroelofs

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

jroelofs added a subscriber: lei. jroelofs added a comment. In D74094#4559037 , @dexonsmith wrote: > In D74094#4554327 , @foad wrote: > >> Hi @erik.pilkington, I see this got reverted: > > I'm not sure if

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

This revision was automatically updated to reflect the committed changes. Closed by commit rGed83797f3cbf: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn. (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 546219. jroelofs added a comment. Rebase. Avoid the dependency on D156735 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 Files:

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 545781. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 Files: clang/test/CodeGenObjC/arc.m clang/test/CodeGenObjC/convert-messages-to-runtime-calls.m llvm/include/llvm/IR/Intrinsics.td

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs added a comment. oops, uploaded the wrong patch to this review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 ___ cfe-commits mailing list

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 545779. jroelofs added a comment. Move the `stripPointerCasts()` change into its own review: https://reviews.llvm.org/D156735 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs added a comment. In D105671#4547848 , @nikic wrote: > Please separate the change to stripPointerCasts() into a separate review. https://reviews.llvm.org/D156735 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 545752. Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 Files: clang/test/CodeGenObjC/arc.m

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jroelofs added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5391 if (FPtr->hasFnAttribute(llvm::Attribute::NoUnwind)) CannotThrow = true; + Is there coverage for a nounwind callee + an unwindabort call? Repository: rG LLVM Github

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jroelofs added inline comments. Herald added a subscriber: jplehr. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2021 + /* Indicates whether we should generate calls using unwindabort, instead of a + * terminate landingpad, for the current EH Scope. */ + bool

[PATCH] D155509: Revert "Remove rdar links; NFC"

jroelofs added a comment. Do you think this and the other patch are good candidates for `.git-blame-ignore-revs` entries? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

jroelofs added a comment. gcc docs seem to indicate that these are valid triples: https://gcc.gnu.org/install/specific.html#powerpc-x-eabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

jroelofs added a comment. I don't think those failures look related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357 ___ cfe-commits mailing list

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

jroelofs added inline comments. Comment at: clang/unittests/AST/UnresolvedSetTest.cpp:11 +}; +} // namespace clang + jroelofs wrote: > This ODR violation broke the build for me because it's picking up the > definition from Decl.h instead of this one. > > ``` >

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

jroelofs added inline comments. Comment at: clang/unittests/AST/UnresolvedSetTest.cpp:11 +}; +} // namespace clang + This ODR violation broke the build for me because it's picking up the definition from Decl.h instead of this one. ```

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

jroelofs added a comment. > It seems to me that maybe anything with OS none (although that doesn’t seem > to be distinguished from unknown) I considered splitting `none` from `unknown` in Triple, but never had the time to do it. I think this would be good for baremetal toolchains in light of

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/Attr.td:1474 + let Spellings = [Clang<"nooutline">]; + let Subjects = SubjectList<[Function, ObjCMethod]>; + let

[PATCH] D150325: WIP: Prototype #ifdef-enforced DEPENDS on tablegen output

jroelofs added a comment. link back to the discourse thread: https://discourse.llvm.org/t/rfc-permanently-fixing-the-missing-tablegen-dependency-issue/70442/14?u=jroelofs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150325/new/

[PATCH] D150325: WIP: Prototype #ifdef-enforced DEPENDS on tablegen output

jroelofs created this revision. Herald added subscribers: steakhal, wenlei, martong, arphaman, hiraditya. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. jroelofs requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D139822: Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR compiler-rt

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139822/new/ https://reviews.llvm.org/D139822

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs added a comment. In D105671#2978248 , @rjmccall wrote: > How does `stripPointerCasts` "see through" an attribute on the underlying > call instruction?

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 369584. jroelofs added a comment. Herald added a subscriber: dexonsmith. Rebased. Also, turns out that `stripPointerCasts()` can see through the `thisreturn` attribute, which defeats a self retain optimization, breaking one of the clang tests. I tweaked a

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs added a comment. In D105671#2884483 , @rjmccall wrote: > IIUC, we sometimes turn `-retain` message sends into calls to `objc_retain` > and so on. Outside of ARC (the only time they're valid), these calls don't > have the semantics of

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 364215. jroelofs added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a note/check to the `[x retain] => objc_retain(x)` test explaining why it shouldn't be lowered as an intrinsic call in the future. Repository:

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

jroelofs added a comment. I moved a couple of new tests from this patch from CodeGen -> CodeGen/PowerPC so they don't fail when the PPC backend isn't built: f6769b663a0d4432b5e00e0c03904a5dfba7b077 Repository: rG LLVM

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jroelofs added a comment. > compiler-rt depends on a libc, typically newlib, which then depends on your > compiler The builtins should only depend on compiler-provided headers, and not on the rest of libc. Agreed re: the rest of compiler-rt. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jroelofs added a comment. Why do you want to ship the builtins as part of your sysroot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 ___ cfe-commits mailing

[PATCH] D95070: Fix crash when emitting NullReturn guards for functions returning BOOL

jroelofs closed this revision. jroelofs added a comment. This landed in 1deee5cacbb76578367186d7ff2937b6fa79b827 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95070/new/

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

jroelofs added a comment. why do module hashes need to be stable when cross-compiling? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 ___ cfe-commits mailing

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jroelofs added a comment. In D97068#2617642 , @ggeorgakoudis wrote: > Add triple to avoid spurious failures in tests They're not really spurious, right... Doesn't this mean that `utils/update_cc_test_checks.py` is now broken for people who develop on a

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jroelofs reopened this revision. jroelofs added a comment. This revision is now accepted and ready to land. Reverted in a24644bb1ce09b40c2d751569dd5bb37ea9c995d to get the bots green again. Feel free to re-land with a fix.

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jroelofs added a comment. In D97068#2611696 , @ggeorgakoudis wrote: > In D97068#2611269 , @thakis wrote: > >> Looks like this breaks tests on mac: http://45.33.8.238/macm1/5075/step_6.txt >> >> Please take a look,

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f6e3316456f: Support `#pragma clang section` directives on MachO targets (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs updated this revision to Diff 326126. jroelofs added a comment. Mark section invalid if the target doesn't like how it's spelled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97233/new/ https://reviews.llvm.org/D97233 Files:

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:304 + if (llvm::Error E = Context.getTargetInfo().isValidSectionSpecifier(SecName)) +Diag(PragmaLoc, diag::err_pragma_section_invalid_for_target) t.p.northover wrote: > Shouldn't this

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs updated this revision to Diff 325798. jroelofs added a comment. `git clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97233/new/ https://reviews.llvm.org/D97233 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs updated this revision to Diff 325599. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97233/new/ https://reviews.llvm.org/D97233 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Basic/TargetInfo.h

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs added inline comments. Comment at: llvm/test/CodeGen/AArch64/clang-section-macho.ll:8 + +attributes #0 = { "implicit-section-name"="TEXT,mytext" } + `"__TEXT,__mytext"` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs created this revision. jroelofs added reviewers: t.p.northover, javed.absar, rogfer01. Herald added a subscriber: hiraditya. Herald added a reviewer: aaron.ballman. jroelofs requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D95070: Fix crash when emitting NullReturn guards for functions returning BOOL

jroelofs updated this revision to Diff 317959. jroelofs added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95070/new/ https://reviews.llvm.org/D95070 Files: clang/lib/CodeGen/CGObjCMac.cpp

[PATCH] D95070: Fix crash when emitting NullReturn guards for functions returning BOOL

jroelofs created this revision. jroelofs added reviewers: rjmccall, arphaman. jroelofs requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CodeGenModule::EmitNullConstant() creates constants with their "in memory" type, not their "in vregs"

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

jroelofs added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:108 + + return std::string(SysRootDir.str()); +} abidh wrote: > jroelofs wrote: > > Small string has an implicit conversion to std::string, so you can just > > `return

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

jroelofs added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:105 + + return std::string(SysRootDir); +} did `return SysRootDir;` not work? Why do you need the explicit std::string ctor call? CHANGES SINCE LAST ACTION

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:105 + + if (!llvm::sys::fs::exists(SysRootDir)) +return std::string(); Why not always

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

jroelofs accepted this revision. jroelofs added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39 +llvm::sys::path::append(SysRoot, "lib"); +getFilePaths().push_back(std::string(SysRoot.str())); +

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Seems reasonable. I could see someone wanting to use `--gcc-toolchain` to point at the baremetal toolchain for their target, but that's unlikely to work out of the box anyway. I'd love

[PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. More context: https://www.openwall.com/lists/musl/2013/03/29/13 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13673/new/ https://reviews.llvm.org/D13673 ___ cfe-commits mailing list

[PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. In D13673#2394064 , @ldionne wrote: > @vkalintiris @jroelofs Is it possible to detect Musl through some macro? I'd > like to get rid of the CMake option -- this isn't the sort of property that > we want to set explicitly at

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51c5add8547a: Extending Baremetal toolchains support for the rtlib option. (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs added a comment. btw, do you need me to commit it for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/ https://reviews.llvm.org/D87164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Yeah, this should do what you're after. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/ https://reviews.llvm.org/D87164

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs added a comment. In D87164#2268366 , @mcarrasco wrote: > @jroelofs no worries, thanks a lot for your time. > > Please tell me if I understood you correctly. > > It is acceptable just to append the -lgcc if -rtlib=libgcc is used, although > the

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs added a comment. > The Baremetal toolchain currently has a fixed behavior regardless of the > -rtlib option's value. It is always linking against compiler-rt unless > -nodefaultlibs is enabled. > > This proposal slightly changes the code in such a way that enabling > -rtlib=libgcc

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

jroelofs added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:80 + zx_status_t status = zx_channel_create(0, , ); + // expected-note@-1 {{Handle allocated through 2nd parameter}} + if (status == 0) { // expected-note {{Assuming 'status' is equal to 0}}

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

jroelofs added subscribers: dcoughlin, jroelofs. jroelofs added inline comments. Herald added subscribers: ASDenysPetrov, martong. Comment at: clang/test/Analysis/fuchsia_handle.cpp:80 + zx_status_t status = zx_channel_create(0, , ); + // expected-note@-1 {{Handle allocated

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/docs/CodingStandards.rst:1582 +clear that it is a single line. Note that comments should only be hoisted for loops and +'if', and not in 'else if'

[PATCH] D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide

jroelofs closed this revision. jroelofs added a comment. 1e06b169be3e59799b8dcaf16d1d03bd4c12da42 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80436/new/

[PATCH] D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide

jroelofs created this revision. jroelofs added reviewers: jyknight, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. See also discussion following: http://lists.llvm.org/pipermail/llvm-dev/2012-May/050098.html Repository: rG LLVM Github Monorepo