[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 ___

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

kda added a comment. Is there a risk of this being too strict for standard C? Should there be a test case for our specific problem? (C calling C++) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

kda added a comment. The bracket builds have finished and they seem to have a conclusive result. The test starts failing with this patch. Built at this patch: https://lab.llvm.org/buildbot/#/builders/236/builds/803 Built at prior patch: https://lab.llvm.org/buildbot/#/builders/236/builds/804

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

kda added a comment. This may have broken HWASAN buildbot: https://lab.llvm.org/buildbot/#/builders/236/builds/786 Running a build just before and after to check to validate guess based on stack. log snippet: ==956880==ERROR: HWAddressSanitizer: tag-mismatch on address 0xc09c0031 at pc

[PATCH] D117622: [MSAN] removing redundant tests and parameters (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b509f2d1a19: [MSAN] removing redundant tests and parameters (NFC) (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117622: [MSAN] removing redundant tests and parameters (NFC)

kda added a comment. Just returning to finish this clean up. Comment at: compiler-rt/test/msan/noundef_analysis.cpp:5 // RUN: FileCheck %s < %t.out -// RUN: %clangxx_msan %s -disable-noundef-analysis -s -fsanitize-memory-param-retval -o %t && not %run %t >%t.out 2>&1 +//

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

kda updated this revision to Diff 457370. kda added a comment. Herald added a subscriber: Enna1. Herald added a project: All. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117622/new/ https://reviews.llvm.org/D117622 Files:

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

kda accepted this revision. kda added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:841 CmdArgs.push_back("-lexecinfo"); // There is no libresolv on Android. + if (!TC.getTriple().isAndroid() &&

[PATCH] D127177: Add checks for -lresolv to sanitizer-ld test. These were missed in https://reviews.llvm.org/D127145.

This revision was automatically updated to reflect the committed changes. Closed by commit rG69cd7417f01a: Add checks for -lresolv to sanitizer-ld test. (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127177/new/

[PATCH] D127177: Add checks for -lresolv to sanitizer-ld test. These were missed in https://reviews.llvm.org/D127145.

kda created this revision. kda added a reviewer: vitalybuka. Herald added a subscriber: cryptoad. Herald added a project: All. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D127145: [Driver] add -lresolv for all but Android.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6dce56b2a308: [Driver] add -lresolv for all but Android. (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda updated this revision to Diff 434634. kda marked an inline comment as done. kda added a comment. removed braces on single statement from conditional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127145/new/ https://reviews.llvm.org/D127145

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda added a comment. In D127145#3561519 , @eugenis wrote: > The interceptor (dn_expand) is only defined on linux && !android, while this > code links libresolv on *bsd and others, too. I think it's ok, as long as all > platforms with the interceptor

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda created this revision. kda added reviewers: vitalybuka, eugenis. Herald added subscribers: Enna1, danielkiss. Herald added a project: All. kda requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, MaskRay. Herald added projects: clang, Sanitizers. Repository:

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

kda added a comment. This has broken sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/24074 Relevant log snippet: FAIL: Clang :: OpenMP/atomic_messages.cpp (9696 of 66080) TEST 'Clang :: OpenMP/atomic_messages.cpp' FAILED

[PATCH] D120159: [Clang] Implement __builtin_source_location.

kda added a comment. Fix looks good. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120159: [Clang] Implement __builtin_source_location.

kda added a comment. This appears to have broken buildbot: sanitizer-x86_64-linux-fast Validating if reversion clears it up. Then will revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

kda accepted this revision. kda added inline comments. Comment at: compiler-rt/test/msan/dtor-base-access.cpp:24 +class TrivialBaseAfter { +public: + int tb1; nit: add single space (consistent indent). Comment at:

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

kda added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1872 // Ignore trivial destructors. + if (BaseClassDecl->hasTrivialDestructor()) { vitalybuka wrote: > kda wrote: > > Maybe not "Ignore"? > @kda I assume it's about inconsistent

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

kda added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1872 // Ignore trivial destructors. + if (BaseClassDecl->hasTrivialDestructor()) { Maybe not "Ignore"? Comment at: clang/lib/CodeGen/CGClass.cpp:1907 //

[PATCH] D119600: Stricter use-after-dtor detection for trivial members.

kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119600/new/ https://reviews.llvm.org/D119600 ___

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

kda added a comment. This still seems to be breaking sanitizers fast: https://lab.llvm.org/buildbot/#/builders/5/builds/18563 To reproduce these results: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

kda added a comment. This looks like it is breaking the sanitizer buildbot for android: https://lab.llvm.org/buildbot/#/builders/77/builds/13756/steps/21/logs/stdio Failed Tests (1): HWAddressSanitizer-aarch64 :: TestCases/stack-uas.c Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118205: [ASan] Added a unit test for D118184.

kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118205/new/ https://reviews.llvm.org/D118205

[PATCH] D118184: [ASan] Not linking asan_static library for DSO.

kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. unit test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118184/new/ https://reviews.llvm.org/D118184

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

kda updated this revision to Diff 401028. kda added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. remove "-s" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117622/new/ https://reviews.llvm.org/D117622

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

kda created this revision. kda added a reviewer: vitalybuka. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fixing up some comments and removing redundant tests. Repository: rG LLVM Github Monorepo

[PATCH] D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2)

kda added a comment. Herald added subscribers: luke957, asavonic. Breaks sanitizer buildbots: https://lab.llvm.org/buildbot/#/builders/5/builds/17422 (fast) AND https://lab.llvm.org/buildbot/#/builders/74/builds/8849 (MSAN) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/test/Driver/fsanitize-memory-param-retval.c:8-9 + +// RUN: %clang -target aarch64-linux-gnu -fsyntax-only %s -fsanitize=memory -fsanitize-memory-param-retval -c -### 2>&1 | FileCheck --check-prefix=11 %s +// 11:

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f93448235fe: enable noundef analysis with -fsanitize-memory-param-retval (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117293/new/

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

kda added a comment. In D117293#3243986 , @vitalybuka wrote: > In D117293#3243772 , @vitalybuka > wrote: > >> Just noticed, -enable-noundef-analysis is missing tests undef >>

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

kda added a comment. In D117293#3243735 , @vitalybuka wrote: > Nice! > >>> This completes the work found in: > > It's too late for this set of patches, but phabricator supports "Depends on" > comments (I guess only of the first patch upload), and

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

kda updated this revision to Diff 399937. kda added a comment. add missing files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117293/new/ https://reviews.llvm.org/D117293 Files: clang/include/clang/Driver/Options.td

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

kda created this revision. kda added a reviewer: vitalybuka. Herald added a subscriber: dang. kda requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Enable noundef analysis (-enable-noundef-analysis) via the

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0458b531cfc: Add -fsanitize-address-param-retval to clang. (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:362 + MemorySanitizerOptions{TrackOrigins, Recover, CompileKernel, + CGOpts.SanitizeMemoryParamRetval != 0})); vitalybuka wrote: > we use implicit cast

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399917. kda marked an inline comment as done. kda added a comment. rename file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files:

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399826. kda added a comment. Herald added a subscriber: ormris. enable eager-checks with -fsanitize-memory-param-retval Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399784. kda added a comment. Herald added subscribers: luke957, s.egerton, simoncook. Drop attribute changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files:

[PATCH] D117078: [NFC] Minimize noundef analysis when disabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa141e4713850: [NFC] Minimize noundef analysis when disabled (authored by kda). Changed prior to commit:

[PATCH] D117078: [NFC] Minimize noundef analysis when disabled

kda added a comment. In D117078#3238422 , @vitalybuka wrote: > my editor recommends me to keep git titles <50 chars > Maybe something shorter with exactly the same meaning > "[NFC] Optimize noundef analysis condition" Done! Repository: rG LLVM

[PATCH] D117078: [NFC] Minimize noundef analysis when disabled

kda updated this revision to Diff 399432. kda marked an inline comment as done. kda added a comment. reduce nesting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117078/new/ https://reviews.llvm.org/D117078 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added a comment. >>> This needs a clang/test/Driver test to show that `%clang >>> -fsanitize-memory-param-retval` translates to CC1 >>> `-fsanitize-memory-param-retval`. >> >> Could you point me to an example? > > `test/Driver/fpatchable-function-entry.c` `test/Driver/fbinutils-version.c`

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399362. kda added a comment. add test to validate that flag does not conflict with enable-noundef-analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files:

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

kda updated this revision to Diff 399352. kda added a comment. Herald added subscribers: luke957, s.egerton, simoncook. add param usage test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116701/new/ https://reviews.llvm.org/D116701 Files:

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

kda added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116701/new/ https://reviews.llvm.org/D116701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

kda updated this revision to Diff 399347. kda added a comment. Correcting diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116701/new/ https://reviews.llvm.org/D116701 Files: clang/include/clang/Driver/SanitizerArgs.h

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

kda updated this revision to Diff 399345. kda added a comment. Herald added subscribers: Sanitizers, ormris, dexonsmith, dang. Herald added a project: Sanitizers. enable eager-checks in llvm via flag (-fsanitize-memory-param-retval). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added a comment. In D116633#3226228 , @MaskRay wrote: > This needs a clang/test/Driver test to show that `%clang > -fsanitize-memory-param-retval` translates to CC1 > `-fsanitize-memory-param-retval`. Could you point me to an example?

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117078: Minor adjustment in order of noundef analysis to be a bit more optimal (when disabled).

kda created this revision. kda added reviewers: vitalybuka, eugenis. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117078 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399163. kda added a comment. A few improvements. - Add -fsanitize-address-param-retval to clang. - updated flag help text and dropped use of flag (to be picked up later). - adjust help text - refined rendering of help text - add code generation - introduce

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

kda updated this revision to Diff 398310. kda added a comment. add 3 parameter constructor for MemorySanitizerOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116634/new/ https://reviews.llvm.org/D116634 Files:

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

kda added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/MemorySanitizer.h:28 bool Recover; + bool EagerChecks; }; vitalybuka wrote: > maybe we should use CheckParamRetVal something here? > How about EagerChecksRequested?

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

kda updated this revision to Diff 398303. kda marked 2 inline comments as done. kda added a comment. Reworked for comments and to be llvm only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116634/new/ https://reviews.llvm.org/D116634 Files:

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/include/clang/Driver/Options.td:1675 + PosFlag, NegFlag, + BothFlags<[], "Detect uninitialized parameters and return values.">>, +Group; kda wrote: > kda wrote: > > MaskRay wrote: > > > MaskRay wrote: >

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 398266. kda added a comment. refined rendering of help text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/include/clang/Driver/Options.td:1675 + PosFlag, NegFlag, + BothFlags<[], "Detect uninitialized parameters and return values.">>, +Group; kda wrote: > MaskRay wrote: > > MaskRay wrote: > > > `--help`

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 398263. kda added a comment. adjust help text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda marked 2 inline comments as done. kda added inline comments. Comment at: clang/include/clang/Driver/Options.td:1675 + PosFlag, NegFlag, + BothFlags<[], "Detect uninitialized parameters and return values.">>, +Group; MaskRay wrote: > MaskRay

[PATCH] D116827: Don't pass uninitialized QueryKind

kda added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1313 } + if (IDs.empty()) +return {}; vitalybuka wrote: > kda wrote: > > It seems like the first line of 'findImplementors' is 'if (IDs.empty() || > > !Index)`. > > I wonder if

[PATCH] D116827: Don't pass uninitialized QueryKind

kda requested changes to this revision. kda added a comment. This revision now requires changes to proceed. I think I forgot to 'Request Changes'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/ https://reviews.llvm.org/D116827

[PATCH] D116827: Don't pass uninitialized QueryKind

kda added a comment. This seems to introduce a new branch, should there be a new unit test in: XRefsTests.cpp? Comment at: clang-tools-extra/clangd/XRefs.cpp:1313 } + if (IDs.empty()) +return {}; It seems like the first line of 'findImplementors' is

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2384 +if ((CodeGenOpts.EnableNoundefAttrs || + CodeGenOpts.SanitizeMemoryParamRetval) && +ArgNoUndef) eugenis wrote: > vitalybuka wrote: > > vitalybuka wrote: > > > @eugenis

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

kda created this revision. kda added a reviewer: vitalybuka. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implementation of flag introduced in https://reviews.llvm.org/D116633 Repository: rG LLVM Github Monorepo

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 397648. kda added a comment. trying again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/include/clang/Driver/Options.td:1675 + PosFlag, NegFlag, + BothFlags<[], "eager param-retval uninitialized use detection in MemorySanitizer">>, +Group; vitalybuka wrote: > Maybe "Detect initialized

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 397647. kda marked an inline comment as done. kda added a comment. updated help text and dropped implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files:

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

kda created this revision. kda added a reviewer: vitalybuka. Herald added subscribers: ormris, hiraditya. kda requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. follow up to

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda created this revision. kda added a reviewer: vitalybuka. Herald added subscribers: dexonsmith, dang. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the introduction of this flag, it is no longer necessary to enable noundef

[PATCH] D109967: Simplify handling of builtin with inline redefinition

kda added a comment. Broke fast buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/12360 reverting... A guide to reproducing sanitizer bots can be found here: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1dc005aa7dc5: Add documentation for -fsanitize-address-use-after-return. (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 357385. kda marked an inline comment as done. kda added a comment. - removed redundant mention of the flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files:

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 352849. kda marked an inline comment as done. kda added a comment. Herald added a subscriber: dang. - Responding to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda added a comment. F17415480: _usr_local_google_home_kda_src_uar_llvm-project_build_tools_clang_docs_html_AddressSanitizer.html.png Comment at: clang/docs/AddressSanitizer.rst:18 +* Use-after-return (clang flag

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 352289. kda marked 2 inline comments as done. kda added a comment. - more consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files:

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 352287. kda marked 2 inline comments as done. kda added a comment. - more beauty, added UsersManual changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files:

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 352153. kda added a comment. - attempting to make documentation pretty. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files: clang/docs/AddressSanitizer.rst

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 351571. kda marked an inline comment as done. kda added a comment. - Revised according to feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files:

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda created this revision. kda added a reviewer: vitalybuka. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. for issue: https://github.com/google/sanitizers/issues/1394 Repository: rG LLVM Github Monorepo

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0b469ffa142: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang. (authored by kda). Repository: rG LLVM Github Monorepo

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

kda added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2973 IRBuilder<> IRB(*C); - switch (ClUseAfterReturn) { - case AsanDetectStackUseAfterReturnMode::Always: -for (int i = 0; i <= kMaxAsanStackMallocSizeClass; i++) { -

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

kda updated this revision to Diff 351505. kda marked 9 inline comments as done. kda added a comment. - fixed up conflicting command line parameters. - only emit asan_stack_malloc calls when needed. - trimmed namespace ('llvm'). - improved tests. - Changed default parameters from Never to Runtime.

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

kda updated this revision to Diff 351316. kda added a comment. - Change default parameters from Invalid to Never. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104076/new/ https://reviews.llvm.org/D104076 Files:

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

kda created this revision. Herald added subscribers: ormris, dexonsmith, dang, hiraditya. kda requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Also: - add driver test (fsanitize-use-after-return.c) - add basic IR test

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda updated this revision to Diff 340754. kda added a comment. fixed up some more naming issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101122/new/ https://reviews.llvm.org/D101122 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda marked 4 inline comments as done. kda added a comment. Thank you for delineating the steps. Unfortunately, I don't know where to even start looking for the tests you mention in step 1. Are you looking for something like this: https://reviews.llvm.org/differential/changeset/?ref=2496958

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda updated this revision to Diff 340746. kda added a comment. Revisions as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101122/new/ https://reviews.llvm.org/D101122 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda added a comment. I'm new here. I was told to take small steps. This will eventually effect compiler-rt and llvm. I took the smallest possible step. What I had previously: https://reviews.llvm.org/D99630 And was told it was too large. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda created this revision. kda added a reviewer: vitalybuka. Herald added subscribers: jansvoboda11, dexonsmith, dang. kda requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. introduce flag

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

kda abandoned this revision. kda added a comment. will attempt in smaller pieces. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:3317 ConstantInt::get(IntptrTy, LocalStackSize)); -IRB.SetInsertPoint(InsBefore); -FakeStack

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

kda updated this revision to Diff 335558. kda added a comment. fixed tests for asan_interface.inc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99630/new/ https://reviews.llvm.org/D99630 Files: clang/docs/AddressSanitizer.rst

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

kda updated this revision to Diff 335362. kda added a comment. I think this patch is near completion. But the new code generated for the 'Always' case is definitely wrong. I could use some coaching. I will eventually figure it out, but an interactive session would probably help me along.

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

kda created this revision. Herald added subscribers: jansvoboda11, dexonsmith, dang, hiraditya. kda requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo