sepavloff updated this revision to Diff 137336.
sepavloff added a comment.
Use more consistent option names
Repository:
rC Clang
https://reviews.llvm.org/D43805
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenOptions.h
sepavloff added a comment.
In https://reviews.llvm.org/D43805#1029479, @pcc wrote:
> > If the backend will be changed so that it will not depend on IR type names
>
> Are you referring to https://reviews.llvm.org/D43199? If so it seems to me
> that this should be a cc1 flag that defaults to
pcc added a comment.
> If the backend will be changed so that it will not depend on IR type names
Are you referring to https://reviews.llvm.org/D43199? If so it seems to me that
this should be a cc1 flag that defaults to whether `-flto=thin` is passed. In
any case it seems like a bad idea to
sepavloff added inline comments.
Comment at: include/clang/Driver/Options.td:644
+ HelpText<"Whether to use IR type names (option: auto, none, use)">,
+ Values<"auto,none,use">;
+
rsmith wrote:
> Having "none" and "use" as values for the same option seems like
sepavloff marked an inline comment as done.
sepavloff added a comment.
In https://reviews.llvm.org/D43805#1029455, @pcc wrote:
> Why is this a driver flag? This seems like it ought to be a cc1-only flag to
> me.
Yous are right, this is more like development option. But having the driver
flag
rsmith added inline comments.
Comment at: include/clang/Driver/Options.td:644
+ HelpText<"Whether to use IR type names (option: auto, none, use)">,
+ Values<"auto,none,use">;
+
Having "none" and "use" as values for the same option seems like a category
error.
pcc added a comment.
Why is this a driver flag? This seems like it ought to be a cc1-only flag to me.
Repository:
rC Clang
https://reviews.llvm.org/D43805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Any feedback?
Thanks,
--Serge
2018-02-28 0:02 GMT+07:00 Serge Pavlov via Phabricator <
revi...@reviews.llvm.org>:
> sepavloff marked an inline comment as done.
> sepavloff added inline comments.
>
>
>
> Comment at: include/clang/Driver/Options.td:1735
> + HelpText<"Whether to
sepavloff marked an inline comment as done.
sepavloff added inline comments.
Comment at: include/clang/Driver/Options.td:1735
+ HelpText<"Whether to use IR type names (option: none, use)">,
+ Values<"none,use">;
def relocatable_pch : Flag<["-", "--"], "relocatable-pch">,
sepavloff updated this revision to Diff 136087.
sepavloff added a comment.
Updated patch
- command line option was renamed to `-fir-type-names=`,
- this option is not hidden, as most options in `-f` namespace,
- new value, `auto` was added to possible values of this option.
Repository:
rC
rjmccall added inline comments.
Comment at: include/clang/Driver/Options.td:1735
+ HelpText<"Whether to use IR type names (option: none, use)">,
+ Values<"none,use">;
def relocatable_pch : Flag<["-", "--"], "relocatable-pch">, Flags<[CC1Option]>,
This is an
sepavloff created this revision.
sepavloff added reviewers: rsmith, rjmccall.
Type in the LLVM IR may have names but only for the purpose of human
readability (see discussions in https://reviews.llvm.org/D40567,
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20171127/210816.html
and
12 matches
Mail list logo
