[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

This revision was automatically updated to reflect the committed changes. Closed by commit rG71177ac16801: [clangd] Support new semanticTokens request from LSP 3.16. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76663/new/

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76663/new/ https://reviews.llvm.org/D76663

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:452 + const HighlightingToken *Last = nullptr; + for (const HighlightingToken : Tokens) { +Result.emplace_back(); hokein wrote: > note that we don't calculate

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall updated this revision to Diff 252906. sammccall marked 6 inline comments as done. sammccall added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76663/new/ https://reviews.llvm.org/D76663 Files:

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

hokein added a comment. In D76663#1942273 , @sammccall wrote: > For some context here, I was doing some digging as Heyward Fann is looking at > hooking up our existing syntax highlighting to coc.nvim, and he and Jack Guo > (of

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall added a comment. For some context here, I was doing some digging as Heyward Fann is looking at hooking up our existing syntax highlighting to coc.nvim, and he and Jack Guo (of jackguo380/vim-lsp-cxx-highlight) were asking about the protocol. The new LSP protocol looks really solid,

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall updated this revision to Diff 252676. sammccall added a comment. Update SemanticHighlighting comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76663/new/ https://reviews.llvm.org/D76663 Files:

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is a simpler request/response protocol. Reference: