[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson abandoned this revision. LukeGeeson added a comment. Sub-issues all closed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77540/new/ https://reviews.llvm.org/D77540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added a comment. Hi folks, Thank you for your help, I have split the patches up as follows: 1. https://reviews.llvm.org/D77871 [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics 2. https://reviews.llvm.org/D77872 [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics 3.

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

fhahn added a comment. In D77540#1970034 , @LukeGeeson wrote: > In D77540#1969873 , @fhahn wrote: > > > This patch is quite big and I think it would be easier to review if it > > would be split up into distinct

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added a comment. In D77540#1969873 , @fhahn wrote: > This patch is quite big and I think it would be easier to review if it would > be split up into distinct clang/llvm parts and maybe NEON/SVE parts on the > LLVM side. That's a good

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

fhahn added a comment. This patch is quite big and I think it would be easier to review if it would be split up into distinct clang/llvm parts and maybe NEON/SVE parts on the LLVM side. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:71 + +// +sve implies +f32mm

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:284 + if (HasMatMul) +Builder.defineMacro("__ARM_FEATURE_MATMUL_INT8", "1"); + DavidSpickett wrote: > I don't see specific tests

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:39 bool HasTME; + unsigned HasMatMul; DavidSpickett wrote: > Why is this feature a number for AArch64, does >1 mean something? It seems this was an artifact from how this is

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

DavidSpickett added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:284 + if (HasMatMul) +Builder.defineMacro("__ARM_FEATURE_MATMUL_INT8", "1"); + I don't see specific tests for this #define Comment at:

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added a comment. build failures related to linting, unit tests passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77540/new/ https://reviews.llvm.org/D77540 ___ cfe-commits mailing list