This revision was automatically updated to reflect the committed changes.
Closed by commit rG7f5d91d3ffed: [clang][AIX] Implement ABIInfo and
TargetCodeGenInfo for AIX (authored by jasonliu).
Changed prior to commit:
https://reviews.llvm.org/D79035?vs=263864=264922#toc
Repository:
rG LLVM
Xiangling_L accepted this revision.
Xiangling_L added a comment.
This revision is now accepted and ready to land.
LGTM with a minor comment:
You may want to add a `TODO` or `FIXME` at `clang/lib/CodeGen/TargetInfo.cpp:
4496` and `clang/lib/CodeGen/TargetInfo.cpp:4418` like:
//FIXME:
Correct
ZarkoCA added a comment.
I'm ok with this now. I will let @Xiangling_L approve if she's ok with it since
she had the last few comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
___
jasonliu updated this revision to Diff 263864.
jasonliu added a comment.
Remove driver's error.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
Files:
clang/lib/CodeGen/TargetInfo.cpp
clang/lib/Frontend/CompilerInvocation.cpp
jasonliu marked an inline comment as done.
jasonliu added inline comments.
Comment at: clang/test/Frontend/aix-unsupported.c:10
+// RUN: -c %s 2>&1 | FileCheck %s
+// CHECK: unsupported option
Xiangling_L wrote:
> One thing I am not so sure about is that for
Xiangling_L added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1300
OPT_maix_struct_return, OPT_msvr4_struct_return)) {
+// TODO: We might want to consider enabling these options on AIX in the
+// future.
jasonliu updated this revision to Diff 263502.
jasonliu added a comment.
Add error report in clang_cc1 for unsupported option on AIX.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
Files:
clang/lib/CodeGen/TargetInfo.cpp
Xiangling_L added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4684
return false;
case CodeGenOptions::SRCK_InRegs: // -msvr4-struct-return
return true;
jasonliu wrote:
> Xiangling_L wrote:
> > I noticed that in patch
jasonliu added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1547
// Otherwise, if the type contains an SSE vector type, the alignment is 16.
+ if (Align >= 16 && (isSIMDVectorType(getContext(), Ty) ||
Xiangling_L wrote:
> Also update the
jasonliu updated this revision to Diff 262964.
jasonliu marked 5 inline comments as done.
jasonliu added a comment.
Address Xiangling's comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
Files:
clang/lib/CodeGen/TargetInfo.cpp
jasonliu updated this revision to Diff 262958.
jasonliu marked 2 inline comments as done.
jasonliu added a comment.
Address Zarko's comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
Files:
clang/lib/CodeGen/TargetInfo.cpp
Xiangling_L added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1547
// Otherwise, if the type contains an SSE vector type, the alignment is 16.
+ if (Align >= 16 && (isSIMDVectorType(getContext(), Ty) ||
Also update the comment?
ZarkoCA added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:5244
llvm::Value *Address) const {
-
- return PPC64_initDwarfEHRegSizeTable(CGF, Address);
+ return PPC_initDwarfEHRegSizeTable(CGF, Address, /*
jasonliu updated this revision to Diff 262878.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
Files:
clang/lib/CodeGen/TargetInfo.cpp
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/CodeGen/aix-complex.c
clang/test/CodeGen/aix-return.c
jasonliu updated this revision to Diff 262869.
jasonliu added a comment.
Address comments.
Add in over aligned structure and structure containing vector type handling for
argument on AIX.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
Files:
ZarkoCA added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4257
+ // 64-bit only registers:
+ // 114: tfhar
+ // 115: tfiar
From what I've seen, the tfhar, tfiar and texasr are used by the Power8 CPU,
which means that there is potential for
jasonliu added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4368
+
+ return emitVoidPtrVAArg(CGF, VAListAddr, Ty, /*Indirect*/ false, TypeInfo,
+ SlotSize, /*AllowHigher*/ true);
ZarkoCA wrote:
> Is there a reason why
jasonliu updated this revision to Diff 262252.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
Files:
clang/lib/CodeGen/TargetInfo.cpp
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/CodeGen/aix-complex.c
clang/test/CodeGen/aix-return.c
jasonliu updated this revision to Diff 262250.
jasonliu marked 12 inline comments as done.
jasonliu added a comment.
Rebase and address comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
Files:
clang/lib/CodeGen/TargetInfo.cpp
Xiangling_L added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4317
+ if (isAggregateTypeForABI(RetTy))
+return getNaturalAlignIndirect(RetTy);
+
Xiangling_L wrote:
> jasonliu wrote:
> > Xiangling_L wrote:
> > > This method uses the ABI
Xiangling_L added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4317
+ if (isAggregateTypeForABI(RetTy))
+return getNaturalAlignIndirect(RetTy);
+
jasonliu wrote:
> Xiangling_L wrote:
> > This method uses the ABI alignment of the given
ZarkoCA added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4368
+
+ return emitVoidPtrVAArg(CGF, VAListAddr, Ty, /*Indirect*/ false, TypeInfo,
+ SlotSize, /*AllowHigher*/ true);
Is there a reason why Indirect is set to
jasonliu marked 2 inline comments as done.
jasonliu added inline comments.
Comment at: clang/test/CodeGen/ppc32-dwarf.c:2
+// RUN: %clang_cc1 -triple powerpc-unknown-aix -emit-llvm %s -o - | FileCheck
%s
+// RUN: %clang_cc1 -triple powerpc-unknown-unknown -emit-llvm %s -o - |
jasonliu marked 2 inline comments as done.
jasonliu added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4317
+ if (isAggregateTypeForABI(RetTy))
+return getNaturalAlignIndirect(RetTy);
+
Xiangling_L wrote:
> This method uses the ABI
Xiangling_L added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4179
+ // This is calculated from the LLVM and GCC tables and verified
+ // against gcc output. AFAIK all ABIs use the same encoding.
+
Minor comment about comment style:
Though I
jasonliu created this revision.
jasonliu added reviewers: Xiangling_L, sfertile, hubert.reinterpretcast,
cebowleratibm, ZarkoCA.
Herald added subscribers: kbarton, nemanjai.
Herald added a project: clang.
Created AIXABIInfo and AIXTargetCodeGenInfo for AIX ABI.
Some investigation and FAQ on why
26 matches
Mail list logo
