[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08b289867b5a: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id (authored by nridge). Repository: rG LLVM Github

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sure, sounds good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. @dblaikie now that the dependent patch has been merged and (presumably) stuck, do you think we can proceed with this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge updated this revision to Diff 357827. nridge added a comment. Rebase on top of refactor patch changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 Files: clang/lib/AST/TypePrinter.cpp

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. In D104619#2846262 , @dblaikie wrote: > If there's already some duplication, perhaps a pre-patch to generalize that > functionality, then using that functionality in this patch? I posted the patch to generalize the AST printing

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge updated this revision to Diff 356604. nridge added a comment. Rebase on top of refactor patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 Files: clang/lib/AST/TypePrinter.cpp

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge planned changes to this revision. nridge added a comment. In D104619#2846262 , @dblaikie wrote: > If there's already some duplication, perhaps a pre-patch to generalize that > functionality, then using that functionality in this patch? Sounds

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

dblaikie added a comment. In D104619#2846259 , @nridge wrote: > In D104619#2846258 , @dblaikie > wrote: > >> if that's the case, maybe there's room to refactor the commonality - >> avoiding the near(if it is

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. In D104619#2846258 , @dblaikie wrote: > if that's the case, maybe there's room to refactor the commonality - avoiding > the near(if it is near) duplication and justifying the complexity/more > general design a bit more, by

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

dblaikie added a comment. In D104619#2846255 , @nridge wrote: > I based the infrastructure closely on that in `DeclPrinterTest.cpp` and > `StmtPrinterTest.cpp`. I figured the general framework could come in useful > to people adding new type printing

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. I based the infrastructure closely on that in `DeclPrinterTest.cpp` and `StmtPrinterTest.cpp`. I figured the general framework could come in useful to people adding new type printing tests in the future. I'm happy to trim it down a bit (e.g. remove unused methods and

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

dblaikie added a comment. The test code seems a bit overly general/overengineered for the use case, perhaps? (for instance it has unused parameters like the "Args" parameter - that neither caller passes in a value for, it has accessors (GetPRinted/getNumFoundTypes) when all the code fits on a

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge updated this revision to Diff 355104. nridge added a comment. fix comment at top of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 Files: clang/lib/AST/TypePrinter.cpp

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. In D104619#2831966 , @dblaikie wrote: > So likely what you'd need would be a unit test of some kind (check around in > clang/unittests to see if there are other AST pretty printer tests, for > instance). Thanks for the