[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/fast-isel-fcmp-nan.ll:5 ; CHECK-LABEL: TestULT: -; CHECK: xscmpudp +; CHECK: fcmpu ; CHECK: blr nemanjai wrote: > Why do we not emit the VSX instructions here any longer? How are crbits >

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. amyk marked an inline comment as done. Closed by commit rG2534dc120a4c: [PowerPC] Enable CR bits support for Power8 and above. (authored by amyk). Changed prior to

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) shchenz wrote: > nemanjai

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) nemanjai wrote: > shchenz

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

nemanjai added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3566 +Control the CR-bit tracking feature on PowerPC. ``-mcrbits`` (the enablement of CR-bit tracking support) is the default for POWER8 and above. + ``` ... is the default

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

nemanjai added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) shchenz wrote: > amyk wrote:

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] =

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk marked an inline comment as done. amyk added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true)

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk updated this revision to Diff 425417. amyk added a comment. Address review comments of adding documentation to `clang/docs/ClangCommandLineReference.rst` and adding AIX checks to `clang/test/Driver/ppc-crbits.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz added a comment. > This patch turns on support for CR bit accesses for Power8 and above. The > reason why CR bits are turned on as the default for Power8 and above is that > because later architectures make use of builtins and instructions that > require CR bit accesses (such as the

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, power-llvm-team. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a subscriber: cfe-commits. This patch