[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cbc9206697e: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp (authored by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

kwk accepted this revision. kwk added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/Format.cpp:2774 - -const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))";

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:2774 - -const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; kwk wrote: > owenpan wrote: > > kwk wrote: > > > MyDeveloperDay wrote: > > > >

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

kwk added inline comments. Comment at: clang/lib/Format/Format.cpp:2774 - -const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; owenpan wrote: > kwk wrote: > > MyDeveloperDay wrote: > > > Did I miss where this

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

owenpan added a comment. @kwk D134733 reminded me of https://reviews.llvm.org/D121370#3401173, which I realized didn't go far enough. This NFC patch is what I should have suggested to you then. If you want to do the cleanup differently, you can either make

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

kwk added a comment. I didn't see much difference in what this patch does compare to mine but I saw that it removes the need for instantiating multiple `llvm::Regex` objects from a single static pattern. But that's something I've just done in a new revision of my own patch:

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2774 - -const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; Did I miss where this comes from now? Repository: rG LLVM Github

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, kwk, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.