This revision was automatically updated to reflect the committed changes.
a.sidorin marked an inline comment as done.
Closed by commit rL330704: [ASTImporter] Allow testing of import sequences; fix
import of typedefs for… (authored by a.sidorin, committed by ).
Herald added a subscriber:
a.sidorin marked 2 inline comments as done.
a.sidorin added a comment.
Thank you Gabor!
Comment at: unittests/AST/ASTImporterTest.cpp:356
+ ImportAction(StringRef FromFilename, StringRef ToFilename,
+ const std::string )
+ : FromFilename(FromFilename),
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Overall looks good, some minor nits inline. If those can be resolved
trivially, I am ok with committing this without another round of reviews.
Comment at:
a.sidorin updated this revision to Diff 141537.
a.sidorin added a comment.
Rebase to the latest master; add a suggestion from Adam Balogh (thanks!).
Repository:
rC Clang
https://reviews.llvm.org/D44079
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
baloghadamsoftware added a comment.
By moving the code that sets the type name of an anoynmous declaration from
Import(Decl*) to ImportDefinition(RecordDecl*, RecordDecl*,
ImportDefinitionKind) (and the same for Enum) we will not crash upon importing
typedefs containing anonymous strcutures.
baloghadamsoftware added a comment.
Hi,
Thank you for the patch.
It seems that the new approach still does not solve a problem with anonymous
structures in typedefs.In C++ a copy constructor is automatically generated,
and its parameter is the anonymous structure itself. This triggers caching
a.sidorin created this revision.
a.sidorin added reviewers: r.stahl, xazax.hun, jingham, szepet.
Herald added subscribers: martong, rnkovacs.
This patch introduces the ability to test an arbitrary sequence of imports
between a given set of virtual source files. This should finally allow
us
