[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

This revision was automatically updated to reflect the committed changes. Closed by commit rL349212: Mangle calling conventions into function pointer types where GCC does (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, that looks great. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55672/new/ https://reviews.llvm.org/D55672 ___ cfe-commits

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rnk updated this revision to Diff 178144. rnk added a comment. - Add ms_abi and sysv_abi tests to match GCC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55672/new/ https://reviews.llvm.org/D55672 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/CodeGenCXX/mangle-win-ccs.cpp

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rnk updated this revision to Diff 178138. rnk added a comment. - more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55672/new/ https://reviews.llvm.org/D55672 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/CodeGenCXX/mangle-win-ccs.cpp Index:

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rnk added a comment. In D55672#1330460 , @rjmccall wrote: > Thanks. I think you missed these, though: > > - a template argument that's just a function type, not a function pointer or > reference type I think useTemplateFnType is supposed to handle

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rjmccall added a comment. In D55672#1330458 , @rnk wrote: > In D55672#1330402 , @rnk wrote: > > > - a specialization of a function template that happens to be declared with > > this calling convention (this also

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rjmccall added a comment. Thanks. I think you missed these, though: - a template argument that's just a function type, not a function pointer or reference type - a specialization of a function template that happens to be declared with this calling convention (this also probably shouldn't

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rnk added a comment. In D55672#1330402 , @rnk wrote: > - a specialization of a function template that happens to be declared with > this calling convention (this also probably shouldn't include the CC in the > mangling, but it's okay to match GCC if it

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rnk updated this revision to Diff 178137. rnk added a comment. - add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55672/new/ https://reviews.llvm.org/D55672 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/CodeGenCXX/mangle-win-ccs.cpp Index:

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rnk planned changes to this revision. rnk added a comment. I guess that was premature, I suppose I should test these cases John enumerated: > I think some basic validation of that is probably called for before > committing. The obvious places to check: > > - a function pointer type > - a

[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

rnk created this revision. rnk added reviewers: rjmccall, efriedma. GCC 5.1 began mangling these Windows calling conventions into function types, since they can be used for overloading. They've always been mangled in the MS ABI, but they are new to the Itanium mangler. Note that the calling