[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

aaron.ballman added a comment. In D61508#4469426 , @garymm wrote: > @aaron.ballman what's remaining for this to be mergeable? It needs to be rebased onto trunk and it looks like there's some test coverage missing for unsupported styles. It should

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

garymm added a comment. Herald added subscribers: carlosgalvezp, mgehre. Herald added a project: All. @aaron.ballman what's remaining for this to be mergeable? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61508/new/ https://reviews.llvm.org/D61508

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:30 +} +std::string BugproneHeaderGuardCheck::getHeaderGuard(StringRef Filename, +

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt marked an inline comment as done. trixirt added inline comments. Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:30 +} +std::string BugproneHeaderGuardCheck::getHeaderGuard(StringRef Filename, + StringRef OldGuard)

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 200630. trixirt added a comment. Add a newline to separate functions Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61508/new/ https://reviews.llvm.org/D61508 Files: clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

aaron.ballman added a comment. In D61508#1509368 , @trixirt wrote: > Latest change addresses most of issues. > Outstanding is adding a test when garbage GuardStyle value is fed into > config. > The trial testcase used only CHECK-*-NOT which caused

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt added a comment. Latest change addresses most of issues. Outstanding is adding a test when garbage GuardStyle value is fed into config. The trial testcase used only CHECK-*-NOT which caused complaining from test harness looking for the CHECK- cases. Looking for something similar in the

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 200380. trixirt added a comment. Change the GuardStyle data type from a string to an enum. Add test cases for explicitly setting valid style. Document valid style values. Reduce llvm-header-guard doc to point to bugprone-header-guard. Repository: rCTE

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:50 + + } else { +if (OldGuard.size()) I think this should be an `else if` rather than an `else`. I'd like to see us diagnose unknown guard styles so that we only

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 199358. trixirt added a comment. llvm-header-guard is an alias to bugprone-header-guard. The style is passed through the option 'GuardStyle' A regression test was added for llvm-header-guard. llvm unit tests were modified to the new class and option

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

JonasToth added a comment. > My understanding of the directory layout guidance in the docs is that > different styles get different directories. Yes, but for "the same check" we use aliases instead. When aliasing checks in different categories it is possible to change default configuration

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt added a comment. All of the real work is the header-guard checks is done by their common base class utils/HeaderGuard. The much smaller llvm and bugprone subclasses are only concerned with the style of the fix. My understanding of the directory layout guidance in the docs is that

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 198352. trixirt retitled this revision from "[clang-tidy] misc-header-guard : a simple version of llvm-header-guard" to "[clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard". trixirt added a comment. Move from misc to bugprone