[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 added a subscriber: jdoerfert. njames93 added a comment. In D77085#1967883 , @nemanjai wrote: > Awesome, thanks. Certainly fixes the compile time failures in my local build. > There is still a link-time failure (undefined reference) with my share

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

nemanjai added a comment. In D77085#1967864 , @njames93 wrote: > In D77085#1967807 , @nemanjai wrote: > > > A recent commit has taken down a whole bunch of bots. The build error > > messages all seem to point to co

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 added a comment. In D77085#1967807 , @nemanjai wrote: > A recent commit has taken down a whole bunch of bots. The build error > messages all seem to point to code in this patch. If this is indeed the > cause, please revert. I was aware and hop

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

nemanjai added a comment. Herald added a subscriber: wuzish. A recent commit has taken down a whole bunch of bots. The build error messages all seem to point to code in this patch. If this is indeed the cause, please revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf7cc268fe4: [clang-tidy] Added support for validating configuration options (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D77085?vs=255023&id=255764#toc Repository: rG L

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few minor nits. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:117 + llvm::Expected ValueOr = get(LocalName); + if (ValueOr) { +r

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 added a comment. I added support for bools. The previous integer parsing behaviour is still there, however now it also responds to `true` or `false`. This won't parse `True|TRUE|False|FALSE` etc as I wanted it to be in line with `.clang-format` configuration files for handling of bool.

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 updated this revision to Diff 255023. njames93 added a comment. - Extended support for boolean types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 Files: clang-tools-extra/clang-tidy/ClangTidyC

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 marked 8 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:25 + llvm::raw_svector_ostream Output(Buffer); + Output << "warning: Option not found '" << OptionName << "'\n"; + return std::string(Buffer);

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:25 + llvm::raw_svector_ostream Output(Buffer); + Output << "warning: Option not found '" << OptionName << "'\n"; + return std::string(Buffer); aaron.ballman wrote:

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 updated this revision to Diff 254890. njames93 added a comment. - Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-tools

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

aaron.ballman added a comment. Thank you for working on this, I think it's going to be a very useful interface! Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:25 + llvm::raw_svector_ostream Output(Buffer); + Output << "warning: Option not found '" << OptionName <

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 updated this revision to Diff 254552. njames93 added a comment. - Small refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-too

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 updated this revision to Diff 253751. njames93 added a comment. - Fix assertions failing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp c

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 added a comment. This pretty much nulls out (clang-tidy) Warn on invalid "case" configurations for readability-identifier-naming I have moved that into a follow up patch that can be submitted now if you'd like. Repository: rG LLVM Github Monorepo

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 added a comment. njames93 added a project: clang-tools-extra. This pretty much nulls out (clang-tidy) Warn on inva