[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

efriedma added a comment. (Please mark this "closed" to reflect the fact that it was merged.) Comment at: clang/lib/Sema/JumpDiagnostics.cpp:935 +LabelStmt *Label = cast(To); +Label->setSideEntry(true); } tentzen wrote: > rjmccall wrote: > > This doe

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#3453565 , @bowang wrote: >> Hi, this patch is just part-1 of Windows SEH feature support. Part-2 work >> had been sitting in https://reviews.llvm.org/D102817/new/ since last May >> 2021. It's been reviewed, and feedba

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

bowang added a comment. > Hi, this patch is just part-1 of Windows SEH feature support. Part-2 work > had been sitting in https://reviews.llvm.org/D102817/new/ since last May > 2021. It's been reviewed, and feedbacks had been addressed. but nobody has > approved it. To handle Hardware Except

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#3450940 , @bowang wrote: > Any updates on this patch? Would like to see it moving forward. > > I was trying to use Google Breakpad with Clang. Breakpad is a crash handling > library that generates a minidump at crash. Th

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

bowang added a comment. Any updates on this patch? Would like to see it moving forward. I was trying to use Google Breakpad with Clang. Breakpad is a crash handling library that generates a minidump at crash. The exception handler on Windows relies on SEH. Breakpad works fine with MSVC. But wh

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. @aganea Oh, my mistake. did not mean to enable -fasync-exceptions under -EHa in this patch. will fix it shortly... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 _

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aganea added a comment. In D80344#2797317 , @tentzen wrote: > @aganea , this patch should be zero-impact without explicit option > -fasync-exceptions. Are you also seeing a crash without this option? I'm using `/EHa` which I expect translates to `-fasyn

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, yes I can repro the crash with -fasync-exceptions plus -O2 option. Working on it now.. thank you for reporting this bug.. @aganea , this patch should be zero-impact without explicit option -fasync-exceptions. Are you also seeing a crash without this option? thanks

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

zahiraam added a comment. Actually adding -O2 to all the LIT tests in this patch will trigger the same assertion at CGCleanup.cpp:1326. The code's assuming there is always an invoke destination in the program, but in these cases the InvokeDest is null. According to Microsoft's documentation,

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aganea added a comment. In D80344#2792355 , @tentzen wrote: > Thank you for reporting this . From the callstack it does not seem related > to this patch. It was actually `git bisect` which pointed to me to this patch, it could be a side-effect of it.

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

zahiraam added a comment. In D80344#2796066 , @pengfei wrote: > We found another crush: https://godbolt.org/z/vcbvddEKr Even smaller https://godbolt.org/z/dbrGjGbaf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

pengfei added a comment. We found another crush: https://godbolt.org/z/vcbvddEKr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-

RE: [EXTERNAL] [PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1 aganea added a comment. Hello, this patch introduces a regression in one of our codebases. The compilation of several TUs fails with the following callstack: PLEASE submit a bug report to https://nam06

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aganea added a comment. Hello, this patch introduces a regression in one of our codebases. The compilation of several TUs fails with the following callstack: PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Passed many CodeGen related test suites over the weekend. It landed in.. commit 9ca9be098fedb14182c50c9dd700f3fa91c8d4c7 (HEAD -> main) Author: Ten Tzen Date: Sun May 16 18:12:47 2021 -0700 [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1 Repository

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith accepted this revision. asmith added a comment. Thanks everyone for the great feedback! We'll move forward with landing this first patch and start the review of the next one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. bool keepFramePointer(const MachineFunction &MF) const override; In D80344#2673335 , @lebedev.ri wrote: > In D80344#2673148 , @asmith wrote: > >> In D80344#2671157

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. In D80344#2684450 , @tentzen wrote: > Hi, > (Last call for review!!) Please refer to https://llvm.org/docs/CodeReview.html > Is there any more comments? This review has lasted for more than a year now. > I believe I had ad

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, (Last call for review!!) Is there any more comments? This review has lasted for more than a year now. I believe I had addressed or answered all questions and concerns. Thank all reviewers' precious feedbacks. For late comers, again (1) Original llvm-dev [RFC] discuss

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 336033. tentzen added a comment. fixed command option typos in two test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 336011. tentzen marked an inline comment as done. tentzen added a comment. clang-format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/cl

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. In D80344#2673148 , @asmith wrote: > In D80344#2671157 , @lebedev.ri > wrote: > >> It would be good for @rjmccall / @rsmith / etc to actually finish reviewing >> this and accept it. >>

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aeubanks added a comment. could you clang-format the patch? Comment at: clang/lib/CodeGen/CGException.cpp:1666-1667 + ++J) { + if (isa(J)) { +auto LI = dyn_cast(J); +LI->setVolatile(true); ``` if (auto*LI = dyn_cast<...>(J)) { ...

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. @rjmccall @rsmith Thanks for your help. Do you have any additional feedback before we commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. In D80344#2671157 , @lebedev.ri wrote: > It would be good for @rjmccall / @rsmith / etc to actually finish reviewing > this and accept it. > I would personally want to see the next patches - what changes are needed for > llvm an

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. It would be good for @rjmccall / @rsmith / etc to actually finish reviewing this and accept it. I would personally want to see the next patches - what changes are needed for llvm analysis, transforms? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen marked 13 inline comments as done. tentzen added a comment. hi, I believe I'd addressed all issues or concerns, and it's rebased to up-to-date source in new _main branch now. Does this look good to everyone? If I don't hear any objection in a couple of days, I will go ahead make this pa

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 335068. tentzen added a comment. rebase the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic/La

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:886 HelpText<"Enable C++ exceptions">, Flags<[CC1Option]>; +def fasync_exceptions: Flag<["-"], "fasync-exceptions">, Group, + HelpText<"Enable EH Asynchronous exceptions">, Flags<[CC1Option]

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 334855. tentzen added a comment. Removed some files (mostly for Part 2 of this feature) that were accidentally put in last revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llv

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. Hi John, how does this look now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 325966. tentzen added a comment. Herald added a subscriber: jfb. changed option name and a couple of minor changes per John McCall's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://re

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen marked an inline comment as not done. tentzen added a comment. thank you for the thorough review again. My answer for each comment below: Comment at: clang/lib/CodeGen/CGCleanup.cpp:1341 + llvm::FunctionCallee SehCppScope = + CGM.CreateRuntimeFunction(FTy, "llvm.

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Herald added a reviewer: jansvoboda11. Hi, John, sorry for the delay. I'm still in the middle of something. will context-switch a little bit latter. thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCleanup.cpp:1341 + llvm::FunctionCallee SehCppScope = + CGM.CreateRuntimeFunction(FTy, "llvm.seh.scope.begin"); + EmitSehScope(*this, SehCppScope); We generally prefer to get intrinsic functio

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. I'm sorry that it's taking a while to find time to review the implementation; I'll try to get to it this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. This patch looks ready to land. Are there any other concerns or feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, Is there any more concerns, feedbacks or suggestions? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2410417 , @pengfei wrote: > In D80344#2407305 , @tentzen wrote: > >> In D80344#2407250 , @pengfei wrote: >> >>> Do we need to consider FP e

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

pengfei added a comment. In D80344#2407305 , @tentzen wrote: > In D80344#2407250 , @pengfei wrote: > >> Do we need to consider FP exceptions in _try block? > > Yes, FP exception is handled as long as FP exceptions a

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2407309 , @belliash wrote: > Does it really work for x86_64 architecture only? I have tried using this > with x86 build and produced binaries looks like this should work on this > platform as well, but I have not tried

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

belliash added a comment. Does it really work for x86_64 architecture only? I have tried using this with x86 build and produced binaries looks like this should work on this platform as well, but I have not tried running produced executables to see the results yet tbh. Repository: rG LLVM Gi

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen marked 2 inline comments as done. tentzen added a comment. In D80344#2407250 , @pengfei wrote: > Do we need to consider FP exceptions in _try block? Yes, FP exception is handled as long as FP exceptions are not disabled (Ex via _controlfp() runti

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

pengfei added a comment. Do we need to consider FP exceptions in _try block? Comment at: clang/include/clang/Driver/Options.td:886 HelpText<"Enable C++ exceptions">, Flags<[CC1Option]>; +def feh_asynch: Flag<["-"], "feh-asynch">, Group, + HelpText<"Enable EH Asynchronous ex

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 306510. tentzen added a comment. Per Joseph's feedback, further clarify the semantic of llvm.seh.try.begin and llvm.seh.try.end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.or

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added inline comments. Comment at: llvm/docs/LangRef.rst:11591 +and the EH cleanup is no longer required (e.g. because the destructor is being +called). + JosephTremoulet wrote: > Maybe add something here like > > > Any set of operations can then be conf

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

JosephTremoulet added inline comments. Comment at: llvm/docs/LangRef.rst:11587 +C++ object with a non-trivial destructor. ``llvm.seh.scope.begin`` is used to mark +the start of the region; it is aways called with ``invoke``, with the unwind block +being the desired unwind dest

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 306469. tentzen added a comment. Fixed the clang fault when built without '-feh-asynch' option. EHStack's CGF field must be initialized even without -feh-asynch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

belliash added a comment. With your latest patch update clang segfaults for me even when '-feh-asynch' is not passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-c

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 306287. tentzen added a comment. per review feedback from John McCall and others, this update includes: - Rename intrinsic eha.scope.begin() with seh.scope.begin(). - Update LangRef.rst with detailed explanation - Add conditional cleanup test case and move th

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

belliash added a comment. When do you plan to enable this on x86? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. Sounds good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. OK, great. Summarize our discussion above, I will follow up with: - rename intrinsic eha.scope.begin() with seh.scope.begin(). - update LangRef.rst with detailed explanation - not to allow inlining under SEH direct lexical scope - add conditional cleanup test case and m

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2293954 , @tentzen wrote: > In D80344#2291926 , @rjmccall wrote: > >> Okay. I think we're on the same page about representation now. If you can >> come up with a good replaceme

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2291926 , @rjmccall wrote: > Okay. I think we're on the same page about representation now. If you can > come up with a good replacement for "eha" in the intrinsic names, I think > this is pretty much ready to go. ho

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. Okay. I think we're on the same page about representation now. If you can come up with a good replacement for "eha" in the intrinsic names, I think this is pretty much ready to go. Comment at: llvm/docs/LangRef.rst:11584 +These intrinsics make Bloc

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2291688 , @rjmccall wrote: > In D80344#2291456 , @tentzen wrote: > >> Reordering is NOT okay for instructions 'directly' within a _try. 'directly' >> here means it's the code from

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2291456 , @tentzen wrote: > In D80344#2291156 , @rjmccall wrote: > >> In D80344#2288898 , @tentzen wrote: >> >>> In D80344#2286838

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2291156 , @rjmccall wrote: > In D80344#2288898 , @tentzen wrote: > >> In D80344#2286838 , @rjmccall wrote: >> >>> In D80344#228

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2291385 , @asmith wrote: >> @rjmccall wrote: >> I think you're missing what I'm asking. If LLVM accepts this feature, it >> will become our collective responsibility as a project to keep it working. >> You have a la

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. > @rjmccall wrote: > I think you're missing what I'm asking. If LLVM accepts this feature, it > will become our collective responsibility as a project to keep it working. > You have a large external correctness test suite for this feature. It does > not sound like yo

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2288898 , @tentzen wrote: > In D80344#2286838 , @rjmccall wrote: > >> In D80344#228 , @tentzen wrote: >> >>> There is absolutely NO ex

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2286838 , @rjmccall wrote: > In D80344#228 , @tentzen wrote: > >> Thank you for prompt reply again. >> >>> [rjmccall] And I agree with him that the potential benefits are >>>

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#228 , @tentzen wrote: > Thank you for prompt reply again. > >> [rjmccall] And I agree with him that the potential benefits are substantial. >> I'm just saying that one barely-trafficked RFC thread is not evidence of

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Thank you for prompt reply again. > [rjmccall] And I agree with him that the potential benefits are substantial. > I'm just saying that one barely-trafficked RFC thread is not evidence of a > community consensus. OK, thanks. it's good to know you are also supportive i

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2280617 , @tentzen wrote: > Hi, John, thank you for reviewing this patch and providing feedback. > regarding your comments: > > 1, In the RFC thread early, Reid K (the major contributor of Windows SEH/EH > support) had

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, John, thank you for reviewing this patch and providing feedback. regarding your comments: 1, In the RFC thread early, Reid K (the major contributor of Windows SEH/EH support) had agreed that "the value proposition is clear and large". 2, could you elaborate why do

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. I've made some brief comments about the code, but I think I have much larger concerns here. The first is whether LLVM really intends to satisfy the constraints necessary to make these exceptions work, which I don't think you've gotten clear consensus about at all. Un

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. In D80344#2255090 , @asmith wrote: > Yes there was an RFC and discussion and several requests for comments. > http://lists.llvm.org/pipermail/llvm-dev/2020-March/140541.html It is probably good to state so in the patch's descri

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. Yes there was an RFC and discussion and several requests for comments. http://lists.llvm.org/pipermail/llvm-dev/2020-March/140541.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. I feel like this may be trying to do too many things at once. Was there an RFC? There are several patches here: 1. langref 2. llvm side of the patch (maybe should be in the pr

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. does it look good to you? or any more comment? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 268375. tentzen marked an inline comment as done. tentzen edited the summary of this revision. tentzen added a comment. update a couple of changes per David Majnemer's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen marked 3 inline comments as done. tentzen added a comment. thank you David. will update and submit a new patch shortly. Comment at: clang/lib/CodeGen/CGException.cpp:603-609 + // For IsEHa catch(...) must handle HW exception + // Adjective = HT_IsStdDotDot (0

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

majnemer added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1783 + + bool IsSideEntry() const { return SideEntry; } + void setSideEntry() { SideEntry = true; } I think this should be isSideEntry to be consistent. Comment at: cl

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Is there any feedback? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 266374. tentzen added a comment. update LangRef.rst for new intrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h clang/i

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. In D80344#2051804 , @tentzen wrote: > > It may be helpful (even for the reviewers) to first specify their behavior, > > instead of writing that after-the-fact "backwardly" based on the > > implementation. > > For reviewers, th

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 265819. tentzen removed a reviewer: lebedev.ri. tentzen added a comment. fixed tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clan

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. > It may be helpful (even for the reviewers) to first specify their behavior, > instead of writing that after-the-fact "backwardly" based on the > implementation. For reviewers, the purpose of those intrinsic are described in Summary section: - Two intrinsic are create

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri resigned from this revision. lebedev.ri added a comment. In D80344#2051697 , @tentzen wrote: > In D80344#2051127 , @lebedev.ri > wrote: > > > This should likely be at least 3 patches: llvm middle-end, ll

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 265812. tentzen retitled this revision from "[Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)" to "[Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1". tentzen edited the summary of this revision. tentzen added a reviewer: lebedev.ri