[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

joechrisellis updated this revision to Diff 308964. joechrisellis added a comment. Address @sdesmalen's comments. - Update commit message to better reflect the changes in this patch. - Rename `debug-declare-no-warnings-on-scalable-vectors.ll` to `dbg-info-scalable-typesize-warning.ll`.

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

sdesmalen added a comment. Please rename `debug-declare-no-warnings-on-scalable-vectors.ll` to something different, because these 'warnings' are only temporary and will be replaced by errors in the future. Having 'no warnings' in the name of the test name seems wrong from that perspective. In

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

joechrisellis updated this revision to Diff 308910. joechrisellis added a comment. Reduce debug info in `debug-declare-no-warnings-on-scalable-vectors.ll`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

joechrisellis commandeered this revision. joechrisellis edited reviewers, added: fpetrogalli; removed: joechrisellis. joechrisellis added a comment. I am finishing up this patch.  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli updated this revision to Diff 308078. fpetrogalli added a comment. Reverted `getFragmentSizeInBits` to return an integral type and not `TypeSize`, because scalable variables cannot be part of structs/arrays - hence they cannot be pointed by fragments. Repository: rG LLVM Github

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli added a comment. Hi @sdesmalen I have extracted D92020 to implement only the change of interface for `AllocaInst::getAllocationSizeInBits`. I wanted to extract also the interface change in `DbgVariableIntrinsic::getFragmentSizeInBits()` but such

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli updated this revision to Diff 307329. fpetrogalli added a comment. Add comment to `DbgVariableIntrinsic::getFragmentSizeInBits()`. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 Files:

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli updated this revision to Diff 307306. fpetrogalli added a comment. Rebase on top of D92020 . NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 Files:

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:589 sort(FrameData.Allocas, [&](const auto , const auto ) { -return GetAllocaSize(Iter1) > GetAllocaSize(Iter2); +return

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli updated this revision to Diff 306715. fpetrogalli edited the summary of this revision. fpetrogalli added a comment. I have added assertions around before `TypeSize` comparisons where it made sense to do so, but not in the lambda used in the `sort` invocation. Repository: rG LLVM

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Thank you for the review @sdesmalen 1. I have replied to the comment about `auto` with my reason for removing it. 2. I removed the C test, as the LL file is enough. 3. The third comment requires more investigation, I'll

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

sdesmalen added a comment. This patch needs to be retitled to what this is actually doing: changing the getTypeAllocationSizeInBits and getFragmentSizeInBits to return a TypeSize instead of `unsigned`. It would be even better if you can split those up into two patches with separate tests for