Hi Richard,
Thanks for reviewing. Agree, that was a bit confusing. More specifically,
the warning message was confusing (i.e. wrong). This patch is for compiling .c
input in C++ mode. The new flag should be ignored for C++ *input*, and indeed
not when it is in C++ *mode* as the warning message
yaron.keren added inline comments.
Comment at: lib/Basic/FileManager.cpp:221-222
@@ -220,1 +220,4 @@
+ SmallString1024 NativeFilename;
+ llvm::sys::path::native(Filename, NativeFilename);
+
rsmith wrote:
I have two concerns with this:
1) It's needlessly
Author: klimek
Date: Thu Aug 13 04:09:28 2015
New Revision: 244876
URL: http://llvm.org/viewvc/llvm-project?rev=244876view=rev
Log:
Fix formatting.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h
Modified: clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h
Hi Ivan,
CHECK-EIGHT is failing bots, see
http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24306/steps/check-all/logs/FAIL%3A%20Clang%3A%3Adependency-gen.c
I disabled it in r244869.
Yaron
2015-08-13 7:04 GMT+03:00 Ivan Krasin via cfe-commits
cfe-commits@lists.llvm.org:
Author: yrnkrn
Date: Thu Aug 13 02:12:03 2015
New Revision: 244871
URL: http://llvm.org/viewvc/llvm-project?rev=244871view=rev
Log:
Remove superfluous private:, TypeCache is private by default.
Modified:
cfe/trunk/lib/CodeGen/CodeGenTypes.h
Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h
angelgarcia updated this revision to Diff 32036.
angelgarcia marked 4 inline comments as done.
angelgarcia added a comment.
Set IncludeStyle as an option. Fix comments.
http://reviews.llvm.org/D11946
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/modernize/CMakeLists.txt
andreybokhanko added a comment.
John,
Thank you for the quick reply!
Let me make sure I understand what you said, using my test as an example (BTW,
sorry if this is a dumb question -- I asked our local Clang experts, but no-one
seems to be 100% sure what to do):
1: struct T {
2: ~T()
On 13 August 2015 at 07:15, Yaron Keren via cfe-commits
cfe-commits@lists.llvm.org wrote:
CHECK-EIGHT is failing bots, see
http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24306/steps/check-all/logs/FAIL%3A%20Clang%3A%3Adependency-gen.c
That check only works if compiler-rt
chapuni added a comment.
I wish, in clang/llvm, internal path separator would be slash.
It'd be better to use backslash where it'd be really required, for example
interface to cmd.exe or MS toolchain.
For me, native-ization is nightmare.
http://reviews.llvm.org/D11944
klimek added a comment.
In http://reviews.llvm.org/D11944#223597, @chapuni wrote:
I wish, in clang/llvm, internal path separator would be slash.
It'd be better to use backslash where it'd be really required, for example
interface to cmd.exe or MS toolchain.
For me, native-ization is
On Wed, Aug 12, 2015 at 07:18:05PM -0500, Hal Finkel via cfe-commits wrote:
I could say the same thing about many optimizations -- I spend a lot
of time tracking down bugs they expose -- the real thing to investigate
here are the potential benefits to real code from performing the
Author: djasper
Date: Thu Aug 13 08:37:08 2015
New Revision: 244890
URL: http://llvm.org/viewvc/llvm-project?rev=244890view=rev
Log:
clang-format: Fix incorrect lambda-detection.
Before:
[ a, a ]() - a1{};
After:
[a, a]() - a1 {};
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
Author: djasper
Date: Thu Aug 13 08:43:51 2015
New Revision: 244891
URL: http://llvm.org/viewvc/llvm-project?rev=244891view=rev
Log:
clang-format: Inside decltype(), there is an expression.
Before:
decltype(a* b) F();
After:
decltype(a * b) F();
Modified:
Author: benlangmuir
Date: Thu Aug 13 12:30:07 2015
New Revision: 244917
URL: http://llvm.org/viewvc/llvm-project?rev=244917view=rev
Log:
Attempt to fix build after r244912
Some compilers were less happy about converting a lambda to a comparator
function for array_pod_sort.
Modified:
diltsman updated this revision to Diff 32082.
diltsman marked an inline comment as done.
diltsman added a comment.
Arguments and Command can now be in the same compilation database for the same
file. Arguments are preferred when both are present.
http://reviews.llvm.org/D10365
Files:
Author: nmusgrave
Date: Thu Aug 13 13:35:11 2015
New Revision: 244933
URL: http://llvm.org/viewvc/llvm-project?rev=244933view=rev
Log:
Fix previous commit: poison only class members, simpler tests
Summary: Poisoning applied to only class members, and before dtors for base
class invoked
There is great variety of OSs, compilers, configs in the bots. You can't
get the smae with try bots unless everything is duplicated which is a
waste. You test locally, commit, watch the bots here:
http://lab.llvm.org:8011/grid
or wait for buildbot failure e-mails which arrive a bit slower.
Author: rsmith
Date: Thu Aug 13 13:30:25 2015
New Revision: 244931
URL: http://llvm.org/viewvc/llvm-project?rev=244931view=rev
Log:
[modules] For explicit module file dependencies, only list direct dependency
module files.
Modified:
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
Author: rnk
Date: Thu Aug 13 13:10:32 2015
New Revision: 244925
URL: http://llvm.org/viewvc/llvm-project?rev=244925view=rev
Log:
Try to fix new.cpp after r244920 to make it pass
Modified:
cfe/trunk/test/CodeGenCXX/new.cpp
Modified: cfe/trunk/test/CodeGenCXX/new.cpp
URL:
Author: rsmith
Date: Thu Aug 13 13:11:20 2015
New Revision: 244927
URL: http://llvm.org/viewvc/llvm-project?rev=244927view=rev
Log:
Fix wrong expected test output in r244923.
Modified:
cfe/trunk/test/Modules/dependency-gen.modulemap
Modified: cfe/trunk/test/Modules/dependency-gen.modulemap
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
angelgarcia changed the visibility of this Differential Revision from Public
(No Login Required) to All Users.
If there weren't any includes in the file, or all of them
Thank you, Yaron.
Sorry for breaking the build, it obviously passed locally and I didn't
think about all the variety of the supported configs. :(
Does LLVM have try bots, so that I can run the tests with my patch before
committing it?
krasin
On Thu, Aug 13, 2015 at 3:40 AM, Renato Golin
rsmith added inline comments.
Comment at: lib/AST/ASTContext.cpp:8557
@@ +8556,3 @@
+ if (MayCreate) {
+auto *MTVI = MaterializedTemporaryValues[E];
+if (*MTVI == nullptr) {
Maybe use a reference here rather than a pointer.
Comment at:
Author: dblaikie
Date: Thu Aug 13 18:09:18 2015
New Revision: 244981
URL: http://llvm.org/viewvc/llvm-project?rev=244981view=rev
Log:
Wdeprecated: Make the SecKeychainBugVisitor copyable (for the clone support in
the CRTP base) my removing the user-declared dtor
The implicit dtor is just as
Tweaked a test in r244970.
Could you split it out if you would like to run it for the default target?
On Fri, Aug 14, 2015 at 5:07 AM Ivan Krasin via cfe-commits
cfe-commits@lists.llvm.org wrote:
Thank you, Yaron. Understood.
On Thu, Aug 13, 2015 at 11:04 AM, Yaron Keren yaron.ke...@gmail.com
I have created http://reviews.llvm.org/D12021, please take a look.
On Thu, Aug 13, 2015 at 4:13 PM, Ivan Krasin kra...@google.com wrote:
Hi there,
I will remove both test cases, which rely on the existence of the default
blacklist. It's handled by the driver anyway, and the code I changed is
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcc accepted this revision.
pcc added a reviewer: pcc.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Yes, this can be a separate driver test.
http://reviews.llvm.org/D12021
___
cfe-commits mailing list
On Thu, Aug 13, 2015 at 4:47 PM, Ben Langmuir blangm...@apple.com wrote:
Yep, that should be it!
Great!
-- Sean Silva
On Aug 13, 2015, at 4:45 PM, Sean Silva chisophu...@gmail.com wrote:
This was the last thing blocking http://reviews.llvm.org/D10423 on your
side, right?
-- Sean
Author: dblaikie
Date: Thu Aug 13 18:05:58 2015
New Revision: 244980
URL: http://llvm.org/viewvc/llvm-project?rev=244980view=rev
Log:
Fix the MSVC build which cannot manifest default move ops
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h
Modified:
This was the last thing blocking http://reviews.llvm.org/D10423 on your
side, right?
-- Sean Silva
On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: benlangmuir
Date: Thu Aug 13 12:13:33 2015
New Revision: 244912
URL:
hfinkel added a subscriber: hfinkel.
hfinkel requested changes to this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision now requires changes to proceed.
As I've said in the review for http://reviews.llvm.org/D11814, this should be
added to TargetOptions, and
On Thu, Aug 13, 2015 at 5:16 PM hfin...@anl.gov hfin...@anl.gov wrote:
hfinkel added a comment.
In http://reviews.llvm.org/D11815#224169, @echristo wrote:
No, RESET_OPTION isn't the right way to do this either. For exactly this
sort of reason. You can't actually represent all of the code
On Thu, Aug 13, 2015 at 5:15 PM, Justin Bogner m...@justinbogner.com
wrote:
David Majnemer david.majne...@gmail.com writes:
majnemer created this revision.
majnemer added a reviewer: rsmith.
majnemer added a subscriber: cfe-commits.
We risk iterator invalidation issues if we use
Author: dblaikie
Date: Thu Aug 13 17:23:53 2015
New Revision: 244973
URL: http://llvm.org/viewvc/llvm-project?rev=244973view=rev
Log:
Wdeprecated: PathPieces are copied, make them safely implicitly copyable by
removing the unnecessary user declared dtor.
Modified:
Author: dblaikie
Date: Thu Aug 13 18:15:20 2015
New Revision: 244983
URL: http://llvm.org/viewvc/llvm-project?rev=244983view=rev
Log:
Wdeprecated: Make Filter safely move constructible.
makeFilter returns Filters by value which seems to be only safe when the
copy doesn't occur and RVO kicks in.
Yep, that should be it!
On Aug 13, 2015, at 4:45 PM, Sean Silva chisophu...@gmail.com wrote:
This was the last thing blocking http://reviews.llvm.org/D10423
http://reviews.llvm.org/D10423 on your side, right?
-- Sean Silva
On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits
On Thu, Aug 13, 2015 at 2:45 PM, Brad Smith via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: brad
Date: Thu Aug 13 16:45:57 2015
New Revision: 244961
URL: http://llvm.org/viewvc/llvm-project?rev=244961view=rev
Log:
[SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.
Author: brad
Date: Thu Aug 13 17:00:53 2015
New Revision: 244962
URL: http://llvm.org/viewvc/llvm-project?rev=244962view=rev
Log:
Removed one too many braces.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
Author: chapuni
Date: Thu Aug 13 17:17:34 2015
New Revision: 244970
URL: http://llvm.org/viewvc/llvm-project?rev=244970view=rev
Log:
clang/test/Frontend/dependency-gen.c: Add explicit -target x86_64-linux-gnu for
-fsanitize.
Modified:
cfe/trunk/test/Frontend/dependency-gen.c
Modified:
Author: dblaikie
Date: Thu Aug 13 17:33:24 2015
New Revision: 244974
URL: http://llvm.org/viewvc/llvm-project?rev=244974view=rev
Log:
Wdeprecated: RegionBindingsRef are copy constructed, make sure that's safe by
removing the unnecessary user-declared copy assignment operator
The user-defined
majnemer updated this revision to Diff 32106.
majnemer added a comment.
- Address Richard's latest review comments.
http://reviews.llvm.org/D11629
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTContext.cpp
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/PR24289.cpp
Index:
krasin created this revision.
krasin added a reviewer: chapuni.
krasin added subscribers: pcc, cfe-commits.
http://reviews.llvm.org/D12021
Files:
test/Frontend/dependency-gen.c
Index: test/Frontend/dependency-gen.c
===
---
Author: jketema
Date: Thu Aug 13 18:43:12 2015
New Revision: 244987
URL: http://llvm.org/viewvc/llvm-project?rev=244987view=rev
Log:
Remove files accidentally not removed in r244310
Removed:
libclc/trunk/generic/lib/LLVM3.6/
libclc/trunk/generic/lib/SOURCES_LLVM3.6
Removed:
Prazek added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:1832
@@ +1831,3 @@
+ // Generate vtable assumptions if we are calling dynamic class ctor
+ // and we are not in another ctor.
+ if (CGM.getCodeGenOpts().OptimizationLevel 0
hfinkel wrote:
I
Apologies, I'm really resistant to more things being used in
TargetOptions and I was (perhaps mistakenly) under the impression
that you wanted to move it to TargetOptions without an IR
serialization. We need all options to have that sort of
serialization right? :)
Absolutely, they
Author: brad
Date: Thu Aug 13 16:45:57 2015
New Revision: 244961
URL: http://llvm.org/viewvc/llvm-project?rev=244961view=rev
Log:
[SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Preprocessor/init.c
Modified:
Author: dblaikie
Date: Thu Aug 13 17:12:21 2015
New Revision: 244968
URL: http://llvm.org/viewvc/llvm-project?rev=244968view=rev
Log:
Wdeprecated: Make BumpVectorContext movable
Turns out the one place that relied on the implicit copy ctor was safe
because it created an object in a state where
diltsman updated this revision to Diff 32099.
diltsman marked an inline comment as done.
diltsman added a comment.
Added test for command and arguments in same object.
Fixed bug where parse failed if command and argument resolved to empty lists.
http://reviews.llvm.org/D10365
Files:
Hi there,
I will remove both test cases, which rely on the existence of the default
blacklist. It's handled by the driver anyway, and the code I changed is in
the frontend; at this point, there's no such a thing, as a default
blacklist, all of them are explicit.
Just a sec.
krasin
On Thu, Aug
sunfish marked 2 inline comments as done.
Comment at: lib/Basic/Targets.cpp:6935
@@ +6934,3 @@
+
+public:
+ explicit WebAssemblyTargetInfo(const llvm::Triple T) : TargetInfo(T) {
I've now removed this (for now; we can discuss what to do in a later patch).
majnemer updated this revision to Diff 32100.
majnemer added a comment.
- Address Justin's review comments.
- Address Richard's review comments.
http://reviews.llvm.org/D11629
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTContext.cpp
lib/CodeGen/CodeGenModule.h
Author: dblaikie
Date: Thu Aug 13 18:38:46 2015
New Revision: 244986
URL: http://llvm.org/viewvc/llvm-project?rev=244986view=rev
Log:
Wdeprecated: Ensure CheckNames are copy assignable (used in
setCurrentCheckName) by removing the unnecessary copy ctor
Modified:
Author: majnemer
Date: Thu Aug 13 18:50:15 2015
New Revision: 244989
URL: http://llvm.org/viewvc/llvm-project?rev=244989view=rev
Log:
Avoid iteration invalidation issues around MaterializedTemporaryExpr
We risk iterator invalidation issues if we use a DenseMap to hold the
backing storage for an
- Original Message -
From: Eric Christopher echri...@gmail.com
To: reviews+d11815+public+324fadcdaae02...@reviews.llvm.org,
ahata...@gmail.com, dexonsm...@apple.com,
hfin...@anl.gov
Cc: cfe-commits@lists.llvm.org
Sent: Thursday, August 13, 2015 7:39:53 PM
Subject: Re: [PATCH]
Author: dblaikie
Date: Thu Aug 13 16:15:23 2015
New Revision: 244956
URL: http://llvm.org/viewvc/llvm-project?rev=244956view=rev
Log:
Wdeprecated: Replace deprecated throw() with LLVM_NOEXCEPT which expands to
'noexcept' where available (and throw() otherwise)
Modified:
chandlerc added a comment.
I agree with both Marshall and Hal.
However, I'm also not opposed to platforms opting out if this if they want to.
If a particular platform wants to define the behavior of null pointers passed
to these functions, that seems like a reasonable thing to support here.
Author: dblaikie
Date: Thu Aug 13 16:24:08 2015
New Revision: 244958
URL: http://llvm.org/viewvc/llvm-project?rev=244958view=rev
Log:
Wdeprecated: CommentVerifiers are returned by value, make sure they're
correctly copy/moveable
Modified:
cfe/trunk/unittests/Tooling/CommentHandlerTest.cpp
David Majnemer david.majne...@gmail.com writes:
majnemer created this revision.
majnemer added a reviewer: rsmith.
majnemer added a subscriber: cfe-commits.
We risk iterator invalidation issues if we use DenseMap structures for
MaterializedTemporaryExprs. Use a std::map to ensure that they
Please make such programs crash early and often. They are a nightmare to
maintain. Make them blow in the face of the original authors; not after
they are gone.
-- Gaby
On Thu, Aug 13, 2015 at 11:18 AM, Richard Smith via cfe-commits
cfe-commits@lists.llvm.org wrote:
On Thu, Aug 13, 2015 at
Thank you, Yaron. Understood.
On Thu, Aug 13, 2015 at 11:04 AM, Yaron Keren yaron.ke...@gmail.com wrote:
There is great variety of OSs, compilers, configs in the bots. You can't
get the smae with try bots unless everything is duplicated which is a
waste. You test locally, commit, watch the
I don't see anywhere in the C standard that says that a memcpy() with NULL
for either pointer is UB (which would only be valid for the case where n ==
0). This seems like a particularly aggressive (mis)optimization in the
general case. It should only be acceptable if the length is guaranteed to
be
Prazek marked 5 inline comments as done.
Prazek added a comment.
http://reviews.llvm.org/D11859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd added a comment.
AIUI, ucrt is absolutely relevant since msvcrt itself has been split out into
the ucrt. msvcrt is the shared common bits, while the ucrt is more
platform specific bits.
But really, the point is: supporting an older version with a newer compiler is
what doing this
majnemer added a comment.
In http://reviews.llvm.org/D7642#224225, @compnerd wrote:
AIUI, ucrt is absolutely relevant since msvcrt itself has been split out into
the ucrt. msvcrt is the shared common bits, while the ucrt is more
platform specific bits.
But really, the point is:
Prazek created this revision.
Prazek added reviewers: rsmith, majnemer, pcc.
Prazek added a subscriber: cfe-commits.
Adding !invariant.group to vptr load/stores for devirtualization purposes.
For more goto:
http://lists.llvm.org/pipermail/cfe-dev/2015-July/044227.htm
dcoughlin added a comment.
I'm still looking at this. Higher-level comments coming soon.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1110
@@ +1109,3 @@
+ assert(RO.getOffset() = 0 Offset should not be negative);
+ uint64_t LowerOffset = RO.getOffset();
+
Author: dblaikie
Date: Thu Aug 13 20:26:19 2015
New Revision: 244998
URL: http://llvm.org/viewvc/llvm-project?rev=244998view=rev
Log:
unique_ptrify ConsumedBlockInfo analysis to make it move assignable
ConsumedBlockInfo objects were move assigned, but only in a state where
the dtor was a no-op
rjmccall added a comment.
In http://reviews.llvm.org/D11297#223622, @andreybokhanko wrote:
John,
Thank you for the quick reply!
Let me make sure I understand what you said, using my test as an example
(BTW, sorry if this is a dumb question -- I asked our local Clang experts,
but no-one
Prazek updated this revision to Diff 32122.
Prazek marked an inline comment as done.
http://reviews.llvm.org/D11859
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
We could support that by allowing the MSVC version in the triple to be
different from the -fms-compatibility-version on the command line. Today,
this might even with with --target.
That said, I don't imagine many people are doing this. Microsoft makes it
hard for you to do this, and lots of code
Prazek marked an inline comment as done.
Comment at: lib/CodeGen/CGClass.cpp:1832
@@ +1831,3 @@
+ // Generate vtable assumptions if we are calling dynamic class ctor
+ // and we are not in another ctor.
+ if (CGM.getCodeGenOpts().OptimizationLevel 0
rsmith
Hello ,
i have tried to solve but after removing the lib/PoolAllocate
code doesn't compile with LLVM mainline, and you don't need it for
SAFECode. You can remove PoolAllocate from the list of directories to
compile in poolalloc/lib/Makefile. also am not able to compile this in
Windows
//=== TypeChecks.cpp - Insert runtime type checks
-===//
//
// The LLVM Compiler Infrastructure
//
// This file was developed by the LLVM research group and is distributed
under
// the University of Illinois Open Source License. See LICENSE.TXT for
On Thu, Aug 13, 2015 at 4:53 PM, Stephen Hines via cfe-commits
cfe-commits@lists.llvm.org wrote:
I don't see anywhere in the C standard that says that a memcpy() with NULL
for either pointer is UB (which would only be valid for the case where n ==
0). This seems like a particularly aggressive
angelgarcia updated this revision to Diff 32059.
angelgarcia added a comment.
Remove StringSwitch.
http://reviews.llvm.org/D11946
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Makefile
76 matches
Mail list logo
