[PATCH] D43510: [clangd] don't insert new includes if either original header or canonical header is already included.

ioeric updated this revision to Diff 135857. ioeric marked an inline comment as done. ioeric added a comment. - Merge with origin/master - Use llvm::StringSet Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43510 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp

[PATCH] D43510: [clangd] don't insert new includes if either original header or canonical header is already included.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326070: [clangd] dont insert new includes if either original header or canonical… (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r326070 - [clangd] don't insert new includes if either original header or canonical header is already included.

Author: ioeric Date: Mon Feb 26 00:32:13 2018 New Revision: 326070 URL: http://llvm.org/viewvc/llvm-project?rev=326070=rev Log: [clangd] don't insert new includes if either original header or canonical header is already included. Summary: Changes: o Store both the original header and the

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

aaron.ballman added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + // Options. + if (Options.FormatStyle) { Extraneous whitespace. Comment at: unittests/clang-tidy/ClangTidyTest.h:147 + if (Options.FormatStyle)

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

zturner added a comment. @rnk by "in an MSVC environment" do you mean "when -fms-compatibility is present"? https://reviews.llvm.org/D43700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

colden added a comment. In https://reviews.llvm.org/D43700#1019505, @aganea wrote: > Thanks for fixing this @zturner. I simply want to back-up what @probinson > says above - most of the games we do at Ubisoft are currently using a > different compilation toolchains for each platform (we ship

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

zturner added a comment. In https://reviews.llvm.org/D43700#1019533, @smeenai wrote: > The `-g` meaning `-gcodeview` for MSVC environments change should be a > separate diff though, right? Yes I'm not doing that in this patch. Just wanted to clarify what he meant. I'm writing a test for

[PATCH] D43773: Implement the container bits of P0805R1

mclow.lists created this revision. mclow.lists added a reviewer: EricWF. P0805R1 is about comparing heterogenous containers. This is the implementation for `array`, `vector`, `deque`, `list` and `forward_list`. The `tuple`

[PATCH] D43773: Implement the container bits of P0805R1

mclow.lists updated this revision to Diff 135941. mclow.lists added a comment. forgot to include the changes for `` in the diff. https://reviews.llvm.org/D43773 Files: include/array include/deque include/forward_list include/list include/vector

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka added inline comments. Comment at: test/asan/TestCases/intercept-rethrow-exception.cc:48 + // memcpy is intercepted by asan which performs checks on src and dst + using T = int[1000]; + T x {}; robot wrote: > vitalybuka wrote: > > You can include

r326108 - [Driver] Forward opt-remark hotness threshold to LTO

Author: anemet Date: Mon Feb 26 10:38:11 2018 New Revision: 326108 URL: http://llvm.org/viewvc/llvm-project?rev=326108=rev Log: [Driver] Forward opt-remark hotness threshold to LTO Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp cfe/trunk/test/Driver/darwin-ld.c Modified:

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

smeenai added a comment. The `-g` meaning `-gcodeview` for MSVC environments change should be a separate diff though, right? https://reviews.llvm.org/D43700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rC326113: Emit proper CodeView when -gcodeview is passed without the cl driver. (authored by zturner, committed by ). Changed prior to commit: https://reviews.llvm.org/D43700?vs=135723=135932#toc

r326102 - [DebugInfo] Support DWARF v5 source code embedding extension

Author: scott.linder Date: Mon Feb 26 09:32:31 2018 New Revision: 326102 URL: http://llvm.org/viewvc/llvm-project?rev=326102=rev Log: [DebugInfo] Support DWARF v5 source code embedding extension In DWARF v5 the Line Number Program Header is extensible, allowing values with new content types.

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

kevinl added a comment. @krasimir ping? would appreciate you committing this for me. thanks! Repository: rC Clang https://reviews.llvm.org/D43312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

aaron.ballman added a comment. This fix is missing test coverage, can you add a C++11 and C++14 test to demonstrate the behavior differences? Comment at: clang-tidy/modernize/MakeSharedCheck.cpp:30 +bool MakeSharedCheck::isVersionSupported(const clang::LangOptions ) const

r326116 - Revert "Emit proper CodeView when -gcodeview is passed without the cl driver."

Author: zturner Date: Mon Feb 26 11:51:29 2018 New Revision: 326116 URL: http://llvm.org/viewvc/llvm-project?rev=326116=rev Log: Revert "Emit proper CodeView when -gcodeview is passed without the cl driver." This reverts commit e17911006548518634fad66bb8648bcad49a1d64. This is failing on ASAN

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

aganea added a comment. Thanks for fixing this @zturner. I simply want to back-up what @probinson says above - most of the games we do at Ubisoft are currently using a different compilation toolchains for each platform (we ship at least 4-5 platforms for each top game). It can be clang or it

[PATCH] D43749: [Attr] Fix alloc_size's diags to report arg idx not value

aaron.ballman added a comment. In https://reviews.llvm.org/D43749#1019359, @jdenny wrote: > In https://reviews.llvm.org/D43749#1018846, @aaron.ballman wrote: > > > Committed (with whitespace fix for the test case) in r326058, thanks for > > the patch! > > > Sure. Thanks for committing. > > By

[PATCH] D42766: [DebugInfo] Support DWARFv5 source code embedding extension

This revision was automatically updated to reflect the committed changes. Closed by commit rL326102: [DebugInfo] Support DWARF v5 source code embedding extension (authored by scott.linder, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43547: [Indexing] Fixing inconsistencies between FUNCDNAME and generated code by improving ASTContext's API for MangleContext

rnk added a comment. Code looks good, but we should test it. Can you add a CodeGenCXX test that shows the issue with FUNCDNAME? I see the issue with this program: #include int main() { const char *s1 = ([]() { return __FUNCDNAME__; })(); const char *s2 = ([]() { return

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

colden added a comment. In https://reviews.llvm.org/D43700#1019506, @zturner wrote: > @rnk by "in an MSVC environment" do you mean "when -fms-compatibility is > present"? It looks like other places in this file are using `Triple.isWindowsMSVCEnvironment()`, which I think would make sense to

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

zturner added a comment. I had to revert this for now. It breaks the asan bots which expect column info. That fix is easy, but it also breaks a random linux bots which I don't have the ability to debug at the moment because my linux machine is not working. Hopefully I can get that resolved

[PATCH] D43749: [Attr] Fix alloc_size's diags to report arg idx not value

jdenny added a comment. In https://reviews.llvm.org/D43749#1018846, @aaron.ballman wrote: > Committed (with whitespace fix for the test case) in r326058, thanks for the > patch! Sure. Thanks for committing. By the way the commit log you added isn't quite right. The issue isn't base 0

[PATCH] D43749: [Attr] Fix alloc_size's diags to report arg idx not value

jdenny added a comment. In https://reviews.llvm.org/D43749#1019377, @aaron.ballman wrote: > Oh, yeah, I did muck up that commit log message a bit. Sorry about that! No problem. :-) I'll get to your comments in the other patches hopefully soon. Thanks again. https://reviews.llvm.org/D43749

r326113 - Emit proper CodeView when -gcodeview is passed without the cl driver.

Author: zturner Date: Mon Feb 26 11:25:39 2018 New Revision: 326113 URL: http://llvm.org/viewvc/llvm-project?rev=326113=rev Log: Emit proper CodeView when -gcodeview is passed without the cl driver. Windows debuggers don't work properly when column info is emitted with lines. We handled this by

[clang-tools-extra] r326118 - Fix for LLVM r326109

Author: davezarzycki Date: Mon Feb 26 12:21:30 2018 New Revision: 326118 URL: http://llvm.org/viewvc/llvm-project?rev=326118=rev Log: Fix for LLVM r326109 Modified: clang-tools-extra/trunk/clang-query/QueryParser.cpp clang-tools-extra/trunk/clang-query/QueryParser.h Modified:

[PATCH] D43218: [analyzer] Quickfix: do not overflow in calculating offset in RegionManager

This revision was automatically updated to reflect the committed changes. Closed by commit rC326122: [analyzer] Quickfix: do not overflow in calculating offset in RegionManager (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r326122 - [analyzer] Quickfix: do not overflow in calculating offset in RegionManager

Author: george.karpenkov Date: Mon Feb 26 13:03:06 2018 New Revision: 326122 URL: http://llvm.org/viewvc/llvm-project?rev=326122=rev Log: [analyzer] Quickfix: do not overflow in calculating offset in RegionManager Addresses https://bugs.llvm.org/show_bug.cgi?id=36206 rdar://37159026 A proper

[PATCH] D43773: Implement the container bits of P0805R1

tcanens added a comment. Hmm, for `vector` and `deque`, we define a temporary variable, check that sizes match and then use range-and-a-half `equal`: const typename vector<_Tp1, _Allocator1>::size_type __sz = __x.size(); return __sz == __y.size() && _VSTD::equal(__x.begin(), __x.end(),

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

ruiu added a comment. This change looks good to me, but I think we shouldn't check in an executable binary file. Can you create `ld.foo.exe` in the test? Since you don't actually run ld.foo.exe, creating that executable should be very easy. https://reviews.llvm.org/D43621

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

jakehehrlich added a comment. Can you add a test for when #pragma GCC visibility push(hidden) is used and the visibility attribute is hidden? https://reviews.llvm.org/D43392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT326132: [asan] Intercept std::rethrow_exception indirectly (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42644?vs=132990=135965#toc Repository: rCRT

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:159-160 + CleannedReplacements = std::move(FormattedReplacements); + if (!CleannedReplacements) +llvm_unreachable("!CleannedReplacements"); +} else {

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D43621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

kubamracek added a comment. Great! So the versions in `ObjCRuntime.h` didn't really match what the iOS and macOS supported? https://reviews.llvm.org/D43787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks for digging into and addressing this! https://reviews.llvm.org/D43787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett updated this revision to Diff 135944. juliehockett marked 6 inline comments as done. juliehockett added a comment. After discussion, the goal of this checker slightly changed to target definitions in header files, rather than declarations. As a result, the check now adds the

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:52-53 + Finder->addMatcher( + functionDecl(allOf(hasAnyName(SmallVector(Names.begin(), + Names.end())), +

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

jakehehrlich added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:26 + +// AST_MATCHER(FunctionDecl, isInHeaderFile) { +// return Node.getExplicitVisibility(NamedDecl::VisibilityForType); What are these comments doing here?

r326136 - [analyzer] Exploration strategy prioritizing unexplored nodes first

Author: george.karpenkov Date: Mon Feb 26 14:14:18 2018 New Revision: 326136 URL: http://llvm.org/viewvc/llvm-project?rev=326136=rev Log: [analyzer] Exploration strategy prioritizing unexplored nodes first See D42775 for discussion. Turns out, just exploring nodes which weren't explored first

[PATCH] D43354: [analyzer] Exploration strategy prioritizing unexplored nodes first

This revision was automatically updated to reflect the committed changes. Closed by commit rC326136: [analyzer] Exploration strategy prioritizing unexplored nodes first (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

[PATCH] D43421: [analyzer] Do not analyze bison-generated files

This revision was automatically updated to reflect the committed changes. Closed by commit rC326135: [analyzer] Do not analyze bison-generated files (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D43421

r326135 - [analyzer] Do not analyze bison-generated files

Author: george.karpenkov Date: Mon Feb 26 14:14:16 2018 New Revision: 326135 URL: http://llvm.org/viewvc/llvm-project?rev=326135=rev Log: [analyzer] Do not analyze bison-generated files Bison/YACC generated files result in a very large number of (presumably) false positives from the analyzer.

[PATCH] D43775: add UUID to the acronyms list of objc property name checks

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Wizard added reviewers: benhamilton, hokein. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43775 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp Index:

[PATCH] D43780: [Tooling] [1/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri created this revision. lebedev.ri added reviewers: klimek, bkramer, alexfh, pcc. lebedev.ri added projects: clang, clang-tools-extra. Herald added subscribers: jkorous-apple, ioeric. I'm not sure whether there are any principal reasons why it returns raw owning pointer, or it is just

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri created this revision. lebedev.ri added reviewers: klimek, bkramer, alexfh, pcc. lebedev.ri added a project: clang. Noticed during review of https://reviews.llvm.org/D41102. I'm not sure whether there are any principal reasons why it returns raw owning pointer, or it is just a old

[libcxx] r326120 - [libcxx] [test] Fix MSVC warnings and errors.

Author: stl_msft Date: Mon Feb 26 12:47:46 2018 New Revision: 326120 URL: http://llvm.org/viewvc/llvm-project?rev=326120=rev Log: [libcxx] [test] Fix MSVC warnings and errors. test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp

r326131 - Revert "[analyzer] Quickfix: do not overflow in calculating offset in RegionManager"

Author: george.karpenkov Date: Mon Feb 26 13:32:57 2018 New Revision: 326131 URL: http://llvm.org/viewvc/llvm-project?rev=326131=rev Log: Revert "[analyzer] Quickfix: do not overflow in calculating offset in RegionManager" This reverts commit df306c4c5ab4a6b8d3c47432346d1f9b90c328b4. Reverting

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

erichkeane added inline comments. Comment at: include/clang/CodeGen/CGFunctionInfo.h:519 + /// Whether this function has nocf_check attribute. + unsigned NoCfCheck : 1; + aaron.ballman wrote: > oren_ben_simhon wrote: > > aaron.ballman wrote: > > > This is

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

vsapsai added a comment. In https://reviews.llvm.org/D43787#1019886, @kubamracek wrote: > Great! So the versions in `ObjCRuntime.h` didn't really match what the iOS > and macOS supported? Yes, support for assigning nil for a key for NSMutableDictionary was added in macOS 10.11, iOS 9.

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

yaxunl created this revision. yaxunl added reviewers: b-sumner, Anastasia, bader. Herald added a subscriber: nhaehnle. OpenCL runtime tracks the invoke function emitted for any block expression. Due to restrictions on blocks in OpenCL (v2.0 s6.12.5), it is always possible to know the block invoke

[PATCH] D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

rnk accepted this revision. rnk added a comment. Thanks! https://reviews.llvm.org/D43734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. If its easy enough to wire that through to the frontend as a proper diagnostic, that would be better with a test. Otherwise, this is good to continue to make progress.

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone added a comment. @rtrieu please take a look? Repository: rC Clang https://reviews.llvm.org/D43322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

aaron.ballman added inline comments. Comment at: include/clang/CodeGen/CGFunctionInfo.h:519 + /// Whether this function has nocf_check attribute. + unsigned NoCfCheck : 1; + oren_ben_simhon wrote: > aaron.ballman wrote: > > This is unfortunate -- it bumps the

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

vsapsai created this revision. vsapsai added reviewers: vsk, kubamracek. Herald added a subscriber: jkorous-apple. Update min deployment target in some tests so that they don't try to link against libarclite and don't fail when it's not available. rdar://problem/29253617

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam added a comment. In https://reviews.llvm.org/D43576#1016588, @rsmith wrote: > In https://reviews.llvm.org/D43576#1016561, @majnemer wrote: > > > Here's my thinking: the `__uuidof` expression literally declares a variable > > called `_GUID_ddb47a6a_0f23_11d5_9109_00e0296b75d3` of type

Re: r326168 - Attempt to fix greendragon bot after r326141

Never mind, I didn’t realize Reid resubmitted my cl after I reverted it. In fact, I reverted it because of this greendragon failure which I wasn’t sure how to fix at the time On Mon, Feb 26, 2018 at 10:12 PM Adam Nemet wrote: > BTW, I think that the LLVM bots have trouble

Re: r326168 - Attempt to fix greendragon bot after r326141

Hmm. Reid had included a fix for compiler-rt in r326141, but that doesn't seem particularly relevant to this failure. In any case, I expect I'll receive emails when that bot is up and running again, and I can take a look then. (It didn't repro locally on Linux for me.) From: Zachary Turner

[PATCH] D43805: Optionally use nameless IR types

rjmccall added inline comments. Comment at: include/clang/Driver/Options.td:1735 + HelpText<"Whether to use IR type names (option: none, use)">, + Values<"none,use">; def relocatable_pch : Flag<["-", "--"], "relocatable-pch">, Flags<[CC1Option]>, This is an

[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

krisb created this revision. Herald added subscribers: cfe-commits, mgorny, klimek. Repository: rC Clang https://reviews.llvm.org/D43809 Files: include/clang/Frontend/CompilerInstance.h lib/CodeGen/CodeGenAction.cpp lib/Frontend/CompilerInstance.cpp unittests/Format/FormatTest.cpp

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adding a check to restrict specific includes. Given a list of includes that should not be used,

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

rnk added a comment. In https://reviews.llvm.org/D43621#1019724, @ruiu wrote: > This change looks good to me, but I think we shouldn't check in an executable > binary file. Can you create `ld.foo.exe` in the test? Since you don't > actually run ld.foo.exe, creating that executable should be

[PATCH] D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

This revision was automatically updated to reflect the committed changes. Closed by commit rL326173: [RecordLayout] Dont align to non-power-of-2 sizes when using -mms-bitfields (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r326173 - [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

Author: mstorsjo Date: Mon Feb 26 22:27:06 2018 New Revision: 326173 URL: http://llvm.org/viewvc/llvm-project?rev=326173=rev Log: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields When targeting GNU/MinGW for i386, the size of the "long double" data type is 12 bytes

Re: r326168 - Attempt to fix greendragon bot after r326141

So this doesn’t appear to fix the issue that led to my revert earlier. http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/6760 There’s no slashes in the command line that’s failing. However, this bot doesn’t seem to be updating and hasn’t pulled in this cl yet, but I

[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

krisb updated this revision to Diff 136041. krisb added a comment. Reverted unintentional changes. Repository: rC Clang https://reviews.llvm.org/D43809 Files: include/clang/Frontend/CompilerInstance.h lib/CodeGen/CodeGenAction.cpp lib/Frontend/CompilerInstance.cpp

r326144 - Fix codeview-column-info.c test with a triple

Author: rnk Date: Mon Feb 26 15:06:40 2018 New Revision: 326144 URL: http://llvm.org/viewvc/llvm-project?rev=326144=rev Log: Fix codeview-column-info.c test with a triple Modified: cfe/trunk/test/Driver/codeview-column-info.c Modified: cfe/trunk/test/Driver/codeview-column-info.c URL:

r326146 - [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Mon Feb 26 15:15:52 2018 New Revision: 326146 URL: http://llvm.org/viewvc/llvm-project?rev=326146=rev Log: [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. This patch is a targeted suppression heuristic for false positives `MallocChecker` produces when a shared / reference-counting pointer is

[PATCH] D43606: [Driver] Add SafeStack to a map of incompatible sanitizers

phosek updated this revision to Diff 136002. phosek marked an inline comment as done. Herald added subscribers: Sanitizers, llvm-commits. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D43606 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/fsanitize.c Index:

r326151 - [Driver] Add SafeStack to a map of incompatible sanitizers

Author: phosek Date: Mon Feb 26 16:01:26 2018 New Revision: 326151 URL: http://llvm.org/viewvc/llvm-project?rev=326151=rev Log: [Driver] Add SafeStack to a map of incompatible sanitizers This allows reporting an error when user tries to use SafeStack with incompatible sanitizers. Differential

[PATCH] D43606: [Driver] Add SafeStack to a map of incompatible sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rL326151: [Driver] Add SafeStack to a map of incompatible sanitizers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D43606?vs=136002=136004#toc Repository: rL

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: include/clang/AST/Attr.h:210-212 + unsigned Idx; + bool HasThis; + bool IsValid; aaron.ballman wrote: > I think it might be best to mash these together using bit-fields: > ``` > unsigned Idx : 30; > unsigned HasThis :

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2899 + // to find out if a likely-false-positive suppression should kick in. + for (const LocationContext *LC = CurrentLC; LC; LC = LC->getParent()) { +if

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2899 + // to find out if a likely-false-positive suppression should kick in. + for (const LocationContext *LC = CurrentLC; LC; LC = LC->getParent()) { +if (isa(LC->getDecl()))

r326145 - Fix which Darwin versions have ObjC runtime with full subscripting support.

Author: vsapsai Date: Mon Feb 26 15:10:23 2018 New Revision: 326145 URL: http://llvm.org/viewvc/llvm-project?rev=326145=rev Log: Fix which Darwin versions have ObjC runtime with full subscripting support. Update min deployment target in some tests so that they don't try to link against

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:527 private: +bool shouldSuppressOnAtomicReferenceCountingPointers( +const Stmt *S, const LocationContext *CurrentLC); Docstring.

[PATCH] D43782: [analyzer] Switch the default exploration strategy to priority queue based on coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rC326157: [analyzer] Switch the default exploration strategy to priority queue based on… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r326157 - [analyzer] Switch the default exploration strategy to priority queue based on coverage

Author: george.karpenkov Date: Mon Feb 26 17:31:56 2018 New Revision: 326157 URL: http://llvm.org/viewvc/llvm-project?rev=326157=rev Log: [analyzer] Switch the default exploration strategy to priority queue based on coverage After the investigation it seems safe to flip the switch.

[PATCH] D43798: [analyzer] UndefinedAssignment: Fix warning message on implicit copy/move constructors.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. When a class forgets to initialize a field in the constructor, and then gets copied around, a warning is emitted that the value assigned to

[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

jdenny updated this revision to Diff 135982. jdenny added a comment. Aaron: Because the last two arguments for objc_bridge_related must be delimited with commas, this revision takes the view that they are not optional but are permitted to be the empty string. The test suite behaves as

[PATCH] D43666: [analyzer] When constructing a temporary without construction context, track it for destruction anyway.

NoQ updated this revision to Diff 135994. NoQ marked 3 inline comments as done. NoQ added a comment. Fix cleanup node generation logic. https://reviews.llvm.org/D43666 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp

[PATCH] D43666: [analyzer] When constructing a temporary without construction context, track it for destruction anyway.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:2262 + assert(DidCacheOutOnCleanup || + areInitializedTemporariesClear(Pred->getState(), Pred->getLocationContext(), dcoughlin wrote:

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

rsmith added a comment. In https://reviews.llvm.org/D43576#1019703, @zahiraam wrote: > Currently this declaration: > struct > __declspec(uuid("{DDB47A6A-0F23-11D5-9109-00E0296B75D3}")) > S1; > > a CXXRecordDecl type is generated with attributes (the uuid being an > attribute). Are you

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

Eugene.Zelenko added inline comments. Comment at: clang-tidy/fuchsia/CMakeLists.txt:8 OverloadedOperatorCheck.cpp + RestrictIncludesCheck.cpp StaticallyConstructedObjectsCheck.cpp Will be good idea to be have consistent name and documentation terminology:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136010. juliehockett marked 10 inline comments as done. juliehockett added a comment. 1. Moved the serialization logic out of the Mapper class and into its own namespace 2. Updated tests 3. Addressing comments https://reviews.llvm.org/D41102 Files:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1017918, @lebedev.ri wrote: > Is there some (internal to `BitstreamWriter`) logic that would 'assert()' if > trying to output some recordid > which is, according to the `BLOCKINFO_BLOCK`, should not be there? > E.g. outputting

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek created this revision. phosek added reviewers: EricWF, mclow.lists, beanz. Herald added subscribers: cfe-commits, christof, mgorny. When the generated __config file is being used, it is currently only copied during installation process. However, that means that the file that gets copied

r326141 - Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver."

Author: rnk Date: Mon Feb 26 14:55:33 2018 New Revision: 326141 URL: http://llvm.org/viewvc/llvm-project?rev=326141=rev Log: Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver." Reverts r326116 and re-lands r326113 with a fix to ASan so that it enables column info in

r326152 - Revert "Revert "[analyzer] Quickfix: do not overflow in calculating offset in RegionManager""

Author: george.karpenkov Date: Mon Feb 26 16:05:04 2018 New Revision: 326152 URL: http://llvm.org/viewvc/llvm-project?rev=326152=rev Log: Revert "Revert "[analyzer] Quickfix: do not overflow in calculating offset in RegionManager"" This reverts commit c4cc41166d93178a3ddd4b2b5a685cf74a459247.

r326155 - [analyzer] Logging test quickfix.

Author: george.karpenkov Date: Mon Feb 26 17:13:28 2018 New Revision: 326155 URL: http://llvm.org/viewvc/llvm-project?rev=326155=rev Log: [analyzer] Logging test quickfix. Modified: cfe/trunk/test/Analysis/region_store_overflow.c Modified: cfe/trunk/test/Analysis/region_store_overflow.c

[PATCH] D43773: Implement the container bits of P0805R1

mclow.lists added a comment. > Is there a subtle reason for this inconsistency that I'm not seeing? I suspect that it's because they were written at different times. (When I say 'written at different times', I mean I adapted the existing `op==` for the containers - not that this new code was

[PATCH] D43773: Implement the container bits of P0805R1

mclow.lists added a comment. I can certainly make them all the same. https://reviews.llvm.org/D43773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r326156 - [analyzer] Logging test typo quickfix.

Author: george.karpenkov Date: Mon Feb 26 17:31:06 2018 New Revision: 326156 URL: http://llvm.org/viewvc/llvm-project?rev=326156=rev Log: [analyzer] Logging test typo quickfix. Modified: cfe/trunk/test/Analysis/region_store_overflow.c Modified:

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 136019. jdenny marked 8 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. This revision should address all issues raised. https://reviews.llvm.org/D43248 Files: include/clang/AST/Attr.h

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326143: Fix which Darwin versions have ObjC runtime with full subscripting support. (authored by vsapsai, committed by ). Herald added subscribers: llvm-commits, delcypher. Changed prior to commit:

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ updated this revision to Diff 136020. NoQ added a comment. Address comments. https://reviews.llvm.org/D43791 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/NewDelete-atomics.cpp Index: test/Analysis/NewDelete-atomics.cpp

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2847 + + AtomicExpr::AtomicOp Op = AE->getOp(); + if (Op != AtomicExpr::AO__c11_atomic_fetch_add && george.karpenkov wrote: > IMO would be slightly easier to read with logic

  1   2   >