[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl updated this revision to Diff 137421. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. Removed CallArg::getAggregateAddress(). https://reviews.llvm.org/D34367 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGCall.h

[PATCH] D43917: [analyzer] [NFC] Minor refactoring of NonNullParamChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC326935: [analyzer] [NFC] Minor refactoring of NonNullParamChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r326935 - [analyzer] [NFC] Minor refactoring of NonNullParamChecker

Author: george.karpenkov Date: Wed Mar 7 11:27:32 2018 New Revision: 326935 URL: http://llvm.org/viewvc/llvm-project?rev=326935=rev Log: [analyzer] [NFC] Minor refactoring of NonNullParamChecker Differential Revision: https://reviews.llvm.org/D43917 Modified:

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl updated this revision to Diff 137460. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. Added comment about emit non-null argument check. https://reviews.llvm.org/D34367 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall.cpp

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. LGTM! https://reviews.llvm.org/D34367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis created this revision. thakis added a reviewer: rnk. No effective behavior change, just for cleanliness. Fixes PR36159. https://reviews.llvm.org/D44223 Files: lib/CodeGen/MicrosoftCXXABI.cpp Index: lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D43990: set dso_local on tls init functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I think Richard has been really busy preparing for some C++ committee function. I think we should go forward with this. https://reviews.llvm.org/D43990

[PATCH] D44218: Correct the alignment for the PS4 target

ormris created this revision. ormris added reviewers: rsmith, craig.topper, echristo, erichkeane. See above. Repository: rC Clang https://reviews.llvm.org/D44218 Files: lib/Basic/Targets/OSTargets.h test/Preprocessor/init.c Index: test/Preprocessor/init.c

r326937 - [OpenCL] Remove block invoke function from emitted block literal struct

Author: yaxunl Date: Wed Mar 7 11:32:58 2018 New Revision: 326937 URL: http://llvm.org/viewvc/llvm-project?rev=326937=rev Log: [OpenCL] Remove block invoke function from emitted block literal struct OpenCL runtime tracks the invoke function emitted for any block expression. Due to restrictions

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

This revision was automatically updated to reflect the committed changes. Closed by commit rC326937: [OpenCL] Remove block invoke function from emitted block literal struct (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D43783 Files:

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 137447. https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@ -388,6 +388,21 @@ //

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D44221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. In https://reviews.llvm.org/D41102#1028995, @lebedev.ri wrote: > Some further notes based on the SHA1 nature. I'm sorry, brainfreeze, i meant `40` chars, not `20`. Updated comments... Comment at: clang-doc/BitcodeWriter.cpp:309 +

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

efriedma added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1202 + SmallVector VBases(VBaseMap.begin(), VBaseMap.end()); + std::stable_sort(VBases.begin(), VBases.end(), + [](const VBaseEntry , const VBaseEntry ) {

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 137457. juliehockett marked 13 inline comments as done. juliehockett added a comment. Updating bitcode writer for hashed USRs, and re-running clang-format. Also cleaning up a couple of unused fields. https://reviews.llvm.org/D41102 Files:

RE: [PATCH] D44218: Correct the alignment for the PS4 target

Thanks! I’ll commit this. From: Eric Christopher [mailto:echri...@gmail.com] Sent: Wednesday, March 7, 2018 12:33 PM To: reviews+d44218+public+fd8ca19cc9985...@reviews.llvm.org Cc: cfe-commits@lists.llvm.org; craig.top...@gmail.com; erich.ke...@intel.com; filcab+llvm.phabrica...@gmail.com; Voss,

r326926 - Push a function scope when parsing function bodies without a declaration

Author: rnk Date: Wed Mar 7 10:55:10 2018 New Revision: 326926 URL: http://llvm.org/viewvc/llvm-project?rev=326926=rev Log: Push a function scope when parsing function bodies without a declaration Summary: This is PR36536. There are a few ways to reach Sema::ActOnStartOfFunctionDef with a null

Re: r326926 - Push a function scope when parsing function bodies without a declaration

On Wed, Mar 7, 2018 at 1:55 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Wed Mar 7 10:55:10 2018 > New Revision: 326926 > > URL: http://llvm.org/viewvc/llvm-project?rev=326926=rev > Log: > Push a function scope when parsing function bodies without

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3427 (void)InitialArgSize; -RValue RVArg = Args.back().RV; -EmitNonNullArgCheck(RVArg, ArgTypes[Idx], (*Arg)->getExprLoc(), AC, -ParamsToSkip + Idx); -// @llvm.objectsize

Re: [PATCH] D44218: Correct the alignment for the PS4 target

LGTM. On Wed, Mar 7, 2018, 11:02 AM Matthew Voss via Phabricator < revi...@reviews.llvm.org> wrote: > ormris created this revision. > ormris added reviewers: rsmith, craig.topper, echristo, erichkeane. > > See above. > > > Repository: > rC Clang > > https://reviews.llvm.org/D44218 > > Files: >

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone added a comment. Btw, I'm going to be talking about this patch tonight at 7 in Palo Alto. :) https://www.meetup.com/ACCU-Bay-Area/events/248040207/ https://docs.google.com/presentation/d/18ZRnedocXSQKn9Eh67gGv-ignReHfRD7vj_dxrra1kc/ Repository: rC Clang

[PATCH] D44174: do not register matcher for objc-only checks when analyzing non-objc sources to save resources

This revision was automatically updated to reflect the committed changes. Closed by commit rL326928: do not register matcher for objc-only checks when analyzing non-objc sources to… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1207 + + for (const VBaseEntry E : VBases) { +if (!E.second.hasVtorDisp()) (I added the missing `&` here locally.) https://reviews.llvm.org/D44223

r326922 - [OPENMP] Fix lifetime of the loop counters.

Author: abataev Date: Wed Mar 7 10:17:06 2018 New Revision: 326922 URL: http://llvm.org/viewvc/llvm-project?rev=326922=rev Log: [OPENMP] Fix lifetime of the loop counters. We may emit incorrect lifetime info during codegen for loop counters in OpenMP constructs because of automatic scope

[PATCH] D44217: [clang-tidy] Enable Python 3 support for add_new_check.py

jbcoe created this revision. jbcoe added a reviewer: alexfh. Herald added a subscriber: xazax.hun. In Python 3, filters are lazily evaluated and strings are not bytes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44217 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D43980: Push a function scope when parsing function bodies without a declaration

rnk added a comment. Thanks! John touched this code last in https://reviews.llvm.org/rL112038 in 2010, so maybe he has some thoughts on how to clean this and the follow-up. I think I'll land this as is since it fixes the crash and we can discuss more improvements in

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

rnk added a comment. Thanks for investigating! Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1206 + + for (const VBase : VBases) { +if (!V.second.hasVtorDisp()) I think we can avoid the sort altogether if we iterate `RD->vbases()`, which should already be

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

rnk created this revision. rnk added a reviewer: rjmccall. This provides no measurable build speedup, but it reinstates an optimization from r112038 that was lost in r179618. It requires moving CapturedScopeInfo::Capture out to clang::sema, which might be too general since we have plenty of

[PATCH] D44222: [AArch64] Add vmulxh_lane FP16 intrinsics

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: az, evandro, olista01. Herald added subscribers: kristof.beyls, javed.absar, rengolin. Add 2 vmulxh_lane vector intrinsics that were commented out. https://reviews.llvm.org/D44222 Files: include/clang/Basic/arm_neon.td

[PATCH] D44222: [AArch64] Add vmulxh_lane FP16 intrinsics

evandro accepted this revision. evandro added a comment. This revision is now accepted and ready to land. Looks pretty straightforward to me. https://reviews.llvm.org/D44222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis updated this revision to Diff 137463. thakis added a comment. Herald added a subscriber: mgrang. sort unstably https://reviews.llvm.org/D44223 Files: lib/CodeGen/MicrosoftCXXABI.cpp Index: lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D43980: Push a function scope when parsing function bodies without a declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rC326926: Push a function scope when parsing function bodies without a declaration (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D43980?vs=136635=137437#toc

[PATCH] D43980: Push a function scope when parsing function bodies without a declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL326926: Push a function scope when parsing function bodies without a declaration (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 137448. https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@ -388,6 +388,25 @@ //

r326942 - Correct the alignment for the PS4 target

Author: ormris Date: Wed Mar 7 12:48:16 2018 New Revision: 326942 URL: http://llvm.org/viewvc/llvm-project?rev=326942=rev Log: Correct the alignment for the PS4 target https://reviews.llvm.org/D44218 Modified: cfe/trunk/lib/Basic/Targets/OSTargets.h cfe/trunk/test/Preprocessor/init.c

Re: [libcxx] r323971 - Remove ; use instead. See https://libcxx.llvm.org/TS_deprecation.html

On Sat, Feb 24, 2018 at 7:17 PM, Marshall Clow wrote: > On Thu, Feb 22, 2018 at 7:58 AM, Nico Weber wrote: > >> I have a small personal project where I used to use this. I tried >> switching to instead, but that apparently requires -std=c++17. >>

r326946 - CodeGen: Fix address space of indirect function argument

Author: yaxunl Date: Wed Mar 7 13:45:40 2018 New Revision: 326946 URL: http://llvm.org/viewvc/llvm-project?rev=326946=rev Log: CodeGen: Fix address space of indirect function argument The indirect function argument is in alloca address space in LLVM IR. However, during Clang codegen for C++,

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

niko added a comment. If this is OK as it is, can someone with commit access push this? Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r326960 - [ms] Emit vtordisp initializers in a deterministic order.

Author: nico Date: Wed Mar 7 15:15:20 2018 New Revision: 326960 URL: http://llvm.org/viewvc/llvm-project?rev=326960=rev Log: [ms] Emit vtordisp initializers in a deterministic order. No effective behavior change, just for cleanliness. Analysis and typing by me, actual patch mostly by Reid.

[PATCH] D44231: Check for sizeof that call functions

pfultz2 updated this revision to Diff 137499. https://reviews.llvm.org/D44231 Files: clang-tidy/misc/SizeofExpressionCheck.cpp clang-tidy/misc/SizeofExpressionCheck.h test/clang-tidy/misc-sizeof-expression.cpp Index: test/clang-tidy/misc-sizeof-expression.cpp

[PATCH] D44095: [ObjC] Allow declaring __weak pointer fields in C structs in ObjC-ARC

ahatanak added inline comments. Comment at: include/clang/AST/Decl.h:3631 +PassedIndirectly = true; + } + rjmccall wrote: > I feel like this flag should be set by Sema for C++ types that have to be > passed indirectly as well; it can then become the single

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rL326965: [Sema] Make getCurFunction() return null outside function parsing (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rC326965: [Sema] Make getCurFunction() return null outside function parsing (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D44039?vs=137472=137506#toc Repository:

r326965 - [Sema] Make getCurFunction() return null outside function parsing

Author: rnk Date: Wed Mar 7 16:14:34 2018 New Revision: 326965 URL: http://llvm.org/viewvc/llvm-project?rev=326965=rev Log: [Sema] Make getCurFunction() return null outside function parsing Summary: Before this patch, Sema pre-allocated a FunctionScopeInfo and kept it in the first, always

Re: r326602 - [Attr] Fix parameter indexing for several attributes

(I had to revert this since it caused https://bugs.llvm.org/show_bug.cgi?id=36620) On Fri, Mar 2, 2018 at 2:03 PM, Joel E. Denny via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jdenny > Date: Fri Mar 2 11:03:22 2018 > New Revision: 326602 > > URL:

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL326946: CodeGen: Fix address space of indirect function argument (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r326948 - [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory

Author: gbercea Date: Wed Mar 7 13:59:50 2018 New Revision: 326948 URL: http://llvm.org/viewvc/llvm-project?rev=326948=rev Log: [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory Summary: Remove this scheme for now since it will be covered by another more

[PATCH] D44183: [analyzer] Don't crash with assertion failure on structured bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rC326951: [analyzer] Dont crash with assertion failure on structured bindings (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D44172: [analyzer] [PointerArithChecker] do not warn on indexes into vector types

This revision was automatically updated to reflect the committed changes. Closed by commit rC326952: [analyzer] [PointerArithChecker] do not warn on indexes into vector types (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r326952 - [analyzer] [PointerArithChecker] do not warn on indexes into vector types

Author: george.karpenkov Date: Wed Mar 7 14:20:39 2018 New Revision: 326952 URL: http://llvm.org/viewvc/llvm-project?rev=326952=rev Log: [analyzer] [PointerArithChecker] do not warn on indexes into vector types rdar://35041502 Differential Revision: https://reviews.llvm.org/D44172 Modified:

[PATCH] D44229: Don't use -pie in relocatable link.

mgrang added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311 + if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) || + Args.hasArg(options::OPT_r)) return false; We also need to check for -Wl,-r and -Xlinker

r326971 - [MS] Pass CVRU qualifiers properly in Itanium mangler

Author: rnk Date: Wed Mar 7 16:55:09 2018 New Revision: 326971 URL: http://llvm.org/viewvc/llvm-project?rev=326971=rev Log: [MS] Pass CVRU qualifiers properly in Itanium mangler We already have a mangling for the __unaligned qualifier, we just have to call Qualifiers::getFromCVRUMask instead of

[PATCH] D16632: clang-cl: Take dllexport from original function decl into account

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D16632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44239: [analyzer] Re-enable constructor inlining when lifetime extension through fields occurs.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. NoQ added a dependency: D44238: [CFG] Fix automatic destructors when a member is bound to a reference.. In code like const int = C().x;

[PATCH] D44204: [clang-format] Break consecutive string literals in text protos

This revision was automatically updated to reflect the committed changes. Closed by commit rL326945: [clang-format] Break consecutive string literals in text protos (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis updated this revision to Diff 137470. thakis added a comment. rnk comment https://reviews.llvm.org/D44223 Files: lib/CodeGen/MicrosoftCXXABI.cpp Index: lib/CodeGen/MicrosoftCXXABI.cpp === ---

[clang-tools-extra] r326954 - [Documentation] Fix Clang-tidy checks list broken in r326909.

Author: eugenezelenko Date: Wed Mar 7 14:30:50 2018 New Revision: 326954 URL: http://llvm.org/viewvc/llvm-project?rev=326954=rev Log: [Documentation] Fix Clang-tidy checks list broken in r326909. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[PATCH] D44231: Check for sizeof that call functions

pfultz2 updated this revision to Diff 137496. https://reviews.llvm.org/D44231 Files: clangd/CodeComplete.cpp test/clangd/protocol.test unittests/clangd/CodeCompleteTests.cpp Index: unittests/clangd/CodeCompleteTests.cpp ===

[PATCH] D44095: [ObjC] Allow declaring __weak pointer fields in C structs in ObjC-ARC

ahatanak updated this revision to Diff 137500. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D44095 Files: include/clang/AST/Decl.h include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/ASTImporter.cpp

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

NoQ created this revision. NoQ added reviewers: rsmith, doug.gregor, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. In code like const int = A().x; the destructor for `A()` was not present in the CFG due to two problems in the

r326945 - [clang-format] Break consecutive string literals in text protos

Author: krasimir Date: Wed Mar 7 13:30:38 2018 New Revision: 326945 URL: http://llvm.org/viewvc/llvm-project?rev=326945=rev Log: [clang-format] Break consecutive string literals in text protos Summary: This patch fixes a bug where consecutive string literals in text protos were put on the same

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis marked an inline comment as done. thakis added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1206 + + for (const VBase : VBases) { +if (!V.second.hasVtorDisp()) rnk wrote: > I think we can avoid the sort altogether if we iterate

r326951 - [analyzer] Don't crash with assertion failure on structured bindings

Author: george.karpenkov Date: Wed Mar 7 14:20:35 2018 New Revision: 326951 URL: http://llvm.org/viewvc/llvm-project?rev=326951=rev Log: [analyzer] Don't crash with assertion failure on structured bindings Proper modeling still remains to be done. Note that BindingDecl#getHoldingVar() is almost

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

rnk updated this revision to Diff 137487. rnk added a comment. - remove Sema::recordEvaluatedWeakUse to fix Linux build https://reviews.llvm.org/D44221 Files: clang/include/clang/Sema/ScopeInfo.h clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaLambda.h

[libcxx] r326958 - Include since we use it. Thanks to Andrey Maksimov for the catch.

Author: marshall Date: Wed Mar 7 14:51:16 2018 New Revision: 326958 URL: http://llvm.org/viewvc/llvm-project?rev=326958=rev Log: Include since we use it. Thanks to Andrey Maksimov for the catch. Modified: libcxx/trunk/test/std/numerics/rand/rand.device/eval.pass.cpp Modified:

[PATCH] D44231: Check for sizeof that call functions

pfultz2 created this revision. pfultz2 added reviewers: clang-tools-extra, hokein, alexfh, aaron.ballman, ilya-biryukov. Herald added a subscriber: jkorous-apple. A common mistake that I have found in our codebase is calling a function to get an integer or enum that represents the type such as:

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

rjmccall added a comment. I agree that having those sites just no-op themselves is the cleanest approach. https://reviews.llvm.org/D44039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis closed this revision. thakis marked an inline comment as done. thakis added a comment. r326960, thanks! https://reviews.llvm.org/D44223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r326962 - [MS] Accept __unaligned as a qualifier on member function pointers

Author: rnk Date: Wed Mar 7 15:26:02 2018 New Revision: 326962 URL: http://llvm.org/viewvc/llvm-project?rev=326962=rev Log: [MS] Accept __unaligned as a qualifier on member function pointers We need to treat __unaligned like the other 'cvr' qualifiers when it appears at the end of a function

r326973 - When substituting previously-checked template arguments into a template

Author: rsmith Date: Wed Mar 7 17:07:33 2018 New Revision: 326973 URL: http://llvm.org/viewvc/llvm-project?rev=326973=rev Log: When substituting previously-checked template arguments into a template template parameter that is an expanded parameter pack, only substitute into the current slice,

[clang-tools-extra] r326928 - do not register matcher for objc-only checks when analyzing non-objc sources to save resources

Author: wizard Date: Wed Mar 7 10:59:25 2018 New Revision: 326928 URL: http://llvm.org/viewvc/llvm-project?rev=326928=rev Log: do not register matcher for objc-only checks when analyzing non-objc sources to save resources Summary: I did not put lang opt check in AvoidSpinlockCheck since

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

simark added a comment. In https://reviews.llvm.org/D44226#1030625, @ilya-biryukov wrote: > I would vouch for adding a log level instead. It's a very well understood > concept that certainly covers this use-case and can be useful in other places. > WDYT? I agree. How would you prefer the

[PATCH] D44231: Check for sizeof that call functions

pfultz2 updated this revision to Diff 137497. https://reviews.llvm.org/D44231 Files: clang-tidy/misc/SizeofExpressionCheck.cpp clang-tidy/misc/SizeofExpressionCheck.h test/clang-tidy/misc-sizeof-expression.cpp Index: test/clang-tidy/misc-sizeof-expression.cpp

[PATCH] D43990: set dso_local on tls init functions

espindola closed this revision. espindola added a comment. r326961 https://reviews.llvm.org/D43990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r326979 - [Documentation] Fix Release notes problems introduced in r326889. Add highlighting.

Author: eugenezelenko Date: Wed Mar 7 17:37:39 2018 New Revision: 326979 URL: http://llvm.org/viewvc/llvm-project?rev=326979=rev Log: [Documentation] Fix Release notes problems introduced in r326889. Add highlighting. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified:

Re: r326602 - [Attr] Fix parameter indexing for several attributes

Joel, can you investigate the issue? ~Aaron On Wed, Mar 7, 2018 at 4:32 PM, Nico Weber via cfe-commits wrote: > (I had to revert this since it caused > https://bugs.llvm.org/show_bug.cgi?id=36620) > > On Fri, Mar 2, 2018 at 2:03 PM, Joel E. Denny via cfe-commits >

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

rnk updated this revision to Diff 137472. rnk added a comment. Bring back Sema::setFunctionHas* methods which internally do nothing when called outside function scope. This appears to happen in practice when parsing invalid code involving things like statement expressions, VLAs at global scope,

[PATCH] D44213: [clangd] Remove unused field in HandlerRegisterer

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE326947: [clangd] Remove unused field in HandlerRegisterer (authored by simark, committed by ). Changed prior to commit: https://reviews.llvm.org/D44213?vs=137410=137471#toc Repository: rCTE Clang

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

simark updated this revision to Diff 137478. simark added a comment. Changed -log-to-stderr to -log-lsp-to-stderr The first version disabled a bit too much, this version removes the LSP communication logging in a more fine grained way. Repository: rCTE Clang Tools Extra

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

ilya-biryukov added a comment. I would vouch for adding a log level instead. It's a very well understood concept that certainly covers this use-case and can be useful in other places. WDYT? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44226

r326957 - Avoid including ScopeInfo.h from Sema.h

Author: rnk Date: Wed Mar 7 14:48:35 2018 New Revision: 326957 URL: http://llvm.org/viewvc/llvm-project?rev=326957=rev Log: Avoid including ScopeInfo.h from Sema.h Summary: This provides no measurable build speedup, but it reinstates an optimization from r112038 that was lost in r179618. It

r326961 - Set dso_local on tls init functions.

Author: rafael Date: Wed Mar 7 15:18:06 2018 New Revision: 326961 URL: http://llvm.org/viewvc/llvm-project?rev=326961=rev Log: Set dso_local on tls init functions. We copy the visibility, so copying the dso_local flag seems the natural thing to do. Modified:

r326974 - Revert "[Sema] Make getCurFunction() return null outside function parsing"

Author: rnk Date: Wed Mar 7 17:12:22 2018 New Revision: 326974 URL: http://llvm.org/viewvc/llvm-project?rev=326974=rev Log: Revert "[Sema] Make getCurFunction() return null outside function parsing" This reverts r326965. It seems to have caused repeating test failures in

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Hmm, i'm missing something about the way store sha1... Comment at: clang-doc/BitcodeWriter.cpp:53 +{// 0. Fixed-size integer (length of the sha1'd USR) + llvm::BitCodeAbbrevOp(llvm::BitCodeAbbrevOp::VBR, +

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1207 uint64_t ConstantVBaseOffset = -Layout.getVBaseClassOffset(I->first).getQuantity(); +

[PATCH] D43625: [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory

This revision was automatically updated to reflect the committed changes. Closed by commit rC326948: [OpenMP] Remove implicit data sharing code gen that aims to use device shared… (authored by gbercea, committed by ). Changed prior to commit:

[PATCH] D37994: Implement LWG2946: More ambiguity in `string` vs. `string_view`

mclow.lists updated this revision to Diff 137474. mclow.lists added a comment. Added the proposed resolution for https://wg21.link/lwg3075 as well, and some deduction guide tests for `string_view` https://reviews.llvm.org/D37994 Files: include/string

[PATCH] D44229: Don't use -pie in relocatable link.

eugenis created this revision. eugenis added a reviewer: srhines. Android, in particular, got PIE enabled by default in r316606. It resulted in relocatable links passing both -r and -pie to the linker, which is not allowed. https://reviews.llvm.org/D44229 Files:

[PATCH] D44229: Don't use -pie in relocatable link.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks for fixing this quickly. :) https://reviews.llvm.org/D44229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44233: Set dso_local on external rtti GVs

espindola created this revision. espindola added a reviewer: rnk. In this particular case it would be possible to just add an else with CGM.setDSOLocal(GV), but it seems better to have as many callers as possible just call setGVProperties so that we can centralize the logic there. This patch

r326968 - Fix a doc typo; NFC

Author: gbiv Date: Wed Mar 7 16:22:04 2018 New Revision: 326968 URL: http://llvm.org/viewvc/llvm-project?rev=326968=rev Log: Fix a doc typo; NFC Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp URL:

[PATCH] D44213: [clangd] Remove unused field in HandlerRegisterer

malaperle accepted this revision. malaperle added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44189: [RISCV] Verify the input value of -march=

apazos added inline comments. Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:48 + break; +default: + // First letter should be 'i' or 'g'. In the switch cases move default to first position. Comment at:

[PATCH] D44226: [clangd] Add -log-to-stderr option

simark created this revision. Herald added subscribers: cfe-commits, ioeric, JDevlieghere, jkorous-apple, ilya-biryukov, klimek. Currently, clangd prints all the LSP communication on stderr. While this is good for developping, I don't think it's good as a general default. For example, we are

[PATCH] D44131: [analyzer] Support temporaries conjured by conservatively evaluated functions.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

This revision was automatically updated to reflect the committed changes. Closed by commit rC326957: Avoid including ScopeInfo.h from Sema.h (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D44221?vs=137487=137488#toc Repository: rC Clang

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL326957: Avoid including ScopeInfo.h from Sema.h (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44221?vs=137487=137489#toc

[PATCH] D44229: Don't use -pie in relocatable link.

eugenis added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311 + if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) || + Args.hasArg(options::OPT_r)) return false; mgrang wrote: > We also need to check for

r326988 - [CodeGen] Emit lifetime.ends in both EH and non-EH blocks

Author: gbiv Date: Wed Mar 7 21:32:30 2018 New Revision: 326988 URL: http://llvm.org/viewvc/llvm-project?rev=326988=rev Log: [CodeGen] Emit lifetime.ends in both EH and non-EH blocks Before this, we'd only emit lifetime.ends for these temps in non-exceptional paths. This potentially made our

[PATCH] D44095: [ObjC] Allow declaring __weak pointer fields in C structs in ObjC-ARC

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. Comment at: lib/CodeGen/CGNonTrivialStruct.cpp:764 +Object = CGF->EmitObjCConsumeObject(QT, Object); +CGF->EmitARCStoreWeak(Addrs[DstIdx], Object,

  1   2   >