Re: r338032 - [OPENMP] Force OpenMP 4.5 when compiling for offloading.

Hi Alexey, maybe we can now raise the version generally? Is that something that we want to do before branching for 7.0? According to http://clang.llvm.org/docs/OpenMPSupport.html, all directives of OpenMP 4.5 are supported (even if Clang may not generate optimal code). Cheers, Jonas On

Re: [clang-tools-extra] r338017 - [clangd] Proof-of-concept query iterators for Dex symbol index

[Resending with cfe-commits@, whoops] Hi Kirill, We believe this patch might be breaking one of the buildbots: http://lab.llvm.org:8011/builders/clang-x86_64-linux- abi-test/builds/29719 Which is complaining about the std::unique_ptr copy constructor being called in DexIndexTests.cpp. It

[PATCH] D49848: Parse a possible trailing postfix expression suffix after a fold expression

rsmith added a comment. Shouldn't the caller of ParseParenExpression already be doing this? Repository: rC Clang https://reviews.llvm.org/D49848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman added inline comments. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:144 + Context); + Module *M = Owner.get(); + if (!M) morehouse wrote: > Why not just rename `Owner` to `M` and remove

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman updated this revision to Diff 157544. emmettneyman added a comment. - Code style fixes - Removed `FPasses` - Allowed CL Args to specify opt level for `OptLLVM()` Repository: rC Clang https://reviews.llvm.org/D49526 Files:

[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

This revision was automatically updated to reflect the committed changes. Closed by commit rC338041: [CodeGen][ObjC] Make block copy/dispose helper functions exception-safe. (authored by ahatanak, committed by ). Changed prior to commit: https://reviews.llvm.org/D49718?vs=157395=157514#toc

r338049 - [OPENMP] What's new for OpenMP in clang.

Author: abataev Date: Thu Jul 26 10:53:45 2018 New Revision: 338049 URL: http://llvm.org/viewvc/llvm-project?rev=338049=rev Log: [OPENMP] What's new for OpenMP in clang. Updated ReleaseNotes + Status of the OpenMP support in clang. Modified: cfe/trunk/docs/OpenMPSupport.rst

[PATCH] D49871: Improve support of PDB as an external layout source

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: rsmith, zturner, rnk, mstorsjo, majnemer. aleksandr.urakov added a project: clang. This patch improves support of PDB as an external layout source in the next cases: - Multiple non-virtual inheritance from packed base

[PATCH] D49868: [Sema] Fix a crash by completing a type before using it

rjmccall added a comment. Could you include a test that satisfies the exception but requires a template to be instantiated to check that? It's probably already tested elsewhere, but still. Repository: rC Clang https://reviews.llvm.org/D49868

[PATCH] D49844: [AST] Add a isActuallyImplicitCast() helper to the CastExpr class.

lebedev.ri abandoned this revision. lebedev.ri added a comment. In https://reviews.llvm.org/D49844#1177273, @rsmith wrote: > What I requested was that either we make `CastExpr::isPartOfExplicitCast()` > return `true` for `CastExpr`s that are not `ImplicitCastExpr`s, or that we > move

[PATCH] D49871: Improve support of PDB as an external layout source

aleksandr.urakov added a comment. Thank you! Can you, please, commit this for me? I have no commit access. Repository: rC Clang https://reviews.llvm.org/D49871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49864: The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas created this revision. janosimas added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. When the argument -- is passed to clang-tidy-diff.py it should pass the following arguments to clang-tidy. It does that but also includes -- as an argument, there should be a +1

[PATCH] D49715: [analyzer] CallEvent: Add partially working methods for obtaining the callee stack frame.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:197 + + // Recover CFG block via reverse lookup. Maybe it should just be a part of the + // CallEvent object? That would have been convenient. george.karpenkov wrote: > Can we remove

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

morehouse added a comment. Do we need to parse the arguments for opt-level, or can we just hardcode `-O2` and remove the argument parsing code? Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:144 + Context); + Module

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle added a comment. In https://reviews.llvm.org/D49833#1176337, @ilya-biryukov wrote: > Not strictly opposed to this change, but is there any reason why the clients > can't guarantee they'll send didChangeConfiguration right after clangd is > initialized? LSP: > Until the server has

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman added a comment. In https://reviews.llvm.org/D49526#1177208, @morehouse wrote: > Do we need to parse the arguments for opt-level, or can we just hardcode > `-O2` and remove the argument parsing code? I have the argument parsing code since the original `clang-proto-fuzzer` code

Re: r337470 - [Sema] Add a new warning, -Wmemset-transposed-args

On 7/26/18 12:52 PM, Richard Smith wrote: Other than the (fixed) ffmpeg false positive, I see this firing in three places. One of them is in the libc tests for memset and bzero, where the 0 argument is intentional. I don't find this case very convincing, if you're literally the one

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

ABataev updated this revision to Diff 157563. ABataev added a comment. Address ERic's comments. Repository: rC Clang https://reviews.llvm.org/D49148 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/DiagnosticGroups.td include/clang/Driver/ToolChain.h

[PATCH] D49770: [ARM64] [Windows] Follow MS X86_64 C++ ABI when passing structs

ssijaric updated this revision to Diff 157559. ssijaric added a comment. Last change before committing to address Reid's point of using CCK_MicrosoftWin64 for Windows on both X86_64 and ARM64. Repository: rC Clang https://reviews.llvm.org/D49770 Files: include/clang/Basic/TargetInfo.h

Re: r337470 - [Sema] Add a new warning, -Wmemset-transposed-args

On Thu, 26 Jul 2018 at 13:22, Arthur O'Dwyer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Jul 26, 2018 at 12:52 PM, Richard Smith > wrote: > >> Other than the (fixed) ffmpeg false positive, I see this firing in three >> places. >> >> One of them is in the libc tests for memset

[PATCH] D49770: [ARM64] [Windows] Follow MS X86_64 C++ ABI when passing structs

rnk accepted this revision. rnk added a comment. Please avoid the extra enum case, and commit. Comment at: include/clang/Basic/TargetInfo.h:1223 enum CallingConvKind { CCK_Default, This is poorly named. I'll try to send a patch to rename it after this

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman updated this revision to Diff 157545. emmettneyman added a comment. Small change to fix line length Repository: rC Clang https://reviews.llvm.org/D49526 Files: clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman updated this revision to Diff 157553. emmettneyman added a comment. Changed int to CodeGenOpt::Level and fixed unique_ptr issue Repository: rC Clang https://reviews.llvm.org/D49526 Files: clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp

[PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

Meinersbur added a comment. ping Repository: rC Clang https://reviews.llvm.org/D48808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

probinson accepted this revision. probinson added a comment. Although I am far from expert in how Clang manages declarations, AFAICT this does what @rsmith requested, so LGTM. https://reviews.llvm.org/D46190 ___ cfe-commits mailing list

[PATCH] D49873: [Docs] ReleasesNotes update / Static analyser

devnexen created this revision. devnexen added a reviewer: pcc. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49873 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

[PATCH] D49589: [UBSan] Strengthen pointer checks in 'new' expressions

sepavloff updated this revision to Diff 157519. sepavloff added a comment. Updated patch Now information, if sanitizer checks are generated while processing 'new' expression, is passed through function call arguments. Repository: rC Clang https://reviews.llvm.org/D49589 Files:

[PATCH] D49701: [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration

george.karpenkov added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:44 #include "clang/AST/Expr.h" +#include "clang/AST/ExprObjC.h" #include "clang/AST/ExprCXX.h" aaron.ballman wrote: > This list should remain sorted

r338050 - [COFF, ARM64] Decide when to mark struct returns as SRet

Author: mgrang Date: Thu Jul 26 11:07:59 2018 New Revision: 338050 URL: http://llvm.org/viewvc/llvm-project?rev=338050=rev Log: [COFF, ARM64] Decide when to mark struct returns as SRet Summary: Refer the MS ARM64 ABI Convention for the behavior for struct returns:

Re: r338049 - [OPENMP] What's new for OpenMP in clang.

Oh, yes, it is a typo, thanks for catching it! - Best regards, Alexey Bataev 26.07.2018 13:59, Jonas Hahnfeld via cfe-commits пишет: > Hi Alexey, > > On 2018-07-26 19:53, Alexey Bataev via cfe-commits wrote: >> Author: abataev >> Date: Thu Jul 26 10:53:45 2018 >> New Revision: 338049

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:115 + make_unique(M.get()); + FPasses->add(createTargetTransformInfoWrapperPass(TargetIRAnalysis())); + emmettneyman wrote: > morehouse wrote: > > morehouse

r338041 - [CodeGen][ObjC] Make block copy/dispose helper functions exception-safe.

Author: ahatanak Date: Thu Jul 26 09:51:21 2018 New Revision: 338041 URL: http://llvm.org/viewvc/llvm-project?rev=338041=rev Log: [CodeGen][ObjC] Make block copy/dispose helper functions exception-safe. When an exception is thrown in a block copy helper function, captured objects that have

[PATCH] D49865: Inform the AST of #pragma FENV_ACCESS use

kpn created this revision. kpn added reviewers: rsmith, craig.topper, hfinkel. Herald added a subscriber: cfe-commits. We have in place support for parsing #pragma FENV_ACCESS, but that information is then discarded with a warning to the user that we don't support it. This patch gets us one

[PATCH] D49701: [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration

george.karpenkov updated this revision to Diff 157520. https://reviews.llvm.org/D49701 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h clang/include/clang/ASTMatchers/ASTMatchersInternal.h clang/lib/ASTMatchers/ASTMatchersInternal.cpp

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

This revision was automatically updated to reflect the committed changes. Closed by commit rC338057: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the… (authored by simark, committed by ). Changed prior to commit: https://reviews.llvm.org/D48903?vs=157467=157548#toc

r338057 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

Author: simark Date: Thu Jul 26 11:55:02 2018 New Revision: 338057 URL: http://llvm.org/viewvc/llvm-project?rev=338057=rev Log: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name Summary: InMemoryFileSystem::status behaves differently than

[PATCH] D49589: [UBSan] Strengthen pointer checks in 'new' expressions

rjmccall added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2190 This, Args, AggValueSlot::MayOverlap, - E->getLocation()); + E->getLocation(), true); } Please include `/* */`

[PATCH] D49844: [AST] Add a isActuallyImplicitCast() helper to the CastExpr class.

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. What I requested was that either we make `CastExpr::isPartOfExplicitCast()` return `true` for `CastExpr`s that are not `ImplicitCastExpr`s, or that we move `isPartOfExplicitCast` do

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:933-938 + if (TC.supportsDebugInfoOption(A)) { +Action(); +return true; + } + reportUnsupportedDebugInfoOption(A, Args, D, TC.getTriple()); + return

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:4040-4041 // explicit nested-name-specifier). - void MarkAnyDeclReferenced(SourceLocation Loc, Decl *D, bool MightBeOdrUse); + void MarkAnyDeclReferenced(SourceLocation Loc, Decl *D, bool MightBeOdrUse, +

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

ldionne added a comment. This is a very tricky change since it touches all the input stream operations, both formatted and unformatted. However, I think it's an important change as it fixes extremely broken behavior. The paper I'm working on to fix this in the Standard is

[PATCH] D49589: [UBSan] Strengthen pointer checks in 'new' expressions

sepavloff added a comment. > Also, please remember that your analysis is not the only thing happening in > the compiler. isChecked is not a meaningful name taken out of context. `Address` is not modified in the current patch version. As for `AggValueSlot`, this method name is leaved, as there

r338045 - [RISCV] Add support for interrupt attribute

Author: apazos Date: Thu Jul 26 10:37:45 2018 New Revision: 338045 URL: http://llvm.org/viewvc/llvm-project?rev=338045=rev Log: [RISCV] Add support for interrupt attribute Summary: Clang supports the GNU style ``__attribute__((interrupt))`` attribute on RISCV targets. Permissible values for

[PATCH] D48412: [RISCV] Add support for interrupt attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rC338045: [RISCV] Add support for interrupt attribute (authored by apazos, committed by ). Herald added a subscriber: jrtc27. Repository: rC Clang https://reviews.llvm.org/D48412 Files:

r338048 - [Sema][ObjC] Do not propagate the nullability specifier on the receiver

Author: ahatanak Date: Thu Jul 26 10:51:13 2018 New Revision: 338048 URL: http://llvm.org/viewvc/llvm-project?rev=338048=rev Log: [Sema][ObjC] Do not propagate the nullability specifier on the receiver to the result type of a message send if the result type cannot have a nullability specifier.

Re: r338049 - [OPENMP] What's new for OpenMP in clang.

Hi Alexey, On 2018-07-26 19:53, Alexey Bataev via cfe-commits wrote: Author: abataev Date: Thu Jul 26 10:53:45 2018 New Revision: 338049 URL: http://llvm.org/viewvc/llvm-project?rev=338049=rev Log: [OPENMP] What's new for OpenMP in clang. Updated ReleaseNotes + Status of the OpenMP support in

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

mgrang added a comment. @rsmith Could you please take a look at the updated patch? I would like to commit this. Thanks. https://reviews.llvm.org/D48862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r338054 - Revert Clangd Dex Iterators patch

Author: omtcyfz Date: Thu Jul 26 11:25:48 2018 New Revision: 338054 URL: http://llvm.org/viewvc/llvm-project?rev=338054=rev Log: Revert Clangd Dex Iterators patch This reverts two revisions: * https://reviews.llvm.org/rL338017 * https://reviews.llvm.org/rL338028 They caused crash for Clang 3.6

Re: r337470 - [Sema] Add a new warning, -Wmemset-transposed-args

On Thu, Jul 26, 2018 at 12:52 PM, Richard Smith wrote: > Other than the (fixed) ffmpeg false positive, I see this firing in three > places. > > One of them is in the libc tests for memset and bzero, where the 0 > argument is intentional. > One of them is here:

[PATCH] D49838: [AST] Sink 'part of explicit cast' down into ImplicitCastExpr

rsmith added inline comments. Comment at: include/clang/AST/Expr.h:2928 + bool getIsPartOfExplicitCast() const { +return CastExprBits.PartOfExplicitCast; Please also rename this to`isPartOfExplicitCast` as requested on IRC. Comment at:

[PATCH] D48027: [analyzer] Improve `CallDescription` to handle c++ method.

MTC updated this revision to Diff 157499. MTC added a comment. @xazax.hun Thanks for your tips! After some investigation, `MatchFinder::match` just traverse one ASTNode, that means `match(namedDecl(HasNameMatcher()))` and `match(namedDecl(matchesName()))` both not traverse children. So there

[PATCH] D49790: [AST] Small doc update for DeclContext

bricci updated this revision to Diff 157505. bricci edited the summary of this revision. bricci added a comment. Re-added the "friend class ASTWriter" after making hasNeedToReconcileExternalVisibleStorage, hasLazyLocalLexicalLookups and hasLazyExternalLexicalLookups in DeclContext private. This

r338056 - Refactor checking of switch conditions and case values.

Author: rsmith Date: Thu Jul 26 11:41:30 2018 New Revision: 338056 URL: http://llvm.org/viewvc/llvm-project?rev=338056=rev Log: Refactor checking of switch conditions and case values. Check each case value in turn while parsing it, performing the conversion to the switch type within the context

r338055 - [OPENMP, DOCS] Fixed typo, NFC.

Author: abataev Date: Thu Jul 26 11:40:41 2018 New Revision: 338055 URL: http://llvm.org/viewvc/llvm-project?rev=338055=rev Log: [OPENMP, DOCS] Fixed typo, NFC. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[PATCH] D49871: Improve support of PDB as an external layout source

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D49871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r337470 - [Sema] Add a new warning, -Wmemset-transposed-args

On Thu, 26 Jul 2018 at 13:14, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On 7/26/18 12:52 PM, Richard Smith wrote: > > Other than the (fixed) ffmpeg false positive, I see this firing in three > places. > > One of them is in the libc tests for memset and bzero,

Re: r337470 - [Sema] Add a new warning, -Wmemset-transposed-args

On 7/26/18 1:38 PM, Richard Smith wrote: On Thu, 26 Jul 2018 at 13:14, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: On 7/26/18 12:52 PM, Richard Smith wrote: Other than the (fixed) ffmpeg false positive, I see this firing in three places. One

[PATCH] D49838: [AST] Sink 'part of explicit cast' down into ImplicitCastExpr

lebedev.ri added inline comments. Comment at: include/clang/AST/Expr.h:2928 + bool getIsPartOfExplicitCast() const { +return CastExprBits.PartOfExplicitCast; rsmith wrote: > Please also rename this to`isPartOfExplicitCast` as requested on IRC. Right,

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman updated this revision to Diff 157577. emmettneyman added a comment. Made some minor fixes Repository: rC Clang https://reviews.llvm.org/D49526 Files: clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt

[PATCH] D49838: [AST] Sink 'part of explicit cast' down into ImplicitCastExpr

lebedev.ri updated this revision to Diff 157576. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. Address @rsmith review notes. Repository: rC Clang https://reviews.llvm.org/D49838 Files: include/clang/AST/Expr.h include/clang/AST/Stmt.h lib/AST/ASTDumper.cpp

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

lebedev.ri updated this revision to Diff 157585. lebedev.ri added a comment. Rebase, Address @rsmith review notes - just inline https://reviews.llvm.org/D49844. Repository: rC Clang https://reviews.llvm.org/D48958 Files: docs/ReleaseNotes.rst docs/UndefinedBehaviorSanitizer.rst

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert added a comment. Imagine having a producer loop, where we check a loop condition while holding a mutex, but release it in the loop body to let other producers/consumers do their work. In that scenario it makes sense to allow "relocking" a scope. RelockableScope Scope(mu);

[PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

greened created this revision. greened added reviewers: jroelofs, hans, probinson, ismail, rtrieu. Herald added a subscriber: cfe-commits. This test fails if clang is configure with, for example, gold as the default linker. It does not appear that this test really relies on lld so make the

[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

arphaman added a comment. In https://reviews.llvm.org/D49758#1174629, @ilya-biryukov wrote: > The mode of operation where compile commands come from the client seems > useful, but I wonder if there's any value in mixing it with > `compile_commands.json` and other CDB plugins. > Do you plan to

[libcxx] r338094 - Correctly mark the Filesystem status as complete.

Author: ericwf Date: Thu Jul 26 20:16:02 2018 New Revision: 338094 URL: http://llvm.org/viewvc/llvm-project?rev=338094=rev Log: Correctly mark the Filesystem status as complete. Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[libcxx] r338096 - Add libc++fs to the test deps, and not to the target 'cxx'.

Author: ericwf Date: Thu Jul 26 20:47:46 2018 New Revision: 338096 URL: http://llvm.org/viewvc/llvm-project?rev=338096=rev Log: Add libc++fs to the test deps, and not to the target 'cxx'. Modified: libcxx/trunk/lib/CMakeLists.txt libcxx/trunk/test/CMakeLists.txt Modified:

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 157642. Rakete added a comment. Addressed review comments. Note that clang doesn't support the fourth kind of lambda yet ([]<>), because https://reviews.llvm.org/D36527 hasn't been merged yet, so I didn't add a test case for that one. Repository:

[PATCH] D49862: [clang-tidy] Fix a crash in fuchsia-multiple-inheritance

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/clang-tidy/fuchsia-multiple-inheritance-crash.cpp:1 +// RUN: clang-tidy -checks='fuchsia-multiple-inheritance' %s -- +template nit:

[PATCH] D49899: Make test/Driver/fuchsia.c(pp) work with lld or gold

phosek requested changes to this revision. phosek added a comment. This revision now requires changes to proceed. We don't actively support gold in Fuchsia driver and currently have no plans on doing so. We should instead modify the driver to always use lld even if gold is set as the default

[PATCH] D49848: Parse a possible trailing postfix expression suffix after a fold expression

Rakete updated this revision to Diff 157580. Rakete added a comment. Add a test without any casts. Repository: rC Clang https://reviews.llvm.org/D49848 Files: include/clang/Parse/Parser.h lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expressions.cpp Index:

[PATCH] D49868: [Sema] Fix a crash by completing a type before using it

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. https://reviews.llvm.org/D49868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert created this revision. aaronpuchert added reviewers: delesley, aaron.ballman. Herald added a subscriber: cfe-commits. It's already allowed to prematurely release a scoped lock, now we also allow relocking it again, possibly even in another mode. Arguably the solution is not very

Re: r338057 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

I reverted this in r338084 because it broke clang tests on Windows: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12916 On Thu, Jul 26, 2018 at 11:55 AM Simon Marchi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: simark > Date: Thu Jul 26 11:55:02 2018 > New

r338084 - Revert r338057 "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name"

Author: rnk Date: Thu Jul 26 16:21:51 2018 New Revision: 338084 URL: http://llvm.org/viewvc/llvm-project?rev=338084=rev Log: Revert r338057 "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name" This broke clang/test/PCH/case-insensitive-include.c on Windows.

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad accepted this revision. TheAhmad marked 3 inline comments as done. TheAhmad added a comment. This revision is now accepted and ready to land. Thanks Eugene! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 ___

[PATCH] D49338: Implement - P0122R7

mclow.lists closed this revision. mclow.lists added a comment. Landed as r337804. https://reviews.llvm.org/D49338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

greened created this revision. greened added reviewers: sbc100, sunfish. Herald added subscribers: cfe-commits, aheejin, jgravelle-google, dschuff. lld is the only supported linker that works for WebAssembly, so ensure clang is using it for this test. This gets the tests passing when

[PATCH] D49589: [UBSan] Strengthen pointer checks in 'new' expressions

sepavloff updated this revision to Diff 157643. sepavloff added a comment. Updated patch Added names for boolean arguments, renamed a field in AggValueSlot. No functional changes. Repository: rC Clang https://reviews.llvm.org/D49589 Files: lib/CodeGen/CGClass.cpp

r338098 - [WWW] Fixing file permissions for the .html pages.

Author: sqlbyme Date: Thu Jul 26 21:41:37 2018 New Revision: 338098 URL: http://llvm.org/viewvc/llvm-project?rev=338098=rev Log: [WWW] Fixing file permissions for the .html pages. Modified: cfe/trunk/www/OpenProjects.html (props changed) cfe/trunk/www/UniversalDriver.html (props

[PATCH] D49063: [libclang 1/8] Add support for ObjCObjectType

yvvan added a comment. I'm mostly fine with your set of patches. Let me double check and we can get it in. https://reviews.llvm.org/D49063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

rjmccall added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:2582 /// yet; if a cleanup is required for the variable itself, that needs /// to be done externally. +void CodeGenFunction::enterByrefCleanup(CleanupKind Kind, Address Addr, ahatanak wrote:

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:125 + Context); + Module *M = Owner.get(); + if (!M) We should be able to get rid of this line now, and rename Owner

[PATCH] D49876: [Fixed Point Arithmetic] Addition of intrinsic/builtin functions

leonardchan created this revision. leonardchan added a project: clang. Herald added a subscriber: cfe-commits. This patch is not actually up for review and meant to hold the remaining work done after https://reviews.llvm.org/D47017 but haven't submitted for review yet. This patch contains: -

r338086 - [WWW] Adding a test page to work out an auto-deployment issue.

Author: sqlbyme Date: Thu Jul 26 16:23:40 2018 New Revision: 338086 URL: http://llvm.org/viewvc/llvm-project?rev=338086=rev Log: [WWW] Adding a test page to work out an auto-deployment issue. Added: cfe/trunk/www/test.html Added: cfe/trunk/www/test.html URL:

r338091 - added shared library to fix buildbot

Author: emmettneyman Date: Thu Jul 26 17:43:26 2018 New Revision: 338091 URL: http://llvm.org/viewvc/llvm-project?rev=338091=rev Log: added shared library to fix buildbot Summary: added shared library to fix buildbot Subscribers: mgorny, cfe-commits Differential Revision:

[PATCH] D49895: added shared library to fix buildbot

emmettneyman created this revision. Herald added subscribers: cfe-commits, mgorny. added shared library to fix buildbot Repository: rC Clang https://reviews.llvm.org/D49895 Files: clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt Index:

[PATCH] D49890: Clang-Tidy Export Problem

Eugene.Zelenko added inline comments. Comment at: ClangTidy.cpp:612 + + FileManager *Files = new FileManager(FileSystemOptions()); + vfs::FileSystem = *Files->getVirtualFileSystem(); You could use auto here, because type is in new statement.

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

This revision was automatically updated to reflect the committed changes. Closed by commit rL338077: Updated llvm-proto-fuzzer to execute the compiled code (authored by emmettneyman, committed by ). Changed prior to commit: https://reviews.llvm.org/D49526?vs=157577=157591#toc Repository: rL

r338077 - Updated llvm-proto-fuzzer to execute the compiled code

Author: emmettneyman Date: Thu Jul 26 15:23:25 2018 New Revision: 338077 URL: http://llvm.org/viewvc/llvm-project?rev=338077=rev Log: Updated llvm-proto-fuzzer to execute the compiled code Summary: Made changes to the llvm-proto-fuzzer - Added loop vectorizer optimization pass in order to have

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 157611. Rakete added a comment. Rebased + friendly ping Repository: rC Clang https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp

[PATCH] D49892: Added shared library to fix build bot

emmettneyman created this revision. emmettneyman added a reviewer: morehouse. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D49892 Files: clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

rsmith added a comment. This looks good, with some minor changes. Please add more test coverage, though, specifically: - test all four forms of lambda that we recognize after `delete` - add a test that the FixItHint is correct (maybe in test/FixIt/fixit-cxx0x.cpp, which checks that applying

[PATCH] D49895: added shared library to fix buildbot

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC338091: added shared library to fix buildbot (authored by emmettneyman, committed by ). Changed prior to commit:

[libcxx] r338093 - Implement

Copied: libcxx/trunk/test/std/input.output/filesystems/class.path/path.nonmember/path.factory.pass.cpp (from r338006, libcxx/trunk/test/std/experimental/filesystem/class.path/path.nonmember/path.factory.pass.cpp) URL:

[libcxx] r338095 - Attempt to unbreak *all the bots*

Author: ericwf Date: Thu Jul 26 20:42:58 2018 New Revision: 338095 URL: http://llvm.org/viewvc/llvm-project?rev=338095=rev Log: Attempt to unbreak *all the bots* The bots were failing to build the cxx_filesystem target, so the tests were failing. Though this does lead me to wonder how it was

r338087 - [WWW] Removing my test file as the auto-deployment script has been fixed.

Author: sqlbyme Date: Thu Jul 26 16:29:54 2018 New Revision: 338087 URL: http://llvm.org/viewvc/llvm-project?rev=338087=rev Log: [WWW] Removing my test file as the auto-deployment script has been fixed. Removed: cfe/trunk/www/test.html Removed: cfe/trunk/www/test.html URL:

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad created this revision. TheAhmad added a reviewer: alexfh. TheAhmad added a project: clang-tools-extra. Hi. Clang tidy has problem with compile command databases that do not use necassarily absolute file paths. This is common in many projects that use makefiles as the build system,

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- marked 3 inline comments as done. 0x8000- added inline comments. Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:55 + +By default only `0`, `1` and `-1` integer values are accepted without a warning. +This can be overridden with the

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- updated this revision to Diff 157615. 0x8000- marked an inline comment as done. 0x8000- added a comment. Remove extra verbose namespaces and update documentation to indicate why -1 is accepted even when not explicitly called out. Repository: rCTE Clang Tools Extra

[PATCH] D49890: Clang-Tidy Export Problem

Eugene.Zelenko added inline comments. Comment at: ClangTidy.cpp:620 + llvm::StringMap SingleErrors; + for (const ClangTidyError : Errors) { +if (!Error.BuildDirectory.empty()) { You could use auto, since it's iterator over container.

  1   2   >