sammccall added a comment.
In https://reviews.llvm.org/D51279#1214268, @ilya-biryukov wrote:
> Just noticed I'm not on the reviewers list, sorry for chiming in without
> invitation. Was really excited about the change :-)
fixed :-)
Comment at: clangd/index/FileIndex.cpp:58
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added inline comments.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:133
+assert(TraitsComputed && "calling transferTo on moved-from object");
+const CommandTraits = getTraits();
+
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:32
static llvm::cl::opt
-UseDex("use-dex-index",
I think we should stick to the same option and just flip the default.
Introducing yet another option (that is going to
sammccall added a comment.
In https://reviews.llvm.org/D51314#1215381, @sammccall wrote:
> I'm a bit uncomfortable about the places where we need the type, because this
> is the only thing forcing us to parse before we've picked a command to
> transfer, and the number of commands we need to
kbobyrev updated this revision to Diff 162808.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Complete two last paragraphs, address few comments.
We haven't figured out whether we should suggest using this particular workflow
at this point, but we're discussing the
Anastasia added a comment.
In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote:
> In https://reviews.llvm.org/D43783#1204353, @svenvh wrote:
>
> > Sorry for digging up an old commit...
> >
> > Apparently this broke block arguments, e.g. the following test case:
> >
> > int foo(int (^
This revision was automatically updated to reflect the committed changes.
ioeric marked an inline comment as done.
Closed by commit rCTE340822: [clangd] Use buffered llvm::errs() in the clangd
binary. (authored by ioeric, committed by ).
Changed prior to commit:
kbobyrev updated this revision to Diff 162842.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D51352
Files:
clang-tools-extra/clangd/tool/ClangdMain.cpp
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
sammccall added a comment.
Thanks for finding this problem, this fix *mostly* looks good (though I think
we can probably drop memoization).
I'm a bit uncomfortable about the places where we need the type, because this
is the only thing forcing us to parse before we've picked a command to
ilya-biryukov updated this revision to Diff 162817.
ilya-biryukov added a comment.
Herald added a subscriber: mgrang.
- Remove mutexes, recompute every time instead
- Delay creation of TransferableCommand to avoid calling getAllCommands() on
JSONCompilationDatabase
Repository:
rC Clang
sidorovd created this revision.
sidorovd added reviewers: yaxunl, Anastasia.
Herald added a subscriber: cfe-commits.
Overloadable function candidate should not be viable if it uses extensions
(Half or Double type) that are not enabled or supported.
Repository:
rC Clang
Author: ibiryukov
Date: Tue Aug 28 04:04:07 2018
New Revision: 340816
URL: http://llvm.org/viewvc/llvm-project?rev=340816=rev
Log:
[clangd] Remove unused parameter. NFC
Modified:
clang-tools-extra/trunk/clangd/XRefs.cpp
Modified: clang-tools-extra/trunk/clangd/XRefs.cpp
URL:
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/tool/ClangdMain.cpp:263
+ // Use buffered stream to stderr. Unbuffered stream can cause significant
+ // (non-deterministic) latency for the
kbobyrev updated this revision to Diff 162840.
kbobyrev added a comment.
Run `clang-format`.
https://reviews.llvm.org/D51352
Files:
clang-tools-extra/clangd/tool/ClangdMain.cpp
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Dex is now mature enough to be used as the default static index. This patch
performs the switch
sammccall added inline comments.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:124
+// A CompileCommand that can be applied to another file. Any instance of this
+// object is invalid after std::move() from it.
struct TransferableCommand {
hamzasood marked an inline comment as done.
hamzasood added inline comments.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:136
+ // Otherwise just check the clang file name.
+ return llvm::sys::path::stem(CmdLine.front()).endswith_lower("clang-cl");
+}
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: lib/Format/UnwrappedLineFormatter.cpp:486
return 0;
+if (Line.First->is(tok::kw_default)) {
+ const FormatToken *Tok =
ilya-biryukov planned changes to this revision.
ilya-biryukov added a comment.
As discussed offline, instead of changing the interface of AllTUsScheduler, we
could add concurrency to StandloneToolExecutor
Repository:
rC Clang
https://reviews.llvm.org/D51298
Author: ioeric
Date: Tue Aug 28 06:15:50 2018
New Revision: 340822
URL: http://llvm.org/viewvc/llvm-project?rev=340822=rev
Log:
[clangd] Use buffered llvm::errs() in the clangd binary.
Summary: Unbuffered stream can cause significant (non-deterministic) latency
for the logger.
Reviewers:
Author: ibiryukov
Date: Tue Aug 28 03:57:45 2018
New Revision: 340815
URL: http://llvm.org/viewvc/llvm-project?rev=340815=rev
Log:
[clangd] Add some trace::Spans. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clangd/TUScheduler.cpp
Modified:
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Unbuffered stream can cause significant (non-deterministic) latency for the
logger.
Repository:
rCTE Clang Tools Extra
sammccall accepted this revision.
sammccall added a comment.
Awesome :-)
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:220
-// CommandIndex does the real work: given a filename, it produces the best
-// matching TransferableCommand by matching filenames.
Anastasia added a comment.
In https://reviews.llvm.org/D51212#1214173, @hans wrote:
> Anastasia: will you commit this to the branch, or would like me to do it?
I will commit this! Thanks!
https://reviews.llvm.org/D51212
___
cfe-commits mailing
atanasyan added a comment.
In https://reviews.llvm.org/D51234#1213813, @ruiu wrote:
> If this piece of code used to be working correctly, there is another piece of
> code that adds `-flavor ld` to the command line. But if that's the case, this
> change wouldn't work because it constructs
sidorovd updated this revision to Diff 162812.
https://reviews.llvm.org/D51341
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/Sema/SemaOverload.cpp
test/SemaOpenCL/half-double-overload.cl
Index: test/SemaOpenCL/half-double-overload.cl
sammccall accepted this revision.
sammccall added a comment.
In https://reviews.llvm.org/D51310#1214548, @kbobyrev wrote:
> It's probably better to roll out proximity path boosting & actual two-stage
> filtering before rolling this out.
Up to you (I don't understand the interaction), but this
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340805: [Analyzer] Iterator Checker - Part 3: Invalidation
check, first for (copy)… (authored by baloghadamsoftware, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D32747
Files:
Author: baloghadamsoftware
Date: Tue Aug 28 01:41:15 2018
New Revision: 340805
URL: http://llvm.org/viewvc/llvm-project?rev=340805=rev
Log:
[Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy)
assignments
We add check for invalidation of iterators. The only operation we
ilya-biryukov updated this revision to Diff 162851.
ilya-biryukov added a comment.
- Reformat the code
- Minor spelling fix
Repository:
rC Clang
https://reviews.llvm.org/D51314
Files:
lib/Tooling/InterpolatingCompilationDatabase.cpp
Index: lib/Tooling/InterpolatingCompilationDatabase.cpp
hokein updated this revision to Diff 162856.
hokein added a comment.
Minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50385
Files:
clangd/index/Index.cpp
clangd/index/Index.h
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
Szelethus abandoned this revision.
Szelethus added a comment.
In https://reviews.llvm.org/D49986#1192798, @Szelethus wrote:
> In https://reviews.llvm.org/D49985#1181568, @NoQ wrote:
>
> > In https://reviews.llvm.org/D49985#1181564, @dblaikie wrote:
> >
> > > It looks like concat orders the
hokein updated this revision to Diff 162854.
hokein marked 10 inline comments as done.
hokein added a comment.
Address review comments and fix code style.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50385
Files:
clangd/index/Index.cpp
clangd/index/Index.h
ilya-biryukov updated this revision to Diff 162855.
ilya-biryukov added a comment.
- Lowercase everything stored in the index.
Repository:
rC Clang
https://reviews.llvm.org/D51314
Files:
lib/Tooling/InterpolatingCompilationDatabase.cpp
Index:
hokein added inline comments.
Comment at: clangd/index/Index.h:377
+ llvm::ArrayRef find(const SymbolID ) const {
+ auto It = Occurrences.find(ID);
+ if (It == Occurrences.end())
sammccall wrote:
> return Occurrences.lookup(ID)?
The `DenseMap::lookup`
ilya-biryukov updated this revision to Diff 162868.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
- Cleanups
Repository:
rC Clang
https://reviews.llvm.org/D51314
Files:
lib/Tooling/InterpolatingCompilationDatabase.cpp
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks! Could you please change the commit title tag:
[Sema] -> [OpenCL]
Comment at: lib/Sema/Sema.cpp:42
#include "llvm/ADT/SmallSet.h"
+
using namespace
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:32
+// FIXME(kbobyrev): This option should be removed as Dex is now the default
+// static index.
hugoeg updated this revision to Diff 162864.
hugoeg marked 2 inline comments as done.
hugoeg added a comment.
made some major updates after no-namespace landed
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
Author: omtcyfz
Date: Tue Aug 28 07:55:05 2018
New Revision: 340828
URL: http://llvm.org/viewvc/llvm-project?rev=340828=rev
Log:
[clangd] Switch to Dex by default for the static index
Dex is now mature enough to be used as the default static index. This
patch performs the switch but introduces a
sammccall accepted this revision.
sammccall added inline comments.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:127
// Language detected from -x or the filename.
- types::ID Type = types::TY_INVALID;
+ // When set, cannot be TY_INVALID.
+ llvm::Optional
kbobyrev updated this revision to Diff 162865.
kbobyrev marked an inline comment as done.
https://reviews.llvm.org/D51352
Files:
clang-tools-extra/clangd/tool/ClangdMain.cpp
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
hamzasood updated this revision to Diff 162872.
hamzasood added a comment.
- Re-uploaded with full context.
Yeah, I encountered these issues while using clangd on Windows. I haven't run
into any clangd issues after applying this patch, but admittedly my usage is
very basic (pretty much just
Author: ibiryukov
Date: Tue Aug 28 09:15:56 2018
New Revision: 340838
URL: http://llvm.org/viewvc/llvm-project?rev=340838=rev
Log:
Parse compile commands lazily in InterpolatingCompilationDatabase
Summary:
This greatly reduces the time to read 'compile_commands.json'.
For Chromium on my machine
atanasyan created this revision.
atanasyan added reviewers: hans, petarj, smaksimovic, abeserminji.
Herald added subscribers: arichardson, sdardis.
MIPS specific part of Clang 7.0 Release notes. Feel free to add more notes if I
miss something.
Repository:
rC Clang
sammccall added a comment.
Nice!
We could reduce the scope of this patch somewhat by ignoring file proximity and
just switching to return the most popular header. This would be a solid
improvement over current behavior, and provide the infrastructure for the
file-proximity approach.
usaxena95 created this revision.
Herald added a subscriber: cfe-commits.
Added support of creating a hardlink from one file to another file.
After a hardlink is added between two files, both file will have the same:
1. UniqueID (inode)
2. Size
3. Buffer
This will bring replay of compilation
ilya-biryukov updated this revision to Diff 162863.
ilya-biryukov added a comment.
- Sort Paths, they are different from OriginalPaths, i.e. lowercased.
Repository:
rC Clang
https://reviews.llvm.org/D51314
Files:
lib/Tooling/InterpolatingCompilationDatabase.cpp
simark added inline comments.
Comment at: clangd/Protocol.h:889
+ // Does this node implement the method targeted by the request?
+ bool DeclaresMethod;
+
kadircet wrote:
> I think comment and the name is in contradiction here, do you mean
> DefinesMethod?
hokein added inline comments.
Comment at: test/clang-tidy/Inputs/absl/external-file.h:1
+void DirectAcess2() { absl::strings_internal::InternalFunction(); }
+
The file can not self-compile, and we should make it compilable.
And put the newly-added code at the
chrib created this revision.
Herald added subscribers: cfe-commits, srhines.
Fix -print-multi-directory to print the selected multilib
Repository:
rC Clang
https://reviews.llvm.org/D51354
Files:
include/clang/Driver/ToolChain.h
lib/Driver/Driver.cpp
lib/Driver/ToolChains/Linux.cpp
Author: marshall
Date: Tue Aug 28 06:29:30 2018
New Revision: 340823
URL: http://llvm.org/viewvc/llvm-project?rev=340823=rev
Log:
Use addressof instead of operator& in make_shared. Fixes PR38729. As a
drive-by, make the same change in raw_storage_iterator (twice).
Modified:
ilya-biryukov updated this revision to Diff 162849.
ilya-biryukov marked 6 inline comments as done.
ilya-biryukov added a comment.
- Update the comments
- Rename the new class to FileIndex
- Restore an accidentally lost comment
- Store file types in a parallel array instead of recomputing on each
ilya-biryukov updated this revision to Diff 162861.
ilya-biryukov added a comment.
- Handle TransferableCommands with TY_INVALID type (never transfer -x flag for
those)
- Add a test with invalid extensions, seen a crash while experimenting
- Update the test wrt to the new behavior.
Repository:
atanasyan created this revision.
atanasyan added reviewers: echristo, ruiu.
The "-flavor old-gnu" option were introduced to enable old version of LLD ELF
linker implementation. This option has been removed from the linker since LLD
3.9. I do not think that there is a real case when the latest
hugoeg added a comment.
@aaron.ballman when you get the chance could you take another look at this and
commit if it is ready? My internship ends rather soon and this is a tad time
sensitive and I don't have commit access. Thank you for your time!
https://reviews.llvm.org/D51061
hugoeg added a comment.
@aaron.ballman when you get the chance could you take another look at this and
commit if it is ready? My internship ends rather soon and this is a tad time
sensitive. Thank you for your time!
https://reviews.llvm.org/D51132
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340838: Parse compile commands lazily in
InterpolatingCompilationDatabase (authored by ibiryukov, committed by ).
Herald
sammccall accepted this revision.
sammccall added inline comments.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:229
+//
+// Apart from path proximity signals, also takes file extensions into account
+// when scoring the candidates.
(this comment
ilya-biryukov added a comment.
Thanks for the change. Having something like this makes total sense.
Mutating existing in-memory nodes looks shaky and requires making `Status`
mutable, which also looks undesirable.
Maybe we could consider adding a new kind of `InMemoryNode` for hard links that
sammccall added a comment.
Hi, sorry about overlooking cl mode flags when adding this, I was blissfully
unaware that `compile_commands.json` could use that syntax :-)
Out of curiosity, are you using this with clangd or some other tool? I'm sure
there are places where clangd injects unixy
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340828: [clangd] Switch to Dex by default for the static
index (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
hugoeg marked an inline comment as done.
hugoeg added inline comments.
Comment at: test/clang-tidy/Inputs/absl/external-file.h:1
+void DirectAcess2() { absl::strings_internal::InternalFunction(); }
+
hokein wrote:
> The file can not self-compile, and we should
chrib added a comment.
https://bugs.llvm.org/show_bug.cgi?id=21360
Repository:
rC Clang
https://reviews.llvm.org/D51354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev created this revision.
kbobyrev added a reviewer: hokein.
kbobyrev added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
Instead of parsing and compiling the `llvm::Regex` each time, it's faster to
use basic string matching for filename prefix check.
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Comment at: test/SemaOpenCL/access-qualifier.cl:107
+
+kernel void image_wo_twice(write_only write_only image1d_t i){} //
expected-warning {{duplicate
teemperor updated this revision to Diff 162902.
teemperor added a comment.
- Now using UpdateExceptionSpec.
- Added a comment to the SemaExceptionSpec.cpp code why we are permitting this.
https://reviews.llvm.org/D43871
Files:
lib/Headers/mm_malloc.h
lib/Sema/SemaExceptionSpec.cpp
sammccall added a comment.
Thanks for fixing this!
Mostly just picky style comments.
In particular, I know that some of the other maintainers here are just as
ignorant of the cl driver as I am, and I want to make sure that it's still
possible to follow the logic and debug unrelated problems
hugoeg updated this revision to Diff 162921.
hugoeg added a comment.
renamed check as suggested
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDependenciesCheck.cpp
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticLexKinds.td:476
+ ExtWarn<"likely typo, expected \"FILENAME\" or "
+ "but filename is '%0'">, InGroup;
+
This seems like the wrong warning group for this diagnostic as it doesn't
hamzasood added a comment.
Thanks for the detailed feedback; I’ll try to get a new patch up in a few hours.
However I disagree with some of them (see replies).
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:124
+// Determine whether the given file path is the
hugoeg updated this revision to Diff 162932.
hugoeg added a comment.
merge conflicts resolved @aaron.ballman
https://reviews.llvm.org/D51132
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/RedundantStrcatCallsCheck.cpp
Author: maskray
Date: Tue Aug 28 10:20:28 2018
New Revision: 340845
URL: http://llvm.org/viewvc/llvm-project?rev=340845=rev
Log:
[Driver] Delete last reference of lld -flavor old-gnu
This is dead code because lld -flavor old-gnu was removed in 2016 by rLLD262158.
Modified:
Author: morehouse
Date: Tue Aug 28 11:34:32 2018
New Revision: 340860
URL: http://llvm.org/viewvc/llvm-project?rev=340860=rev
Log:
[libFuzzer] Port to Windows
Summary:
Port libFuzzer to windows-msvc.
This patch allows libFuzzer targets to be built and run on Windows, using
-fsanitize=fuzzer
lebedev.ri added a comment.
ping.
Repository:
rC Clang
https://reviews.llvm.org/D50901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
ping.
Repository:
rC Clang
https://reviews.llvm.org/D50250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: morehouse
Date: Tue Aug 28 12:07:24 2018
New Revision: 340867
URL: http://llvm.org/viewvc/llvm-project?rev=340867=rev
Log:
Revert "[libFuzzer] Port to Windows"
This reverts commit r340860 due to failing tests.
Modified:
cfe/trunk/lib/Driver/ToolChains/MSVC.cpp
Modified:
ilya-biryukov added inline comments.
Herald added a subscriber: kadircet.
Comment at: clangd/XRefs.cpp:105
+// Sort results. Declarations being referenced explicitly come first.
+std::sort(Result.begin(), Result.end(),
+ [](const DeclInfo , const DeclInfo )
hugoeg updated this revision to Diff 162895.
hugoeg marked 3 inline comments as done.
hugoeg added a comment.
fixed issues outlines in comments
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
ioeric updated this revision to Diff 162897.
ioeric marked 3 inline comments as done.
ioeric retitled this revision from "[clangd] Support multiple #include headers
in one symbol." to "[clangd] *Prototype* Support multiple #include headers in
one symbol.".
ioeric edited the summary of this
Author: vedantk
Date: Tue Aug 28 11:01:42 2018
New Revision: 340849
URL: http://llvm.org/viewvc/llvm-project?rev=340849=rev
Log:
[ubsan] Enable -fsanitize=vptr on Apple devices and simulators
It seems like an oversight that this check was not always enabled for
on-device or device simulator
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340849: [ubsan] Enable -fsanitize=vptr on Apple devices and
simulators (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
kpn created this revision.
kpn added a reviewer: rsmith.
Herald added a reviewer: javed.absar.
Herald added a subscriber: cfe-commits.
This builds on https://reviews.llvm.org/D49865 to get #pragma STDC FENV_ACCESS
ON to and used by AST handling of function calls to math intrinsics. This now
delcypher accepted this revision.
delcypher added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/test/Driver/fsanitize.c:426
+// RUN: %clang -target arm-apple-ios4 -fsanitize=vptr %s -### 2>&1 | FileCheck
%s
ilya-biryukov added a comment.
Sorry for the delays with this review
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric added a comment.
Thanks for the review! I reduced the scope of the patch. PTAL
Comment at: clangd/CodeComplete.cpp:1396
+ if (IndexResult && !IndexResult->IncludeHeaders.empty()) {
+for (const auto : IndexResult->IncludeHeaders)
+
nickdesaulniers updated this revision to Diff 162908.
nickdesaulniers added a comment.
- Take rsmith's sugguested wording. Add info about __GNUC_STDC_INLINE__.
Repository:
rC Clang
https://reviews.llvm.org/D51190
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
sammccall marked 3 inline comments as done.
sammccall added inline comments.
Comment at: clangd/ClangdServer.cpp:122
+ // - symbols declared both in the main file and the preamble
+ // (Note that symbols *only* in the main file are not indexed).
FileIndex MainFileIdx;
ilya-biryukov added a comment.
Thanks for looking into this. Would be cool to get this supported after the
proposal is finalized.
Comment at: clangd/Protocol.h:891
+
+ std::vector Parents;
+
What is the proposal to add children (i.e. overriden methods) to
vsk updated this revision to Diff 162918.
vsk marked 2 inline comments as done.
vsk added a comment.
Address the latest round of review feedback.
https://reviews.llvm.org/D50927
Files:
clang/lib/Sema/SemaLambda.cpp
clang/test/CXX/expr/expr.prim/expr.prim.lambda/p14.cpp
rsmith added a comment.
I think `-gcc-toolchain`, if specified, should simply be taken as the location
of the GCC toolchain; we should never go looking for it anywhere else if
`-gcc-toolchain` is specified. So I think the patch is not quite right as-is,
as it also affects that case. I think
vsk added inline comments.
Comment at: clang/lib/Sema/SemaLambda.cpp:1422-1424
auto Entity = InitializedEntity::InitializeLambdaCapture(
Var->getIdentifier(), Field->getType(), Loc);
InitializationKind InitKind = InitializationKind::CreateDirect(Loc, Loc,
Loc);
aaron.ballman added a comment.
In https://reviews.llvm.org/D51132#1215916, @hugoeg wrote:
> @aaron.ballman when you get the chance could you take another look at this
> and commit if it is ready? My internship ends rather soon and this is a tad
> time sensitive. Thank you for your time!
When
modocache added subscribers: aaron.ballman, erikjv, modocache.
modocache added reviewers: aaron.ballman, erikjv.
modocache added a comment.
This looks good to me, but maybe some people who've modified this part of the
codebase before could review this as well? @aaron.ballman added a fix-it for
Eugene.Zelenko added a comment.
I still thik will be good idea to rename check (deps -> dependencies).
https://reviews.llvm.org/D50542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
teemperor marked 3 inline comments as done.
teemperor added inline comments.
Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:6
+#include "libc-empty-except.h"
+
+void f() {
bruno wrote:
> In a testcase like this but using the actual real headers,
Author: ahatanak
Date: Tue Aug 28 11:18:01 2018
New Revision: 340854
URL: http://llvm.org/viewvc/llvm-project?rev=340854=rev
Log:
Define variables in test case rather than using values from functions
emitted ealier.
Modified:
cfe/trunk/test/CodeGenObjCXX/arc-blocks.mm
Modified:
LGTM
On Tue, Aug 28, 2018, 7:49 AM Simon Atanasyan via Phabricator <
revi...@reviews.llvm.org> wrote:
> atanasyan created this revision.
> atanasyan added reviewers: echristo, ruiu.
>
> The "-flavor old-gnu" option were introduced to enable old version of LLD
> ELF linker implementation. This
JonasToth added a subscriber: lebedev.ri.
JonasToth added a comment.
I had to revert the `CHECK-NOTES` change that @lebedev.ri introduced with his
revision. It fails the test, i think there is an inconsistency or so in the
check-clang-tidy script. I will try to figure out whats the issue.
Author: yaxunl
Date: Tue Aug 28 14:09:09 2018
New Revision: 340873
URL: http://llvm.org/viewvc/llvm-project?rev=340873=rev
Log:
[HIP] Fix output file extension
OffloadBundlingJobAction constructor accepts a list of JobAction as inputs.
The host JobAction is the last one. The file type of
1 - 100 of 158 matches
Mail list logo
