[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I do not like to have a variable storing/mention one stuff named in plural. It is your decision as it is just my personal feeling. Comment at: clang/include/clang/Analy

r360863 - [builtin] Fixed definitions of builtins that rely on the int/long long type is 32/64 bits

Author: karka Date: Thu May 16 00:18:02 2019 New Revision: 360863 URL: http://llvm.org/viewvc/llvm-project?rev=360863&view=rev Log: [builtin] Fixed definitions of builtins that rely on the int/long long type is 32/64 bits Summary: The definition of the builtins __builtin_bswap32, __builtin_bitre

[PATCH] D61845: [builtin] Fixed definitions of builtins that rely on the int/long long type is 32/64 bits

This revision was automatically updated to reflect the committed changes. Closed by commit rL360863: [builtin] Fixed definitions of builtins that rely on the int/long long type is… (authored by karka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repositor

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

theraven requested changes to this revision. theraven added inline comments. This revision now requires changes to proceed. Comment at: lib/AST/ASTContext.cpp:6973 QualType PointeeTy = OPT->getPointeeType(); -if (!Options.EncodingProperty() && +if (getLangOpts().ObjC

[clang-tools-extra] r360869 - [clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy.

Author: jonastoth Date: Thu May 16 02:22:39 2019 New Revision: 360869 URL: http://llvm.org/viewvc/llvm-project?rev=360869&view=rev Log: [clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy. Summary: When run-clang-tidy is given the -quiet flag, do not output the potenti

[PATCH] D61849: Do not list enabled checks when -quiet is given to run-clang-tidy.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360869: [clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy. (authored by JonasToth, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D61849: Do not list enabled checks when -quiet is given to run-clang-tidy.

JonasToth added a comment. Yes someone has to do it on behalf of you. I did so for you. After a view good patches you can get commit rights from chris lattner, until then the reviewer can commit for you. Thank you for the patch! Repository: rL LLVM CHANGES SINCE LAST ACTION https://review

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov updated this revision to Diff 199775. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59885/new/ https://reviews.llvm.org/D59885 Files:

[PATCH] D61722: [AST] Add RecoveryExpr; produce it on overload resolution failure and missing member.

sammccall marked 3 inline comments as done. sammccall added a comment. Thanks for the useful insights! I'm going to work on a version of this patch that doesn't rely on type dependency and treats errors as a new concept instead. I'm not convinced it's feasible to drop RecoveryExpr and reuse exis

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1521 Tok[0].setAnnotationValue(AnnotationVal); - EnterTokenStream(std::move(Tok), 1, true); + EnterTokenStream(std::move(Tok), 1, true, /*IsReinject*/ true); } rsmith wrote: > I

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay added a comment. Herald added a project: clang. I'm very comfortable with the AVR changes at this point, I am going to go ahead and commit the patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54334/new/ https://reviews.llvm.org/D54334 _

Re: r360308 - [c++20] Implement P0846R0: allow (ADL-only) calls to template-ids whose

On 15/05/2019 18:16, Stephan Bergmann wrote: The below commit started to cause the following failure: ...and which apparently got fixed in the meantime, presumably by "Make tentative parsing to detect templ

[PATCH] D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output.

svenpanne added a comment. I think `ninja clang-test-tools` is the right target here, and it is happy with the change, which is not very surprising: AFAICT, there is just a single, very simple check for `run-clang-tidy.py`. Anyway, my manual testing with and without `-quiet` shows no problems,

[PATCH] D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output.

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM then, i can commit for you again? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61850/new/ https://reviews.llvm.org/D61850

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3885 + if (ArgNo) { +auto *PD = dyn_cast(VD); +ParmCache[PD].reset(D); aprantl wrote: > A `dyn_cast` followed by an unconditional use seems

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 199788. djtodoro added a comment. -Careful use of `dyn_cast` -Fill the `ParamCache` only in the case of `EnableDebugEntryValues` option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/C

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

Szelethus added a comment. Hmmm, how about this? #include struct VBase1 { VBase1() { std::cout << "VBase1()\n"; } VBase1(int) { std::cout << "VBase1(int)\n"; } }; struct VBase2 { VBase2() { std::cout << "VBase2()\n"; } VBase2(std::string) { std::cout << "VBase2(std:

[clang-tools-extra] r360882 - [clang-tidy] Handle member variables in readability-simplify-boolean-expr

Author: jonastoth Date: Thu May 16 05:35:00 2019 New Revision: 360882 URL: http://llvm.org/viewvc/llvm-project?rev=360882&view=rev Log: [clang-tidy] Handle member variables in readability-simplify-boolean-expr - Add readability-simplify-boolean-expr test cases for member variables Fixes PR40179

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

JonasToth added a comment. Thank you for the patch and sorry for the long delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360882: [clang-tidy] Handle member variables in readability-simplify-boolean-expr (authored by JonasToth, committed by ). Herald added a project: clang. Repository: rCTE Clang Tools Extra CHANGES SIN

[clang-tools-extra] r360883 - [clang-tidy] Removed superfluous and slightly annoying newlines in run-clang-tidy's output.

Author: jonastoth Date: Thu May 16 05:39:22 2019 New Revision: 360883 URL: http://llvm.org/viewvc/llvm-project?rev=360883&view=rev Log: [clang-tidy] Removed superfluous and slightly annoying newlines in run-clang-tidy's output. Summary: The output of clang-tidy itself already has enough newlines

r360885 - Fix isInSystemMacro in presence of macro and pasted token

Author: serge_sans_paille Date: Thu May 16 05:40:00 2019 New Revision: 360885 URL: http://llvm.org/viewvc/llvm-project?rev=360885&view=rev Log: Fix isInSystemMacro in presence of macro and pasted token When a warning is raised from the expansion of a system macro that involves pasted token, there

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ilya-biryukov added a comment. Thanks! Mostly NITs from me, the design looks nice! Would you mind adding some tests before we land this? The only major thing that I'd argue against is adding helper functions like `findPreviousToken` to `SourceCode.h`. It's fine to have them in the `.cpp` files

[PATCH] D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360883: [clang-tidy] Removed superfluous and slightly annoying newlines in run-clang… (authored by JonasToth, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

This revision was automatically updated to reflect the committed changes. Closed by commit rC360885: Fix isInSystemMacro in presence of macro and pasted token (authored by serge_sans_paille, committed by ). Changed prior to commit: https://reviews.llvm.org/D59413?vs=199585&id=199801#toc Reposi

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

mgorny created this revision. mgorny added reviewers: jroelofs, krytarowski. Herald added subscribers: libcxx-commits, ldionne, christof. Fix two issues that caused libcxx source path not to be inferred correctly when not specified explicitly: 1. get_lit_conf() uses default value only if the lit

[PATCH] D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output.

JonasToth added a comment. Thans for the patch! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61850/new/ https://reviews.llvm.org/D61850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman added a comment. I'm not certain where you're planning to go with this change (or is this the only change you're trying to make in this area?), so it's a bit hard to evaluate this patch. Can you explain a bit more about what you're ultimately trying to accomplish? It might help i

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

aaron.ballman added a comment. What will be making use of/testing this new functionality? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61834/new/ https://reviews.llvm.org/D61834 ___ cfe-commits mailing list cfe-comm

r360891 - Reland "[analyzer] Add an example plugin for checker dependency handling"

Author: szelethus Date: Thu May 16 06:22:04 2019 New Revision: 360891 URL: http://llvm.org/viewvc/llvm-project?rev=360891&view=rev Log: Reland "[analyzer] Add an example plugin for checker dependency handling" Buildbots complained that they couldn't find the newly added plugins. The solution was

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL360891: Reland "[analyzer] Add an example plugin for checker dependency handling" (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D59464?vs=199663&id=199807#toc

r360892 - Recommit [Object] Change object::SectionRef::getContents() to return Expected

Author: maskray Date: Thu May 16 06:24:04 2019 New Revision: 360892 URL: http://llvm.org/viewvc/llvm-project?rev=360892&view=rev Log: Recommit [Object] Change object::SectionRef::getContents() to return Expected r360876 didn't fix 2 call sites in clang. Expected> may be better but use Expected

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava marked an inline comment as done. adalava added a comment. In D61950#1504169 , @MaskRay wrote: > Will FreeBSD 13 or future releases support ELFv1? If not, it may be cleaner > to not invent `-elfv2` `-elfv1` triples, but rather dispatch on the majo

r360896 - [clang] Handle lround/llround builtins

Author: azanella Date: Thu May 16 06:43:25 2019 New Revision: 360896 URL: http://llvm.org/viewvc/llvm-project?rev=360896&view=rev Log: [clang] Handle lround/llround builtins As for other floating-point rounding builtins that can be optimized when build with -fno-math-errno, this patch adds suppor

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 added a comment. Sorry for the late answer, I was working on my thesis which is about taint analysis. During that, I implemented several cool features (namespaces, std::cin, std::string, etc.) for the checker. I will share them soon. I thought about the API notes and I think it will fit

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

JonasToth added a comment. Given this revision is accepted and seems ready to go: Do you need someone to commit on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 ___ cfe-commits mailin

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

javed.absar marked 4 inline comments as done. javed.absar added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:438 +} else if (Feature == "+8msecext") { + if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) { +Diags.Report(diag::err_target_u

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

javed.absar updated this revision to Diff 199819. javed.absar added a comment. Updated based on review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59879/new/ https://reviews.llvm.org/D59879 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D61530: Add AIX Version Macros

This revision was automatically updated to reflect the committed changes. Closed by commit rC360900: Add AIX Version Macros (authored by xingxue, committed by ). Changed prior to commit: https://reviews.llvm.org/D61530?vs=198056&id=199825#toc Repository: rC Clang CHANGES SINCE LAST ACTION

r360900 - Add AIX Version Macros

Author: xingxue Date: Thu May 16 07:22:37 2019 New Revision: 360900 URL: http://llvm.org/viewvc/llvm-project?rev=360900&view=rev Log: Add AIX Version Macros Summary: - This patch checks the AIX version and defines the appropriate macros. - Follow up to a comment on D59048. Author: andusy Review

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62010 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeCompletion/enum-preferred-type.cpp Index: clang/test/

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

aaron.ballman added a comment. Thanks for this -- it looks like really interesting functionality! I've mostly found nits thus far, but did have a question about clang-query support for it. Comment at: include/clang/AST/ASTContext.h:562-563 public: + ast_type_traits::Traversa

[PATCH] D61836: Move TraversalKind enum to ast_type_traits

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some commenting requests. Comment at: include/clang/AST/ASTTypeTraits.h:44 +enum TraversalKind { + /// Will traverse any child nodes. + TK_AsI

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker updated this revision to Diff 199830. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Stmt.h clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/Se

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay accepted this revision. MaskRay added a comment. Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 ___ cfe-commits mailing lis

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

Eugene.Zelenko added a comment. Will be good idea to mention new option in the Release Notes. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-concat-nested-namespaces.rst:56 + A comma-separated list of filename extensions of header files (the filename + exte

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/CodeCompletion/enum-preferred-type.cpp:13 + if (color == N::Color::Red) {} + + // RUN: %clang_cc1 -fsyntax-only -code-completion-at

r360907 - ftime-trace as a CoreOption

Author: aganea Date: Thu May 16 08:14:01 2019 New Revision: 360907 URL: http://llvm.org/viewvc/llvm-project?rev=360907&view=rev Log: ftime-trace as a CoreOption Differential Revision: https://reviews.llvm.org/D61945 Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/test/Drive

[PATCH] D61945: ftime-trace as a CoreOption

This revision was automatically updated to reflect the committed changes. Closed by commit rL360907: ftime-trace as a CoreOption (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D61945?v

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

ilya-biryukov updated this revision to Diff 199835. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - add a test case with a fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62010/new/ https://reviews.llvm.org/D620

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

kadircet added inline comments. Comment at: clang/test/CodeCompletion/enum-preferred-type.cpp:19 + // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:12:16 %s -o - | FileCheck %s + // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:12:21 %s -o - | FileCheck %s + //

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

ilya-biryukov added a comment. Thanks for a quick review! Comment at: clang/test/CodeCompletion/enum-preferred-type.cpp:19 + // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:12:16 %s -o - | FileCheck %s + // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:12:21 %

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

ilya-biryukov updated this revision to Diff 199839. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Fix a line number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62010/new/ https://reviews.llvm.org/D62010 Files:

r360910 - [analyzer] Add a test plugin for checker option handling

Author: szelethus Date: Thu May 16 08:55:07 2019 New Revision: 360910 URL: http://llvm.org/viewvc/llvm-project?rev=360910&view=rev Log: [analyzer] Add a test plugin for checker option handling Differential Revision: https://reviews.llvm.org/D59465 Added: cfe/trunk/test/Analysis/plugins/Check

[PATCH] D61756: Add a __FILE_NAME__ macro.

hintonda added a comment. In D61756#1504109 , @kristina wrote: > Reverted in rL360842 as Windows bots were > failing. > > I suspect the `MSVCCompat` case may need to be handled differently depending > on the host OS si

[PATCH] D59465: [analyzer] Add a test plugin for checker option handling

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL360910: [analyzer] Add a test plugin for checker option handling (authored by Szelethus, committed by ). Herald added a pr

r360912 - [CodeComplete] Complete enumerators when preferred type is an enum

Author: ibiryukov Date: Thu May 16 09:06:57 2019 New Revision: 360912 URL: http://llvm.org/viewvc/llvm-project?rev=360912&view=rev Log: [CodeComplete] Complete enumerators when preferred type is an enum Reviewers: kadircet Reviewed By: kadircet Subscribers: cfe-commits Tags: #clang Differenti

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

This revision was automatically updated to reflect the committed changes. Closed by commit rL360912: [CodeComplete] Complete enumerators when preferred type is an enum (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type name/access index

yonghong-song updated this revision to Diff 199843. yonghong-song retitled this revision from "[BPF] Preserve original struct/union type name/access index and array subscripts" to "[BPF] Preserve debuginfo array/union/struct type name/access index". yonghong-song edited the summary of this revisi

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ilya-biryukov added a comment. LG, just a few NITs wrt to exposing implementation details in the header. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:161 +// components are gathered as a `Case` and rules are defined as an ordered list +// of cases. //

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type name/access index

yonghong-song added a comment. @rsmith @eli.friedman Hi, I just implemented a new version which generates intrinsics only. Three intrinsics are implemented for array/union/structure separately as their handling and parameters are different. Could you take a look? Thanks! Repository: rC Clan

Re: r360308 - [c++20] Implement P0846R0: allow (ADL-only) calls to template-ids whose

On Thu, 16 May 2019, 03:38 Stephan Bergmann via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > On 15/05/2019 18:16, Stephan Bergmann wrote: > > The below commit started to cause the following failure: > > ...and which apparently got fixed in the meantime, presumably by > < > https://github.co

[PATCH] D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR

rjmccall added inline comments. Comment at: include/clang/Driver/Options.td:1500 + Flag<["-"], "fobjc-no-builtin-retain-release">, Group, + Flags<[CC1Option]>; def fno_objc_convert_messages_to_runtime_calls : I know I suggested this name, but it should probabl

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. With one comment that I will leave to you for what you think is best. Comment at: include/clang/Driver/Options.td:2145 + Flags<[DriverOption,CC1Option]>, + HelpText

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

JonasToth added a comment. Hi shixiao, thank you for taking a look at this. Please extend the unit-tests (clang-tools-extra/test/clang-tidy) for this check, your revision description already includes a good start. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNes

r360918 - [X86] Update doxygen comments for AVX512BF16 to not refer to masks as 'immediates'. Refer to parameter names instead of 'src', 'src1', 'src2'. NFC

Author: ctopper Date: Thu May 16 10:34:35 2019 New Revision: 360918 URL: http://llvm.org/viewvc/llvm-project?rev=360918&view=rev Log: [X86] Update doxygen comments for AVX512BF16 to not refer to masks as 'immediates'. Refer to parameter names instead of 'src', 'src1', 'src2'. NFC Modified: c

[PATCH] D60456: [RISCV][WIP/RFC] Hard float ABI support

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9232 +if (IsFloat && Size > FLen) + return false; +// Can't be eligible if an integer type was already found (only fp+int or Is this the only consideration for floating-poin

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. There is a simpler example distribution configuration, but sadly there isn't documentation. That is something I can fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org/D61909 ___

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. I should note, this and many more aspects of the build system were topics I discussed in a talk at the 2016 LLVM Dev meeting when we switched off autoconf: https://www.youtube.com/watch?v=StF77Cx7pz8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1504663 , @aaron.ballman wrote: > I'm not certain where you're planning to go with this change (or is this the > only change you're trying to make in this area?), so it's a bit hard to > evaluate this patch. Can you e

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire added a comment. In D61834#1504665 , @aaron.ballman wrote: > What will be making use of/testing this new functionality? Any code which has a `DynTypedNode` and wishes to traverse it. I envisage this as a more-flexible `DynTypedNode::dump` that

r360920 - Move TraversalKind enum to ast_type_traits

Author: steveire Date: Thu May 16 10:57:38 2019 New Revision: 360920 URL: http://llvm.org/viewvc/llvm-project?rev=360920&view=rev Log: Move TraversalKind enum to ast_type_traits Summary: Make it usable outside of ASTMatchFinder. This will make it possible to use this enum to control whether cert

[PATCH] D61836: Move TraversalKind enum to ast_type_traits

This revision was automatically updated to reflect the committed changes. Closed by commit rC360920: Move TraversalKind enum to ast_type_traits (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D61836?vs=199180&id=199856#toc Repository: rC Clang CHANGE

r360922 - Update comments on enums

Author: steveire Date: Thu May 16 11:02:36 2019 New Revision: 360922 URL: http://llvm.org/viewvc/llvm-project?rev=360922&view=rev Log: Update comments on enums Modified: cfe/trunk/include/clang/AST/ASTTypeTraits.h Modified: cfe/trunk/include/clang/AST/ASTTypeTraits.h URL: http://llvm.org/vi

[PATCH] D61836: Move TraversalKind enum to ast_type_traits

steveire added a comment. Thanks, I made the comment changes in a separate commit because otherwise this would cease to be a refactoring commit. Commits get too noisy if their content is modified "mid-flight". Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61836

[PATCH] D61909: Add Clang shared library with C++ exports

winksaville added a comment. In D61909#1505046 , @beanz wrote: > There is a simpler example distribution configuration, but sadly there isn't > documentation. That is something I can fix. Please add documentation if you want people to use it :) In the m

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. In D61909#1505083 , @winksaville wrote: > Please add documentation if you want people to use it :) I won't disagree that it should be documented, and I already started. I do want to point out though that your motivation starting t

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 199861. jcai19 added a comment. Add fixes based on comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files: clang-tools-extra/clang-tidy/android/AndroidTidyModu

[PATCH] D61909: Add Clang shared library with C++ exports

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. We can add CLANG_LINK_CLANG_DYLIB as a follow-up patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm

r360924 - [X86] Stop implicitly enabling avx512vl when avx512bf16 is enabled.

Author: ctopper Date: Thu May 16 11:28:17 2019 New Revision: 360924 URL: http://llvm.org/viewvc/llvm-project?rev=360924&view=rev Log: [X86] Stop implicitly enabling avx512vl when avx512bf16 is enabled. Previously we were doing this so that the 256 bit selectw builtin could be used in the impleme

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

aaron.ballman added a comment. In D61834#1505056 , @steveire wrote: > In D61834#1504665 , @aaron.ballman > wrote: > > > What will be making use of/testing this new functionality? > > > Any code which has a `DynType

[PATCH] D62019: [clang] Handle lrint/llrint builtins

zatrazz created this revision. zatrazz added reviewers: efriedma, rengolin, javed.absar, huntergr, SjoerdMeijer, t.p.northover, echristo, evandro. zatrazz added a project: clang. Herald added subscribers: kristina, kristof.beyls. As for other floating-point rounding builtins that can be optimized

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel updated this revision to Diff 199869. ymandel added a comment. adjust some API comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61335/new/ https://reviews.llvm.org/D61335 Files: clang/include/clang/Tooling/Refactoring/Transformer.

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 199870. jcai19 marked 4 inline comments as done. jcai19 added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files: clang-tools-extra/clang-tidy

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman added a comment. In D61835#1505048 , @steveire wrote: > In D61835#1504663 , @aaron.ballman > wrote: > > > I'm not certain where you're planning to go with this change (or is this > > the only change

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 marked 4 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/clang-tidy/android/CloexecPipeCheck.cpp:27 +void CloexecPipeCheck::check(const MatchFinder::MatchResult &Result) { + const std::string &ReplacementText = + (Twine("pipe2(")

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

rsmith added a comment. In D58920#1503872 , @modocache wrote: > Thanks for the help, @rsmith! Your suggestions were spot-on. (It took me a > little while to figure out why, even using the `LazyDeclPtr` directly, I was > still triggering deserialization.

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

rsmith accepted this revision. rsmith added a comment. LGTM, thank you! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36357/new/ https://reviews.llvm.org/D36357 ___ cfe-commits mailing list cfe-comm

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel marked 5 inline comments as done. ymandel added a comment. Thanks!! Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:278 +/// Builds the matcher needed for registration. +ast_matchers::internal::DynTypedMatcher buildMatcher(const RewriteRule &Rule); + -

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang/lib/Lex/Pragma.cpp:370 // Push the tokens onto the stack. - EnterTokenStream(TokArray, PragmaToks

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. All our bots are failing which seems to have been caused by the latest reland: FAIL: Clang :: Analysis/checker-plugins.c (297 of 14793) TEST 'Clang :: Analysis/checker-plugins.c' FAILED Script: -- : 'RUN: at line 1';

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1505151 , @aaron.ballman wrote: > In D61835#1505048 , @steveire wrote: > > > The users of the follow-up patch > > https://reviews.llvm.org/D61837#change-x5mxz9Lpijjs need that

[PATCH] D62009: [clang] perform semantic checking in constant context

rsmith added a comment. The approach we've been taking for this up until now is to use a `ConstantExpr` node to mark the entry point of a constant context; it looks like that would continue to work here, but we're missing those nodes in some cases? (This is preferable to using a flag because it

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire updated this revision to Diff 199875. steveire marked 10 inline comments as done. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61837/new/ https://reviews.llvm.org/D61837 Files: include/clang/AST/ASTContext.h include

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire added inline comments. Comment at: include/clang/AST/ASTContext.h:562-563 public: + ast_type_traits::TraversalKind GetTraversalKind() const { return Traversal; } + void SetTraversalKind(ast_type_traits::TraversalKind TK) { Traversal = TK; } + aaron.ba

Re: r360637 - PR41817: Fix regression in r359260 that caused the MS compatibility

*From: *Richard Smith *Date: *Wed, May 15, 2019 at 5:43 PM > On Wed, 15 May 2019 at 15:54, Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> We could probably re-land Richard's change (although it's quite a lot of >> code...), but... drop the conflicting `static` on the fl

[PATCH] D61909: Add Clang shared library with C++ exports

winksaville added a comment. Just to be clear, I have nothing to do with any distribution except as a user (Arch Linux) so please take what I say and request with a huge grain of salt. As mentioned I have filed a bug against the clang package in Arch Linux

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman added a comment. In D61835#1505202 , @steveire wrote: > In D61835#1505151 , @aaron.ballman > wrote: > > > In D61835#1505048 , @steveire > > wrote: > > > > > T

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTContext.h:562-563 public: + ast_type_traits::TraversalKind GetTraversalKind() const { return Traversal; } + void SetTraversalKind(ast_type_traits::TraversalKind TK) { Traversal = TK; } + ste

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 marked 2 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe.cpp:9 + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: prefer pipe2() to pipe() because pipe2() allows O_CLOEXEC [android-cloexec-pipe] + // C

  1   2   3   >