r366406 - [PowerPC][Clang] Remove use of malloc in mm_malloc

Author: chaofan Date: Wed Jul 17 23:20:12 2019 New Revision: 366406 URL: http://llvm.org/viewvc/llvm-project?rev=366406=rev Log: [PowerPC][Clang] Remove use of malloc in mm_malloc Remove dependency of malloc in implementation of mm_malloc function in PowerPC intrinsics and alignment assumption

[PATCH] D64850: Remove use of malloc in PPC mm_malloc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366406: [PowerPC][Clang] Remove use of malloc in mm_malloc (authored by chaofan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

aaron.ballman added inline comments. Comment at: clang/lib/Driver/Types.cpp:305 + P.clear(); + for (auto Phase : getInfo(Id).Phases) +P.push_back(Phase); Can't you use the local `Phases` object instead of calling `getInfo()` again? This seems like it

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske updated this revision to Diff 210490. balazske marked an inline comment as not done. balazske added a comment. - Renamed 'Unit', changed constructors. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64554/new/ https://reviews.llvm.org/D64554 Files:

[clang-tools-extra] r366408 - clang-tidy release notes: Split and order changes by type

Author: hans Date: Thu Jul 18 00:12:47 2019 New Revision: 366408 URL: http://llvm.org/viewvc/llvm-project?rev=366408=rev Log: clang-tidy release notes: Split and order changes by type Patch by Eugene Zelenko! Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus added a comment. In D63279#1590676 , @NoQ wrote: > /me has just noticed that this isn't D34812 . Oh great find! Is it worth ~~seizing~~ commandeering @baloghadamsoftware? CHANGES SINCE LAST ACTION

[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1447-1454 // If we have an expression that provided the value, try to track where it // came from. if (InitE) { if

r366409 - [CodeComplete] Fix ASTUnit cached completion of macros from preamble, broken in r342528

Author: sammccall Date: Thu Jul 18 00:17:49 2019 New Revision: 366409 URL: http://llvm.org/viewvc/llvm-project?rev=366409=rev Log: [CodeComplete] Fix ASTUnit cached completion of macros from preamble, broken in r342528 Summary: The problem is the default LoadExternal with no completer, which

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

baloghadamsoftware added a comment. In D63279#1590676 , @NoQ wrote: > /me has just noticed that this isn't D34812 . Oh, I just noticed that there was already an attempt to fix this :-) However, it seems that the review

[PATCH] D64712: [clangd][NFC] Refactor background-index shard loading

sammccall added a comment. Refactoring generally looks good. You're replacing a lot of documented code with new undocumented code, can we add some high-level comments? Comment at: clang-tools-extra/clangd/index/Background.cpp:130 + +bool hasChanged(llvm::vfs::FileSystem *FS,

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:195 Intent intent() const override { return Refactor; } + // Compute the extraction context for the Selection + void computeExtractionContext(const SelectionTree::Node

[PATCH] D64863: [clangd] Ignore diags from builtin files

hokein added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:473 + SourceManager = Info.getSourceManager(); + if (!InsideMainFile && SM.isWrittenInBuiltinFile(Info.getLocation())) { +IgnoreDiagnostics::log(DiagLevel, Info);

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

baloghadamsoftware updated this revision to Diff 210498. baloghadamsoftware added a comment. Fix wrong upload. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63279/new/ https://reviews.llvm.org/D63279 Files: lib/StaticAnalyzer/Core/LoopUnrolling.cpp test/Analysis/loop-unrolling.cpp

[PATCH] D64855: [clangd] Added highlightings for template parameters and specializations.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:141 // visit a TypeLoc where the underlying Type is a CXXRecordDecl). +if(isa(D)) { + addToken(Loc, HighlightingKind::Class); nit: clang-format

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:288 +ASTContext , FileManager , +ASTUnit *FromUnit, bool MinimalImport, +std::shared_ptr SharedState); Why do we still need `FromUnit` in

[PATCH] D64863: [clangd] Ignore diags from builtin files

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:473 + SourceManager = Info.getSourceManager(); + if (!InsideMainFile && SM.isWrittenInBuiltinFile(Info.getLocation())) { +IgnoreDiagnostics::log(DiagLevel, Info);

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1589818 , @lebedev.ri wrote: > In D64695#1589740 , @Manikishan > wrote: > > > In D64695#1589508 , @lebedev.ri > > wrote: > > > > > Is

[PATCH] D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64867/new/ https://reviews.llvm.org/D64867 ___ cfe-commits mailing list

[PATCH] D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode

neil.hickey added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:414 else -llvm_unreachable("Unsupported OpenCL C++ version"); +llvm_unreachable("Unsupported C++ version for OpenCL"); Builder.defineMacro("__CL_CPP_VERSION_1_0__",

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill reopened this revision. chill added a comment. This revision is now accepted and ready to land. I reverted the patch, have to rework `tcancel`. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210501. mantognini marked 4 inline comments as done. mantognini added a comment. - Minor refactoring of getThisObjectType - Removed unnecessary assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:2267 QualType ClassTy = C.getTypeDeclType(Decl); - ClassTy = C.getQualifiedType(ClassTy, FPT->getMethodQuals()); - return C.getPointerType(ClassTy); + return C.getQualifiedType(ClassTy,

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/Yaml.h:48 + return Config; +} Szelethus wrote: > ```lang=c++ > } // end of namespace clang > } // end of namespace ento > ``` I mean, the other way around >.< Comment

r366417 - [OpenCL][PR42033] Fix addr space deduction with template parameters

Author: stulova Date: Thu Jul 18 02:12:49 2019 New Revision: 366417 URL: http://llvm.org/viewvc/llvm-project?rev=366417=rev Log: [OpenCL][PR42033] Fix addr space deduction with template parameters If dependent types appear in pointers or references we allow addr space deduction because the addr

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

This revision was automatically updated to reflect the committed changes. Closed by commit rL366417: [OpenCL][PR42033] Fix addr space deduction with template parameters (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1277-1292 +State = setContainerData(State, ContReg, CData->newEnd(OldEndSym)); } else {

[PATCH] D64855: [clangd] Added highlightings for template parameters and specializations.

jvikstrom updated this revision to Diff 210503. jvikstrom added a comment. Added testcases and made highlighting work for template template parameters as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64855/new/

[PATCH] D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:414 else -llvm_unreachable("Unsupported OpenCL C++ version"); +llvm_unreachable("Unsupported C++ version for OpenCL");

[PATCH] D64855: [clangd] Added highlightings for template parameters and specializations.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:179 +R"cpp( + template + class $Class[[A]] { hokein wrote: >

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske marked 4 inline comments as done. balazske added inline comments. Comment at: include/clang/AST/ASTImporter.h:288 +ASTContext , FileManager , +ASTUnit *FromUnit, bool MinimalImport, +std::shared_ptr SharedState);

[PATCH] D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

ilya-biryukov created this revision. ilya-biryukov added reviewers: rsmith, gribozavr. Herald added a project: clang. Instead of traversing inside the TraverseDecl() function. Previously the attributes were traversed after Travese(Some)Decl returns. Logically attributes are properties of

[PATCH] D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

ilya-biryukov updated this revision to Diff 210507. ilya-biryukov added a comment. - Visit attributes before visiting the Decl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64907/new/ https://reviews.llvm.org/D64907 Files:

[PATCH] D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

ilya-biryukov added a comment. Wanted to write unit tests, but couldn't find any that check traversal order. I'm aware of `Tooling/RecursiveASTVisitorTests`, but they mostly check that implicit nodes are visited. Do we have other tests for traversals? Repository: rG LLVM Github Monorepo

[PATCH] D64739: [SVE][Inline-Asm] Add support to clang for SVE inline assembly

rovka added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:307 -// 32-bit floating point regsisters +// 32-bit floating point registers "s0", "s1", "s2", "s3", "s4", "s5", "s6", "s7", "s8", "s9", "s10", "s11", You should commit

[clang-tools-extra] r366420 - [clangd] Added highlightings for template parameters and specializations.

Author: jvikstrom Date: Thu Jul 18 02:56:38 2019 New Revision: 366420 URL: http://llvm.org/viewvc/llvm-project?rev=366420=rev Log: [clangd] Added highlightings for template parameters and specializations. Summary: Template parameters and specializations were not being highlighted before. This

[PATCH] D64855: [clangd] Added highlightings for template parameters and specializations.

jvikstrom marked 2 inline comments as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:179 +R"cpp( + template + class $Class[[A]] { hokein wrote: > hokein wrote: > > could you add

[PATCH] D64855: [clangd] Added highlightings for template parameters and specializations.

This revision was automatically updated to reflect the committed changes. jvikstrom marked an inline comment as done. Closed by commit rL366420: [clangd] Added highlightings for template parameters and specializations. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/ https://reviews.llvm.org/D64569

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210511. kadircet marked 13 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files:

r366421 - [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL

Author: stulova Date: Thu Jul 18 03:02:35 2019 New Revision: 366421 URL: http://llvm.org/viewvc/llvm-project?rev=366421=rev Log: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL Clang doesn't implement OpenCL C++, change the comments to reflect that. Differential Revision:

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:490 + auto FS = FSProvider.getFileSystem(); + llvm::DenseSet TUsToIndex; + for (auto : Result.Shards) { sammccall wrote: > nit: again, this patch is adding Path/PathRef

r366422 - [OpenCL] Improve destructor support in C++ for OpenCL

Author: mantognini Date: Thu Jul 18 03:04:18 2019 New Revision: 366422 URL: http://llvm.org/viewvc/llvm-project?rev=366422=rev Log: [OpenCL] Improve destructor support in C++ for OpenCL Summary: This patch does mainly three things: 1. It fixes a false positive error detection in Sema that is

[PATCH] D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL366421: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:119 void addToken(SourceLocation Loc, const NamedDecl *D) { +if (D->isInvalidDecl()) + return; This means if we won't emit most of symbols if the AST is

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rL366422: [OpenCL] Improve destructor support in C++ for OpenCL (authored by mantognini, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59426: [PR41010][OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59426/new/ https://reviews.llvm.org/D59426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

oydale added a comment. @rsmith, @rjmccall, I don't have access to commit this myself, could one of you commit it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64656/new/ https://reviews.llvm.org/D64656

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah created this revision. SureYeaah added reviewers: kadircet, sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - For now, we don't trigger in any case if it's an empty selection - Fixed unittests Repository:

[PATCH] D64712: [clangd] Refactor background-index shard loading

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:133 + if (!Buf) { +elog("Background-index: Couldn't read {0 to validate stored index: {1}", + LS.AbsolutePath, Buf.getError().message()); `{0` is missing its

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 210527. jvikstrom marked 9 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 Files:

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah updated this revision to Diff 210526. SureYeaah added a comment. Added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64912/new/ https://reviews.llvm.org/D64912 Files: clang-tools-extra/clangd/refactor/Tweak.cpp

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Looks good from my side. @ilya-biryukov will be nice if you could take a second look on the patch. We plan to land it before the release cut today. Comment at:

Re: r366422 - [OpenCL] Improve destructor support in C++ for OpenCL

Hi Marco, Your commit crashes clang when building the LLVM Support with libc++ library. I'll revert the commit to unbreak our integrate. See the details in the following bug: https://bugs.llvm.org/show_bug.cgi?id=42665 On Thu, Jul 18, 2019 at 1:42 PM Ilya Biryukov wrote: > Hi Marco, > > Your

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added a comment. one missing point -- could you please update the patch description? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 ___ cfe-commits

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51 +/// The Length of the selection +unsigned SelectionLength; /// The AST nodes that were selected. maybe expose a `SourceLocation SelectionEnd` ? Repository:

[clang-tools-extra] r366427 - Bump the trunk version to 10.0.0svn

Author: hans Date: Thu Jul 18 04:51:05 2019 New Revision: 366427 URL: http://llvm.org/viewvc/llvm-project?rev=366427=rev Log: Bump the trunk version to 10.0.0svn and clear the release notes. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/conf.py

[libunwind] r366427 - Bump the trunk version to 10.0.0svn

Author: hans Date: Thu Jul 18 04:51:05 2019 New Revision: 366427 URL: http://llvm.org/viewvc/llvm-project?rev=366427=rev Log: Bump the trunk version to 10.0.0svn and clear the release notes. Modified: libunwind/trunk/CMakeLists.txt libunwind/trunk/docs/conf.py Modified:

r366427 - Bump the trunk version to 10.0.0svn

Author: hans Date: Thu Jul 18 04:51:05 2019 New Revision: 366427 URL: http://llvm.org/viewvc/llvm-project?rev=366427=rev Log: Bump the trunk version to 10.0.0svn and clear the release notes. Modified: cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/docs/conf.py Modified:

[libunwind] r366428 - Creating release_90 branch off revision 366426

Author: hans Date: Thu Jul 18 04:53:54 2019 New Revision: 366428 URL: http://llvm.org/viewvc/llvm-project?rev=366428=rev Log: Creating release_90 branch off revision 366426 Added: libunwind/branches/release_90/ - copied from r366426, libunwind/trunk/

[libclc] r366428 - Creating release_90 branch off revision 366426

Author: hans Date: Thu Jul 18 04:53:54 2019 New Revision: 366428 URL: http://llvm.org/viewvc/llvm-project?rev=366428=rev Log: Creating release_90 branch off revision 366426 Added: libclc/branches/release_90/ - copied from r366426, libclc/trunk/

r366429 - Revert r366422: [OpenCL] Improve destructor support in C++ for OpenCL

Author: ibiryukov Date: Thu Jul 18 04:55:33 2019 New Revision: 366429 URL: http://llvm.org/viewvc/llvm-project?rev=366429=rev Log: Revert r366422: [OpenCL] Improve destructor support in C++ for OpenCL Reason: this commit causes crashes in the clang compiler when building LLVM Support with

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:46 +// removed. +for (unsigned I = 0; I < Tokens.size(); ++I) { + ArrayRef TokRef(Tokens); we don't care the Kind in `HighlightingToken` now, I think we

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:46 +// removed. +for (unsigned I = 0; I < Tokens.size(); ++I) { + ArrayRef TokRef(Tokens); hokein wrote: > we

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom updated this revision to Diff 210530. jvikstrom added a comment. Added comment saying conflicting tokens are not highlighted in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://reviews.llvm.org/D64741 Files:

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything(.bind("vardecl"), this); +} jpakkane wrote: > alexfh wrote: > > jpakkane wrote: >

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. In D55044#1589496 , @alexfh wrote: > Seems good now. Haojian, do you have any concerns? sorry for the looong delay, I totally miss this thread. looks

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah marked an inline comment as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51 +/// The Length of the selection +unsigned SelectionLength; /// The AST nodes that were selected. kadircet wrote: >

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah updated this revision to Diff 210536. SureYeaah added a comment. Added selectionend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64912/new/ https://reviews.llvm.org/D64912 Files: clang-tools-extra/clangd/refactor/Tweak.cpp

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah updated this revision to Diff 210537. SureYeaah added a comment. Fixed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64912/new/ https://reviews.llvm.org/D64912 Files: clang-tools-extra/clangd/refactor/Tweak.cpp

[PATCH] D64914: Implement P1771

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, chandlerc. Herald added a project: clang. EWG met on 7/18/19 and came to the conclusion that our initial intent was to apply to constructors, so approved the paper and expected implementers to use implementers discretion

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51 +/// The Length of the selection +unsigned SelectionLength; /// The AST nodes that were selected. SureYeaah wrote: > kadircet wrote: > > maybe expose a

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 updated this revision to Diff 210540. boga95 marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210541. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files:

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp:93 + +void BackgroundIndexLoader::load(PathRef MainFile, + BackgroundIndexStorage *Storage) { sammccall wrote: > This handles

[PATCH] D64915: [clangd] cleanup: unify the implemenation of checking a location is inside main file.

hokein created this revision. hokein added reviewers: ilya-biryukov, kadircet. Herald added subscribers: arphaman, jkorous, MaskRay. Herald added a project: clang. We have variant implementations in the codebase, this patch unifies them. Repository: rG LLVM Github Monorepo

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao marked an inline comment as done. shixiao added inline comments. Comment at: clang-tools-extra/test/clang-tidy/modernize-concat-nested-namespaces.h:1 +#pragma once + alexfh wrote: > alexfh wrote: > > Please put the header under Inputs// directory to

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/modernize-concat-nested-namespaces.h:1 +#pragma once + shixiao wrote: > alexfh wrote: > > alexfh wrote: > > > Please put the header under Inputs// directory to keep the > > >

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah marked 5 inline comments as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:208 const SelectionTree::Node *N = Inputs.ASTSelection.commonAncestor(); - if (!N) -return false; - Target =

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210545. SureYeaah added a comment. Refactored code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64918: [ASTUnit] Fix a regression in cached completions

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: clang. After r345152 cached completions started adding namespaces after nested name specifiers, e.g. in `some_name::^` The CCC_Symbol indicates the

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM. Comment at: include/clang/AST/ASTImporter.h:288 +ASTContext , FileManager , +ASTUnit *FromUnit, bool MinimalImport, +

[PATCH] D64915: [clangd] cleanup: unify the implemenation of checking a location is inside main file.

ilya-biryukov added a comment. Neat! Many thanks, that's a very useful cleanup. A few suggestions from my side. Comment at: clang-tools-extra/clangd/SourceCode.cpp:332 +bool isInsideMainFile(SourceLocation Loc, const SourceManager ) { + return Loc.isValid() &&

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

Anastasia added a comment. The commit has been reverted due to issues with libc++: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190715/279833.html However, without this change dtors are largely not usable in OpenCL due to ICE on wrong IR. I would like to be able to fix this on the

[PATCH] D64801: [analyzer] Add CTU user docs

martong updated this revision to Diff 210552. martong added a comment. - Add notes about macro expansion crash with CTU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64801/new/ https://reviews.llvm.org/D64801 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:208 const SelectionTree::Node *N = Inputs.ASTSelection.commonAncestor(); - if (!N) -return false; - Target = llvm::make_unique(N, SM, Ctx); - return

r366437 - [OPENMP][NVPTX]Mark barrier functions calls as convergent.

Author: abataev Date: Thu Jul 18 06:49:24 2019 New Revision: 366437 URL: http://llvm.org/viewvc/llvm-project?rev=366437=rev Log: [OPENMP][NVPTX]Mark barrier functions calls as convergent. Added convergent attribute to the barrier functions calls for correct optimizations. Modified:

[PATCH] D64918: [ASTUnit] Fix a regression in cached completions

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Index/complete-qualified-with-preamble.cpp:7 +// START-OF-LINE: Class +// -- With preambles. +// RUN: CINDEXTEST_EDITING=1 c-index-test

[PATCH] D64918: [ASTUnit] Fix a regression in cached completions

kadircet accepted this revision. kadircet added a comment. LGTM from my side as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64918/new/ https://reviews.llvm.org/D64918 ___ cfe-commits mailing

[PATCH] D64627: [clangd] Suppress unwritten scopes when expanding auto.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64627/new/ https://reviews.llvm.org/D64627

[PATCH] D64918: [ASTUnit] Fix a regression in cached completions

ilya-biryukov updated this revision to Diff 210555. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - s/preamble/cached completions (in tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64918/new/

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

aganea added a comment. It totally makes sense, thanks for the explanation Nico! Let's forget about `cl` compatibility, that wasn't my initial intent. We always pass //relative// paths on the cmd-line, for all the reasons you've mentioned. We also pass `-fdiagnostics-absolute-paths` hoping to

[PATCH] D64918: [ASTUnit] Fix a regression in cached completions

ilya-biryukov added inline comments. Comment at: clang/test/Index/complete-qualified-with-preamble.cpp:7 +// START-OF-LINE: Class +// -- With preambles. +// RUN: CINDEXTEST_EDITING=1 c-index-test -code-completion-at=%s:3:1 %s \ sammccall wrote: > Nit: This (and

r366439 - [analyzer] Add CTU user docs

Author: martong Date: Thu Jul 18 07:03:25 2019 New Revision: 366439 URL: http://llvm.org/viewvc/llvm-project?rev=366439=rev Log: [analyzer] Add CTU user docs Reviewers: dkrupp, a_sidorin, Szelethus, NoQ Subscribers: whisperity, xazax.hun, baloghadamsoftware, szepet, rnkovacs, a.sidorin,

[PATCH] D64801: [analyzer] Add CTU user docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL366439: [analyzer] Add CTU user docs (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64922: [clangd] Added option to enable semantic highlighting via an experimental capability

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Adds option to enable semantic highlighting as an experimental capability. The reason for this

[PATCH] D64922: [clangd] Added option to enable semantic highlighting via an experimental capability

jvikstrom updated this revision to Diff 210559. jvikstrom added a comment. Made Protocol comment be doxygen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64922/new/ https://reviews.llvm.org/D64922 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:292 + Target = llvm::make_unique(TargetNode, SM, Ctx); + return true; +} kadircet wrote: > `return Target->InsertionPoint`? Changed to checking if target

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210560. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Fixed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

ilya-biryukov added a comment. A few suggestions from me, I haven't looked into the diffing algorithm and the tests yet. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:458 +// edit there are stale previous highlightings. +std::lock_guard

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. As discussed, the long-term fix might be to avoid ever encountering these paths (filtering everything we get over LSP, CDBs etc). Maybe add a fixme on removeDots? Repository: rG LLVM

  1   2   3   >