[PATCH] D66406: [clangd] Update theme when color theme changes in vscode extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370305: [clangd] Update themeRuleMatcher when color theme changes in vscode extension. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

jvikstrom updated this revision to Diff 217811. jvikstrom marked 5 inline comments as done. jvikstrom added a comment. Clarified comments. Added tests. Not getting expansions inside other macro expansions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r370323 - [Index] Create PP callbacks in the ASTConsumer

Author: gribozavr Date: Thu Aug 29 03:23:29 2019 New Revision: 370323 URL: http://llvm.org/viewvc/llvm-project?rev=370323=rev Log: [Index] Create PP callbacks in the ASTConsumer Doing so removes one reason to create a custom FrontendAction. FrontendActions are not desirable because they are

[PATCH] D66876: Indexing: create PP callbacks in the ASTConsumer

gribozavr added a comment. Committed as r370323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66876/new/ https://reviews.llvm.org/D66876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66878: [Index] Stopped wrapping FrontendActions in libIndex and its users

gribozavr marked 2 inline comments as done. gribozavr added a comment. Committed as r370337. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66878/new/ https://reviews.llvm.org/D66878 ___ cfe-commits

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

This revision was automatically updated to reflect the committed changes. Closed by commit rL370338: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored… (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D66933: [ASTImporter] Propagate errors during import of overridden methods.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. If importing overridden methods fails for a method it can be

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

This revision was automatically updated to reflect the committed changes. Closed by commit rL370335: [CodeGen]: dont treat structures returned in registers as memory inputs (authored by glider, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r370335 - [CodeGen]: don't treat structures returned in registers as memory inputs

Author: glider Date: Thu Aug 29 04:21:41 2019 New Revision: 370335 URL: http://llvm.org/viewvc/llvm-project?rev=370335=rev Log: [CodeGen]: don't treat structures returned in registers as memory inputs Summary: The "=r" output constraint for a structure variable passed to inline asm shouldn't be

r370336 - [Index] Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

Author: gribozavr Date: Thu Aug 29 04:38:43 2019 New Revision: 370336 URL: http://llvm.org/viewvc/llvm-project?rev=370336=rev Log: [Index] Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction Doing so removes the last reason to expose a FrontendAction from

[PATCH] D66669: [X86] Remove what little support we had for MPX

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - please reword the X86InstrMPX.td comment like @xbolva00 suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

ilya-biryukov added a comment. Looks great, just requests for comments and more test-cases from my side Comment at: clang-tools-extra/clangd/ClangdUnit.h:148 + /// All macro expansion locations in the main file. + std::vector MainFileMacroExpLocs; NIT:

[PATCH] D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal

baloghadamsoftware added a comment. In D62893#1608000 , @Szelethus wrote: > Makes sense! But, does any of the test cases actually test *this* particular > change? I added some reachability checks before committing. Repository: rL LLVM CHANGES

[PATCH] D66866: [ASTImporter] At import of records re-order indirect fields too.

balazske updated this revision to Diff 217816. balazske added a comment. - Simplified field matcher in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66866/new/ https://reviews.llvm.org/D66866 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

gribozavr closed this revision. gribozavr marked an inline comment as done. gribozavr added a comment. Committed as r370336. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66877/new/ https://reviews.llvm.org/D66877

[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

jvikstrom updated this revision to Diff 217785. jvikstrom marked an inline comment as done. jvikstrom added a comment. Use `conf.affectsConfiguration('workbench.colorTheme')` instead of keeping track of the old color theme manually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:248 +TEST(ClangdUnitTest, CollectsMainFileMacroExpansions) { + Annotations TestCase(R"cpp( +#define MACRO_ARGS(X, Y) X Y ilya-biryukov wrote: > Could you add

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 217820. kadircet marked an inline comment as done. kadircet added a comment. - Get rid off compatibility check for files that are not open in the editor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb marked 2 inline comments as done. krisb added a comment. @dnsampaio, thanks! This is definitely better. I also added ARMV8_5A as a test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018

[clang-tools-extra] r370338 - [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

Author: gribozavr Date: Thu Aug 29 04:47:34 2019 New Revision: 370338 URL: http://llvm.org/viewvc/llvm-project?rev=370338=rev Log: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution Subscribers: jkorous,

r370338 - [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

Author: gribozavr Date: Thu Aug 29 04:47:34 2019 New Revision: 370338 URL: http://llvm.org/viewvc/llvm-project?rev=370338=rev Log: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution Subscribers: jkorous,

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet marked 14 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:601 + llvm::inconvertibleErrorCode(), + "File contents differ on disk for %s, please save", FilePath.data()); +}

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 217803. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files:

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66937 Files: clang-tools-extra/docs/clangd/Installation.rst

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider added a comment. Landed r370335, thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65234/new/ https://reviews.llvm.org/D65234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66404: [CFG] Make destructor calls more accurate

nathanchance added a comment. This commit causes some warnings in the Linux kernel that appear to be false positives. For example: CC drivers/base/cpu.o drivers/base/cpu.c:404:1: error: control may reach end of non-void function [-Werror,-Wreturn-type] } ^ 1 error generated.

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. TokenBuffer does not collect macro expansions inside macro arguments which is needed for semantic

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider updated this revision to Diff 217831. glider added a comment. Rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65234/new/ https://reviews.llvm.org/D65234 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/asm-attrs.c

[clang-tools-extra] r370304 - Reland "[clangd] Migrate last tweak tests to TweakTesting.h and remove old helpers. NFC"

Author: sammccall Date: Thu Aug 29 01:20:48 2019 New Revision: 370304 URL: http://llvm.org/viewvc/llvm-project?rev=370304=rev Log: Reland "[clangd] Migrate last tweak tests to TweakTesting.h and remove old helpers. NFC" This reverts commit 3dcf55aa45bad800533b36b70a14ebeb2b84e219, and avoids

[clang-tools-extra] r370305 - [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

Author: jvikstrom Date: Thu Aug 29 01:40:17 2019 New Revision: 370305 URL: http://llvm.org/viewvc/llvm-project?rev=370305=rev Log: [clangd] Update themeRuleMatcher when color theme changes in vscode extension. Summary: Add event listener that listens to configuration changes and reloads the

[PATCH] D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal

This revision was automatically updated to reflect the committed changes. Closed by commit rL370314: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal (authored by baloghadamsoftware, committed by ). Herald added a project: LLVM. Herald added a subscriber:

r370314 - [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal

Author: baloghadamsoftware Date: Thu Aug 29 02:35:47 2019 New Revision: 370314 URL: http://llvm.org/viewvc/llvm-project?rev=370314=rev Log: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal Range errors (dereferencing or incrementing the past-the-end iterator or

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:601 + llvm::inconvertibleErrorCode(), + "File contents differ on disk for %s, please save", FilePath.data()); +} kadircet wrote: > sammccall wrote: > > you

[PATCH] D66883: PR42045: Fix diagnosing enqueue_kernel call with too few args

This revision was automatically updated to reflect the committed changes. Closed by commit rL370322: [OpenCL] Fix diagnosing enqueue_kernel call with too few args (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r370322 - [OpenCL] Fix diagnosing enqueue_kernel call with too few args

Author: svenvh Date: Thu Aug 29 03:21:06 2019 New Revision: 370322 URL: http://llvm.org/viewvc/llvm-project?rev=370322=rev Log: [OpenCL] Fix diagnosing enqueue_kernel call with too few args The err_typecheck_call_too_few_args diagnostic takes arguments, but none were provided causing clang to

[clang-tools-extra] r370337 - [Index] Stopped wrapping FrontendActions in libIndex and its users

Author: gribozavr Date: Thu Aug 29 04:43:05 2019 New Revision: 370337 URL: http://llvm.org/viewvc/llvm-project?rev=370337=rev Log: [Index] Stopped wrapping FrontendActions in libIndex and its users Exposed a new function, createIndexingASTConsumer, that creates an ASTConsumer. ASTConsumers

r370337 - [Index] Stopped wrapping FrontendActions in libIndex and its users

Author: gribozavr Date: Thu Aug 29 04:43:05 2019 New Revision: 370337 URL: http://llvm.org/viewvc/llvm-project?rev=370337=rev Log: [Index] Stopped wrapping FrontendActions in libIndex and its users Exposed a new function, createIndexingASTConsumer, that creates an ASTConsumer. ASTConsumers

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

kadircet added a subscriber: sammccall. kadircet added a comment. Thanks for updating this! Pinging @sammccall since he is also working on writing some release docs, might be helpful to bring this to your attention. Comment at:

[clang-tools-extra] r370343 - Fix MSVC "not all control paths return a value" warning. NFCI.

Author: rksimon Date: Thu Aug 29 05:37:02 2019 New Revision: 370343 URL: http://llvm.org/viewvc/llvm-project?rev=370343=rev Log: Fix MSVC "not all control paths return a value" warning. NFCI. Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/ExtractFunction.cpp Modified:

[clang-tools-extra] r370371 - [clangd] Update out-of-date links in readme, NFC.

Author: hokein Date: Thu Aug 29 07:57:32 2019 New Revision: 370371 URL: http://llvm.org/viewvc/llvm-project?rev=370371=rev Log: [clangd] Update out-of-date links in readme, NFC. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/README.md Modified:

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:107 +class CollectMainFileMacroExpansions : public PPCallbacks { + const SourceManager Maybe make this part of

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaron.ballman added a comment. In D66919#1650174 , @dexonsmith wrote: > This could cause a lot of churn in existing projects (especially with `static > void foo()`), without giving Clang any new information. I'm wary of this. Those projects likely

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman added a comment. In D66856#1649721 , @erik.pilkington wrote: > In D66856#1648809 , @aaron.ballman > wrote: > > > I'm wondering whether this should even warn pedantically. There are no > > format

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM. One optional nit as it is not related with this patch anymore. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:659 llvm::ARM::ArchKind ArchKind; - if (CPU ==

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:107 +class CollectMainFileMacroExpansions : public PPCallbacks { + const SourceManager ilya-biryukov wrote: > Maybe make this

[clang-tools-extra] r370367 - [clangd][NFC] Update background-index command line description

Author: kadircet Date: Thu Aug 29 07:38:02 2019 New Revision: 370367 URL: http://llvm.org/viewvc/llvm-project?rev=370367=rev Log: [clangd][NFC] Update background-index command line description Summary: We didn't change this in D64019 just in case we revert it back. Deleting it now. Reviewers:

[PATCH] D66933: [ASTImporter] Propagate errors during import of overridden methods.

martong accepted this revision. martong added a reviewer: a_sidorin. martong added a comment. This revision is now accepted and ready to land. LGTM, other than a few comments. Comment at: clang/lib/AST/ASTImporter.cpp:7809 -void ASTNodeImporter::ImportOverrides(CXXMethodDecl

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

MaskRay added inline comments. Comment at: cfe/trunk/include/clang/Index/IndexingAction.h:58 +const IndexingOptions , std::shared_ptr PP, +std::function ShouldSkipFunctionBody); + I know ShouldSkipFunctionBody is important for multi-threaded indexing,

[PATCH] D66943: [clangd][NFC] Update background-index command line description

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We didn't change this in D64019 just in case we revert it back.

Re: r370321 - [Index] Marked a bunch of classes 'final'

Nitpick (sorry): I think common style for commit message is to describe what the change does in present tense, i.e. ""Mark a bunch of classes 'final'". On Thu, Aug 29, 2019 at 6:15 AM Dmitri Gribenko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gribozavr > Date: Thu Aug 29

Re: [clang-tools-extra] r370367 - [clangd][NFC] Update background-index command line description

Merged to release_90 in r370370. On Thu, Aug 29, 2019 at 4:36 PM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Thu Aug 29 07:38:02 2019 > New Revision: 370367 > > URL: http://llvm.org/viewvc/llvm-project?rev=370367=rev > Log: > [clangd][NFC] Update background-index command

r370340 - Removed two function declarations that don't have definitions

Author: gribozavr Date: Thu Aug 29 05:10:15 2019 New Revision: 370340 URL: http://llvm.org/viewvc/llvm-project?rev=370340=rev Log: Removed two function declarations that don't have definitions Modified: cfe/trunk/include/clang/AST/DeclCXX.h Modified: cfe/trunk/include/clang/AST/DeclCXX.h

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. The previous matcher "hasAnyTemplateArgument(templateArgument())" only matches the first template argument, but the check wants to iterate all template arguments.

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah updated this revision to Diff 217881. SureYeaah added a comment. Added null statement check in TraverseStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66732/new/ https://reviews.llvm.org/D66732 Files:

r370341 - Removed `AnyFunctionDecl`, it is unused.

Author: gribozavr Date: Thu Aug 29 05:17:21 2019 New Revision: 370341 URL: http://llvm.org/viewvc/llvm-project?rev=370341=rev Log: Removed `AnyFunctionDecl`, it is unused. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/include/clang/AST/DeclTemplate.h Modified:

[PATCH] D66866: [ASTImporter] At import of records re-order indirect fields too.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66866/new/ https://reviews.llvm.org/D66866

r370361 - Removed a function declaration that doesn't have a definition

Author: gribozavr Date: Thu Aug 29 07:21:05 2019 New Revision: 370361 URL: http://llvm.org/viewvc/llvm-project?rev=370361=rev Log: Removed a function declaration that doesn't have a definition Modified: cfe/trunk/include/clang/AST/ExprCXX.h Modified: cfe/trunk/include/clang/AST/ExprCXX.h

[PATCH] D66949: [clangd] Add .vscode-test to .gitignore.

hokein created this revision. hokein added a reviewer: jvikstrom. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66949 Files:

[PATCH] D66948: [CodeGen]: fix error message for "=r" asm constraint

glider created this revision. glider added reviewers: eli.friedman, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. Nico Weber reported that the following code: char buf[9]; asm("" : "=r" (buf)); yields the "impossible constraint in asm: can't store struct

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah updated this revision to Diff 217865. SureYeaah added a comment. Removed selectionTree Visitor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66732/new/ https://reviews.llvm.org/D66732 Files:

[PATCH] D66943: [clangd][NFC] Update background-index command line description

This revision was automatically updated to reflect the committed changes. Closed by commit rL370367: [clangd][NFC] Update background-index command line description (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:107 +class CollectMainFileMacroExpansions : public PPCallbacks { + const SourceManager jvikstrom wrote: > ilya-biryukov wrote: > > Maybe make this part of

[PATCH] D66947: Changed FrontendActionFactory::create to return a std::unique_ptr

gribozavr created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66947 Files: clang-tools-extra/clang-doc/ClangDoc.cpp

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong created this revision. martong added reviewers: shafik, a_sidorin, balazske. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs, mgorny. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong updated this revision to Diff 217899. martong

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 217899. martong added a comment. - Fix copy error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp

[PATCH] D66947: Changed FrontendActionFactory::create to return a std::unique_ptr

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66947/new/ https://reviews.llvm.org/D66947

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

lebedev.ri added a comment. In D66960#1651243 , @gribozavr wrote: > In D66960#1651198 , @lebedev.ri > wrote: > > > This is missing documentation changes. > > > Could you point out such places? I tried to remove

[PATCH] D66948: [CodeGen]: fix error message for "=r" asm constraint

glider updated this revision to Diff 217887. glider added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66948/new/ https://reviews.llvm.org/D66948 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/x86_64-PR42672.c

[PATCH] D66950: [SimplifyCFG] Skip sinking common lifetime markers of `alloca`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG001871dee8b1: [SimplifyCFG] Skip sinking common lifetime markers of `alloca`. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66950/new/

[clang-tools-extra] r370372 - [Clangd] NFC: Added fixme for checking for local/anonymous types for extracted parameters

Author: sureyeaah Date: Thu Aug 29 08:11:59 2019 New Revision: 370372 URL: http://llvm.org/viewvc/llvm-project?rev=370372=rev Log: [Clangd] NFC: Added fixme for checking for local/anonymous types for extracted parameters Modified:

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd added a comment. In D65761#1646059 , @rnk wrote: > I plan to take a look at this tomorrow, sorry for putting this off for a > while. :( Thanks @rnk! If there's anything I can clarify/fix, please let me know. Repository: rG LLVM Github

[PATCH] D66950: [SimplifyCFG] Skip sinking common lifetime markers of `alloca`.

hliao updated this revision to Diff 217901. hliao added a comment. Herald added subscribers: cfe-commits, erik.pilkington, mgorny. Herald added a project: clang. Revise `isLifeTimeMarker` following review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

dexonsmith added a comment. In D66919#1650775 , @aaron.ballman wrote: > In D66919#1650174 , @dexonsmith > wrote: > > > This could cause a lot of churn in existing projects (especially with > > `static void

[clang-tools-extra] r370379 - Changed FrontendActionFactory::create to return a std::unique_ptr

Author: gribozavr Date: Thu Aug 29 09:38:36 2019 New Revision: 370379 URL: http://llvm.org/viewvc/llvm-project?rev=370379=rev Log: Changed FrontendActionFactory::create to return a std::unique_ptr Subscribers: jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision:

r370379 - Changed FrontendActionFactory::create to return a std::unique_ptr

Author: gribozavr Date: Thu Aug 29 09:38:36 2019 New Revision: 370379 URL: http://llvm.org/viewvc/llvm-project?rev=370379=rev Log: Changed FrontendActionFactory::create to return a std::unique_ptr Subscribers: jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision:

r370383 - Added 'inline' to functions defined in headers to avoid ODR violations

Author: gribozavr Date: Thu Aug 29 09:58:13 2019 New Revision: 370383 URL: http://llvm.org/viewvc/llvm-project?rev=370383=rev Log: Added 'inline' to functions defined in headers to avoid ODR violations Modified: cfe/trunk/unittests/CodeGen/IRMatchers.h Modified:

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

gribozavr added a comment. In D66960#1651198 , @lebedev.ri wrote: > This is missing documentation changes. Could you point out such places? I tried to remove "takes ownership" comments which became redundant. > And this likely would be good to mention

[PATCH] D66862: Make lround builtin constexpr (and others)

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Small nit, just default construct the APFloats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66862/new/

[PATCH] D66862: Make lround builtin constexpr (and others)

craig.topper added a comment. What if the input is nan or infinity or out of range. The spec says an implementation defined value is returned. But we've deferred to whatever library we're compiled with. Which makes our implementation defined behavior outside of clang's control and it now

[PATCH] D66862: Make lround builtin constexpr (and others)

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. Craig topper pointed out to me that constexpr cannot throw exceptions, and at least the rints can raise some exceptions, which aren't allowed in Constexpr. The round

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver added a comment. (from IRC) Add tests for: - out of range - nan - rounding up _and_ down Also, use the builtin APFloat methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66862/new/ https://reviews.llvm.org/D66862

[PATCH] D66862: Make lround builtin constexpr (and others)

lebedev.ri added inline comments. Comment at: clang/test/SemaCXX/math-builtins.cpp:5 +{ + constexpr float f = 12345.6789; + Needs more tests This looks like you always round up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

logan-5 added a comment. //ping// Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66621/new/ https://reviews.llvm.org/D66621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

gribozavr created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66960 Files: clang-tools-extra/clangd/unittests/IndexActionTests.cpp

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri abandoned this revision. lebedev.ri added a comment. Herald added a project: LLVM. Superseded by D66960 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43779/new/ https://reviews.llvm.org/D43779

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

lebedev.ri added a comment. This is missing documentation changes. And this likely would be good to mention in releasenotes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66960/new/ https://reviews.llvm.org/D66960

[PATCH] D43780: [Tooling] [1/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri abandoned this revision. lebedev.ri added a comment. Herald added subscribers: kadircet, arphaman, jkorous. Herald added a project: LLVM. Superseded by D66960 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43780/new/

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaron.ballman added a comment. In D66919#1651108 , @dexonsmith wrote: > In D66919#1650775 , @aaron.ballman > wrote: > > > In D66919#1650174 , @dexonsmith > > wrote: > > >

[PATCH] D66950: [SimplifyCFG] Skip sinking common lifetime markers of `alloca`.

hliao updated this revision to Diff 217903. hliao added a comment. Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66950/new/ https://reviews.llvm.org/D66950 Files: llvm/lib/Transforms/Utils/SimplifyCFG.cpp

[PATCH] D66947: Changed FrontendActionFactory::create to return a std::unique_ptr

This revision was automatically updated to reflect the committed changes. Closed by commit rL370379: Changed FrontendActionFactory::create to return a std::unique_ptr (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

jvikstrom updated this revision to Diff 217920. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Added test for prepending concatenations. Also added made tests pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66928/new/

[PATCH] D66947: Changed FrontendActionFactory::create to return a std::unique_ptr

lebedev.ri added a comment. Commented on wrong patch. In D66960#1651198 , @lebedev.ri wrote: > This is missing documentation changes. > And this likely would be good to mention in releasenotes. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:260 +// Macros from token concatenations included. +#define CONCAT(X) X##1() +#define MACRO1() 123

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 217806. kadircet added a comment. - Handle formatting error in ClangdServer rather than just printing it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files:

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. In D66751#1646991 , @sammccall wrote: > Yes. I actually ripped this out of the patch, because it wasn't related > enough and the patch is large. Makes sense and thanks for summing it

r370321 - [Index] Marked a bunch of classes 'final'

Author: gribozavr Date: Thu Aug 29 03:16:41 2019 New Revision: 370321 URL: http://llvm.org/viewvc/llvm-project?rev=370321=rev Log: [Index] Marked a bunch of classes 'final' This file defines multiple inheritance hierarchies and 'final' helps with readability. Modified:

[PATCH] D66875: [Index] Marked a bunch of classes 'final'

gribozavr added a comment. Committed as r370321. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66875/new/ https://reviews.llvm.org/D66875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 217819. krisb added a comment. Applied the comment & rebased. Also changed the patch to take into account only the latest 'crypto' in the Features vector, to avoid enabling 'sha2' and 'aes' when 'crypto' was finally disabled. Repository: rC Clang CHANGES

[PATCH] D66964: Sort Java imports without newline

thakis added a comment. Making the tests in this patch pass sounds good to me too :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66964/new/ https://reviews.llvm.org/D66964 ___ cfe-commits mailing

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9616 +return EvaluateFloat(E->getArg(0), Val, Info) && + Success(lround(Val.convertToDouble()), E); + } craig.topper wrote: >

  1   2   >