[clang-tools-extra] e326f52 - [clangd] Fix the incomplete template specialization in findTarget.

Author: Haojian Wu Date: 2020-02-21T09:42:02+01:00 New Revision: e326f52430419af1ca5aed635168672fbaab5654 URL: https://github.com/llvm/llvm-project/commit/e326f52430419af1ca5aed635168672fbaab5654 DIFF: https://github.com/llvm/llvm-project/commit/e326f52430419af1ca5aed635168672fbaab5654.diff LO

[PATCH] D74900: [clangd] Fix the incomplete template specialization in findTarget.

hokein updated this revision to Diff 245800. hokein added a comment. Fxi the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74900/new/ https://reviews.llvm.org/D74900 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clang

[PATCH] D74900: [clangd] Fix the incomplete template specialization in findTarget.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe326f5243041: [clangd] Fix the incomplete template specialization in findTarget. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74900?vs=245800&id=245801#toc Repository: rG

[clang-tools-extra] bc49819 - [clangd] Allow renaming class templates in cross-file rename.

Author: Haojian Wu Date: 2020-02-21T09:57:10+01:00 New Revision: bc498198b5559829d8f7138db01b0f51afefe2a7 URL: https://github.com/llvm/llvm-project/commit/bc498198b5559829d8f7138db01b0f51afefe2a7 DIFF: https://github.com/llvm/llvm-project/commit/bc498198b5559829d8f7138db01b0f51afefe2a7.diff LO

[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc498198b555: [clangd] Allow renaming class templates in cross-file rename. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74709?vs=244953&id=245802#toc Repository: rG LLVM

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille updated this revision to Diff 245805. serge-sans-paille added a comment. Add a configure feature test to filter out tests that depend on platform linker, as hinted by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/ne

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:70 size_t UTF8Length = llvm::countLeadingOnes(C); -// 0xxx is ASCII, handled above. 10xxx is a trailing byte, invalid here. -// 1xxx is not valid UTF-8 at all. Assert because it's

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added a comment. also could you clang-format your changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74731/new/ https://reviews.llvm.org/D74731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D74934: [Clang interpreter] Rename Block.{h,cpp} to AllocatedBlock.{h,cpp}

nand added a comment. Was wondering if ```InterpBlock``` might be a more suitable name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74934/new/ https://reviews.llvm.org/D74934 ___ cfe-commits mailing

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

nhaehnle added a comment. I find this phrasing pretty confusing. How about the following: > This indicates that objects accessed via pointer values based on the argument > or return value are not **modified**, during the execution of the function, > via pointer values not based on the argument

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

serge-sans-paille added a comment. Let's go that way then. @xur I leave it to you to add the appropriate warning at least on the clang side? Feel free to just use the code from https://reviews.llvm.org/D74871?id=245594. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

andwar added a comment. Cheers for working on this @kmclaughlin! Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:2035 + +def int_aarch64_sve_bdep_x : AdvSIMD_2VectorArg_Intrinsic; +def int_aarch64_sve_bext_x : AdvSIMD_2VectorArg_Intrinsic; What does `_x`

[PATCH] D74470: Seperated DIBasicType DIFlags to DIBTFlags.

Chirag updated this revision to Diff 245809. Chirag added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Moved five of the DIFlags to DISPFlags. (updated few clang testcases) DIFlagExplicit -> DISPFlagExplicit DIFlagPrototyped -> DISPFlagPrototyped DIFlagNoReturn

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

nlopes added a comment. I agree with @aqjune that stating clearly the definition of object in this context. See this example in the C spec: For example, the second call of f in g has undefined behavior because each of d[1] through d[49] is accessed through both p and q. void g(void) {

[PATCH] D62961: [AST] Add new Type queries for sizeless types

rsandifo-arm updated this revision to Diff 245812. rsandifo-arm added a comment. Update to latest master. Defer making sizeless types incomplete until D62962 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62961/new

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:407 +// FIXME Add detailed diagnostic. +std::string Msg = "Function argument constraint is not satisfied"; +auto R = std::make_unique(BT, Msg, N);

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

calixte created this revision. calixte added a reviewer: marco-c. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. There is no need to write out gcdas when forking because we can just reset the counters in the parent proce

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

marco-c added a comment. Also, as we discussed, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93623#c5 regarding exec. Comment at: compiler-rt/lib/profile/GCDAProfiling.c:665 + gcov_lock(); + // Avoid a concurrent modification of the lists during the fork + pid = fork(); ---

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

sammccall added a comment. > Proposing a fix to extend the ascii handling code to take extended ascii as > well. Please reduce the scope of this patch to not crashing on invalid utf-8. Handling other encodings is in principle possible, but requires more work and a more precise understanding of

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

calixte updated this revision to Diff 245837. calixte added a comment. If exec** fails we need to reset the counters since they've have dumped just before to avoid to count them twice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74953/new/ https

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

kmclaughlin updated this revision to Diff 245835. kmclaughlin added a comment. - Removed NumVecs parameter from SelectTableSVE2 as the value is always the same (2) - Removed unnecessary -asm-verbose=0 from the RUN line of sve2-intrinsics-bit-permutation.ll CHANGES SINCE LAST ACTION https://r

[PATCH] D74961: [clangd] Make global rename file limit adjustable

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74961 Files: clang-tools-ext

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74962 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling/Syntax/Token

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

calixte updated this revision to Diff 245843. calixte marked 4 inline comments as done. calixte added a comment. Add more comments to explain why we need to lock around the fork Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74953/new/ https://revie

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

calixte added inline comments. Comment at: compiler-rt/lib/profile/GCDAProfiling.c:671 +pid_t child_pid = getpid(); +if (child_pid != parent_pid) { + // The pid changed so we've a fork marco-c wrote: > Nit: do we need this check or can we just use th

[PATCH] D74829: [clang-rename] Add the USR of incomplete decl to the USRSet.

kbobyrev added a comment. Yeah, it works in Clang-Rename due to additional steps in the renaming process. Testing only Clangd's rename is sufficient here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74829/new/ https://reviews.llvm.org/D74829

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L updated this revision to Diff 245844. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Update the comment about ABI description; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

kmclaughlin marked 4 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this, @andwar! Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:2035 + +def int_aarch64_sve_bdep_x : AdvSIMD_2VectorArg_Intrinsic; +def int_aarch64_sve_bext_x : AdvSIMD_2VectorA

[clang] a49a41e - [AST][NFC] Update outdated comments in ASTStructuralEquivalence.cpp

Author: Gabor Marton Date: 2020-02-21T15:54:58+01:00 New Revision: a49a41e7855fad426abf6ee9b8b88a535e8d33cc URL: https://github.com/llvm/llvm-project/commit/a49a41e7855fad426abf6ee9b8b88a535e8d33cc DIFF: https://github.com/llvm/llvm-project/commit/a49a41e7855fad426abf6ee9b8b88a535e8d33cc.diff

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

marco-c accepted this revision. marco-c added a comment. This revision is now accepted and ready to land. Could you test the last iteration of the patch on Mozilla's CI (with the workaround for the mismatch in LLVM version used by Rust)? Comment at: llvm/lib/Transforms/Instrum

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

kiranchandramohan added a comment. Will tests come in a later patch? Comment at: clang/include/clang/AST/OpenMPClause.h:6700 /// independent of clang. Thus, expressions and conditions are evaluated in - /// this method. + /// this method. If \p DeviceSetOnly is set only th

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

calixte marked an inline comment as done. calixte added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp:635 void GCOVProfiler::AddFlushBeforeForkAndExec() { - SmallVector ForkAndExecs; + SmallVector, 2> ForkAndExecs; for (auto &F : M->func

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

calixte updated this revision to Diff 245848. calixte added a comment. Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74953/new/ https://reviews.llvm.org/D74953 Files: clang/lib/Driver/ToolChains/Darwin.cpp compiler-rt/lib/profile/GC

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1357-1359 + // Skip last tokens. + while (Tok.isNot(tok::annot_pragma_openmp_end)) +ConsumeAnyToken(); Better to emit a warning here about extra tokens at the end of the directive

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg updated this revision to Diff 245853. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 Files: libcxx/include/cstddef libcxx/include/new libcxx/include/stddef.h Index: libcxx/include/stddef.h ===

[PATCH] D74834: [clangd] Expose the rename LimitFiles option to the C++ API, NFC.

hokein updated this revision to Diff 245852. hokein marked 2 inline comments as done. hokein added a comment. address review comments - move the options to clangdServer::rename API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74834/new/ https://re

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org/D74015 __

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

sammccall marked an inline comment as done. sammccall added a comment. Thanks Richard! Haojian agreed to take a look at this. Comment at: clang/lib/AST/ExprConcepts.cpp:186 + if (Dependent) +addDependence(ExprDependence::ValueInstantiation); } Per Richard

[PATCH] D74961: [clangd] Make global rename file limit adjustable

hokein added a comment. oops, I should have synced with you first (the task was assigned to me in the Tuesday meeting), I have https://reviews.llvm.org/D74834 which is under review. Apology for this. Maybe you subscribe all clangd patches in phabricator as well (to allow better tracking), sinc

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

On 18 Feb 2020, at 16:40, Aaron Ballman wrote: > Yup, I saw the failure on IRC and pushed up a change Thanks again Aaron. Now that the dust has settled, bug 23564 can be closed (fixed by commit 260b91f379c) if someone with a bugzilla account wants to do that. I didn't search further to see if t

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

On Fri, Feb 21, 2020 at 10:54 AM John Marshall wrote: > > On 18 Feb 2020, at 16:40, Aaron Ballman wrote: > > Yup, I saw the failure on IRC and pushed up a change > > Thanks again Aaron. Now that the dust has settled, bug 23564 can be closed > (fixed by commit 260b91f379c) if someone with a bugzi

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert added a comment. In D74941#1886403 , @kiranchandramohan wrote: > Will tests come in a later patch? I have tests, seems I forgot to add them. Will fix later today with the other things. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:335 clang::Token T; - while (!L.LexFromRawLexer(T)) + while (!L.LexFromRawLexer(T) && L.getCurrentBufferOffset() < FR.endOffset()) AddToken(T); Discussed offline, this loop

[PATCH] D74966: [PATCH] [ARM] Add Cortex-M55 Support for clang and llvm

LukeGeeson created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch upstreams support for the ARM Armv8.1m cpu Cortex-M55. In detail adding support for: - mcpu option in clang - Arm Target Features in cla

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1357-1359 + // Skip last tokens. + while (Tok.isNot(tok::annot_pragma_openmp_end)) +ConsumeAnyToken(); ABataev wrote: > Better to emit a

[PATCH] D74934: [Clang interpreter] Rename Block.{h,cpp} to InterpBlock.{h,cpp}

MaskRay updated this revision to Diff 245862. MaskRay retitled this revision from "[Clang interpreter] Rename Block.{h,cpp} to AllocatedBlock.{h,cpp}" to "[Clang interpreter] Rename Block.{h,cpp} to InterpBlock.{h,cpp}". MaskRay added a comment. Rename Block.{h,cpp} to InterpBlock.{h,cpp} Repo

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 245863. hliao added a comment. Rebase to the trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.c

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + rjmccall wrote: > leonardchan wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > ebevhan wrote: > > > > > rjmccall wrote

[PATCH] D74966: [PATCH] [ARM] Add Cortex-M55 Support for clang and llvm

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARM.td:625 - //===--===// Seems unrelated ;) Comment at: llvm/test/CodeGen/ARM/build-attributes.ll:1376 ;

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 245875. awpandey marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-template-parameter.cpp llvm/i

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor clause.

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. This step is the preparation of allowing lvalue in map/motion clause. Repository: rG LLVM Github Monorepo https://r

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor clause.

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15283 +return false; + return Visit(E->IgnoreParenImpCasts());; +} @ABataev, in the previous patch you mentioned that we don't need `I

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 245879. Xiangling_L added a comment. Rebase to incorparate `XL` C++ ABI name && comdat changes; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/inclu

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

luismarques updated this revision to Diff 245881. luismarques edited the summary of this revision. luismarques added a comment. Herald added a subscriber: fedor.sergeev. As suggested by @efriedma, the patch was reworked to have one target with native atomics, and one without. No RUN run with a de

Re: [PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

OK. I will add a warning but not turn it off at the CodeGenOpt (but it will not pass to LLVMContext). I will update the patch shortly. On Fri, Feb 21, 2020 at 1:53 AM serge via Phabricator < revi...@reviews.llvm.org> wrote: > serge-sans-paille added a comment. > > Let's go that way then. @xur I

[clang] 23444ed - [AST matchers] Add basic matchers for googletest EXPECT/ASSERT calls.

Author: Yitzhak Mandelbaum Date: 2020-02-21T12:05:15-05:00 New Revision: 23444edf30ba00ccefa3a582ac7ddc29774e9da5 URL: https://github.com/llvm/llvm-project/commit/23444edf30ba00ccefa3a582ac7ddc29774e9da5 DIFF: https://github.com/llvm/llvm-project/commit/23444edf30ba00ccefa3a582ac7ddc29774e9da5.

[PATCH] D74972: [hexagon] Define __ELF__ by default.

sidneym created this revision. sidneym added reviewers: kparzysz, bcain. Herald added subscribers: Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers, LLVM. __ELF__ is not enabled by default. Correcting an issue in compiler-rt's cmake revealed that __ELF__ was not defined.

[PATCH] D74840: [AST matchers] Add basic matchers for googletest EXPECT/ASSERT calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG23444edf30ba: [AST matchers] Add basic matchers for googletest EXPECT/ASSERT calls. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7484

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

xur updated this revision to Diff 245891. xur added reviewers: mehdi_amini, serge-sans-paille. xur added a comment. Update the patch based on the reviews from Mehdi and Serge. Reuse Sege's warning code in https://reviews.llvm.org/D74871?id=245594. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15238 + Sema &SemaRef; + OpenMPClauseKind CKind; + OMPClauseMappableExprCommon::MappableExprComponentList &Components; Default initializer here Comment at: clang/lib/Se

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Do you have commit rights or should someone help you committing the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782 ___

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1834 +case CK_Tigerlake: +case CK_Lakemont: + craig.topper wrote: > zoecarver wrote: > > craig.topper wrote: > > > I think Lakemont is

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1226 + // intrinsic currently, where NumVecs is always 2 + unsigned NumVecs = 2; + nit: You can just as well inline this value now. Comment at: llvm/

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes added a comment. I don't have commit rights (this is my first llvm commit!), so could someone help out? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782 ___ cfe-commits mailin

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver updated this revision to Diff 245897. zoecarver added a comment. - Update getCPUCacheLineSize to return optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 Files: clang/include/clang/Basic/

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver updated this revision to Diff 245896. zoecarver marked 6 inline comments as done. zoecarver added a comment. - Update values returned by getCPUCacheLineSize based on review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

jasonliu added a comment. Just kindly reminder that you might want to update the Summary in the commit message to reflect the new name we picked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org/D74015 _

[clang] e4df934 - [Clang interpreter] Rename Block.{h,cpp} to InterpBlock.{h,cpp}

Author: Fangrui Song Date: 2020-02-21T09:47:28-08:00 New Revision: e4df934ca7b408cfb52531016198545a8d50f41a URL: https://github.com/llvm/llvm-project/commit/e4df934ca7b408cfb52531016198545a8d50f41a DIFF: https://github.com/llvm/llvm-project/commit/e4df934ca7b408cfb52531016198545a8d50f41a.diff

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong created this revision. martong added reviewers: NoQ, Szelethus, balazske, gamesh411, baloghadamsoftware, steakhal. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang. marto

[PATCH] D74934: [Clang interpreter] Rename Block.{h,cpp} to InterpBlock.{h,cpp}

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4df934ca7b4: [Clang interpreter] Rename Block.{h,cpp} to InterpBlock.{h,cpp} (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74934/new/

[PATCH] D74833: [AArch64][SVE] Add intrinsics for SVE2 cryptographic instructions

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74833/new/ https://reviews.llvm.org/D74833

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor clause.

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15356 + Expr::EvalResult Result; + if (AE->getIdx()->EvaluateAsInt(Result, SemaRef.getASTContext())) { +if (!Result.Val.getInt().isNullValue()) { -

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:151 + + using ValueConstraintPtr = std::shared_ptr; + /// The complete list of constraints that defines a single branch. ---

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15356 + Expr::EvalResult Result; + if (AE->getIdx()->EvaluateAsInt(Result, SemaRef.getASTContext())) { +if (!Result.Val.getInt().isNullValue()) { cchen wrote: > ABataev wro

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

zoecarver updated this revision to Diff 245908. zoecarver added a comment. - Remove std::shared_ptr::allocate_shared Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66178/new/ https://reviews.llvm.org/D66178 Files: libcxx/include/memory Index: l

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74847/new/ https://reviews.llvm.org/D74847 ___

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

zoecarver updated this revision to Diff 245907. zoecarver edited the summary of this revision. zoecarver added a comment. Herald added projects: clang, libc++. Herald added a subscriber: cfe-commits. - Remove std::shared_ptr::allocate_shared Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1220 +void AArch64DAGToDAGISel::SelectTableSVE2(SDNode *N, unsigned Opc) { + SDLoc DL(N); Is it possible to write this as a TableGen pattern? We manage for other vari

[PATCH] D68887: [clang-tidy] Copy the Ranges field from the Diagnostic when creating the ClangTidyError

compositeprimes updated this revision to Diff 245915. compositeprimes edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68887/new/ https://reviews.llvm.org/D68887 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp Index: clang-tidy/ClangTidyDiagnosticC

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen updated this revision to Diff 245912. cchen added a comment. Fix based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp Index: clang/lib/Sema/SemaOp

[clang] 1723f21 - Fix MSVC "not all control paths return a value" warning. NFCI.

Author: Simon Pilgrim Date: 2020-02-21T18:23:55Z New Revision: 1723f219939e1d4dc1c53ec7caf10c9380822b99 URL: https://github.com/llvm/llvm-project/commit/1723f219939e1d4dc1c53ec7caf10c9380822b99 DIFF: https://github.com/llvm/llvm-project/commit/1723f219939e1d4dc1c53ec7caf10c9380822b99.diff LOG:

[PATCH] D74734: [AArch64][SVE] Add the SVE dupq_lane intrinsic

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7495 + // DUPQ can be used when idx is in range. + auto CIdx = dyn_cast(Idx128); + if (CIdx && (CId

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1834 +case CK_Tigerlake: +case CK_Lakemont: + zoecarver wrote: > craig.topper wrote: > > zoecarver wrote: > > > craig.topper wrote: > > > > I think Lakemont is 16 bytes. Assum

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

zoecarver added a comment. @ldionne friendly ping. This patch now //only// removes `std::shared_ptr::allocate_shared`. Should be an easy change. And I think we fixed @phosek's issue by breaking `__hold2.get()->get()` into a variable so that compilers that parse args backwards still work here.

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

zoecarver updated this revision to Diff 245918. zoecarver added a comment. - Use __create_with_control_block in allocate_shared Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66178/new/ https://reviews.llvm.org/D66178 Files: libcxx/include/memory

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1834 +case CK_Tigerlake: +case CK_Lakemont: + craig.topper wrote: > zoecarver wrote: > > craig.topper wrote: > > > zoecarver wrote: >

[PATCH] D72579: Evaluate __{c11_,}atomic_is_lock_free to 0 (avoid libcall) if larger than MaxAtomicPromoteWidth

jyknight requested changes to this revision. jyknight added a comment. This revision now requires changes to proceed. This isn't correct. The atomic interface is designed to be forward-compatible with new CPUs that have wider atomic instructions. That clang has a MaxAtomicPromoteWidth value _at

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

aganea added a reviewer: rsmith. aganea added a comment. I've tested this patch and it solves our original issue. Could anyone please take a look so that it can be landed & merged into 10.0? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://review

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15319 } + return Visit(E); +} `return RelevantExpr || Visit(E);`? Comment at: clang/lib/Sema/SemaOpenMP.cpp:15346 } + return Visit(E); +} -

[clang] 0781e93 - [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

Author: Luís Marques Date: 2020-02-21T19:29:57Z New Revision: 0781e93a6eaa71ec5d87be3bbd053067f7ee URL: https://github.com/llvm/llvm-project/commit/0781e93a6eaa71ec5d87be3bbd053067f7ee DIFF: https://github.com/llvm/llvm-project/commit/0781e93a6eaa71ec5d87be3bbd053067f7ee.diff LOG:

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

This revision was automatically updated to reflect the committed changes. Closed by commit rG0781e93a6eaa: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V (authored by luismarques). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74847/

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 245929. Xiangling_L edited the summary of this revision. Xiangling_L added a comment. Update the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mangle.h clan

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen marked 11 inline comments as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15450 } + bool VisitCXXThisExpr(CXXThisExpr *CTE) { return true; } + bool VisitStmt(Stmt *) { ABataev wrote: > Do you really need this function? R

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen updated this revision to Diff 245955. cchen added a comment. Fix by feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp Index: clang/lib/Sema/SemaOpenMP.cp

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

dblaikie added a comment. Please simplify the test case - at least to remove the long/uppercase identifiers to use placeholder names (this avoids any accidental semantic meaning they might carry (or appear to carry, but not actually carry)). What's the failure mode this is avoiding? There's no

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

ABataev added a comment. Did you try to run the tests? I would suggest adding a test, at least, where a function is mapped. We should see the error message here. Seems to me, we don't have this one. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15422-15423 + Expr::EvalResult

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

aganea added a comment. @llunak Small typo: your patch fixes PR44953, not PR44958. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74846 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:138 + : Includes(Includes), Delegate(Delegate), SM(SM), PP(PP) { +MainFileTokens = syntax::tokenize(SM.getMainFileID(), SM, LangOpts); + } -

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet updated this revision to Diff 245960. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments. - Add tests by mimicking a clang-tidy check. - only tokenize the preamble section, not the whole file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet updated this revision to Diff 245962. kadircet added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74842/new/ https://reviews.llvm.org/D74842 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/

  1   2   >