[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

sepavloff added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2290 + // rounding mode. + if (VD->isFileVarDecl() || VD->isConstexpr() || + (!getLangOpts().CPlusPlus && VD->isStaticLocal())) { rsmith wrote: > It's far

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:128 const auto ValueFilter = [](const NamedDecl *D) { return isa(D); }; +const auto TypeFilter = [](const NamedDecl *D) { return !isa(D); }; nridge wrote: > hokein wrote: > >

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This allows us MSAN to instrument this function. Previous version is not

[clang-tools-extra] 8392685 - [clangd] Mark code action as "preferred" if it's the sole quickfix action

Author: Sam McCall Date: 2020-09-30T10:11:30+02:00 New Revision: 8392685c2b9f3c2025100dd25b6c6e5eae312d92 URL: https://github.com/llvm/llvm-project/commit/8392685c2b9f3c2025100dd25b6c6e5eae312d92 DIFF: https://github.com/llvm/llvm-project/commit/8392685c2b9f3c2025100dd25b6c6e5eae312d92.diff

[PATCH] D88489: [clangd] Mark code action as "preferred" if it's the sole quickfix action

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8392685c2b9f: [clangd] Mark code action as preferred if its the sole quickfix action (authored by sammccall). Repository: rG LLVM Github

[PATCH] D88265: Fix comma with half vectors.

fhahn added a comment. Could you adjust the commit message to be a bit more descriptive, e.g something like `[Sema] Support Comma operator for fp16 vectors.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

sepavloff updated this revision to Diff 295194. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88498/new/ https://reviews.llvm.org/D88498 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ba0779fbb41: [clangd] Extract options struct for ClangdLSPServer. NFC (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 7ba0779 - [clangd] Extract options struct for ClangdLSPServer. NFC

Author: Sam McCall Date: 2020-09-30T10:09:52+02:00 New Revision: 7ba0779fbb41b6fa8213aa31622ff45484037eb4 URL: https://github.com/llvm/llvm-project/commit/7ba0779fbb41b6fa8213aa31622ff45484037eb4 DIFF: https://github.com/llvm/llvm-project/commit/7ba0779fbb41b6fa8213aa31622ff45484037eb4.diff

Re: Upcoming upgrade of LLVM buildbot

Hello everyone, Starting tomorrow we will be upgrading the staging and production LLVM build bot. To make the transition smooth we would not accept any change to zorg from tomorrow 11:00 AM PDT till the production bot is up and running the new version. Please feel free to talk to me if you will

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

baloghadamsoftware added a comment. Yes, @NoQ is right. If the constraint manager cannot reason about a value, then then `ProgramState::assume()` will return the same state with the new assumption in the constraints. Whenever `ProgramState::assume()` returns `nullptr` it means that the

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:56 + // Features like indexing must be enabled if desired. + static Options optsForTest(); +

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

sepavloff added inline comments. Comment at: clang/test/AST/const-fpfeatures-strict.c:39 + +// CHECK: @var_04 = {{.*}} %struct.S { float 0x3FF02000 } +// CHECK: @var_05 = {{.*}} %struct.S { float 0x3FF02000 } mibintc wrote: > I think the

[clang-tools-extra] 64e8fd5 - [clangd][remote] Make sure relative paths are absolute with respect to posix style

Author: Kadir Cetinkaya Date: 2020-09-30T11:08:49+02:00 New Revision: 64e8fd540ecc38ee3daf942499091589785e2733 URL: https://github.com/llvm/llvm-project/commit/64e8fd540ecc38ee3daf942499091589785e2733 DIFF:

[PATCH] D88507: [clangd][remote] Make sure relative paths are absolute with respect to posix style

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64e8fd540ecc: [clangd][remote] Make sure relative paths are absolute with respect to posix… (authored by kadircet). Repository: rG LLVM Github

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

svenvh added a comment. LGTM! I'd suggest waiting a bit before committing this though, to give people time to catch up on the RFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88300/new/ https://reviews.llvm.org/D88300 ___ cfe-commits

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

bdf accepted this revision. bdf added a comment. This revision is now accepted and ready to land. Looks good. Good idea to add tests to verify that we match `__builtin_except()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88363/new/

[PATCH] D88550: [HIP] Fix -fgpu-allow-device-init option

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. The option needs to be passed to both host and device compilation. https://reviews.llvm.org/D88550 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/HIP.cpp

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Even though I don't imagine the discussion on the RFC (http://lists.llvm.org/pipermail/cfe-dev/2020-September/066883.html) will affect this functionality I think it's good

[PATCH] D88553: [clangd] Stash a patch piece

kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88553

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

ro added a comment. This patch broke builds with `gcc`, e.g. Builder clang-solaris11-amd64 Build #6724 : [23/122] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o FAILED:

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

azabaznov added a comment. In D88300#2302796 , @svenvh wrote: > LGTM! I'd suggest waiting a bit before committing this though, to give > people time to catch up on the RFC. Thanks! Sure, I'm agree with that, let's wait. CHANGES SINCE LAST ACTION

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

void added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1679 + // Inlining a function the explicitly should not have a stack protector may + // break the code if inlined into a function that does have a stack s/the/that/

[PATCH] D31383: [inline asm] "=i" output constraint support - gcc compatiblity

blackliner added a comment. I am getting errors with clang-tidy, is this the right place to ask for those additional constraints? CUDA allows a few more output constraints --> https://docs.nvidia.com/cuda/inline-ptx-assembly/index.html#constraints 1.1.2. Constraints There is a separate

[clang-tools-extra] 6342b38 - [clangd] Fix member/type name conflict caught by buildbots.

Author: Sam McCall Date: 2020-09-30T10:56:43+02:00 New Revision: 6342b38c5fee74df94d7b0c34e5a93b9b22763df URL: https://github.com/llvm/llvm-project/commit/6342b38c5fee74df94d7b0c34e5a93b9b22763df DIFF: https://github.com/llvm/llvm-project/commit/6342b38c5fee74df94d7b0c34e5a93b9b22763df.diff

Re: [PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

Yes, sorry about that. It has been fixed in 6342b38c5fee74df94d7b0c34e5a93b9b22763df. On Wed, Sep 30, 2020 at 11:12 AM Rainer Orth via Phabricator < revi...@reviews.llvm.org> wrote: > ro added a comment. > > This patch broke builds with `gcc`, e.g. Builder clang-solaris11-amd64 > Build #6724 < >

[PATCH] D88546: [ARM] Update NEON testcase with missing target string in

rs created this revision. rs added reviewers: SjoerdMeijer, john.brawn. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. rs requested review of this revision. This is a follow-up from https://reviews.llvm.org/D61717. Where Richard described the

[PATCH] D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1120 namespace ns { class [[Foo]] {}; } - using ns::F^oo; + using ns::[[F^oo]]; )cpp", sammccall wrote: > hokein wrote: > > this seems a small

[PATCH] D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl.

hokein updated this revision to Diff 295238. hokein added a comment. refine the patch based on the offline discussion: - don't set the Underlying bits for using-declaration's underlying decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] d99f46c - [clangd] Fix fuzzer build after 7ba0779fbb41b6fa8

Author: Sam McCall Date: 2020-09-30T11:02:05+02:00 New Revision: d99f46c6eb8debaa1a14c122956177dc2a40ef9b URL: https://github.com/llvm/llvm-project/commit/d99f46c6eb8debaa1a14c122956177dc2a40ef9b DIFF: https://github.com/llvm/llvm-project/commit/d99f46c6eb8debaa1a14c122956177dc2a40ef9b.diff

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl marked an inline comment as done. yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88370/new/ https://reviews.llvm.org/D88370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

martong added a comment. In D88019#2296337 , @steakhal wrote: > In D88019#2291953 , @steakhal wrote: > >> What are our options mitigating anything similar happening in the future? >> >> This way any change touching

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stuij requested review of this revision. This test broke for our toolchain as this test triggered unrelated warnings. Being more specific about not expecting fuse-ld warnings won't invalidate the

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel added a comment. > I'm not concerned about the basic idea behind the proposed matcher, I'm only > worried we're making AST matching more confusing by having two different ways > of inconsistently accomplishing the same-ish thing. Aaron, I appreciate this concern, but I would argue that

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1622 EmitBranchOnBoolExpr(CondOp->getCond(), LHSBlock, RHSBlock, - getProfileCount(CondOp), Weights); + getProfileCount(CondOp),

[PATCH] D88526: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88526/new/ https://reviews.llvm.org/D88526

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

arsenm added inline comments. Comment at: clang/test/Driver/amdgpu-macros.cl:380-381 +// RUN: -mno-wavefrontsize64 %s 2>&1 | FileCheck --check-prefixes=WAVE64 %s +// RUN: %clang -E -dM -target amdgcn -mcpu=gfx1010 -mwavefrontsize64 \ +// RUN: -mno-wavefrontsize64 %s 2>&1 |

[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D88557: [HIP] Add option --gpu-instrument-lib=

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: dang. yaxunl requested review of this revision. Add an option `--gpu-instrument-lib=` to allow users to specify an instrument device library. This is for supporting -finstrument in device code for

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij updated this revision to Diff 295262. stuij added a comment. slight change in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88566/new/ https://reviews.llvm.org/D88566 Files: clang/test/Driver/fuse-ld.c Index:

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

NoQ added a comment. > Yup, that's pretty bad. One slightly redeeming thing about this crash is that it's assertion-only. When built without assertions clang doesn't crash and this patch doesn't really change its behavior (adding transition to a null state is equivalent to adding no

[PATCH] D88590: [clangd] Add bencmark for measuring latency of DecisionForest model.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, mgorny. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88590

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2293128 , @aaron.ballman wrote: > In D86671#2284078 , @dougpuob wrote: > >> Hi @aaron.ballman >> About changing `size_t nLength` to `cbLength`. I searched MSVC folders with >>

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1353 if (Begin) { WasmIndices[cast(Begin)] = CustomSections.size(); -if (SectionName !=

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

curdeius added a comment. I agree with both of you. I shouldn't have used the word "regression" indeed. I just meant a change in behaviour. Sorry for that. I'll try to play around and propose a patch to enhance this feature :). If you have any pointers about how to check if everything fits on a

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

Conanap updated this revision to Diff 295393. Conanap marked 6 inline comments as done. Conanap added a comment. Addressed comments and corrected incorrect behaviour on Power10 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86819/new/ https://reviews.llvm.org/D86819 Files:

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962 + case Triple::Wasm: +return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash), + ~0); dschuff wrote: > I may add a couple more

[clang] 21cf2e6 - Handle unknown OSes in DarwinTargetInfo::getExnObjectAlignment

Author: Akira Hatanaka Date: 2020-09-30T16:05:17-07:00 New Revision: 21cf2e6c263d7a50654653bce4e83ab463fae580 URL: https://github.com/llvm/llvm-project/commit/21cf2e6c263d7a50654653bce4e83ab463fae580 DIFF:

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

boga95 marked an inline comment as done. boga95 added a comment. In D71524#2291925 , @steakhal wrote: > In D71524#2284386 , @Szelethus wrote: > >> I figured you're still working on this, sorry! I'd really like to

[clang] e4f50e5 - [ARM] Add missing target for Arm neon test case.

Author: Ranjeet Singh Date: 2020-10-01T00:32:33+01:00 New Revision: e4f50e587f077c246b7f29db0b7daddf583e2b64 URL: https://github.com/llvm/llvm-project/commit/e4f50e587f077c246b7f29db0b7daddf583e2b64 DIFF: https://github.com/llvm/llvm-project/commit/e4f50e587f077c246b7f29db0b7daddf583e2b64.diff

[PATCH] D88546: [ARM] Update NEON testcase with missing target string in

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4f50e587f07: [ARM] Add missing target for Arm neon test case. (authored by rs). Changed prior to commit: https://reviews.llvm.org/D88546?vs=295219=295435#toc Repository: rG LLVM Github Monorepo

[clang-tools-extra] 85fc5bf - [clangd] Remove dead variable. NFC

Author: Sam McCall Date: 2020-09-30T23:19:15+02:00 New Revision: 85fc5bf341395171e67490061f6fbc76b297b78d URL: https://github.com/llvm/llvm-project/commit/85fc5bf341395171e67490061f6fbc76b297b78d DIFF: https://github.com/llvm/llvm-project/commit/85fc5bf341395171e67490061f6fbc76b297b78d.diff

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. I'm trying to say that the value produced by the load should not be the same as the stored value, because these two values are of different types. When exactly does the first value change into the second value is a different story; the current grand vision around which the

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

aqjune added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +LoopMustProgress = true; A silly question:

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2304337 , @njames93 wrote: > Not strictly relevant here, but this does open up the idea of enforcing the > style where an enum constant is prefixed by the initials of the enum name. I like this idea. There is a case

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. (in the latest message by "load" i mean the first load that produces a pointer (i.e., an `ElementRegion`) as the result) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88477/new/ https://reviews.llvm.org/D88477

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1704 +->getArrayElementTypeNoTypeQual() +->isRecordType()) { + auto FieldElement = CGF.Builder.CreateStructGEP(Ptr, Index); Is it OK to possibly create

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver updated this revision to Diff 295445. zoecarver added a comment. - Support constant arrays - Format changes with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87974/new/ https://reviews.llvm.org/D87974 Files:

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/test/CodeGenCXX/builtin-zero-non-value-bits-codegen.cpp:46 +void test(Baz *baz) { + __builtin_zero_non_value_bits(baz); +} zoecarver wrote: > jfb wrote: > > It would

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1652 +auto Element = CGF.Builder.CreateGEP(I8Ptr, Index); +CGF.Builder.CreateAlignedStore(Zero, Element, MaybeAlign()); + }; jfb wrote: > You should use `alignmentAtOffset`

[PATCH] D88630: [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR

loladiro created this revision. loladiro added a reviewer: tstellar. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. loladiro requested review of this revision. Otherwise clang installs all of its tools into `bin/` while LLVM installs its tools into

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 closed this revision. jhuber6 added a comment. Committed in rG9d2378b59150 , forgot to update the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1b60f63 - Revert "[OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def"

Author: Joseph Huber Date: 2020-09-30T15:12:21-04:00 New Revision: 1b60f63e4fd041550019b692dc7bf490dce2c75c URL: https://github.com/llvm/llvm-project/commit/1b60f63e4fd041550019b692dc7bf490dce2c75c DIFF: https://github.com/llvm/llvm-project/commit/1b60f63e4fd041550019b692dc7bf490dce2c75c.diff

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl updated this revision to Diff 295326. yaxunl added a comment. simplifies wavefrontsize64 target feature CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88370/new/ https://reviews.llvm.org/D88370 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Basic/Targets/AMDGPU.h

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, that should mean OpenMPKinds lists all OpenMP runtime functions clang generates, which is great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff created this revision. dschuff added reviewers: aardappel, sbc100. Herald added subscribers: llvm-commits, cfe-commits, ecnelises, sunfish, hiraditya, jgravelle-google. Herald added projects: clang, LLVM. dschuff requested review of this revision. Herald added subscribers: ormris,

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962 + case Triple::Wasm: +return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash), + ~0); I may add a couple more tests to this, but

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:394-395 + // Get the last argument of -mwavefrontsize64 or -mno-wavefrontsize64. + for (auto WaveArg : Args.filtered_reverse(options::OPT_mwavefrontsize64, +

[PATCH] D88265: Fix comma with half vectors.

fhahn added a comment. In D88265#2303841 , @arames wrote: > In D88265#2302653 , @fhahn wrote: > >> Could you adjust the commit message to be a bit more descriptive, e.g >> something like `[Sema] Support Comma

[PATCH] D88265: [Sema] Support Comma operator for fp16 vectors.

This revision was automatically updated to reflect the committed changes. Closed by commit rG700e63293eea: [Sema] Support Comma operator for fp16 vectors. (authored by arames, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bdc8529 - Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload"

Author: Joseph Huber Date: 2020-09-30T15:08:22-04:00 New Revision: bdc85292fb0f2a3965c8c65f9461d285b04841ed URL: https://github.com/llvm/llvm-project/commit/bdc85292fb0f2a3965c8c65f9461d285b04841ed DIFF: https://github.com/llvm/llvm-project/commit/bdc85292fb0f2a3965c8c65f9461d285b04841ed.diff

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl updated this revision to Diff 295312. yaxunl added a comment. simpler code for handling multiple wave64 options CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88370/new/ https://reviews.llvm.org/D88370 Files: clang/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

baloghadamsoftware added a comment. @vabridgers Please try to apply D69726 and check whether it solves this crash! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86743/new/ https://reviews.llvm.org/D86743

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295343. jhuber6 added a comment. Forgot to add one of the test changes from D88594 as it makes this one fail too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/

[clang] 187686b - [CodeGen] add test for NAN creation; NFC

Author: Sanjay Patel Date: 2020-09-30T13:22:12-04:00 New Revision: 187686bea3878c0bf2b150d784e7eab223434e25 URL: https://github.com/llvm/llvm-project/commit/187686bea3878c0bf2b150d784e7eab223434e25 DIFF: https://github.com/llvm/llvm-project/commit/187686bea3878c0bf2b150d784e7eab223434e25.diff

[clang] 700e632 - [Sema] Support Comma operator for fp16 vectors.

Author: Alexandre Rames Date: 2020-09-30T18:23:09+01:00 New Revision: 700e63293eea4a23440f300b1e9125ca2e80c6e9 URL: https://github.com/llvm/llvm-project/commit/700e63293eea4a23440f300b1e9125ca2e80c6e9 DIFF:

[clang] 90eaedd - [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

Author: Joseph Huber Date: 2020-09-30T14:00:01-04:00 New Revision: 90eaedda9b8ef46e2c0c1b8bce33e98a3adbb68c URL: https://github.com/llvm/llvm-project/commit/90eaedda9b8ef46e2c0c1b8bce33e98a3adbb68c DIFF: https://github.com/llvm/llvm-project/commit/90eaedda9b8ef46e2c0c1b8bce33e98a3adbb68c.diff

[clang] 81921eb - [CodeGen] improve coverage for float (32-bit) type of NAN; NFC

Author: Sanjay Patel Date: 2020-09-30T15:10:25-04:00 New Revision: 81921ebc430536ae5718da70a54328c790c8ae19 URL: https://github.com/llvm/llvm-project/commit/81921ebc430536ae5718da70a54328c790c8ae19 DIFF: https://github.com/llvm/llvm-project/commit/81921ebc430536ae5718da70a54328c790c8ae19.diff

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

aeubanks added a comment. In D88138#2304243 , @quic_aankit wrote: > @aeubanks Thanks for the review. Can you also commit the patch on my behalf? Committed in ce5379f0f0675592fd10a522009fd5b1561ca72b

[PATCH] D88265: Fix comma with half vectors.

arames added a comment. In D88265#2302653 , @fhahn wrote: > Could you adjust the commit message to be a bit more descriptive, e.g > something like `[Sema] Support Comma operator for fp16 vectors.` Done! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D88265: Fix comma with half vectors.

arames updated this revision to Diff 295316. arames added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D88557: [HIP] Add option --gpu-instrument-lib=

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Perhaps we should start thinking of shipping some of that bitcode along with clang. Then the instrumentation library could be linked with automatically by the driver when `-finstrument` is

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

baloghadamsoftware requested changes to this revision. baloghadamsoftware added a comment. This revision now requires changes to proceed. In D86743#2303922 , @NoQ wrote: > One slightly redeeming thing about this crash is that it's assertion-only. > When

[PATCH] D88557: [HIP] Add option --gpu-instrument-lib=

yaxunl added a comment. In D88557#2303891 , @tra wrote: > Perhaps we should start thinking of shipping some of that bitcode along with > clang. > Then the instrumentation library could be linked with automatically by the > driver when `-finstrument` is

[PATCH] D88265: [Sema] Support Comma operator for fp16 vectors.

arames added a comment. > Oh I think you'd need to edit the revision on Phabricator (top right on this > page, `edit revision`). But if you are fine with it I can commit the patch > for you with the adjusted commit title. Done ! Thanks for your help ! Repository: rG LLVM Github Monorepo

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594

[clang] 9d2378b - [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

Author: Joseph Huber Date: 2020-09-30T13:58:24-04:00 New Revision: 9d2378b59150f6f1cb5c9cf42ea06b0bb57029a1 URL: https://github.com/llvm/llvm-project/commit/9d2378b59150f6f1cb5c9cf42ea06b0bb57029a1 DIFF: https://github.com/llvm/llvm-project/commit/9d2378b59150f6f1cb5c9cf42ea06b0bb57029a1.diff

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. Not strictly relevant here, but this does open up the idea of enforcing the style where an enum constant is prefixed by the initials of the enum name. Comment at:

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

steakhal added a comment. I'm getting lost :D In D88477#2304230 , @NoQ wrote: > And I believe that this part is already incorrect. Like, regardless of how we > do the dereference (the implicit lvalue-to-rvalue cast), or *whether* we do > it at all

[clang] ae4c400 - [NFC] Fix spacing in clang/test/Driver/aix-ld.c

Author: Hubert Tong Date: 2020-09-30T17:01:32-04:00 New Revision: ae4c400e02fc3f7cff11cc332e6b107353b3e6a2 URL: https://github.com/llvm/llvm-project/commit/ae4c400e02fc3f7cff11cc332e6b107353b3e6a2 DIFF: https://github.com/llvm/llvm-project/commit/ae4c400e02fc3f7cff11cc332e6b107353b3e6a2.diff

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

NoQ added a comment. Thank you for reminding me of this patch. I still think it's a pretty important patch and i'm interested in getting it landed. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1388 - ->castAs() -

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

baloghadamsoftware added a comment. In D86743#2303910 , @NoQ wrote: >> The last comment for that bug is D69726 , >> but the bug is not closed to it seems to me that D69726 >> does not

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295342. jhuber6 added a comment. Moving the Clang error checks into D88594 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430 Files:

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

This revision was automatically updated to reflect the committed changes. Closed by commit rG90eaedda9b8e: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D88430?vs=295343=295353#toc Repository:

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGafc277b0ed0d: [AIX][Clang][Driver] Link libm in c++ mode (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D88500?vs=295111=295355#toc Repository: rG LLVM Github Monorepo

[clang] afc277b - [AIX][Clang][Driver] Link libm in c++ mode

Author: David Tenty Date: 2020-09-30T14:02:17-04:00 New Revision: afc277b0ed0dcd9fbbde6015bbdf289349fb2104 URL: https://github.com/llvm/llvm-project/commit/afc277b0ed0dcd9fbbde6015bbdf289349fb2104 DIFF: https://github.com/llvm/llvm-project/commit/afc277b0ed0dcd9fbbde6015bbdf289349fb2104.diff

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

NoQ added a comment. > The last comment for that bug is D69726 , > but the bug is not closed to it seems to me that D69726 > does not solve it, just takes a single step > towards the solution. It might as well be that the

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: OpenMP, clang. Herald added subscribers: cfe-commits, guansong, yaxunl. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. This patch adds an error to Clang that detects if

[PATCH] D88265: [Sema] Support Comma operator for fp16 vectors.

fhahn accepted this revision. fhahn added a comment. LGTM, thanks. I'll commit this in a minute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 ___ cfe-commits

[clang] 892df30 - Fix interaction of `constinit` and `weak`.

Author: Richard Smith Date: 2020-09-30T10:49:50-07:00 New Revision: 892df30a7f344b6cb9995710efbc94bb25cfb95b URL: https://github.com/llvm/llvm-project/commit/892df30a7f344b6cb9995710efbc94bb25cfb95b DIFF: https://github.com/llvm/llvm-project/commit/892df30a7f344b6cb9995710efbc94bb25cfb95b.diff

  1   2   >